lhc/web/wiklou.git
8 years agoMerge "Title: Fix inaccurate documentation of getUserPermissionsErrorsInternal"
jenkins-bot [Thu, 24 Mar 2016 04:44:21 +0000 (04:44 +0000)]
Merge "Title: Fix inaccurate documentation of getUserPermissionsErrorsInternal"

8 years agoTitle: Fix inaccurate documentation of getUserPermissionsErrorsInternal
Matthew Flaschen [Fri, 18 Mar 2016 23:54:46 +0000 (19:54 -0400)]
Title: Fix inaccurate documentation of getUserPermissionsErrorsInternal

Blocks are checked (checkUserBlock).

Change-Id: I3a164d1003f2bea3e3e07081c9bebfabd884ade9

8 years agoMerge "OutputPage: Minor clean up of <head> and HTML"
jenkins-bot [Thu, 24 Mar 2016 03:45:16 +0000 (03:45 +0000)]
Merge "OutputPage: Minor clean up of <head> and HTML"

8 years agoOutputPage: Minor clean up of <head> and HTML
Timo Tijhof [Thu, 18 Feb 2016 16:33:15 +0000 (16:33 +0000)]
OutputPage: Minor clean up of <head> and HTML

* Remove trailing space in self-closing tag.
  Brings parserTest output of Parser and Parsoid closer together.

* Remove various line breaks at begin and end of script contents.

* Remove FILTER_NOMIN from makeConfigSetScript() output.
  This isn't part of any user- or page-dependent module and not minified.
  And Xml::encodeJsCall already ensures compact output for prod mode.

Bug: T127328
Change-Id: I85a5a59fd0955c1a112e8b24b933f0d9e983a156

8 years agoMerge "jquery.suggestions: Fix typo "singleton" in documentation"
jenkins-bot [Thu, 24 Mar 2016 02:56:31 +0000 (02:56 +0000)]
Merge "jquery.suggestions: Fix typo "singleton" in documentation"

8 years agojquery.suggestions: Fix typo "singleton" in documentation
Timo Tijhof [Thu, 24 Mar 2016 02:44:47 +0000 (02:44 +0000)]
jquery.suggestions: Fix typo "singleton" in documentation

Change-Id: I81af9a1974ea9c9dcd26f201bf055554087ccd99

8 years agoMerge "Request-local caching of DjVu dimensions"
jenkins-bot [Thu, 24 Mar 2016 01:04:14 +0000 (01:04 +0000)]
Merge "Request-local caching of DjVu dimensions"

8 years agoMerge "Request-local caching of revision text"
jenkins-bot [Wed, 23 Mar 2016 23:28:58 +0000 (23:28 +0000)]
Merge "Request-local caching of revision text"

8 years agoRequest-local caching of DjVu dimensions
Ori Livneh [Wed, 23 Mar 2016 19:37:01 +0000 (12:37 -0700)]
Request-local caching of DjVu dimensions

Make DjVuHandler::getDimensionInfo() cache dimension info in memory so that
operations which get the dimensions of each page don't result in multiple
round-trips to memcached.

Change-Id: Idbd11637a8f7d87e4774f76a5b90d7469f3b0857

8 years agomediawiki.requestIdleCallback: Implement timeRemaining()
Timo Tijhof [Sat, 12 Mar 2016 02:19:35 +0000 (02:19 +0000)]
mediawiki.requestIdleCallback: Implement timeRemaining()

This matches the native API. This allows callers to better batch and spread out
expensive operations based on actual execution speed.

Right now CentralNotice is manually creating arbitrarily sized batches in
kvStoreMaintenance. Instead this can use a while loop with timeRemaining()
to run as quickly as possible whilst still being able to stop and yield when
it runs for too long. This way will naturally take more iterations on slow
devices and less iterations on faster ones - to be least disruptive.

While timeRemaining() is already available in the native interface,
it was previously unsafe to call because the fallback didn't implement it.

* Remove redundant QUnit.test() expect numbers.

* Add a test for the native one if available. This will catch silly mistakes
  like assigning the native one to mw.requestIdleCallback directly that result
  in 'Uncaught TypeError: Illegal invocation' due to missing call context.

Change-Id: I9721fab9e89c561e31101b5556a3748431353548

8 years agoMerge "Cast namespaceId to int in SpecialEditWatchlist::cleanupWatchlist"
jenkins-bot [Wed, 23 Mar 2016 21:55:54 +0000 (21:55 +0000)]
Merge "Cast namespaceId to int in SpecialEditWatchlist::cleanupWatchlist"

8 years agoCast namespaceId to int in SpecialEditWatchlist::cleanupWatchlist
addshore [Wed, 23 Mar 2016 21:21:00 +0000 (21:21 +0000)]
Cast namespaceId to int in SpecialEditWatchlist::cleanupWatchlist

Bug: T130778
Change-Id: I4b62e5b251f8c3d31aa2f76a9988b5cb7c8cf3b7

8 years agoMerge "SpecialUploadStash: Add links to view a thumb of each uploaded file"
jenkins-bot [Wed, 23 Mar 2016 21:20:56 +0000 (21:20 +0000)]
Merge "SpecialUploadStash: Add links to view a thumb of each uploaded file"

8 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Wed, 23 Mar 2016 20:54:56 +0000 (21:54 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: Idf395e9379605a64103df4ee0ce3847b600f5ede

8 years agoCleanups to WikiRevision
Aaron Schulz [Fri, 4 Mar 2016 19:58:20 +0000 (11:58 -0800)]
Cleanups to WikiRevision

* Check for blank $source variable more properly.
* Avoid use of ugly File::DELETE_SOURCE flag.
* Remove now-unused $flags parameter to uploadOld().

Change-Id: I6bc610cfead0036700b4f9a82e13f2bd9ab10f32

8 years agoMerge "Add WatchedItemStore::getWatchedItemsForUser"
jenkins-bot [Wed, 23 Mar 2016 15:45:45 +0000 (15:45 +0000)]
Merge "Add WatchedItemStore::getWatchedItemsForUser"

8 years agoMerge "Ensure that User::getId() returns int"
jenkins-bot [Wed, 23 Mar 2016 14:58:51 +0000 (14:58 +0000)]
Merge "Ensure that User::getId() returns int"

8 years agoAdd WatchedItemStore::getWatchedItemsForUser
addshore [Tue, 15 Mar 2016 22:19:16 +0000 (22:19 +0000)]
Add WatchedItemStore::getWatchedItemsForUser

This method is also no used in SpecialEditWatchlist

Unit and Integration tests have also been added.

Bug: T129481
Change-Id: Ica136b6fee63be8de4c2fe502288dd2318d99114

8 years agoMerge "SessionManager: Use existing backend for the ID if one is loaded"
jenkins-bot [Wed, 23 Mar 2016 10:37:13 +0000 (10:37 +0000)]
Merge "SessionManager: Use existing backend for the ID if one is loaded"

8 years agoRequest-local caching of revision text
Ori Livneh [Wed, 23 Mar 2016 00:21:48 +0000 (17:21 -0700)]
Request-local caching of revision text

It's not uncommon for the revision text of a Scribunto module to be retrieved
half a dozen times or more in the course of a single request. Caching them in
APC is a non-starter, because there is no practical way to determine which keys
are hot, and storing everything in APC is not viable. Request-local caching
gives us much of the benefit with no negative consequences apart from a nominal
increase to memory usage.

Use a MapCacheLRU to hold cache items so we can limit the size of the cache to
10 items, to prevent uncontrolled memory growth for long-running scripts.

Change-Id: I77575d6d0ea2d06fc6c93f664c5407641aab88d9

8 years agoMerge "Add new index to make updateCollation.php painless"
jenkins-bot [Wed, 23 Mar 2016 00:56:01 +0000 (00:56 +0000)]
Merge "Add new index to make updateCollation.php painless"

8 years agoMerge "Fix typos in docs/memcached.txt"
jenkins-bot [Tue, 22 Mar 2016 23:26:36 +0000 (23:26 +0000)]
Merge "Fix typos in docs/memcached.txt"

8 years agoFix typos in docs/memcached.txt
Ori Livneh [Tue, 22 Mar 2016 23:02:29 +0000 (16:02 -0700)]
Fix typos in docs/memcached.txt

expriy, expriry => expiry

Change-Id: I96304392e79499d78551e9d66fb0161d759bf1e0

8 years agoUpdate OOjs UI to v0.16.4
James D. Forrester [Tue, 22 Mar 2016 22:50:39 +0000 (15:50 -0700)]
Update OOjs UI to v0.16.4

Release notes:
 https://git.wikimedia.org/blob/oojs%2Fui.git/v0.16.4/History.md

Change-Id: Ic0f8cf4fc956feff29189c4d3e1d83e071daa8f7

8 years agoAdd new index to make updateCollation.php painless
Brian Wolff [Sun, 21 Feb 2016 21:59:14 +0000 (16:59 -0500)]
Add new index to make updateCollation.php painless

We want to update categories in order, to minimize disruption
to users. Previous indexes required a filesort to do this, which
exploded things on large wikis. See bug for details

Bug: T58041
Change-Id: Iee6cd997ff87a313a46fda19d8ab063d0fed8ce8

8 years agoSessionManager: Use existing backend for the ID if one is loaded
Brad Jorsch [Tue, 22 Mar 2016 21:50:32 +0000 (17:50 -0400)]
SessionManager: Use existing backend for the ID if one is loaded

This fixes a bug where SessionBackend::resetId() of the PHP session will
fail to properly load $_SESSION because the new session ID hasn't been
saved to the store yet. It's also a reasonable performance improvement,
no need to call loadSessionInfoFromStore() when we already have the
session loaded.

Change-Id: I30f159ef1267442a6325aabbbdfaf69defc10ed6

8 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Tue, 22 Mar 2016 21:00:03 +0000 (22:00 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: Iba1610b61c1658b22216e57ed5d60d131073feab

8 years agoMerge "Revert "Add link to anon's user page; remove "Not logged in"""
jenkins-bot [Tue, 22 Mar 2016 18:08:27 +0000 (18:08 +0000)]
Merge "Revert "Add link to anon's user page; remove "Not logged in"""

8 years agoMerge "Message: Use RequestContext instead of $wgLang"
jenkins-bot [Tue, 22 Mar 2016 17:17:53 +0000 (17:17 +0000)]
Merge "Message: Use RequestContext instead of $wgLang"

8 years agoRevert "Add link to anon's user page; remove "Not logged in""
Tyler Cipriani [Tue, 22 Mar 2016 16:08:52 +0000 (09:08 -0700)]
Revert "Add link to anon's user page; remove "Not logged in""

This reverts change I049d0671a7050.

This change was reverted in the wmf/1.27.0-wmf.17. Since there is no
clear consensus, revert in master before branching wmf/1.27.0-wmf.18.

Bug: T121793
Change-Id: I2dc0f2562c908d4e419d34e80a64065843778f3d

8 years agoNames.php: Use ʻ instead of ` as ʻokina in Hawaiian
Fomafix [Tue, 22 Mar 2016 06:15:46 +0000 (06:15 +0000)]
Names.php: Use ʻ instead of ` as ʻokina in Hawaiian

https://en.wikipedia.org/wiki/%CA%BBOkina:
In the Unicode standard, the ʻokina is encoded as U+02BB ʻ MODIFIER LETTER TURNED COMMA

Change-Id: I030f3b46382d5c5ed5ba81471f7c4156c660b244

8 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Mon, 21 Mar 2016 22:00:56 +0000 (23:00 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: I9e4277291fc529f86496f46c8eab1c2cd4590903

8 years agoMerge "mw.widgets.CategoryCapsuleItemWidget: Pass the right 'this'"
jenkins-bot [Mon, 21 Mar 2016 20:48:12 +0000 (20:48 +0000)]
Merge "mw.widgets.CategoryCapsuleItemWidget: Pass the right 'this'"

8 years agomw.widgets.CategoryCapsuleItemWidget: Pass the right 'this'
Bartosz Dziewoński [Mon, 21 Mar 2016 16:38:06 +0000 (17:38 +0100)]
mw.widgets.CategoryCapsuleItemWidget: Pass the right 'this'

Follow-up to 7b57752e65c3cac62d973f43d1060b6bd0ab2a2f.

Bug: T130544
Change-Id: I89c18be911bcc492f3a70e1c1da3d2fd2bf65a05

8 years agoMerge "Use WatchedItemStore in ApiQueryInfo::getWatchedInfo"
jenkins-bot [Mon, 21 Mar 2016 10:24:09 +0000 (10:24 +0000)]
Merge "Use WatchedItemStore in ApiQueryInfo::getWatchedInfo"

8 years agoUse WatchedItemStore in ApiQueryInfo::getWatchedInfo
Leszek Manicki [Fri, 18 Mar 2016 13:43:26 +0000 (14:43 +0100)]
Use WatchedItemStore in ApiQueryInfo::getWatchedInfo

Adds a method for getting watchlist's notification timestamps
for a batch of LinkTargets.

Bug: T129482
Change-Id: I1f84212e7879a84b34bb3b53859069fcea282bba

8 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Sun, 20 Mar 2016 21:15:07 +0000 (22:15 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: I3d9b14ae3a5d77fea9694ef113b0180e5677c39e

8 years agoMerge "Update phpunit to 4.8.24"
jenkins-bot [Sun, 20 Mar 2016 17:28:35 +0000 (17:28 +0000)]
Merge "Update phpunit to 4.8.24"

8 years agoMerge "Call Skin::setRelevantUser on Special:EmailUser"
jenkins-bot [Sun, 20 Mar 2016 14:08:18 +0000 (14:08 +0000)]
Merge "Call Skin::setRelevantUser on Special:EmailUser"

8 years agoUpdate phpunit to 4.8.24
Paladox [Sun, 20 Mar 2016 12:12:41 +0000 (12:12 +0000)]
Update phpunit to 4.8.24

See changelog at
https://github.com/sebastianbergmann/phpunit/blob/4.8/ChangeLog-4.8.md

Change-Id: I604f10917e015788acf49cdcd6389957da89fbdb

8 years agoUploadBase: Set mFileSize, if given, even if mTempPath is unknown
Bartosz Dziewoński [Sun, 20 Mar 2016 07:24:29 +0000 (08:24 +0100)]
UploadBase: Set mFileSize, if given, even if mTempPath is unknown

When uploading a file from stash using the action=upload API, with
async=1, UploadFromStash is initialized without initializing a temp
file. dcb5ec5cbf92b9a07f0776b9c194183a13400193 accidentally made it so
that the given file size is ignored if there's no path. This caused
validity checks to fail (because mFileSize is null) and action=upload
to also fail with cryptic 'emptyfile' warning.

This made it impossible to upload files bigger than 10 MB using
UploadWizard, as it uses the async mode for them.

Bug: T130238
Change-Id: Ie35a66a565a370fe9adc66d5fee0866c4d51470e

8 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Sat, 19 Mar 2016 21:10:06 +0000 (22:10 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: I67c4a49a16f5cee599db767b1414cac75bc19fd5

8 years agobuild: Bump npm development dependencies to latest
James D. Forrester [Thu, 17 Mar 2016 19:45:21 +0000 (19:45 +0000)]
build: Bump npm development dependencies to latest

 grunt-contrib-copy     0.8.2  →    1.0.0
 grunt-contrib-watch    0.6.1  →    1.0.0
 karma                0.13.19  →  0.13.22

Change-Id: Idc5c1ac97580e91d9c958c55cdfdda681330c254

8 years agoMerge "Handle HTTPS when running jobs asynchronously"
jenkins-bot [Sat, 19 Mar 2016 16:27:43 +0000 (16:27 +0000)]
Merge "Handle HTTPS when running jobs asynchronously"

8 years agoListFiles: Call Skin::setRelevantUser() when applicable
rillke [Mon, 14 Mar 2016 05:28:04 +0000 (06:28 +0100)]
ListFiles: Call Skin::setRelevantUser() when applicable

Also validate user name before calling `User::newFromName()`

Bug: T129825
Change-Id: I7481ab0fc1720e5e840f0d552934324f676c0241

8 years agoCall Skin::setRelevantUser on Special:EmailUser
umherirrender [Sat, 19 Mar 2016 11:24:04 +0000 (12:24 +0100)]
Call Skin::setRelevantUser on Special:EmailUser

Adding the relevant user to the skin will add user releated links to the
navigation bar. User related links are: contributions, logs and blocks

Change-Id: I37126a228717addc9879fd69fcbe89057ca94cb7

8 years agoMerge "Many more function case mismatches"
jenkins-bot [Sat, 19 Mar 2016 00:37:53 +0000 (00:37 +0000)]
Merge "Many more function case mismatches"

8 years agoMany more function case mismatches
Reedy [Sat, 19 Mar 2016 00:08:06 +0000 (00:08 +0000)]
Many more function case mismatches

Change-Id: I5d3a5eb8adea1ecbf136415bb9fd7a162633ccca

8 years agoMerge "MediaWikiTestCase::assertException() was removed"
jenkins-bot [Sat, 19 Mar 2016 00:15:13 +0000 (00:15 +0000)]
Merge "MediaWikiTestCase::assertException() was removed"

8 years agoMediaWikiTestCase::assertException() was removed
Siebrand Mazeland [Tue, 8 Mar 2016 23:46:51 +0000 (00:46 +0100)]
MediaWikiTestCase::assertException() was removed

Deprecated since 1.22. No uses in core or Gerrit extensions remaining.

Change-Id: Icae4077078c73d766d3c1c9e9e569922151296d9

8 years agoUpdate grunt-karma to 0.12.2
Paladox [Fri, 18 Mar 2016 23:38:07 +0000 (23:38 +0000)]
Update grunt-karma to 0.12.2

Reason because this update will include a fix for incompatibility with
grunt 1.0.0 when it is released.

Change-Id: I39f01e3a68b764a4638c3465a1d116aefd517ef5

8 years agoMessage: Use RequestContext instead of $wgLang
Timo Tijhof [Tue, 1 Mar 2016 00:13:28 +0000 (00:13 +0000)]
Message: Use RequestContext instead of $wgLang

This cuts the $wgLang and StubUserLang which is a bit cleaner.
It also makes it more reliable when load.php sets its
RequestContext user interface language.

Bug: T127920
Change-Id: I05302feb9b3ce9e4c29541e07a4260effc4b55b2

8 years agoFix numerous class/function casing
Reedy [Fri, 18 Mar 2016 13:55:54 +0000 (13:55 +0000)]
Fix numerous class/function casing

Change-Id: I23982bfa0548c9ea3bdb432be7982f1563930715

8 years agoMerge "API: Allow fetching login token from action=query&meta=tokens on private wikis"
jenkins-bot [Fri, 18 Mar 2016 22:19:25 +0000 (22:19 +0000)]
Merge "API: Allow fetching login token from action=query&meta=tokens on private wikis"

8 years agoMerge "resetUserEmail: Allow resetting email without scrambling password"
jenkins-bot [Fri, 18 Mar 2016 22:04:52 +0000 (22:04 +0000)]
Merge "resetUserEmail: Allow resetting email without scrambling password"

8 years agoMerge "Actually make $wgNoReplyAddress default to $wgPasswordSender"
jenkins-bot [Fri, 18 Mar 2016 21:30:58 +0000 (21:30 +0000)]
Merge "Actually make $wgNoReplyAddress default to $wgPasswordSender"

8 years agoMerge "Localisation updates from https://translatewiki.net."
Translation updater bot [Fri, 18 Mar 2016 21:23:55 +0000 (21:23 +0000)]
Merge "Localisation updates from https://translatewiki.net."

8 years agoMerge "Try to fix some other broken-looking legacy maintenance script options"
jenkins-bot [Fri, 18 Mar 2016 21:13:39 +0000 (21:13 +0000)]
Merge "Try to fix some other broken-looking legacy maintenance script options"

8 years agoMerge "Register importImages options without arguments as actual maintenance script...
jenkins-bot [Fri, 18 Mar 2016 21:13:35 +0000 (21:13 +0000)]
Merge "Register importImages options without arguments as actual maintenance script options so they are usable"

8 years agoAPI: Allow fetching login token from action=query&meta=tokens on private wikis
Brad Jorsch [Wed, 16 Mar 2016 14:34:40 +0000 (10:34 -0400)]
API: Allow fetching login token from action=query&meta=tokens on private wikis

The problem is that ApiQuery requires the 'read' right even though
ApiQueryTokens doesn't.

So, we introduce an exception: if action=query gets only meta=tokens
(and optionally rawcontinue and indexpageids, since they don't affect
anything), no other modules and nothing in the ApiPageSet,
ApiQuery::isReadMode() will return false.

Bug: T130112
Change-Id: I83dafb0305ff0cb1fc3bac668b88b5d2022e5880

8 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Fri, 18 Mar 2016 20:57:36 +0000 (21:57 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: I935a1d0bbc9fa5028f2fa1c9b05272ec2e416a7a

8 years agoSpecialUploadStash: Add links to view a thumb of each uploaded file
Bartosz Dziewoński [Fri, 18 Mar 2016 19:50:44 +0000 (20:50 +0100)]
SpecialUploadStash: Add links to view a thumb of each uploaded file

Recently I'm debugging some upload stash issues, and I'm finding it
really annoying when I can't view what's hidden behind the meaningless
names, as it's refusing to serve any files above 1 MB. Constructing
the thumb paths by hand is tiresome.

Change-Id: Ia88b1bb8ef1c9599ee6bc727d310c48393be36fd

8 years agoMerge "ApiQueryStashImageInfo: Don't throw exceptions when the user is not logged in"
jenkins-bot [Fri, 18 Mar 2016 18:19:46 +0000 (18:19 +0000)]
Merge "ApiQueryStashImageInfo: Don't throw exceptions when the user is not logged in"

8 years agoMerge "Use imported namespaces, don't fully qualify"
jenkins-bot [Fri, 18 Mar 2016 18:15:39 +0000 (18:15 +0000)]
Merge "Use imported namespaces, don't fully qualify"

8 years agoMerge "Remove $wgAllowMicroDataAttributes and $wgAllowRdfaAttributes"
jenkins-bot [Fri, 18 Mar 2016 18:03:04 +0000 (18:03 +0000)]
Merge "Remove $wgAllowMicroDataAttributes and $wgAllowRdfaAttributes"

8 years agoRemove $wgAllowMicroDataAttributes and $wgAllowRdfaAttributes
Sébastien Santoro [Tue, 15 Mar 2016 18:23:10 +0000 (18:23 +0000)]
Remove $wgAllowMicroDataAttributes and $wgAllowRdfaAttributes

$wgAllowMicroDataAttributes and $wgAllowRdfaAttributes have been
introduced in MediaWiki 1.16 and required at this moment $wgHTML5
to be true. This last setting has been removed in MediaWiki 1.22.

To simplify the code maintenance and the configuration complexity,
those settings are removed and the features are always available.

RDFa users must now explicitly set $wgHtml5Version to a RDFa
version. Currently the correct values are:

  - HTML+RDFa 1.0
  - XHTML+RDFa 1.0

Bug: T130040
Change-Id: I17a7bff2cad170e381eabf0aec4e26e4fd0cddc3

8 years agoMerge "skins: Minor doc and code clean up in getCategories()"
jenkins-bot [Fri, 18 Mar 2016 16:31:14 +0000 (16:31 +0000)]
Merge "skins: Minor doc and code clean up in getCategories()"

8 years agoMerge "Change "COMMIT ENQUEUED" warnings to level INFO"
jenkins-bot [Fri, 18 Mar 2016 16:30:52 +0000 (16:30 +0000)]
Merge "Change "COMMIT ENQUEUED" warnings to level INFO"

8 years agoMerge "Make spreadAnyEditBlock() calls respect read-only mode"
jenkins-bot [Fri, 18 Mar 2016 16:28:41 +0000 (16:28 +0000)]
Merge "Make spreadAnyEditBlock() calls respect read-only mode"

8 years agoMerge "SpecialUploadStash: Convert form to OOUI"
jenkins-bot [Fri, 18 Mar 2016 16:17:23 +0000 (16:17 +0000)]
Merge "SpecialUploadStash: Convert form to OOUI"

8 years agoApiQueryStashImageInfo: Don't throw exceptions when the user is not logged in
Bartosz Dziewoński [Fri, 18 Mar 2016 00:14:35 +0000 (01:14 +0100)]
ApiQueryStashImageInfo: Don't throw exceptions when the user is not logged in

Bug: T130253
Change-Id: If70b919c65a21b57b3022d495756bf250b0ba786

8 years agoMerge "Link to Special:WhatLinksHere in CatWatch bundeled summary"
jenkins-bot [Fri, 18 Mar 2016 14:21:24 +0000 (14:21 +0000)]
Merge "Link to Special:WhatLinksHere in CatWatch bundeled summary"

8 years agoActually make $wgNoReplyAddress default to $wgPasswordSender
Reedy [Fri, 18 Mar 2016 14:19:07 +0000 (14:19 +0000)]
Actually make $wgNoReplyAddress default to $wgPasswordSender

Bug: T130368
Change-Id: Ifc32f0cf82ea80361822f612b0c6aeb427721606

8 years agoUse imported namespaces, don't fully qualify
Reedy [Fri, 18 Mar 2016 14:02:26 +0000 (14:02 +0000)]
Use imported namespaces, don't fully qualify

Remove unused import in CachedBagOStuff

Change-Id: I60ca8acc0e34384ce6ad6cde1cfb3a5dc8021e5f

8 years agoEnsure that User::getId() returns int
Siebrand Mazeland [Fri, 18 Mar 2016 13:23:40 +0000 (14:23 +0100)]
Ensure that User::getId() returns int

And document User::mId as such.

Change-Id: I65a5a284257da50830675f074f890f27701900e0

8 years agobuild: Remove redundant jscs rule 'disallowQuotedKeysInObjects'
Ricordisamoa [Fri, 18 Mar 2016 09:54:44 +0000 (10:54 +0100)]
build: Remove redundant jscs rule 'disallowQuotedKeysInObjects'

{ "allExcept": [ "reserved" ] } found in the wikimedia preset is
the same as the customized "allButReserved" present in MediaWiki,
except that the latter is deprecated as stated at:
http://jscs.info/rule/disallowQuotedKeysInObjects

Change-Id: I5de2a8f7ad42857ccdc793551d08c77e2aae8156

8 years agoMake spreadAnyEditBlock() calls respect read-only mode
Aaron Schulz [Fri, 18 Mar 2016 01:16:18 +0000 (18:16 -0700)]
Make spreadAnyEditBlock() calls respect read-only mode

Bug: T129968
Change-Id: Ib391bd880fa9e04777a355634035183065de5b0a

8 years agoMerge "Log slow diffs"
jenkins-bot [Fri, 18 Mar 2016 00:52:59 +0000 (00:52 +0000)]
Merge "Log slow diffs"

8 years agoChange "COMMIT ENQUEUED" warnings to level INFO
Aaron Schulz [Fri, 18 Mar 2016 00:50:19 +0000 (17:50 -0700)]
Change "COMMIT ENQUEUED" warnings to level INFO

These are too unimportant and spammy

Change-Id: I2205d9b42014f138ac523967f91df6d340234256

8 years agoMerge "Rename ApiRequest to ApiAction"
jenkins-bot [Fri, 18 Mar 2016 00:08:57 +0000 (00:08 +0000)]
Merge "Rename ApiRequest to ApiAction"

8 years agoSpecialUploadStash: Convert form to OOUI
Bartosz Dziewoński [Thu, 17 Mar 2016 22:45:20 +0000 (23:45 +0100)]
SpecialUploadStash: Convert form to OOUI

Bug: T130328
Change-Id: I2ebbc783ff93dd47c552fa88230ea5ab2dbefb1e

8 years agoMerge "SpecialUploadStash: Disable output gzipping when outputting remove scaled...
jenkins-bot [Thu, 17 Mar 2016 22:51:33 +0000 (22:51 +0000)]
Merge "SpecialUploadStash: Disable output gzipping when outputting remove scaled thumb"

8 years agoRename ApiRequest to ApiAction
Bryan Davis [Thu, 17 Mar 2016 22:43:50 +0000 (16:43 -0600)]
Rename ApiRequest to ApiAction

Half of the work needed for handling this logging stream was done using
the channel name "ApiRequest" and the other half was done under the name
"ApiAction". The ApiRequest naming is easier to change at this point.

Bug: T108618
Change-Id: I5797731abeba22ef6ced7c8407ee670344d35b3d

8 years agoSpecialUploadStash: Disable output gzipping when outputting remove scaled thumb
Bartosz Dziewoński [Thu, 17 Mar 2016 22:22:00 +0000 (23:22 +0100)]
SpecialUploadStash: Disable output gzipping when outputting remove scaled thumb

This is the only code path that wasn't calling wfResetOutputBuffers()
already. All other ones end up in outputLocalFile(), which calls
it via StreamFile::prepareForStream().

I can't really tell why this causes Varnish stuff to go bust, but it's
definitely the right thing to do anyway.

Bug: T130204
Change-Id: Ib6bc9c64c6c893fd7f5a5d906da32d9bee509a98

8 years agoCast API timeSpentBackend to an int
Bryan Davis [Thu, 17 Mar 2016 22:16:25 +0000 (16:16 -0600)]
Cast API timeSpentBackend to an int

Fixes {"timeSpentBackend":"Expected integer, but received double"} Avro
encoding error.

Bug: T108618
Change-Id: Iea79d14afe0ef0d1a9ea88096b7bbd90083df757

8 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Thu, 17 Mar 2016 21:37:47 +0000 (22:37 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: I610b8736afb5cc84d6a057c521a241c3656b73b8

8 years agoskins: Minor doc and code clean up in getCategories()
Timo Tijhof [Thu, 17 Mar 2016 19:53:42 +0000 (19:53 +0000)]
skins: Minor doc and code clean up in getCategories()

* Clarify @return as being a string of HTML.
* Use Html class instead of inline string concatenation.

Change-Id: If3ff352aca897c3952b1f4d6c1b9416f9db35ae6

8 years agoMention that 'APIEditBeforeSave' is also being run on undo
Marius Hoch [Thu, 17 Mar 2016 19:11:30 +0000 (20:11 +0100)]
Mention that 'APIEditBeforeSave' is also being run on undo

This came up in T126861 where we identified this as desired
behavior.

Change-Id: I37e8f59b4b88cc289709da9802df3a0f123939b1

8 years agoAdd WatchedItemStore::countVisitingWatchersMultiple
Leszek Manicki [Tue, 15 Mar 2016 10:39:22 +0000 (11:39 +0100)]
Add WatchedItemStore::countVisitingWatchersMultiple

This is for batch counting of visiting watchers, following the change
made in I2868c31fc09121de381d822e8f49194e3022bb42.
Query/logic has been extracted from ApiQueryInfo.

Bug: T129482
Change-Id: Ia9a534f5edb7af3cb7bf86be358dddb5d8c259cf

8 years agoLink to Special:WhatLinksHere in CatWatch bundeled summary
addshore [Fri, 26 Feb 2016 10:28:16 +0000 (10:28 +0000)]
Link to Special:WhatLinksHere in CatWatch bundeled summary

This link could probably also include
&hidelinks=1&hideredirs=1 options
at a later stage

Bug: T119712
Change-Id: I578d550d25d92e20360bcaaf5392ef75a868a483

8 years agoAdd --with-phpunitclass arg to phpunit.php
Adrian Heine [Thu, 17 Mar 2016 12:28:34 +0000 (13:28 +0100)]
Add --with-phpunitclass arg to phpunit.php

This would allow to easily use stuff like
https://github.com/fiunchinho/phpunit-randomizer.

Change-Id: I28e8b1d261de0395366b18465a0adc4d7c4fde4a

8 years agoMerge "Fix ApiQueryInfo response for prop=watchers"
jenkins-bot [Thu, 17 Mar 2016 10:09:03 +0000 (10:09 +0000)]
Merge "Fix ApiQueryInfo response for prop=watchers"

8 years agoMerge "Fix documentation lies about debug toolbar / cache interaction"
jenkins-bot [Thu, 17 Mar 2016 10:04:59 +0000 (10:04 +0000)]
Merge "Fix documentation lies about debug toolbar / cache interaction"

8 years agoFix ApiQueryInfo response for prop=watchers
Leszek Manicki [Wed, 16 Mar 2016 16:07:31 +0000 (17:07 +0100)]
Fix ApiQueryInfo response for prop=watchers

Ie84e6feaa42db1bc7a1f89b56aed37dd7fe95ea4 part of them problem
with incorrect API response but if when no watchers data is
fetched (ie. due to early return in ApiQueryInfo::getWatcherInfo),
response contains "watchers": null instead of skipping "watchers"
key entirely.

Bug: T129482
Change-Id: I9cab120ec4e6a9cf4626678e45ef14ea8efc8cbc

8 years agoMerge "mediawiki.api.parse: Restore support for stringified objects"
jenkins-bot [Thu, 17 Mar 2016 02:04:30 +0000 (02:04 +0000)]
Merge "mediawiki.api.parse: Restore support for stringified objects"

8 years agoMerge "Action::factory: Don't crash on missing Action classes"
jenkins-bot [Thu, 17 Mar 2016 01:05:49 +0000 (01:05 +0000)]
Merge "Action::factory: Don't crash on missing Action classes"

8 years agomediawiki.api.parse: Restore support for stringified objects
Matthew Flaschen [Fri, 11 Mar 2016 00:04:15 +0000 (19:04 -0500)]
mediawiki.api.parse: Restore support for stringified objects

Follows-up 11e6b3d. Don't assume non-string values are mw.Title objects.
mw.Title is the special case. Restore the previous default of assuming wikitext.

This was presumably avoided earlier because 'instanceof' throws if given undefined
as right-hand expression and don't want a needless dependency on mediawiki.Title.

Change-Id: I794ed4105d116e63ed505a17a237f289b80d3b15

8 years agoAction::factory: Don't crash on missing Action classes
Roan Kattouw [Thu, 17 Mar 2016 00:39:54 +0000 (17:39 -0700)]
Action::factory: Don't crash on missing Action classes

Show the "no such action" error message instead.

Normally I wouldn't favor putting this in here, but it's way
too easy to register a missing class by accident, see my rant
on T107921#2128080.

Bug: T107921
Change-Id: I56da8a5810cae3547a0c8f2d3f435dfd790fbeaf

8 years agoMerge "Support multiple extension-dir paths to be passed to mergeMessageFileList"
jenkins-bot [Wed, 16 Mar 2016 22:32:43 +0000 (22:32 +0000)]
Merge "Support multiple extension-dir paths to be passed to mergeMessageFileList"

8 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Wed, 16 Mar 2016 20:56:35 +0000 (21:56 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: I2cd76699393ba63879babd31f435387593d3a2aa