2 years agoMerge "Selenium: replace UserLoginPage with BlankPage where possible"
jenkins-bot [Mon, 8 Jul 2019 17:00:13 +0000 (17:00 +0000)]
Merge "Selenium: replace UserLoginPage with BlankPage where possible"

2 years agoMerge "build: use the latest webdriverio 4.x related packages"
jenkins-bot [Mon, 8 Jul 2019 15:59:18 +0000 (15:59 +0000)]
Merge "build: use the latest webdriverio 4.x related packages"

2 years agoMerge "Improve specialmute-email-footer description"
jenkins-bot [Mon, 8 Jul 2019 15:50:44 +0000 (15:50 +0000)]
Merge "Improve specialmute-email-footer description"

2 years agobuild: use the latest webdriverio 4.x related packages
Željko Filipin [Mon, 8 Jul 2019 13:29:06 +0000 (15:29 +0200)]
build: use the latest webdriverio 4.x related packages

Updating packages removes dependency on cryptiles. We were using
version 3.1.4 that had a vulnerability.

Bug: T226586
Change-Id: Idccc7f418ed6fce7452a6f0d403477953448a541

2 years agoImprove specialmute-email-footer description
Dayllan Maza [Mon, 8 Jul 2019 14:25:11 +0000 (10:25 -0400)]
Improve specialmute-email-footer description

Change-Id: I058d3477b0707e2fbf09a94517a6005e0694dbae

2 years agoSelenium: replace UserLoginPage with BlankPage where possible
Željko Filipin [Fri, 10 May 2019 15:56:42 +0000 (17:56 +0200)]
Selenium: replace UserLoginPage with BlankPage where possible

When using local storage, any page has to be open. UserLoginPage is usually used.
BlankPage should be slightly faster to load. It also makes it more clear than
any page would do the job.

Change-Id: I50b23993065ad6b093a6cc951d00b0bf7a3d5e68

2 years agoMerge "Move unit tests FormatJsonTest.php to a dedicated file in unit tests"
jenkins-bot [Mon, 8 Jul 2019 12:49:17 +0000 (12:49 +0000)]
Merge "Move unit tests FormatJsonTest.php to a dedicated file in unit tests"

2 years agoMerge "Split SanitizerTest to unit and integration tests"
jenkins-bot [Mon, 8 Jul 2019 12:40:50 +0000 (12:40 +0000)]
Merge "Split SanitizerTest to unit and integration tests"

2 years agoSplit SanitizerTest to unit and integration tests
Amir Sarabadani [Mon, 8 Jul 2019 00:05:57 +0000 (02:05 +0200)]
Split SanitizerTest to unit and integration tests

Out of 150 tests of SanitizerTest.php, 100 of them are pure unit tests
they are moved to the new file in the new structure, the rest stay

Change-Id: I366d37607abff4bcd624a56fb8b2299729fbc088

2 years agoMerge "Reorganize testsuites"
jenkins-bot [Mon, 8 Jul 2019 07:47:41 +0000 (07:47 +0000)]
Merge "Reorganize testsuites"

2 years agoMerge "Change the autonym of Minangkabau from "Baso Minangkabau" to "Minangkabau""
jenkins-bot [Mon, 8 Jul 2019 06:31:42 +0000 (06:31 +0000)]
Merge "Change the autonym of Minangkabau from "Baso Minangkabau" to "Minangkabau""

2 years agoMerge "Tell users how they can force a maintenance script to run again."
jenkins-bot [Mon, 8 Jul 2019 05:44:07 +0000 (05:44 +0000)]
Merge "Tell users how they can force a maintenance script to run again."

2 years agoChange the autonym of Minangkabau from "Baso Minangkabau" to "Minangkabau"
Mahuton [Mon, 8 Jul 2019 05:04:17 +0000 (07:04 +0200)]
Change the autonym of Minangkabau from "Baso Minangkabau" to "Minangkabau"

Change requested on the Minangkabau Wikipedia village pump

Bug: T224806
Change-Id: I40ddc71f4f6ab73b6d4c4f19ec57bc9c9e221b14

2 years agoMove unit tests FormatJsonTest.php to a dedicated file in unit tests
Amir Sarabadani [Sun, 7 Jul 2019 22:23:30 +0000 (00:23 +0200)]
Move unit tests FormatJsonTest.php to a dedicated file in unit tests

Out of 140 tests of this file, 131 one of them are pure unit test
Let's keep the 9 in the original file and move the rest

Bug: T87781
Change-Id: I86dfe17f794c615048b3c20487b0e84d38d13b93

2 years agoReorganize testsuites
Kosta Harlan [Fri, 5 Jul 2019 15:33:08 +0000 (11:33 -0400)]
Reorganize testsuites

The idea is that `vendor/bin/phpunit` could run all of the tests contained in
core + extensions + skins with no overlap, but that we can also provide
granularity for CI which wants to run some testsuites (e.g. core:unit and
core:integration) before extensions/skins, as well as running unit before
integration tests.

Bug: T87781
Change-Id: I2fb57f4a9a58ec7a4042d9cc1821cc484661a6b9

2 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Sun, 7 Jul 2019 20:08:26 +0000 (22:08 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I3f6364eed16e0f0479410147d289b4197c563643

2 years agoMerge "Don't process "all" option in Html::namespaceSelectorOptions"
jenkins-bot [Sat, 6 Jul 2019 15:17:54 +0000 (15:17 +0000)]
Merge "Don't process "all" option in Html::namespaceSelectorOptions"

2 years agoMerge "OutputPage: Load html5shiv without indirection of load.php"
jenkins-bot [Sat, 6 Jul 2019 01:00:54 +0000 (01:00 +0000)]
Merge "OutputPage: Load html5shiv without indirection of load.php"

3 years agoOutputPage: Load html5shiv without indirection of load.php
Timo Tijhof [Thu, 4 Jul 2019 15:54:24 +0000 (16:54 +0100)]
OutputPage: Load html5shiv without indirection of load.php

This library was introduced in 3a30e03645f, to make sure Grade C
stylesheets that apply to HTML5 elements that older browsers might
not know yet, work as expected in old IE.

It originally committed a minified version and loaded it directly
as an HTML script tag in a conditional comment. This had minimal
impact on anything else, and was easy to maintain.

In 68237fb1a74, this was changed to commit the unminified version
instead because Debian maintainers don't like packaging software
that contain minified files, despite being a simple file,
unmodified from the original (upstream publishes it in minified
form, with license header), published under a compatible free
license, and embedded in a license-compliant manner. We then
registered it as an unused ResourceLoader module, to be minified
on-the-fly at run-time.

Support for "server-registered client-unregistered" modules was
removed last week in c554ee8e64e because nothing needed it
anymore (except html5shiv apparently), which resulted in this
module being registered client-side on all page views for all
users (in latest master). This doesn't break anything, but it
is a regression performance-wise.

Restore this by (mostly) going to how it was before: A simple static
file, committed to Git, served as-is. Not related to, served by,
pulled through, nor registered with, ResourceLoader in any way.

Only difference with the original approach is that it is no longer
minified, which means a few more bytes transferred on old IE page
views, which is considered an acceptable compromise.

Bug: T201483
Change-Id: Ib0020b6bd015679b61f63eaa8109ed9b83d8ad15

3 years agoMerge "Fix type hints in jobqueue related classes"
jenkins-bot [Fri, 5 Jul 2019 23:10:40 +0000 (23:10 +0000)]
Merge "Fix type hints in jobqueue related classes"

3 years agoMerge "Adjust type hints in file related classes"
jenkins-bot [Fri, 5 Jul 2019 23:10:34 +0000 (23:10 +0000)]
Merge "Adjust type hints in file related classes"

3 years agoMerge "rdbms: clean up $groups logic in LoadBalancer and expand comments"
jenkins-bot [Fri, 5 Jul 2019 22:00:09 +0000 (22:00 +0000)]
Merge "rdbms: clean up $groups logic in LoadBalancer and expand comments"

3 years agoMerge "Adjust type hints in htmlform related classes"
jenkins-bot [Fri, 5 Jul 2019 21:32:55 +0000 (21:32 +0000)]
Merge "Adjust type hints in htmlform related classes"

3 years agoMerge "build: Update eslint-config-wikimedia to 0.13.0"
jenkins-bot [Fri, 5 Jul 2019 21:18:30 +0000 (21:18 +0000)]
Merge "build: Update eslint-config-wikimedia to 0.13.0"

3 years agoMerge "Pass int for argument to ArchivedFile"
jenkins-bot [Fri, 5 Jul 2019 21:02:51 +0000 (21:02 +0000)]
Merge "Pass int for argument to ArchivedFile"

3 years agobuild: Update eslint-config-wikimedia to 0.13.0
Ed Sanders [Fri, 5 Jul 2019 19:38:29 +0000 (20:38 +0100)]
build: Update eslint-config-wikimedia to 0.13.0

Change-Id: I7df5840bc97f8bbcd8cfc875c2b48b3061ef2c9e

3 years agoFix type hints in jobqueue related classes
Umherirrender [Fri, 5 Jul 2019 20:20:56 +0000 (22:20 +0200)]
Fix type hints in jobqueue related classes

JobQueueGroup is giving RunnableJob on pop(), so it should take the same
type for ack() and deduplicateRootJob()
JobQueue::ack alsready accept the interface

Also change to RunnableJob in JobRunner to work with the type from the
job queue

Change-Id: I7b09586cff8affabe807ee16e80d04f5137dce45

3 years agoPass int for argument to ArchivedFile
Umherirrender [Fri, 5 Jul 2019 20:17:53 +0000 (22:17 +0200)]
Pass int for argument to ArchivedFile

ArchivedFile constructor is complex, but use the correct type for
unneeded arguments

Change-Id: I111daf7fb69d4448d8a362ba70735f3312869c7f

3 years agoMerge "Bidi isolate user names in block error paramters"
jenkins-bot [Fri, 5 Jul 2019 19:25:38 +0000 (19:25 +0000)]
Merge "Bidi isolate user names in block error paramters"

3 years agoAdjust type hints in file related classes
Umherirrender [Mon, 1 Jul 2019 20:30:14 +0000 (22:30 +0200)]
Adjust type hints in file related classes

Change-Id: I3811e0d9a3297293bc52c1a98f3e8fdb5a3d0e85

3 years agoAdjust type hints in htmlform related classes
Umherirrender [Tue, 18 Jun 2019 20:16:31 +0000 (22:16 +0200)]
Adjust type hints in htmlform related classes

The return type of HTMLFormField::loadDataFromRequest to mixed
Some sub classes returning arrays or bools, not everytime strings

HTMLCheckField is working with arrays, so also allow array on getTableRow

Change-Id: I076feea76d8e296f27c8a9fb4cbd9368584ba187

3 years agoMerge "PopulateContentTables: compute sha1 and length if needed."
jenkins-bot [Fri, 5 Jul 2019 15:40:45 +0000 (15:40 +0000)]
Merge "PopulateContentTables: compute sha1 and length if needed."

3 years agoMerge "Add "help" link to Special:Unblock"
jenkins-bot [Fri, 5 Jul 2019 15:40:38 +0000 (15:40 +0000)]
Merge "Add "help" link to Special:Unblock"

3 years agoMerge "Follow-up 9c9cfa2ec3d7: fix non-session entry point error"
jenkins-bot [Fri, 5 Jul 2019 15:02:57 +0000 (15:02 +0000)]
Merge "Follow-up 9c9cfa2ec3d7: fix non-session entry point error"

3 years agoBidi isolate user names in block error paramters
Thalia [Thu, 27 Jun 2019 18:24:52 +0000 (19:24 +0100)]
Bidi isolate user names in block error paramters

This fixes parameters returned by AbstractBlock::getBlockErrorParams,
but not those from ApiBlockInfoTrait.

Change-Id: I122017808766de1e9a9035f2f39a7b08607e56c1

3 years agoPopulateContentTables: compute sha1 and length if needed.
daniel [Thu, 4 Jul 2019 11:54:20 +0000 (13:54 +0200)]
PopulateContentTables: compute sha1 and length if needed.

PopulateContentTables tries to copy rev_sha1 to content_sha1 and rev_len
to content_size, but when updating directly from on old version of
MediaWiki, these fields may be empty or NULL. To ensure that the content
table gets the correct value, we have to compute them on the fly.

Note that PopulateRevisionSha1 runs *after* the normal database updates.
So even though it was introduced in 1.19, it will run after the schema
updates for 1.32, which include PopulateContentTables. This means that
PopulateContentTables can't rely on rev_sha1 to have been filled in
already. But per I0c22286a16d7b, it also means that PopulateRevisionSha1
can make use of the hash in content_sha1 instead of re-calculating.

Bug: T217831
Bug: T200653
Change-Id: I69e91a812ad5f038562220b02c3634589667cdb6

3 years agoTell users how they can force a maintenance script to run again.
daniel [Fri, 5 Jul 2019 13:20:02 +0000 (15:20 +0200)]
Tell users how they can force a maintenance script to run again.

Subclasses of LoggedUpdateMaintenance tell the user that "Update
'{$key}' already logged as completed". This adds "Use --force to
run it again."

Bug: T200653
Change-Id: I8cf3c5383c0fecdc92b58048138332855b5602a6

3 years agoMerge "Import the PSR logger classes in Message"
jenkins-bot [Fri, 5 Jul 2019 06:59:10 +0000 (06:59 +0000)]
Merge "Import the PSR logger classes in Message"

3 years agoMerge "Update populateRevisionSha1.php for MCR schema changes"
jenkins-bot [Fri, 5 Jul 2019 06:56:39 +0000 (06:56 +0000)]
Merge "Update populateRevisionSha1.php for MCR schema changes"

3 years agoMerge "SlotRecord:compute sha1 if empty."
jenkins-bot [Fri, 5 Jul 2019 06:56:31 +0000 (06:56 +0000)]
Merge "SlotRecord:compute sha1 if empty."

3 years agoMerge "resourceloader: Only output ResourceLoaderDynamicStyles when needed"
jenkins-bot [Fri, 5 Jul 2019 02:25:23 +0000 (02:25 +0000)]
Merge "resourceloader: Only output ResourceLoaderDynamicStyles when needed"

3 years agoMerge "Fix types around ILoadBalancer and IResultWrapper"
jenkins-bot [Thu, 4 Jul 2019 22:30:35 +0000 (22:30 +0000)]
Merge "Fix types around ILoadBalancer and IResultWrapper"

3 years agoMerge "rdbms: fix typo and clean up some cruft in MWLBFactory"
jenkins-bot [Thu, 4 Jul 2019 22:30:27 +0000 (22:30 +0000)]
Merge "rdbms: fix typo and clean up some cruft in MWLBFactory"

3 years agordbms: clean up $groups logic in LoadBalancer and expand comments
Aaron Schulz [Mon, 24 Jun 2019 23:36:42 +0000 (16:36 -0700)]
rdbms: clean up $groups logic in LoadBalancer and expand comments

Split out private resolveGroups() method for normalizing query
groups. Move some server index validation to getConnectionIndex()
and make it stricter.

Make getConnectionIndex() group fallback logic aware of the generic
group. The main use case for custom default groups is heavy scripts
or jobs that run in the background. It is probably better to have
good DB server redundancy for the query group and rely on it rather
than possibly fallback onto all of the main servers used for normal
requests. The later behavior could spread slowness or outages.

Also make getAnyOpenConnection() more robust and readable by
splitting out a private pickAnyOpenConnection() method that
checks IDatabase::trxLevel().

In addition, remove redundant is_int() check from isOpen()
method as it will return false in that case even without it.

Remove bogus getConnection() parameter in testCopyTestData().

Change-Id: Ica619c5487c761c724791d151db7388e4b41b0aa

3 years agoMerge "Fix `cursor` on TagItemWidgets"
jenkins-bot [Thu, 4 Jul 2019 20:00:22 +0000 (20:00 +0000)]
Merge "Fix `cursor` on TagItemWidgets"

3 years agoFix types around ILoadBalancer and IResultWrapper
Umherirrender [Thu, 4 Jul 2019 19:56:31 +0000 (21:56 +0200)]
Fix types around ILoadBalancer and IResultWrapper

Change-Id: I08531ccc6db046114f3535cfe6c108936dfff0d0

3 years agoImport the PSR logger classes in Message
Aaron Schulz [Thu, 4 Jul 2019 19:51:09 +0000 (12:51 -0700)]
Import the PSR logger classes in Message

Change-Id: If05db9b55275246174b6f1fd0ca8437f271f5eea

3 years agoMerge "Fix type hints in objectcache related classes"
jenkins-bot [Thu, 4 Jul 2019 19:47:40 +0000 (19:47 +0000)]
Merge "Fix type hints in objectcache related classes"

3 years agoMerge "Fix param documentation of ProtectionForm::show"
jenkins-bot [Thu, 4 Jul 2019 19:44:23 +0000 (19:44 +0000)]
Merge "Fix param documentation of ProtectionForm::show"

3 years agoMerge "PreferencesFormOOUI: Avoid Phan warning with weird signature of TabPanelLayout"
jenkins-bot [Thu, 4 Jul 2019 19:40:39 +0000 (19:40 +0000)]
Merge "PreferencesFormOOUI: Avoid Phan warning with weird signature of TabPanelLayout"

3 years agoMerge "resourceloader: Set value for getStoreKey in server-side"
jenkins-bot [Thu, 4 Jul 2019 19:25:12 +0000 (19:25 +0000)]
Merge "resourceloader: Set value for getStoreKey in server-side"

3 years agoMerge "resourceloader: Set value for getVary in server-side"
jenkins-bot [Thu, 4 Jul 2019 19:25:03 +0000 (19:25 +0000)]
Merge "resourceloader: Set value for getVary in server-side"

3 years agoresourceloader: Only output ResourceLoaderDynamicStyles when needed
Timo Tijhof [Wed, 26 Jun 2019 23:20:33 +0000 (00:20 +0100)]
resourceloader: Only output ResourceLoaderDynamicStyles when needed

In mediawiki.js, this marker has always been optional, falling back to
appending to <head>. When no stylesheets need to be after the marker
(e.g. no site styles on the wiki, and user is not logged-in), then
there is no need for the marker to exist.

In a previous refactor, I was going to do this and created an
"$append" variable in the function to do what this commit does,
but I forgot to actually use it for anything.

Test Plan:
* Local wiki, with no MediaWiki:Common/{Skinname}.css pages existing.
* When logged-out, before this change, there is a marker, now there is not.
* When creating "MediaWiki:Group-user.css" and logging in, there is still
  a marker, and it is still above the <link> for that user styles request
  in the <head>.

Bug: T219342
Change-Id: I2e9657f318088860916823efeb96ae4f1532974c

3 years agoAdd "help" link to Special:Unblock
DannyS712 [Thu, 4 Jul 2019 19:08:31 +0000 (19:08 +0000)]
Add "help" link to Special:Unblock

Bug: T227295
Change-Id: I53712b6f4fc071fecc413f41e8815b73417c205b

3 years agoMerge "Remove "successfully" from specialmute-success and add a link title"
jenkins-bot [Thu, 4 Jul 2019 19:04:26 +0000 (19:04 +0000)]
Merge "Remove "successfully" from specialmute-success and add a link title"

3 years agordbms: fix typo and clean up some cruft in MWLBFactory
Aaron Schulz [Thu, 4 Jul 2019 06:29:06 +0000 (23:29 -0700)]
rdbms: fix typo and clean up some cruft in MWLBFactory

Change-Id: Ib51dfee9ed06326a8b3acfed136e75b13fc4e234

3 years agoPreferencesFormOOUI: Avoid Phan warning with weird signature of TabPanelLayout
Bartosz Dziewoński [Thu, 4 Jul 2019 17:38:58 +0000 (19:38 +0200)]
PreferencesFormOOUI: Avoid Phan warning with weird signature of TabPanelLayout

TabPanelLayout is documented to take two parameters, $name and $config.
The $name position parameter can also be passed as a named config option
in the $config array, but doing so confuses Phan, since there's no good
way to document it. Just don't do it.

Bug: T227144
Change-Id: Ifbd776844d722d58bf9f13cacc490407320731c6

3 years agoresourceloader: Set value for getStoreKey in server-side
Fomafix [Sat, 29 Jun 2019 07:47:57 +0000 (09:47 +0200)]
resourceloader: Set value for getStoreKey in server-side

This change reduces the size of the JavaScript resources.

Change-Id: I850249f910f6275c1b963dc5421ba706ed6e9a56

3 years agoresourceloader: Set value for getVary in server-side
Fomafix [Fri, 28 Jun 2019 13:06:42 +0000 (15:06 +0200)]
resourceloader: Set value for getVary in server-side

This change makes ResourceLoaderStorageVersion a private variable.
The JavaScript global variable wgResourceLoaderStorageVersion is now

This change makes the JavaScript code smaller.

Change-Id: I8e31b95d4c44ba653bedb6be500011a39bc6abd8

3 years agoRemove "successfully" from specialmute-success and add a link title
Amir Aharoni [Tue, 2 Jul 2019 09:39:24 +0000 (12:39 +0300)]
Remove "successfully" from specialmute-success and add a link title

The word "successfully" is unnecessary, according to

The link title will make the whole message more readable in English,
and easier to translate into all languages.

Change-Id: I840bd385f6918658b4a02df4c3ac0a60814abf5a

3 years agoresourceloader: Remove 'mw.legacy' placeholder object
Timo Tijhof [Thu, 4 Jul 2019 16:29:29 +0000 (17:29 +0100)]
resourceloader: Remove 'mw.legacy' placeholder object

This was very briefly used during the development cycle of
MediaWiki 1.16 in 2010. The idea was to port some pre-RL legacy
modules from global variables to mw.legacy.* (such as sajax,
wikibits and other such 'mediawiki.legacy.*' modules),
with a back-compat deprecate-warning alias from their old global
names to the mw.legacy.* namespace.

This was abandoned prior to stable release and never used again,
and properly deprecated after years of no use in MediaWiki 1.22.

Remove this now, finally.

Change-Id: I9ef0984da7a07d4778fbeb71f3d4a7ebba97f29f

3 years agoobjectcache: optimize lock() and unlock() methods in SqlBagOStuff
Aaron Schulz [Sat, 29 Jun 2019 08:36:01 +0000 (01:36 -0700)]
objectcache: optimize lock() and unlock() methods in SqlBagOStuff

Also clean up base method in BagOStuff.

Bug: T113916
Change-Id: I3a1c6afe531a8eae34608bc7fe0aa6f9f4d439fe

3 years agoMerge "Rename various $wikiId fields/parameters to $dbDomain in user classes"
jenkins-bot [Thu, 4 Jul 2019 13:58:54 +0000 (13:58 +0000)]
Merge "Rename various $wikiId fields/parameters to $dbDomain in user classes"

3 years agoMerge "rdbms: make implement IResultWrapper directly instead of via inheritence"
jenkins-bot [Thu, 4 Jul 2019 13:58:16 +0000 (13:58 +0000)]
Merge "rdbms: make implement IResultWrapper directly instead of via inheritence"

3 years agordbms: make implement IResultWrapper directly instead of via inheritence
Aaron Schulz [Thu, 20 Jun 2019 22:17:22 +0000 (23:17 +0100)]
rdbms: make implement IResultWrapper directly instead of via inheritence

Change-Id: If1b15c0c21d0ee336025fb99f47fc19ddf1d5435

3 years agordbms: make temp table tracking in Database more robust
Aaron Schulz [Sat, 8 Jun 2019 06:32:27 +0000 (07:32 +0100)]
rdbms: make temp table tracking in Database more robust

Do not register table changes until query success

Change-Id: I8c0eeb510d15e2f4cc014f62b7a0f146e31b6613

3 years agoUpdate populateRevisionSha1.php for MCR schema changes
Bill Pirkle [Thu, 13 Jun 2019 03:39:43 +0000 (22:39 -0500)]
Update populateRevisionSha1.php for MCR schema changes

Maintenance script populateRevisionSha1.php was using the deprecated
Revision class. Instead, use the new RevisionRecord class if
possible, and custom code otherwise.

Bug: T217829
Change-Id: I0c22286a16d7b243306447d8948428702269a4bd

3 years agoSlotRecord:compute sha1 if empty.
daniel [Thu, 4 Jul 2019 08:52:55 +0000 (10:52 +0200)]
SlotRecord:compute sha1 if empty.

The SHA1 should be computed automatically if empty, not just if it is
missing entirely. This is needed since rev_sha1 may contain an empty
string for old revisions.

Bug: T200653
Bug: T219816
Change-Id: Ia6870a828bc9661fb05085e36315a86483ec48c4

3 years agoDon't process "all" option in Html::namespaceSelectorOptions
Matěj Suchánek [Thu, 4 Jul 2019 08:02:28 +0000 (10:02 +0200)]
Don't process "all" option in Html::namespaceSelectorOptions

The value of "all" can be completely arbitrary and in practice
it's usually an empty string. Avoid attempting to filter it out
and format anyhow.

Bug: T227202
Change-Id: I371466407bd038914faa4dc3b0cae9547cf427eb

3 years agordbms: optimize DatabaseDomain::newFromId() to remember the string form
Aaron Schulz [Thu, 4 Jul 2019 06:39:30 +0000 (23:39 -0700)]
rdbms: optimize DatabaseDomain::newFromId() to remember the string form

Change-Id: I9505a17e25589a77b898d300ad318c92ccc6a94b

3 years agoFollow-up 9c9cfa2ec3d7: fix non-session entry point error
Roan Kattouw [Thu, 4 Jul 2019 00:28:07 +0000 (17:28 -0700)]
Follow-up 9c9cfa2ec3d7: fix non-session entry point error

Even though we shouldn't really need to, we have to set the language on
the RawMessage we generate when the tag message doesn't exist. Because
both MessageLocalizer and RawMessage are kind of hacky and not fully
supported, I had to hack around the various gaps in our infrastructure.
See my comment on the task for details.

Bug: T227233
Change-Id: I5ab3e9b1e8d34b1af531dba33b2f92fcd7f12192

3 years agoMerge "Remove JavaScript global variable wgLoadScript"
jenkins-bot [Wed, 3 Jul 2019 22:28:52 +0000 (22:28 +0000)]
Merge "Remove JavaScript global variable wgLoadScript"

3 years agoMerge "Update OOUI to v0.33.1"
jenkins-bot [Wed, 3 Jul 2019 22:28:44 +0000 (22:28 +0000)]
Merge "Update OOUI to v0.33.1"

3 years agoMerge "rcfilters: Simplify FormWrapperWidget submit code by reducing jQuery use"
jenkins-bot [Wed, 3 Jul 2019 21:58:35 +0000 (21:58 +0000)]
Merge "rcfilters: Simplify FormWrapperWidget submit code by reducing jQuery use"

3 years agoUpdate OOUI to v0.33.1
James D. Forrester [Wed, 3 Jul 2019 21:12:48 +0000 (14:12 -0700)]
Update OOUI to v0.33.1

Release notes:

Bug: T226819
Bug: T226822
Depends-On: Ibff36df9866dd0c8c6fbd2ca4ce0decc633976b0
Change-Id: Ibff36df9866dd0c8c6fbd2ca4ce0decc633976ba

3 years agoFix type hints in objectcache related classes
Umherirrender [Wed, 3 Jul 2019 20:11:51 +0000 (22:11 +0200)]
Fix type hints in objectcache related classes

handleException is only used for RedisException
doWrite is also used with single array

Change-Id: I3010457ce2f143f41c4748ec957dfc3333af9761

3 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Wed, 3 Jul 2019 20:06:00 +0000 (22:06 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I2186b60bd72677933ee92b1b6f60a75d0adfbb5d

3 years agoMerge "mediawiki.action.edit.preview: Use CSS instead of jQuery for animation"
jenkins-bot [Wed, 3 Jul 2019 19:42:13 +0000 (19:42 +0000)]
Merge "mediawiki.action.edit.preview: Use CSS instead of jQuery for animation"

3 years agoMerge "LogFormatter::formatParameterValue: handle bad user names"
jenkins-bot [Wed, 3 Jul 2019 18:49:45 +0000 (18:49 +0000)]
Merge "LogFormatter::formatParameterValue: handle bad user names"

3 years agomediawiki.action.edit.preview: Use CSS instead of jQuery for animation
Fomafix [Wed, 3 Jul 2019 16:02:35 +0000 (18:02 +0200)]
mediawiki.action.edit.preview: Use CSS instead of jQuery for animation

Change-Id: I9f79ddf2cf4548dbf8b8553da030d6da4772187e

3 years agoMerge "Ensure canHaveTalkPage returns false when getTalkPage would fail."
jenkins-bot [Wed, 3 Jul 2019 16:55:34 +0000 (16:55 +0000)]
Merge "Ensure canHaveTalkPage returns false when getTalkPage would fail."

3 years agoLogFormatter::formatParameterValue: handle bad user names
daniel [Wed, 3 Jul 2019 16:49:58 +0000 (18:49 +0200)]
LogFormatter::formatParameterValue: handle bad user names

This makes LogFormatter more robust against bad user names coming from
broken log records.

Bug: T224368
Change-Id: Ifce9e86bddba274182253cd25338766e8093d6ad

3 years agoMerge "Revert "rdbms: codify DatabaseDomain table "_" prefix convention""
jenkins-bot [Wed, 3 Jul 2019 15:57:29 +0000 (15:57 +0000)]
Merge "Revert "rdbms: codify DatabaseDomain table "_" prefix convention""

3 years agoMerge "Improve documentation of getJoin() methods for static analysis"
jenkins-bot [Wed, 3 Jul 2019 15:22:12 +0000 (15:22 +0000)]
Merge "Improve documentation of getJoin() methods for static analysis"

3 years agoMerge "Fix API message maps for block errors"
jenkins-bot [Wed, 3 Jul 2019 14:49:05 +0000 (14:49 +0000)]
Merge "Fix API message maps for block errors"

3 years agoRevert "rdbms: codify DatabaseDomain table "_" prefix convention"
Gergő Tisza [Wed, 3 Jul 2019 11:26:02 +0000 (11:26 +0000)]
Revert "rdbms: codify DatabaseDomain table "_" prefix convention"

This partially reverts commit c4e284f1130cdc2a4811120594bdb8013d17eaaa
(adding _ to prefixes in tests and readbility / code style fixes are preserved).
It broke all installations which used a table prefix not ending in underscore.

Bug: T227147
Change-Id: I99fc0a2f0fc7b5b321d75fd885763688f92f6d04

3 years agoImprove documentation of getJoin() methods for static analysis
Gergő Tisza [Wed, 3 Jul 2019 13:45:01 +0000 (15:45 +0200)]
Improve documentation of getJoin() methods for static analysis

Change-Id: I3943b4b4a630777d06d1689714d8f36c4430cd24

3 years agoMerge "Assert that LocalSettings file exists"
jenkins-bot [Wed, 3 Jul 2019 12:35:00 +0000 (12:35 +0000)]
Merge "Assert that LocalSettings file exists"

3 years agordbms: make DatabaseSqlite try harder to make named locks work
Aaron Schulz [Fri, 28 Jun 2019 02:59:04 +0000 (19:59 -0700)]
rdbms: make DatabaseSqlite try harder to make named locks work

Also make unlock() calls to non-existing locks return false

Change-Id: I9f0cd63e85392d1fab1868638896492bbd8e6531

3 years agoRestore previous export behavior with respect to empty comment text
Ariel T. Glenn [Wed, 3 Jul 2019 08:44:33 +0000 (11:44 +0300)]
Restore previous export behavior with respect to empty comment text

Bug: T174031
Change-Id: I0df1be8cb832e94ecda3db57b5fee5922a866aea

3 years agoEnsure canHaveTalkPage returns false when getTalkPage would fail.
daniel [Mon, 3 Jun 2019 22:56:22 +0000 (00:56 +0200)]
Ensure canHaveTalkPage returns false when getTalkPage would fail.

This causes Title::getTalkPage and NamespaceInfo::getTitle() to throw
an MWException when called on a LinkTarget that is an interwiki link
or a relative section link. These methods were already throwing
MWException when called on a link to a Special page.

Bug: T224814
Change-Id: I525c186a5b8b8fc22bca195da48afead3bfbd402

3 years agoFix API message maps for block errors
Thalia [Wed, 3 Jul 2019 06:47:01 +0000 (07:47 +0100)]
Fix API message maps for block errors

* Add composite block error message key to ApiBase
* Fix partial block error message key to point to partial block API
  error message key
* Add partial and composite block message keys to ApiMessageTrait

Bug: T227167
Bug: T227168
Change-Id: I5c354d2f038c5b02837268584eb43750a9ebb712

3 years agoRemove JavaScript global variable wgLoadScript
Fomafix [Tue, 2 Jul 2019 17:06:49 +0000 (19:06 +0200)]
Remove JavaScript global variable wgLoadScript

  mw.util.wikiScript( 'load' )
instead of
  mw.config.get( 'wgLoadScript' )

The module 'mediawiki.util' now gets the value from a private config

Change-Id: Iae4f4754f40999ba9d7c7161e9a37820c4b5931c

3 years agoMerge "Add @var annotations to XmlTypeCheck class"
jenkins-bot [Wed, 3 Jul 2019 02:29:54 +0000 (02:29 +0000)]
Merge "Add @var annotations to XmlTypeCheck class"

3 years agoMerge "lockmanager: make NullLockManager do reference counting for consistency"
jenkins-bot [Tue, 2 Jul 2019 22:22:22 +0000 (22:22 +0000)]
Merge "lockmanager: make NullLockManager do reference counting for consistency"

3 years agoMerge "lockmanager: disable internal QuorumLockManager methods that should never...
jenkins-bot [Tue, 2 Jul 2019 22:20:39 +0000 (22:20 +0000)]
Merge "lockmanager: disable internal QuorumLockManager methods that should never be reached"

3 years agoMerge "filebackend: remove wfTimestamp() dependency from FileJournal"
jenkins-bot [Tue, 2 Jul 2019 22:20:01 +0000 (22:20 +0000)]
Merge "filebackend: remove wfTimestamp() dependency from FileJournal"

3 years agoMerge "filerepo: remove pointless "foreign" flag in ForeignDBRepo::getMasterDB()"
jenkins-bot [Tue, 2 Jul 2019 22:17:53 +0000 (22:17 +0000)]
Merge "filerepo: remove pointless "foreign" flag in ForeignDBRepo::getMasterDB()"

3 years agolockmanager: make NullLockManager do reference counting for consistency
Aaron Schulz [Fri, 28 Jun 2019 23:56:16 +0000 (16:56 -0700)]
lockmanager: make NullLockManager do reference counting for consistency

Change-Id: I9ebdad0544ffcf87e671f4aca81a91e377c2c7ed

3 years agoMerge "Make UserEditCountUpdate::doUpdate avoid comparing IDatabase instances"
jenkins-bot [Tue, 2 Jul 2019 21:57:10 +0000 (21:57 +0000)]
Merge "Make UserEditCountUpdate::doUpdate avoid comparing IDatabase instances"