Selenium: replace UserLoginPage with BlankPage where possible

When using local storage, any page has to be open. UserLoginPage is usually used.
BlankPage should be slightly faster to load. It also makes it more clear than
any page would do the job.

Change-Id: I50b23993065ad6b093a6cc951d00b0bf7a3d5e68

diff --git a/tests/selenium/specs/page.js b/tests/selenium/specs/page.js
index 93e0b87..db67dde 100644 (file)
--- a/tests/selenium/specs/page.js
+++ b/tests/selenium/specs/page.js
@@ -1,5 +1,6 @@
 const assert = require( 'assert' ),
        Api = require( 'wdio-mediawiki/Api' ),
+       BlankPage = require( 'wdio-mediawiki/BlankPage' ),
        DeletePage = require( '../pageobjects/delete.page' ),
        RestorePage = require( '../pageobjects/restore.page' ),
        EditPage = require( '../pageobjects/edit.page' ),
@@ -14,7 +15,7 @@ describe( 'Page', function () {
 
        before( function () {
                // disable VisualEditor welcome dialog
-               UserLoginPage.open();
+               BlankPage.open();
                browser.localStorage( 'POST', { key: 've-beta-welcome-dialog', value: '1' } );
        } );
 

diff --git a/tests/selenium/specs/rollback.js b/tests/selenium/specs/rollback.js
index 2a79467..bf0dc91 100644 (file)
--- a/tests/selenium/specs/rollback.js
+++ b/tests/selenium/specs/rollback.js
@@ -1,4 +1,5 @@
 const assert = require( 'assert' ),
+       BlankPage = require( 'wdio-mediawiki/BlankPage' ),
        HistoryPage = require( '../pageobjects/history.page' ),
        UserLoginPage = require( 'wdio-mediawiki/LoginPage' ),
        Util = require( 'wdio-mediawiki/Util' );
@@ -10,7 +11,7 @@ describe( 'Rollback with confirmation', function () {
        before( function () {
                // disable VisualEditor welcome dialog
                browser.deleteCookie();
-               UserLoginPage.open();
+               BlankPage.open();
                browser.localStorage( 'POST', { key: 've-beta-welcome-dialog', value: '1' } );
 
                // Enable rollback confirmation for admin user
@@ -90,7 +91,7 @@ describe( 'Rollback without confirmation', function () {
        before( function () {
                // disable VisualEditor welcome dialog
                browser.deleteCookie();
-               UserLoginPage.open();
+               BlankPage.open();
                browser.localStorage( 'POST', { key: 've-beta-welcome-dialog', value: '1' } );
 
                // Disable rollback confirmation for admin user

diff --git a/tests/selenium/specs/user.js b/tests/selenium/specs/user.js
index d55ff4c..1db49ae 100644 (file)
--- a/tests/selenium/specs/user.js
+++ b/tests/selenium/specs/user.js
@@ -1,4 +1,5 @@
 const assert = require( 'assert' ),
+       BlankPage = require( 'wdio-mediawiki/BlankPage' ),
        CreateAccountPage = require( '../pageobjects/createaccount.page' ),
        PreferencesPage = require( '../pageobjects/preferences.page' ),
        UserLoginPage = require( 'wdio-mediawiki/LoginPage' ),
@@ -11,7 +12,7 @@ describe( 'User', function () {
 
        before( function () {
                // disable VisualEditor welcome dialog
-               UserLoginPage.open();
+               BlankPage.open();
                browser.localStorage( 'POST', { key: 've-beta-welcome-dialog', value: '1' } );
        } );