Restore previous export behavior with respect to empty comment text
authorAriel T. Glenn <ariel@wikimedia.org>
Wed, 3 Jul 2019 08:44:33 +0000 (11:44 +0300)
committerAriel T. Glenn <ariel@wikimedia.org>
Wed, 3 Jul 2019 09:10:44 +0000 (12:10 +0300)
Bug: T174031
Change-Id: I0df1be8cb832e94ecda3db57b5fee5922a866aea

includes/export/XmlDumpWriter.php

index bedfe13..f71b0d5 100644 (file)
@@ -337,9 +337,11 @@ class XmlDumpWriter {
                if ( $rev->isDeleted( Revision::DELETED_COMMENT ) ) {
                        $out .= "      " . Xml::element( 'comment', [ 'deleted' => 'deleted' ] ) . "\n";
                } else {
-                       $out .= "      "
-                               . Xml::elementClean( 'comment', [], strval( $rev->getComment()->text ) )
-                               . "\n";
+                       if ( $rev->getComment()->text != '' ) {
+                               $out .= "      "
+                                       . Xml::elementClean( 'comment', [], strval( $rev->getComment()->text ) )
+                                       . "\n";
+                       }
                }
 
                $contentMode = $rev->isDeleted( Revision::DELETED_TEXT ) ? self::WRITE_STUB_DELETED