lhc/web/wiklou.git
6 years agoCSSMin: Remove XML declaration from SVGs
Volker E [Tue, 9 Jan 2018 03:05:40 +0000 (19:05 -0800)]
CSSMin: Remove XML declaration from SVGs

Removing unnecessary XML declaration prolog when embedding SVGs
as data URI and adding more complex elements & attributes to test.

Bug: T175318
Change-Id: Ibec8c2ab498554a6ad33b4420ae6258dcc80fcdf

6 years agoMerge "Add Special:Stats as an alias for Special:Statistics"
jenkins-bot [Thu, 11 Jan 2018 00:06:14 +0000 (00:06 +0000)]
Merge "Add Special:Stats as an alias for Special:Statistics"

6 years agoMerge "Use jQuery 3 .catch( fn ) instead of .then( null, fn )"
jenkins-bot [Wed, 10 Jan 2018 23:48:21 +0000 (23:48 +0000)]
Merge "Use jQuery 3 .catch( fn ) instead of .then( null, fn )"

6 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Wed, 10 Jan 2018 20:56:51 +0000 (21:56 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: I60c6fd2b3c01d2e1b70197b90ca0bc46a5d6a9dc

6 years agoUse findItemFromData instead getItemFromData
Prateek Saxena [Thu, 14 Dec 2017 07:44:50 +0000 (13:14 +0530)]
Use findItemFromData instead getItemFromData

Change-Id: I3cea1dacc1452b05e7e7423e47dcb2ffdf70c1ce
Depends-on: Ia2110f71d1642f61451cb8acc7e8a930d0feb31f
Bug: T76630

6 years ago[MCR] RevisionStore::getTitle, Fix flags passed to Title::newFromID
addshore [Wed, 10 Jan 2018 16:17:40 +0000 (16:17 +0000)]
[MCR] RevisionStore::getTitle, Fix flags passed to Title::newFromID

This was passing $queryFlags directly into Title::newFromID which
expects different flags.

Instead we now set Title::GAID_FOR_UPDATE if $queryFlags will end up
hitting the master.

Change-Id: I9c6e275c22fe74a98e79c54049afa4915a7f565d

6 years agoMerge "Numbers in the parser profiling data are not internationalized"
jenkins-bot [Wed, 10 Jan 2018 18:12:05 +0000 (18:12 +0000)]
Merge "Numbers in the parser profiling data are not internationalized"

6 years agoMerge "Revert "Revert "[MCR] Add and use $title param to RevisionStoregetPrevious...
jenkins-bot [Wed, 10 Jan 2018 17:14:54 +0000 (17:14 +0000)]
Merge "Revert "Revert "[MCR] Add and use $title param to RevisionStoregetPrevious/Next"""

6 years agoRevert "Revert "[MCR] Add and use $title param to RevisionStoregetPrevious/Next""
addshore [Wed, 10 Jan 2018 12:23:06 +0000 (12:23 +0000)]
Revert "Revert "[MCR] Add and use $title param to RevisionStoregetPrevious/Next""

This is a partial revert of a revert that reverted a fix believed to
have had its underlying issue fixed in:
https://gerrit.wikimedia.org/r/#/c/400577/

The compat layer (Revision), now passes a Title object into the
RevisionStore, and this title is used to construct the Record and
also any new Revision objects.

Bug: T184559
Bug: T183548
Change-Id: Id073265c173f60aa8c456550fdb4bb5196013be8

6 years agoMerge "RCFilters: Only normalize title with 'target' when it is needed"
jenkins-bot [Wed, 10 Jan 2018 14:04:58 +0000 (14:04 +0000)]
Merge "RCFilters: Only normalize title with 'target' when it is needed"

6 years agoMerge "Integration tests for FirejailCommand"
jenkins-bot [Wed, 10 Jan 2018 13:25:59 +0000 (13:25 +0000)]
Merge "Integration tests for FirejailCommand"

6 years agoMerge "API: Don't apply size limit to action=compare"
jenkins-bot [Wed, 10 Jan 2018 13:20:22 +0000 (13:20 +0000)]
Merge "API: Don't apply size limit to action=compare"

6 years agoMerge "ApiQueryImageInfo: Don't return URLs if the archived file is missing"
jenkins-bot [Wed, 10 Jan 2018 13:10:19 +0000 (13:10 +0000)]
Merge "ApiQueryImageInfo: Don't return URLs if the archived file is missing"

6 years agoMerge "Use Sanitizer::mergeAttributes when merging classes into attributes"
jenkins-bot [Wed, 10 Jan 2018 13:09:33 +0000 (13:09 +0000)]
Merge "Use Sanitizer::mergeAttributes when merging classes into attributes"

6 years agoMerge "RCFilters: uriprocessor test: use hardcoded uri"
jenkins-bot [Wed, 10 Jan 2018 12:44:23 +0000 (12:44 +0000)]
Merge "RCFilters: uriprocessor test: use hardcoded uri"

6 years agoMerge "Update OOUI to v0.25.0"
jenkins-bot [Wed, 10 Jan 2018 12:39:30 +0000 (12:39 +0000)]
Merge "Update OOUI to v0.25.0"

6 years agoMerge "Bump min supported HHVM version to 3.18.5"
jenkins-bot [Wed, 10 Jan 2018 12:37:30 +0000 (12:37 +0000)]
Merge "Bump min supported HHVM version to 3.18.5"

6 years agoUpdate OOUI to v0.25.0
Volker E [Wed, 10 Jan 2018 01:04:08 +0000 (17:04 -0800)]
Update OOUI to v0.25.0

Release notes:
 https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/History.md;v0.25.0

Depends-On: I5f574a0d2702f421c0c9d2556e3162abd55b9f23
Change-Id: I8a5b279f6dcb9b620e3e4e8998fc2b2d678573db

6 years agoBump min supported HHVM version to 3.18.5
Reedy [Sat, 30 Dec 2017 02:58:03 +0000 (02:58 +0000)]
Bump min supported HHVM version to 3.18.5

Change-Id: I0a22c638bf6bbd6c8b93e50c23f8e455e36acd7c

6 years agoUse jQuery 3 .catch( fn ) instead of .then( null, fn )
Fomafix [Tue, 9 Jan 2018 17:39:01 +0000 (18:39 +0100)]
Use jQuery 3 .catch( fn ) instead of .then( null, fn )

https://api.jquery.com/deferred.catch/ Since jQuery 3
deferred.catch( fn ) is an alias to deferred.then( null, fn )

This improves the readability.

Change-Id: I20fa3a1ed5c959ad0639ddf0162b8837fc15c720

6 years agoMerge "EditPage: Remove separator between cancel and help"
jenkins-bot [Wed, 10 Jan 2018 06:16:53 +0000 (06:16 +0000)]
Merge "EditPage: Remove separator between cancel and help"

6 years agoMerge "Added tests for ComposerInstalled"
jenkins-bot [Wed, 10 Jan 2018 06:04:37 +0000 (06:04 +0000)]
Merge "Added tests for ComposerInstalled"

6 years agoEditPage: Remove separator between cancel and help
Albert221 [Mon, 8 Jan 2018 22:18:05 +0000 (23:18 +0100)]
EditPage: Remove separator between cancel and help

It is no longer needed because those buttons
are already splitted visually by blank space.

Bug: T183672
Change-Id: I1f8a8413a5f4da441e3f4b4ef0b1e03d174987ca

6 years agoAdded tests for ComposerInstalled
ryan10145 [Tue, 9 Jan 2018 01:11:48 +0000 (20:11 -0500)]
Added tests for ComposerInstalled

Bug: T183899
Change-Id: Id822caad044a079884795dbea37baf10514bcf5c

6 years agoMerge "Migrate ar_text to modern storage"
jenkins-bot [Wed, 10 Jan 2018 00:10:51 +0000 (00:10 +0000)]
Merge "Migrate ar_text to modern storage"

6 years agoMerge "[BREAKING CHANGE] Rename TitleWidget#getTitle to TitleWidget#getMWTitle"
jenkins-bot [Tue, 9 Jan 2018 22:40:25 +0000 (22:40 +0000)]
Merge "[BREAKING CHANGE] Rename TitleWidget#getTitle to TitleWidget#getMWTitle"

6 years agoMigrate ar_text to modern storage
Brad Jorsch [Tue, 28 Nov 2017 21:13:09 +0000 (16:13 -0500)]
Migrate ar_text to modern storage

This really should have been done a very long time ago.

This adds a maintenance script to migrate rows with ar_text_id null to
modern storage, either the text table or ExternalStore.

Bug: T36925
Change-Id: I5608c6b6d3ecad516b785e13d668427c1b762e41

6 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Tue, 9 Jan 2018 21:00:13 +0000 (22:00 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: I558e8cc84fb0d24d2eb1d4491a5cf9044cd10379

6 years agoMerge "Remove obsolete style-only module 'mediawiki.action.history.diff'"
jenkins-bot [Tue, 9 Jan 2018 19:15:47 +0000 (19:15 +0000)]
Merge "Remove obsolete style-only module 'mediawiki.action.history.diff'"

6 years agoMerge "CSSMin: Re-introduce whitespace mangling in embedded SVGs"
jenkins-bot [Tue, 9 Jan 2018 17:44:56 +0000 (17:44 +0000)]
Merge "CSSMin: Re-introduce whitespace mangling in embedded SVGs"

6 years agoCSSMin: Re-introduce whitespace mangling in embedded SVGs
Volker E [Tue, 9 Jan 2018 02:34:22 +0000 (18:34 -0800)]
CSSMin: Re-introduce whitespace mangling in embedded SVGs

Convert newlines and tabs to spaces (which can be unencoded),
and consolidate runs of multiple spaces into a single space.
Also remove any leading and trailing spaces that might result
(most files end in a newline, for example).
Follow-up to Iddc98332d. This was reverted as dependency for the
original issues causing patch, but works perfectly fine.

Bug: T175318
Change-Id: Ic25d73caeb42ba7a32ef304806d401047b5a1997

6 years agoMerge "Fix type hint in ApiErrorFormatter::addMessagesFromStatus"
jenkins-bot [Tue, 9 Jan 2018 16:38:04 +0000 (16:38 +0000)]
Merge "Fix type hint in ApiErrorFormatter::addMessagesFromStatus"

6 years agoApiQueryImageInfo: Don't return URLs if the archived file is missing
Brad Jorsch [Tue, 9 Jan 2018 15:19:39 +0000 (10:19 -0500)]
ApiQueryImageInfo: Don't return URLs if the archived file is missing

If the archived file doesn't exist, indicate that instead of returning
bogus URLs.

Bug: T184445
Change-Id: I831b13314300f0289a2baf26ed21d81be31b292a

6 years agoRCFilters: uriprocessor test: use hardcoded uri
Stephane Bisson [Tue, 9 Jan 2018 15:15:06 +0000 (10:15 -0500)]
RCFilters: uriprocessor test: use hardcoded uri

new mw.Uri() without arguments uses the current browser
uri. It caused some tests to fail when run from a uri with
a subpage (Special:JavaScriptTest/qunit) and it's generally
bad to have unit tests use uncontrolled environment data.

Change-Id: Id434a491aadc2d84165edf4fd1c59775c9b815ad

6 years agoMerge "Move BaseDump into includes/export/"
jenkins-bot [Tue, 9 Jan 2018 14:52:14 +0000 (14:52 +0000)]
Merge "Move BaseDump into includes/export/"

6 years agoMerge "Add switch for readonly watchlists"
jenkins-bot [Tue, 9 Jan 2018 13:50:31 +0000 (13:50 +0000)]
Merge "Add switch for readonly watchlists"

6 years agoMerge "Update outdated WikiPageDeletionUpdates documentation"
jenkins-bot [Tue, 9 Jan 2018 13:19:33 +0000 (13:19 +0000)]
Merge "Update outdated WikiPageDeletionUpdates documentation"

6 years agoFix type hint in ApiErrorFormatter::addMessagesFromStatus
Thiemo Mättig [Tue, 9 Jan 2018 13:01:17 +0000 (14:01 +0100)]
Fix type hint in ApiErrorFormatter::addMessagesFromStatus

Change-Id: Ia7b628e9f6a7f8c8d803732504621c13976bf618

6 years agoUse IDatabase interface instead of Database in DBAccessBase
Thiemo Mättig [Tue, 9 Jan 2018 12:55:37 +0000 (13:55 +0100)]
Use IDatabase interface instead of Database in DBAccessBase

There is one subclass I'm aware of that overwrites the releaseConnection
method. It's in the EducationProgram extension and already updated, see
Ibb067ca.

Change-Id: I68504f9cd32aa0d0c6c068dbaa1f2ee65649afa4

6 years agoUpdate outdated WikiPageDeletionUpdates documentation
Thiemo Mättig [Tue, 9 Jan 2018 12:15:04 +0000 (13:15 +0100)]
Update outdated WikiPageDeletionUpdates documentation

This was already updated on
https://www.mediawiki.org/wiki/Manual:Hooks/WikiPageDeletionUpdates
more than a year ago, just missed here.

This patch is a direct follow up for a request in I3a42ec1.

Change-Id: I595b78da214c736d8e73d6d8c7af34a1613dd076

6 years agoMove BaseDump into includes/export/
Chad Horohoe [Mon, 8 Jan 2018 21:10:35 +0000 (13:10 -0800)]
Move BaseDump into includes/export/

There's no reason for this to have to live in Maintenance land. It's
generally useful and lets us avoid some random require/include calls

Change-Id: I60419c7f9fc52313905053bbeb3aa81666c9160c

6 years agoAdd Special:Stats as an alias for Special:Statistics
kaldari [Tue, 9 Jan 2018 01:20:57 +0000 (17:20 -0800)]
Add Special:Stats as an alias for Special:Statistics

Change-Id: Ib3dd0498f6ae77b522ddee786655994b24f63350

6 years agoFollow-up 8a7fb8577: For deprecated RL modules, allow strings
James D. Forrester [Tue, 9 Jan 2018 00:05:05 +0000 (16:05 -0800)]
Follow-up 8a7fb8577: For deprecated RL modules, allow strings

So that more than just PHP code and MediaWiki core can use it, but
also JSON-based static extension registrations. :-)

Change-Id: If22fccbb43c5b05db2a666d61ae8864ee9815e7d

6 years agoMerge "Treat phpdbg as run from the command line when checking PHP_SAPI"
jenkins-bot [Mon, 8 Jan 2018 23:03:41 +0000 (23:03 +0000)]
Merge "Treat phpdbg as run from the command line when checking PHP_SAPI"

6 years agoMerge "RCFilters: Fix limit display for limit=1"
jenkins-bot [Mon, 8 Jan 2018 22:42:08 +0000 (22:42 +0000)]
Merge "RCFilters: Fix limit display for limit=1"

6 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Mon, 8 Jan 2018 21:04:47 +0000 (22:04 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: I9c3cdd99a86aa1a442591406baceeac8edb977ab

6 years agoMerge "Add text to tab links telling if they do exist"
jenkins-bot [Mon, 8 Jan 2018 19:24:22 +0000 (19:24 +0000)]
Merge "Add text to tab links telling if they do exist"

6 years agoPass along interface language to license preview
Matthias Mullie [Mon, 8 Jan 2018 12:36:20 +0000 (13:36 +0100)]
Pass along interface language to license preview

Bug: T184422
Change-Id: Ib1a99271ddc32f3ede0360716422e2de9fdfb005

6 years agoAdd text to tab links telling if they do exist
Albert221 [Wed, 3 Jan 2018 14:33:58 +0000 (15:33 +0100)]
Add text to tab links telling if they do exist

And changed a little bit signature of Linker::titleAttrib
and Linker::tooltipAndAcceskeyAttribs. Added $options
parameter to the second one and made $options parameter
satisfied by passing an array with options, because there
is one more now: 'nonexisting' which tells to add text
about the thing that the page does not exist to its tooltip.

Bug: T19099
Change-Id: Ia76dd6db363f6add5efb8955be9e23a1f8e8476f

6 years agoAPI: Don't apply size limit to action=compare
Brad Jorsch [Mon, 8 Jan 2018 14:21:23 +0000 (09:21 -0500)]
API: Don't apply size limit to action=compare

Some diffs can be really huge. Since ApiComparePages is intended to
return only the diff and some small metadata, bypass $wgAPIMaxResultSize
to allow the diff to be returned even if it's insanely huge.

Really insanely huge diffs might still make PHP run out of memory, even
before it gets the chance to return the diff to the API. That is outside
the scope of this change.

Bug: T184412
Change-Id: I755417f573c3caf85031d03b262aa55bd8cf36d7

6 years agoMerge "Fix BlobStoreFactoryTest @covers tag"
jenkins-bot [Mon, 8 Jan 2018 13:29:03 +0000 (13:29 +0000)]
Merge "Fix BlobStoreFactoryTest @covers tag"

6 years agoMerge "[MCR] Improve documentation and method naming on Revision and RevisionStore."
jenkins-bot [Mon, 8 Jan 2018 13:01:11 +0000 (13:01 +0000)]
Merge "[MCR] Improve documentation and method naming on Revision and RevisionStore."

6 years ago[MCR] Improve documentation and method naming on Revision and RevisionStore.
daniel [Wed, 27 Dec 2017 15:46:03 +0000 (16:46 +0100)]
[MCR] Improve documentation and method naming on Revision and RevisionStore.

Change-Id: I3b049acff9313814a4ac448289d1aef88cb7f9df

6 years agoAssert order of MediaWikiTestCaseSchema*Test execution
addshore [Fri, 5 Jan 2018 15:44:36 +0000 (15:44 +0000)]
Assert order of MediaWikiTestCaseSchema*Test execution

Make sure that we fail if these tests are run in the wrong order.
Essentially testing an assumption that currently holds true, but
could change in the future.

Change-Id: I8f33281d18f6f64e0e06c1b371b973542244dd24

6 years agoFix BlobStoreFactoryTest @covers tag
addshore [Mon, 8 Jan 2018 12:03:35 +0000 (12:03 +0000)]
Fix BlobStoreFactoryTest @covers tag

Change-Id: I6d61d128de3fc63d88c7767f90350f3edbfc447c

6 years agoMerge "Add Help Page link in Special:ExpandTemplates"
jenkins-bot [Mon, 8 Jan 2018 05:42:24 +0000 (05:42 +0000)]
Merge "Add Help Page link in Special:ExpandTemplates"

6 years agoMerge "Add Help Page link in Special:ApiSandbox"
jenkins-bot [Mon, 8 Jan 2018 05:41:17 +0000 (05:41 +0000)]
Merge "Add Help Page link in Special:ApiSandbox"

6 years agoAdd Help Page link in Special:ApiSandbox
Jayprakash12345 [Sun, 7 Jan 2018 08:35:12 +0000 (08:35 +0000)]
Add Help Page link in Special:ApiSandbox

Bug: T184365
Change-Id: I61ca80947c331bbdbe59feff5f33942a7d800a51

6 years agoMerge "Added Tests for ContentModelLogFormatter"
jenkins-bot [Sun, 7 Jan 2018 23:26:55 +0000 (23:26 +0000)]
Merge "Added Tests for ContentModelLogFormatter"

6 years agoAdded Tests for ContentModelLogFormatter
ryan10145 [Sun, 7 Jan 2018 22:54:34 +0000 (17:54 -0500)]
Added Tests for ContentModelLogFormatter

Bug: T183900
Change-Id: I812b477eb45e19a06e5c18bc30da731f4af8cc8f

6 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Sun, 7 Jan 2018 21:22:49 +0000 (22:22 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: Ia3c463c01f95b7dc3257cf878ae0f9560bbbd684

6 years agoMerge "Improve some parameter docs"
jenkins-bot [Sun, 7 Jan 2018 19:35:32 +0000 (19:35 +0000)]
Merge "Improve some parameter docs"

6 years agoNumbers in the parser profiling data are not internationalized
Huji Lee [Tue, 2 Jan 2018 00:48:27 +0000 (19:48 -0500)]
Numbers in the parser profiling data are not internationalized

Bug: T158607
Change-Id: I7c2939e3171e320dce6a11d1c3ba0caf36c81d8f

6 years agoMerge "Add ul { margin-top: 0; margin-bottom: 0 } for multi-column"
jenkins-bot [Sun, 7 Jan 2018 13:01:04 +0000 (13:01 +0000)]
Merge "Add ul { margin-top: 0; margin-bottom: 0 } for multi-column"

6 years agoImprove some parameter docs
Umherirrender [Sun, 7 Jan 2018 10:38:43 +0000 (11:38 +0100)]
Improve some parameter docs

Change-Id: I31e983d7ac287158101b18ad95779d83537302a2

6 years agoAdd Help Page link in Special:ExpandTemplates
Jayprakash12345 [Sun, 7 Jan 2018 08:54:09 +0000 (08:54 +0000)]
Add Help Page link in Special:ExpandTemplates

Bug: T184366
Change-Id: Ice286405ec821c983020ebd6795ae429485c6d3c

6 years agoIntegration tests for FirejailCommand
Gergő Tisza [Fri, 22 Dec 2017 01:20:45 +0000 (01:20 +0000)]
Integration tests for FirejailCommand

Change-Id: I8bb5f8ad528da55c4432928ffb124f9ac0c32518

6 years agoMerge "Add options and join conds to MediaWikiTestCase::assertSelect"
jenkins-bot [Sat, 6 Jan 2018 21:28:22 +0000 (21:28 +0000)]
Merge "Add options and join conds to MediaWikiTestCase::assertSelect"

6 years agoFix dropping of temp tables on SQLite and PG.
daniel [Sat, 6 Jan 2018 10:16:13 +0000 (11:16 +0100)]
Fix dropping of temp tables on SQLite and PG.

Also addresses other compatibility issues with PG mentioned
in comments on I7a4071072.

Bug: T184333
Change-Id: I478aa1aee15fdef99630c65a37b1af5f3f8cce14

6 years agoAdd ul { margin-top: 0; margin-bottom: 0 } for multi-column
Fomafix [Fri, 8 Dec 2017 10:48:40 +0000 (11:48 +0100)]
Add ul { margin-top: 0; margin-bottom: 0 } for multi-column

The multi-column layout of a list has a currently different top margin
on the first column and on the following columns. On skin Timeless this
is conspicuous because there is a bigger top margin for lists.
This change fixes this for all skins.

This is a follow-up to cd95215caee7ead1098e5fa599d83da9bf56385f.

Change-Id: Icce12f52f98482e80aabd36af1359e37e2038705

6 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Sat, 6 Jan 2018 07:44:59 +0000 (08:44 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: I5b6da18066002cd7e995f55595feca586a21dc1a

6 years agoMerge "Add semantic tags to license info text"
jenkins-bot [Fri, 5 Jan 2018 23:57:59 +0000 (23:57 +0000)]
Merge "Add semantic tags to license info text"

6 years ago[BREAKING CHANGE] Rename TitleWidget#getTitle to TitleWidget#getMWTitle
Stephane Bisson [Thu, 4 Jan 2018 20:49:15 +0000 (15:49 -0500)]
[BREAKING CHANGE] Rename TitleWidget#getTitle to TitleWidget#getMWTitle

Rename TitleWidget#getTitle so it won't clash with TitledElement#getTitle

Bug: T184181
Change-Id: I97ff46d8ca60f260af2a0b12e6c053aa91c777d1

6 years agoMake FormatMetadata::flattenArrayReal() work for an associative array
Mark A. Hershberger [Fri, 5 Jan 2018 00:55:40 +0000 (19:55 -0500)]
Make FormatMetadata::flattenArrayReal() work for an associative array

Bug: T87572
Change-Id: I19490ebbbdc3613ae2116c6890ca470bb9f332db

6 years agoMerge "RCLFilters: reword target placeholder"
jenkins-bot [Fri, 5 Jan 2018 17:18:46 +0000 (17:18 +0000)]
Merge "RCLFilters: reword target placeholder"

6 years agoMerge "Introduce DB schema overrides for unit tests."
jenkins-bot [Fri, 5 Jan 2018 16:43:30 +0000 (16:43 +0000)]
Merge "Introduce DB schema overrides for unit tests."

6 years agoMerge "Set a default delimiter in Database::sourceStream"
jenkins-bot [Fri, 5 Jan 2018 16:42:44 +0000 (16:42 +0000)]
Merge "Set a default delimiter in Database::sourceStream"

6 years agoAdd options and join conds to MediaWikiTestCase::assertSelect
Brad Jorsch [Fri, 5 Jan 2018 16:26:56 +0000 (11:26 -0500)]
Add options and join conds to MediaWikiTestCase::assertSelect

Because selects sometimes need to specify these.

Change-Id: I853e8210bbafe16a62060b9075384afb9cdb03c0

6 years agoIntroduce DB schema overrides for unit tests.
daniel [Thu, 16 Nov 2017 16:48:25 +0000 (17:48 +0100)]
Introduce DB schema overrides for unit tests.

This introduces MediaWikiTestCase::getSchemaOverrides,  which can be overwritten
to return information about which tables are going to be altered, and which SQL
files should be used to set up the target schema. This allows tests for a class
that interacts with the database can have a subclass for each supported database
schema.

NOTE: this has only been tested with MySQL.

Bug: T180705
Change-Id: I7a4071072d802a82ecf7d16fbf8882ff8c79287f

6 years agoSet a default delimiter in Database::sourceStream
addshore [Fri, 5 Jan 2018 15:37:30 +0000 (15:37 +0000)]
Set a default delimiter in Database::sourceStream

Discovered while debugging I7a4071072d802a82ecf7d16fbf8882ff8c79287f

DatabaseIntegration test alters the delimiter for the database instance
and it never gets set back.
Simply set the delimiter back to a default value at the start of
sourceSteam (for each new file pointer) which could have a new
delimiter.

Change-Id: Ib829b1c8d87271526fa6826910d40c304c778b32

6 years agoMerge "Remove duplicate names from CREDITS"
jenkins-bot [Fri, 5 Jan 2018 12:45:35 +0000 (12:45 +0000)]
Merge "Remove duplicate names from CREDITS"

6 years agoRCLFilters: reword target placeholder
Stephane Bisson [Fri, 5 Jan 2018 11:29:18 +0000 (06:29 -0500)]
RCLFilters: reword target placeholder

Bug: T172161
Change-Id: I8af648794cf7972efdbb1543665295d8f1368a4b

6 years agoMerge "[MCR] Tests for WikiPage::doUpdateRestrictions"
jenkins-bot [Fri, 5 Jan 2018 10:24:19 +0000 (10:24 +0000)]
Merge "[MCR] Tests for WikiPage::doUpdateRestrictions"

6 years agoUse Sanitizer::mergeAttributes when merging classes into attributes
WMDE-Fisch [Fri, 5 Jan 2018 09:32:56 +0000 (10:32 +0100)]
Use Sanitizer::mergeAttributes when merging classes into attributes

Change-Id: Ia5199a75e6926fe64b3d99d5b5914320491176bb

6 years agoMerge "Localisation updates from https://translatewiki.net."
L10n-bot [Fri, 5 Jan 2018 07:35:08 +0000 (07:35 +0000)]
Merge "Localisation updates from https://translatewiki.net."

6 years agoMerge "Localisation updates from https://translatewiki.net."
L10n-bot [Fri, 5 Jan 2018 07:34:59 +0000 (07:34 +0000)]
Merge "Localisation updates from https://translatewiki.net."

6 years agoRCFilters: Fix limit display for limit=1
Matthew Flaschen [Fri, 5 Jan 2018 05:51:24 +0000 (00:51 -0500)]
RCFilters: Fix limit display for limit=1

Fix typo so it's '1 change' instead of 'change'.

Bug: T182241
Change-Id: I5026207ddbd421cd521252ac7842b54a9e687953

6 years agoUpdate nikic/php-parser to 3.1.3
Kunal Mehta [Thu, 4 Jan 2018 08:18:30 +0000 (00:18 -0800)]
Update nikic/php-parser to 3.1.3

And fix the only incompatibility in findDeprecated.php. It's OK to throw
exceptions on invalid files since we lint all PHP files so there
should be no invalid ones.

Change-Id: Ie5913c2aae4b521a4b6f805e911e4e2764386b45

6 years agoMerge "Added Tests for ListToggle"
jenkins-bot [Fri, 5 Jan 2018 00:53:45 +0000 (00:53 +0000)]
Merge "Added Tests for ListToggle"

6 years agoMerge "rdbms: Remove unused setServerInfo/getServerInfo methods from LoadBalancer"
jenkins-bot [Thu, 4 Jan 2018 23:49:41 +0000 (23:49 +0000)]
Merge "rdbms: Remove unused setServerInfo/getServerInfo methods from LoadBalancer"

6 years agordbms: Remove unused setServerInfo/getServerInfo methods from LoadBalancer
Aaron Schulz [Thu, 4 Jan 2018 18:28:31 +0000 (10:28 -0800)]
rdbms: Remove unused setServerInfo/getServerInfo methods from LoadBalancer

Change-Id: Iffb99c96ca77957a81f1cb8d1e6ae5b1c198e3f5

6 years agoMerge "Fix Maintenance::output when called very early"
jenkins-bot [Thu, 4 Jan 2018 23:35:55 +0000 (23:35 +0000)]
Merge "Fix Maintenance::output when called very early"

6 years agoFix Maintenance::output when called very early
Marius Hoch [Thu, 4 Jan 2018 23:19:55 +0000 (00:19 +0100)]
Fix Maintenance::output when called very early

If a maintenance script is called with --help (or without
required args), this is currently failing, as MediaWikiServices
is only loaded after Maintenance::setup is initially called.
Follows 336454104d1249439e3ff97746de69c5e7b4a5f9.

Change-Id: Ied283d362675b6b98bd3144132a240b432998991

6 years agoAdded Tests for ListToggle
ryan10145 [Thu, 4 Jan 2018 02:41:02 +0000 (21:41 -0500)]
Added Tests for ListToggle

Bug: T183898
Change-Id: I1c6cd8ea21127db56701cc6073fa880b2180d846

6 years agoUse namespaced version of IDatabase
Umherirrender [Thu, 4 Jan 2018 22:18:55 +0000 (23:18 +0100)]
Use namespaced version of IDatabase

Change-Id: I49c9b462d316763f90ebf5a95caa388716d6a278

6 years agoMerge "Moved textbox1 building into TextConflictHelper on edit conflicts"
jenkins-bot [Thu, 4 Jan 2018 21:56:45 +0000 (21:56 +0000)]
Merge "Moved textbox1 building into TextConflictHelper on edit conflicts"

6 years agoFollow-up 6f07389ef2eb: fix variable name
Roan Kattouw [Thu, 4 Jan 2018 20:27:11 +0000 (21:27 +0100)]
Follow-up 6f07389ef2eb: fix variable name

Caused Notice: Undefined variable: text

Bug: T184123
Change-Id: I950a02134b145a2928af33995ca37a6965f265e4

6 years agoMerge "Cleanup live update feature flag and FilterWrapperWidget"
jenkins-bot [Thu, 4 Jan 2018 21:31:20 +0000 (21:31 +0000)]
Merge "Cleanup live update feature flag and FilterWrapperWidget"

6 years agoMerge "Remove deprecated back-compat HtmlFormatter class"
jenkins-bot [Thu, 4 Jan 2018 21:14:12 +0000 (21:14 +0000)]
Merge "Remove deprecated back-compat HtmlFormatter class"

6 years agoMerge "Add tests for ApiFormatRaw"
jenkins-bot [Thu, 4 Jan 2018 21:05:29 +0000 (21:05 +0000)]
Merge "Add tests for ApiFormatRaw"