RCFilters: uriprocessor test: use hardcoded uri
authorStephane Bisson <sbisson@wikimedia.org>
Tue, 9 Jan 2018 15:15:06 +0000 (10:15 -0500)
committerStephane Bisson <sbisson@wikimedia.org>
Tue, 9 Jan 2018 15:15:06 +0000 (10:15 -0500)
new mw.Uri() without arguments uses the current browser
uri. It caused some tests to fail when run from a uri with
a subpage (Special:JavaScriptTest/qunit) and it's generally
bad to have unit tests use uncontrolled environment data.

Change-Id: Id434a491aadc2d84165edf4fd1c59775c9b815ad

tests/qunit/suites/resources/mediawiki.rcfilters/UriProcessor.test.js

index fbd159c..654e66b 100644 (file)
@@ -62,7 +62,7 @@
                var uriProcessor,
                        filtersModel = new mw.rcfilters.dm.FiltersViewModel(),
                        makeUri = function ( queryParams ) {
-                               var uri = new mw.Uri();
+                               var uri = new mw.Uri( 'http://server/wiki/Special:RC' );
                                uri.query = queryParams;
                                return uri;
                        };