lhc/web/wiklou.git
2 years agorollbackEdits.php: Cosmetic changes of outputs
zoranzoki21 [Thu, 10 Jan 2019 13:47:45 +0000 (14:47 +0100)]
rollbackEdits.php: Cosmetic changes of outputs

Change-Id: I18313edf4fe9577fb488159b019689a450454b2f

2 years agoMerge "Improve readability of LogFormatter::makePageLink"
jenkins-bot [Wed, 9 Jan 2019 23:36:27 +0000 (23:36 +0000)]
Merge "Improve readability of LogFormatter::makePageLink"

2 years agoMerge "Don't check for LIBXML_PARSEHUGE presence"
jenkins-bot [Wed, 9 Jan 2019 21:20:38 +0000 (21:20 +0000)]
Merge "Don't check for LIBXML_PARSEHUGE presence"

2 years agoMerge "Remove a CURLOPT_CONNECTTIMEOUT_MS check"
jenkins-bot [Wed, 9 Jan 2019 21:20:32 +0000 (21:20 +0000)]
Merge "Remove a CURLOPT_CONNECTTIMEOUT_MS check"

2 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Wed, 9 Jan 2019 20:53:06 +0000 (21:53 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: I9ee05968b2a310c032969eaf5f52f703b796ba16

2 years agoFix malformed output of block logs
Thalia [Wed, 9 Jan 2019 16:09:37 +0000 (16:09 +0000)]
Fix malformed output of block logs

Avoid adding <span> to expiry parameter whenever block log is
stored as plaintext.

Bug: T208523
Change-Id: Id3fcdfda7311484911ae1f57ec262a2c6e6ab00b

2 years agoImprove readability of LogFormatter::makePageLink
Thalia [Wed, 9 Jan 2019 15:58:16 +0000 (15:58 +0000)]
Improve readability of LogFormatter::makePageLink

Change-Id: I912d9626b99697d5a0394b72a56ffc8a5e7aa1bb

2 years agoFix order of arguments in ChangeTags::getPrevTags
Amir Sarabadani [Wed, 9 Jan 2019 08:05:49 +0000 (09:05 +0100)]
Fix order of arguments in ChangeTags::getPrevTags

Bug: T212703
Change-Id: I9e38c999718762daeb5c155ea8eaaa5d16dd85c1

2 years agoMerge "Localisation updates from https://translatewiki.net."
jenkins-bot [Tue, 8 Jan 2019 21:34:12 +0000 (21:34 +0000)]
Merge "Localisation updates from https://translatewiki.net."

2 years agoMerge "Fix missing ATOMIC_CANCELABLE in MovePage::move()"
jenkins-bot [Tue, 8 Jan 2019 21:24:48 +0000 (21:24 +0000)]
Merge "Fix missing ATOMIC_CANCELABLE in MovePage::move()"

2 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Tue, 8 Jan 2019 21:13:08 +0000 (22:13 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: Ibe90f37243cab5598d9a1d319e0a88ae9fcf4fdb

2 years agoFix missing ATOMIC_CANCELABLE in MovePage::move()
Gergő Tisza [Tue, 8 Jan 2019 19:35:05 +0000 (11:35 -0800)]
Fix missing ATOMIC_CANCELABLE in MovePage::move()

Follow-up to I4aaa8af50d684de.

Bug: T213168
Change-Id: I0566b37117b6c69d4043e77e6368bf79fa84e325

2 years agoMerge "Update the design of Special:Block"
jenkins-bot [Tue, 8 Jan 2019 19:06:47 +0000 (19:06 +0000)]
Merge "Update the design of Special:Block"

2 years agoMerge "build: Update qunitjs to 2.9.1"
jenkins-bot [Tue, 8 Jan 2019 19:00:37 +0000 (19:00 +0000)]
Merge "build: Update qunitjs to 2.9.1"

2 years agoMerge "Remove comments documenting constructors as "constructors""
jenkins-bot [Tue, 8 Jan 2019 18:57:25 +0000 (18:57 +0000)]
Merge "Remove comments documenting constructors as "constructors""

2 years agoMerge "Fix tag for partial blocks config"
jenkins-bot [Tue, 8 Jan 2019 18:48:56 +0000 (18:48 +0000)]
Merge "Fix tag for partial blocks config"

2 years agoMerge "Add @since tags to new public methods related to partial blocks"
jenkins-bot [Tue, 8 Jan 2019 18:37:25 +0000 (18:37 +0000)]
Merge "Add @since tags to new public methods related to partial blocks"

2 years agoFix tag for partial blocks config
Thalia [Tue, 8 Jan 2019 17:44:00 +0000 (17:44 +0000)]
Fix tag for partial blocks config

Change-Id: I421298f216bc018d1606c297b2f89ee53c8da7ec

2 years agobuild: Update eslint-config-wikimedia to 0.10.0
Ed Sanders [Tue, 8 Jan 2019 17:40:11 +0000 (17:40 +0000)]
build: Update eslint-config-wikimedia to 0.10.0

Change-Id: I2930bcabeeb7b7b2eb36063e77b26e664a691b43

2 years agoRelax filter attribute filtering to allow self-referential urls
Brian Wolff [Mon, 28 Jul 2014 21:20:30 +0000 (18:20 -0300)]
Relax filter attribute filtering to allow self-referential urls

The filter attribute will often have things like filter="url( #foo )"
These local to the file filters in svgs should be fine (We already
disallow non-local xlink:href attributes on <filter> elements). In
fact, users can already do the exact same thing by doing:
style="filter: url( #foo )"

Bug: 67044
Change-Id: Ib25328c160c0d5ea7e01dc84616b76e1b9dcd0eb

2 years agoAdd @since tags to new public methods related to partial blocks
Thalia [Tue, 8 Jan 2019 12:44:33 +0000 (12:44 +0000)]
Add @since tags to new public methods related to partial blocks

Bug: T210369
Change-Id: I20197ceee8e5e43fac20addc494b841519b915c8

2 years agoRemove comments documenting constructors as "constructors"
Thiemo Kreuz [Wed, 2 Jan 2019 09:20:13 +0000 (10:20 +0100)]
Remove comments documenting constructors as "constructors"

Such comments are cruft and do not add anything that's not already
obvious from the code.

Change-Id: I42068b0c6c904bc4ee38f1700e0ea14c3d659a25

2 years agoMerge "HTMLSelectLanguageField: Add explicit sort"
jenkins-bot [Tue, 8 Jan 2019 09:21:53 +0000 (09:21 +0000)]
Merge "HTMLSelectLanguageField: Add explicit sort"

2 years agoMerge "Revert "Revert "Title::checkUserBlock should call User::isBlockedFrom for...
jenkins-bot [Tue, 8 Jan 2019 07:00:20 +0000 (07:00 +0000)]
Merge "Revert "Revert "Title::checkUserBlock should call User::isBlockedFrom for every action"""

2 years agoAdd me to .mailmap and remove duplicate name
RazeSoldier [Thu, 3 Jan 2019 05:13:19 +0000 (13:13 +0800)]
Add me to .mailmap and remove duplicate name

Change-Id: I39de232fc6d3986ce36e205d89523fe3c8b52500

2 years agobuild: Update qunitjs to 2.9.1
Timo Tijhof [Tue, 8 Jan 2019 04:59:44 +0000 (20:59 -0800)]
build: Update qunitjs to 2.9.1

Code and integrity from <https://code.jquery.com/qunit/>.
Release notes at <https://github.com/qunitjs/qunit/releases>.

Highlights for the browser version:

- [2.7.0] Reporter: Remove cost of DOM size when
  using "hidepassed=true".
- [2.7.0] Reporter: Use perf.now() for improved accurracy
  of unit test durations.
- [2.7.0] Reporter: Make debugging tests in a browser
  easier by adding timeline markers for DevTools.

Highlights for the npm package / CLI version:

- [2.9.0] CLI: Reduce dependency tree size
               from 143 packages to 9 packages.

Change-Id: I38408d90765cd18d5dd6952b8b6b30cbfa0c7ed5

2 years agoDon't check for LIBXML_PARSEHUGE presence
Max Semenik [Tue, 8 Jan 2019 03:32:39 +0000 (19:32 -0800)]
Don't check for LIBXML_PARSEHUGE presence

It's been present since PHP 5.3.2.

Change-Id: I23a3c50c10e984abe6ff214fbf504ab6f6be763c

2 years agoRemove a CURLOPT_CONNECTTIMEOUT_MS check
Max Semenik [Tue, 8 Jan 2019 02:25:59 +0000 (18:25 -0800)]
Remove a CURLOPT_CONNECTTIMEOUT_MS check

It was introduced in PHP 5.2.3.

Change-Id: I0c7e1684038c98677ceefbcfbb78641e90713002

2 years agoMerge "objectcache: add more "touchedCallback" comments to WANObjectCache"
jenkins-bot [Tue, 8 Jan 2019 00:44:32 +0000 (00:44 +0000)]
Merge "objectcache: add more "touchedCallback" comments to WANObjectCache"

2 years agoHTMLSelectLanguageField: Add explicit sort
Volker E [Mon, 7 Jan 2019 22:25:00 +0000 (14:25 -0800)]
HTMLSelectLanguageField: Add explicit sort

Follow-up to I46dc6cc8f7d.

Change-Id: Ie5f8999cb6a24d394ceb1cf9b92facbd86431960

2 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Mon, 7 Jan 2019 21:11:34 +0000 (22:11 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: I4e4b7c8958b5c5626a9f5dc32f115c13f21eb8be

2 years agoWikiPage::doUpdateRestrictions checks DB_MASTER
Elliott Eggleston [Thu, 20 Dec 2018 16:39:49 +0000 (11:39 -0500)]
WikiPage::doUpdateRestrictions checks DB_MASTER

This would prevent double entries in logs when the same protection
is applied twice within a few minutes. Trying out usage of the
parent patch's new functionality.

Bug: T210983
Change-Id: Ibd6e481db2faa5955f52f36d5d7368adc8747c9c

2 years agoUpdate the design of Special:Block
Thalia [Mon, 7 Jan 2019 14:04:54 +0000 (14:04 +0000)]
Update the design of Special:Block

Update the design now we have the extra options for
partial blocks.

Bug: T202773
Bug: T212964
Change-Id: I569eb2a8b15b9ad7f9f0e99bce2cd9b818a82fb4

2 years agoMerge "Do not pass $archiveName two times to OldLocalFile"
jenkins-bot [Mon, 7 Jan 2019 18:51:29 +0000 (18:51 +0000)]
Merge "Do not pass $archiveName two times to OldLocalFile"

2 years agoobjectcache: add more "touchedCallback" comments to WANObjectCache
Aaron Schulz [Sun, 6 Jan 2019 21:55:14 +0000 (13:55 -0800)]
objectcache: add more "touchedCallback" comments to WANObjectCache

Change-Id: I55775216154aba0042f7c4cf1cb07336aa4a222e

2 years agoMerge "Pass READ_LATEST in $flags to Title::loadRestrictions"
jenkins-bot [Mon, 7 Jan 2019 17:29:11 +0000 (17:29 +0000)]
Merge "Pass READ_LATEST in $flags to Title::loadRestrictions"

2 years agoPass READ_LATEST in $flags to Title::loadRestrictions
Elliott Eggleston [Tue, 18 Dec 2018 19:35:00 +0000 (14:35 -0500)]
Pass READ_LATEST in $flags to Title::loadRestrictions

To be more consistent with other calls that do the same thing
Also bypass cache when READ_LATEST is set.
Removes duplicated $this->getArticleID call.
Removes $readLatest parameter from loadRestrictionsFromRows.

Bug: T210983
Change-Id: I2340e81fda8244b31f6a3c511ca29162f21d91c9

2 years agoMerge "Make user rights conflict error a bit more obvious"
jenkins-bot [Mon, 7 Jan 2019 17:00:01 +0000 (17:00 +0000)]
Merge "Make user rights conflict error a bit more obvious"

2 years agoMerge "Add force option to password policy"
jenkins-bot [Mon, 7 Jan 2019 16:59:55 +0000 (16:59 +0000)]
Merge "Add force option to password policy"

2 years agoMake user rights conflict error a bit more obvious
Gergő Tisza [Mon, 7 Jan 2019 01:36:43 +0000 (17:36 -0800)]
Make user rights conflict error a bit more obvious

Bug: T113048
Change-Id: Ia3992dcb473ec428188505e22b2def75fd23f98e

2 years agoRevert "Revert "Title::checkUserBlock should call User::isBlockedFrom for every action""
Tchanders [Thu, 6 Dec 2018 20:35:40 +0000 (20:35 +0000)]
Revert "Revert "Title::checkUserBlock should call User::isBlockedFrom for every action""

This reverts commit 91fc7480301c8b2404cc280511c2fc83a6c3aa5d.

Hence it reapplies I6312a36911e5b73d773452fefef7ff25b9af08a4.

The changes made by this commit are (excluding the cases
checked for earlier):
* An action can only be blocked if prevents() is true/null and
isBlockedFrom() is truthy. Previously, any action other than
'edit' or 'create' would be blocked if prevents() was true/null,
regardless of isBlockedFrom().
* If an Action can be constructed, and requiresUnblock() is
false, the action won't be blocked. Previously, requiresUnblock()
wasn't checked.

This commit was previously reverted because it exposed that
EditEntityAction::requiresUnblock in Wikibase wrongly returned
false (fixed in I99061230023da2bbd0f98190a2907ca2e9717a4c).
Other potentially similar cases were audited in T211048.

Bug: T208862
Change-Id: If74a1d422290b8c62b7a7a8922621c73c9598269

2 years agoMerge "Special:UserRights: Fix handling of empty conflict check value"
jenkins-bot [Mon, 7 Jan 2019 12:07:46 +0000 (12:07 +0000)]
Merge "Special:UserRights: Fix handling of empty conflict check value"

2 years agoMerge "Improve OutputPage::wrapWikiMsg documentation"
jenkins-bot [Mon, 7 Jan 2019 08:51:10 +0000 (08:51 +0000)]
Merge "Improve OutputPage::wrapWikiMsg documentation"

2 years agoSpecial:UserRights: Fix handling of empty conflict check value
Gergő Tisza [Mon, 7 Jan 2019 02:03:07 +0000 (18:03 -0800)]
Special:UserRights: Fix handling of empty conflict check value

Bug: T164211
Change-Id: I6b710a25e9be29497846fafe39c916d480989a96

2 years agoImprove OutputPage::wrapWikiMsg documentation
Gergő Tisza [Mon, 7 Jan 2019 01:33:50 +0000 (17:33 -0800)]
Improve OutputPage::wrapWikiMsg documentation

Four spaces before the code sample makes it actually intepreted as
code sample in many phpdoc parsers (e.g. PhpStorm) instead of trying
to intepret HTML tags as HTML and making a mess of things.

Change-Id: I17d09a64116fa9b1372a7fd39f2a8049dcf805b1

2 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Sun, 6 Jan 2019 20:58:10 +0000 (21:58 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: I6fcdf609a7ffdacc51d7e8d1cf5974c69eba7dc6

2 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Sat, 5 Jan 2019 20:52:48 +0000 (21:52 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: Ie3a32793aa3d108fbef8534bbfe3d25419f365d2

2 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Sat, 5 Jan 2019 14:01:58 +0000 (15:01 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: I5f2f62795f2efc8b375d1ea2a0d413908792ecc9

2 years agoMerge "Make ContribsPager properties private again"
jenkins-bot [Fri, 4 Jan 2019 22:50:33 +0000 (22:50 +0000)]
Merge "Make ContribsPager properties private again"

2 years agoMake ContribsPager properties private again
Kosta Harlan [Fri, 4 Jan 2019 21:33:45 +0000 (16:33 -0500)]
Make ContribsPager properties private again

Bug: T212771
Follows-Up: I2295a3fefe874a59458e6ea7edd2cfdd9e912096
Depends-On: I847cb6863be2b6b196b2a992c3dde13e0b21462a
Change-Id: I6b7d0c502ab0219de1b04c8e78e4aaffe43ea0d0

2 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Fri, 4 Jan 2019 21:45:00 +0000 (22:45 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: Ie96ca9a369fc56dfee770db77cd81378a9f9beda

2 years agoMerge "DeletedContribsPager: Add getters for properties accessed by Flow"
jenkins-bot [Fri, 4 Jan 2019 21:16:34 +0000 (21:16 +0000)]
Merge "DeletedContribsPager: Add getters for properties accessed by Flow"

2 years agoMerge "Add getters for properties accessed by Flow"
jenkins-bot [Fri, 4 Jan 2019 21:16:28 +0000 (21:16 +0000)]
Merge "Add getters for properties accessed by Flow"

2 years agoRemove unnecessary calc operation in .less file
Thalia [Fri, 4 Jan 2019 18:20:09 +0000 (18:20 +0000)]
Remove unnecessary calc operation in .less file

Change-Id: I3db79e58e6d590da0fc2b168d784e1f666c2337b

2 years agoMerge "Always load styles for Special:Block page"
jenkins-bot [Fri, 4 Jan 2019 11:02:49 +0000 (11:02 +0000)]
Merge "Always load styles for Special:Block page"

2 years agoMerge "Temporarily make ContribsPager properties public to unblock Flow"
jenkins-bot [Fri, 4 Jan 2019 10:12:23 +0000 (10:12 +0000)]
Merge "Temporarily make ContribsPager properties public to unblock Flow"

2 years agoTemporarily make ContribsPager properties public to unblock Flow
Kosta Harlan [Wed, 2 Jan 2019 16:24:20 +0000 (11:24 -0500)]
Temporarily make ContribsPager properties public to unblock Flow

This partially "reverts" Ic2367ca by explicitely marking the properties
Flow depends on as public. Before, these properties have not been
declared, but dynamically created. PHP marks dynamically created
properties as public by default.

Note that before Ic2367ca it was not even documented that these properties
exist. Flow was using undocumented code.

This revert is done to unblock the currently broken Beta cluster and
give us more time to find cleaner solutions. Some much more sustainable
solutions are discussed in T212771.

Bug: T212771
Change-Id: I2295a3fefe874a59458e6ea7edd2cfdd9e912096

2 years agoDeletedContribsPager: Add getters for properties accessed by Flow
Kosta Harlan [Fri, 4 Jan 2019 02:37:21 +0000 (21:37 -0500)]
DeletedContribsPager: Add getters for properties accessed by Flow

Bug: T212771
Follows-Up: I35dad85740cae47877e9eb62d179b1412099aad1
Change-Id: I9d324217cacc2d731945975b7066d4c17bd915fb

2 years agoDon't hardcode guzzle dependancies
Reedy [Fri, 4 Jan 2019 02:17:43 +0000 (02:17 +0000)]
Don't hardcode guzzle dependancies

Change-Id: I09eb6c9a70c269f14e1e8309fdc572769c4fc07d

2 years agoAdd getters for properties accessed by Flow
Kosta Harlan [Thu, 3 Jan 2019 18:54:06 +0000 (13:54 -0500)]
Add getters for properties accessed by Flow

Bug: T212771
Follows-Up: Ic2367ca7e8d8b2b7ae4f80ad04081a0db2821de5
Change-Id: I35dad85740cae47877e9eb62d179b1412099aad1

2 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Thu, 3 Jan 2019 21:24:08 +0000 (22:24 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: I78a173ff93a983f41c8baf5f3b1e739d1aa1f602

2 years agoAlways load styles for Special:Block page
Thalia [Thu, 3 Jan 2019 19:04:48 +0000 (19:04 +0000)]
Always load styles for Special:Block page

Load the styles regardless of whether the user has
JavaScript.

Bug: T212880
Change-Id: If103aebd1ca1368ddee7322bf52f7d9d35bd950c

2 years agoMerge "Remove duplicate assertion in SpecialBlockTest"
jenkins-bot [Thu, 3 Jan 2019 19:25:50 +0000 (19:25 +0000)]
Merge "Remove duplicate assertion in SpecialBlockTest"

2 years agoMerge "Special:Block: Align partial input field better with rest of interface"
jenkins-bot [Thu, 3 Jan 2019 17:54:16 +0000 (17:54 +0000)]
Merge "Special:Block: Align partial input field better with rest of interface"

2 years agoMerge "Fix type for UserMailer::send $body param"
jenkins-bot [Thu, 3 Jan 2019 17:54:11 +0000 (17:54 +0000)]
Merge "Fix type for UserMailer::send $body param"

2 years agoMerge "Add check for editing restriction widget on Special:Block"
jenkins-bot [Thu, 3 Jan 2019 17:54:05 +0000 (17:54 +0000)]
Merge "Add check for editing restriction widget on Special:Block"

2 years agoSpecial:Block: Align partial input field better with rest of interface
Volker E [Wed, 2 Jan 2019 23:54:15 +0000 (15:54 -0800)]
Special:Block: Align partial input field better with rest of interface

Also include sizing foundational variables to deal with `em` rendering quirks,
aimed to be replaced by central ones in future.

Change-Id: Iba65f68b233becba6054ca068a4cf7aaee0d8e4c

2 years agoRemove duplicate assertion in SpecialBlockTest
Thalia [Thu, 3 Jan 2019 17:06:50 +0000 (17:06 +0000)]
Remove duplicate assertion in SpecialBlockTest

Change-Id: I55d0112a8e3acf06fdfca979552a2746ae928c4f

2 years agoFix type for UserMailer::send $body param
Umherirrender [Thu, 3 Jan 2019 17:01:54 +0000 (18:01 +0100)]
Fix type for UserMailer::send $body param

It is documented to be an array, so add it to the type

Change-Id: I92c56fd92f2c09f75d9370aab711b7446c31beb5

2 years agoMerge "watcheditem: Remove unused import/use statement"
jenkins-bot [Thu, 3 Jan 2019 11:58:06 +0000 (11:58 +0000)]
Merge "watcheditem: Remove unused import/use statement"

2 years agoAdd check for editing restriction widget on Special:Block
Thalia [Thu, 3 Jan 2019 10:59:20 +0000 (10:59 +0000)]
Add check for editing restriction widget on Special:Block

If partial blocks is not enabled, editing restriction widget
will not exist, so check before binding events.

Bug: T212808
Change-Id: I33fd7efdc24c026338e25d7c0751d31bc9a7baba

2 years agowatcheditem: Remove unused import/use statement
Derick Alangi [Thu, 3 Jan 2019 10:31:32 +0000 (11:31 +0100)]
watcheditem: Remove unused import/use statement

Namespace imported but never used hence removed as it's not
necessary.

Change-Id: I788852cdbd310f4c891d1f438aac691719386044

2 years agoDo not pass $archiveName two times to OldLocalFile
Thiemo Kreuz [Wed, 2 Jan 2019 14:51:40 +0000 (15:51 +0100)]
Do not pass $archiveName two times to OldLocalFile

Check the first dozen lines in ImportableUploadRevisionImporter::import().
In all cases the $archiveName is passed as a parameter to
OldLocalFile::newFromArchiveName(), and available via
OldLocalFile::getArchiveName().

I used https://codesearch.wmflabs.org/search/?q=uploadOld to make sure
this method is not called anywhere else. I consider it "package private"
and suggest to not apply the deprecation policy on this particular code.

Change-Id: Ibe9fb55d7e0d6e87698a56f7cfbf31d3d44ba70c

2 years agoMerge "Convert Special:AllMessages to use OOUI"
jenkins-bot [Thu, 3 Jan 2019 00:11:48 +0000 (00:11 +0000)]
Merge "Convert Special:AllMessages to use OOUI"

2 years agoMerge "mailmap: list new address not detected by updateCredits.php"
jenkins-bot [Wed, 2 Jan 2019 23:53:35 +0000 (23:53 +0000)]
Merge "mailmap: list new address not detected by updateCredits.php"

2 years agoMerge "Update CREDITS file to include new contributors"
jenkins-bot [Wed, 2 Jan 2019 23:53:28 +0000 (23:53 +0000)]
Merge "Update CREDITS file to include new contributors"

2 years agoConvert Special:AllMessages to use OOUI
Sethakill [Wed, 4 May 2016 19:23:04 +0000 (21:23 +0200)]
Convert Special:AllMessages to use OOUI

Moved form from pager and
added new HTMLSelectLanguageField.

Bug: T117749
Bug: T134425
Change-Id: I46dc6cc8f7ddf8552a726202df136cbbff66588c

2 years agoMerge "SkinApi: Do not load 'mediawiki.searchSuggest'"
jenkins-bot [Wed, 2 Jan 2019 23:10:31 +0000 (23:10 +0000)]
Merge "SkinApi: Do not load 'mediawiki.searchSuggest'"

2 years agoMerge "Make sql.php exit status more informative"
jenkins-bot [Wed, 2 Jan 2019 23:10:26 +0000 (23:10 +0000)]
Merge "Make sql.php exit status more informative"

2 years agoMerge "Unbreak Pbkdf2PasswordTest"
jenkins-bot [Wed, 2 Jan 2019 21:48:11 +0000 (21:48 +0000)]
Merge "Unbreak Pbkdf2PasswordTest"

2 years agoMerge "filerepo: Replace confusing substr() with rtrim()"
jenkins-bot [Wed, 2 Jan 2019 21:22:49 +0000 (21:22 +0000)]
Merge "filerepo: Replace confusing substr() with rtrim()"

2 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Wed, 2 Jan 2019 21:02:33 +0000 (22:02 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: Ife6a31781d2ab05655f80a1c45bdd71b008f75c5

2 years agoMerge "filerepo: Avoid two pointless substr() in File"
jenkins-bot [Wed, 2 Jan 2019 20:58:30 +0000 (20:58 +0000)]
Merge "filerepo: Avoid two pointless substr() in File"

2 years agoMerge "Make use of \File::getArchiveRel to avoid code duplication"
jenkins-bot [Wed, 2 Jan 2019 20:58:25 +0000 (20:58 +0000)]
Merge "Make use of \File::getArchiveRel to avoid code duplication"

2 years agoMerge "user: Ensure returned user groups are sorted"
jenkins-bot [Wed, 2 Jan 2019 20:55:02 +0000 (20:55 +0000)]
Merge "user: Ensure returned user groups are sorted"

2 years agoAdd force option to password policy
Gergő Tisza [Wed, 2 Jan 2019 06:17:30 +0000 (22:17 -0800)]
Add force option to password policy

Adds a way to set an array of options for a password policy. Currently
there is one option, 'forceChange', which forces the user to change
their password (if it fails the given check) before logging in.

Bug: T118774
Change-Id: I28c31fc4eae08c3ac44eff3a05f5e785ce4b9e01

2 years agoTag markers should be wrapped in parentheses on diff page
jdlrobson [Wed, 2 Jan 2019 19:35:38 +0000 (11:35 -0800)]
Tag markers should be wrapped in parentheses on diff page

Bug: T212613
Change-Id: I87ba8a12f520bcad7354dc9ed1c9f46aa02c715f

2 years agoSkinApi: Do not load 'mediawiki.searchSuggest'
Bartosz Dziewoński [Wed, 2 Jan 2019 19:21:18 +0000 (20:21 +0100)]
SkinApi: Do not load 'mediawiki.searchSuggest'

Bug: T212752
Change-Id: Ia6fba6934d0dfc528ad07a159bc5fbf03e9e9f24

2 years agoMerge "Sync up with Parsoid parserTests.txt"
jenkins-bot [Wed, 2 Jan 2019 16:49:44 +0000 (16:49 +0000)]
Merge "Sync up with Parsoid parserTests.txt"

2 years agoMerge "Add missing property declarations to LocalFileTest"
jenkins-bot [Wed, 2 Jan 2019 16:22:06 +0000 (16:22 +0000)]
Merge "Add missing property declarations to LocalFileTest"

2 years agoSync up with Parsoid parserTests.txt
Subramanya Sastry [Fri, 28 Dec 2018 16:27:08 +0000 (10:27 -0600)]
Sync up with Parsoid parserTests.txt

This now aligns with Parsoid commit 391acbfe0c93d632727ea08cd2a10b4dba8c257f

Change-Id: I0e8c154eaf118f9cd5b58d657f64d0829a65c8f0

2 years agofilerepo: Replace confusing substr() with rtrim()
Thiemo Kreuz [Wed, 2 Jan 2019 15:29:04 +0000 (16:29 +0100)]
filerepo: Replace confusing substr() with rtrim()

I just looked at this code for ten minutes to understand what
sub-string is extracted here. Not only are the numbers hard to
understand: With 0 and -1 the last character is removed – that's
really all this does. Even more problematic is the fact there is
no check, hint, not even a comment explaining *which* character is
removed. If – for whatever reason – the code above returns a string
that does *not* end with a slash, the unconditional substr() call
must destroy this string.

rtrim() shows the character.

I checked and these strings are all guaranteed to use forward
slashes, never backwards (Windows) slashes.

Change-Id: I2e17fd583982920bb8a0ca73035094099e5e5d31

2 years agofilerepo: Avoid two pointless substr() in File
Thiemo Kreuz [Wed, 2 Jan 2019 15:27:09 +0000 (16:27 +0100)]
filerepo: Avoid two pointless substr() in File

In both cases the slash was added one line above, just to be cut off
again.

Change-Id: I15ff6b47821033f123f555f02c42fc8984ad9800

2 years agoMake use of \File::getArchiveRel to avoid code duplication
Thiemo Kreuz [Wed, 2 Jan 2019 15:24:56 +0000 (16:24 +0100)]
Make use of \File::getArchiveRel to avoid code duplication

Before, the string "archive/" was hard-coded in many places.

Change-Id: I62e4471711d183f37e89dc02f3709187164faf0e

2 years agoAdd missing property declarations to LocalFileTest
Thiemo Kreuz [Wed, 2 Jan 2019 14:25:44 +0000 (15:25 +0100)]
Add missing property declarations to LocalFileTest

Change-Id: I518a7a939042110f7ca67b0697e35e2e35105a08

2 years agoMerge "Remove unused line"
jenkins-bot [Wed, 2 Jan 2019 12:37:03 +0000 (12:37 +0000)]
Merge "Remove unused line"

2 years agologging: Correct $logId default value in LogPager.php
Alangi Derick [Mon, 3 Dec 2018 12:38:03 +0000 (13:38 +0100)]
logging: Correct $logId default value in LogPager.php

$logId holds the log entry ID of some specific log and the datatype
is an integer (int) which is correct but looking at the constructor,
it does take a bool (false) which contradicts the docs above. So per
@Thiemo's advice after review of prev PS, it would be better to replace
false with 0 and leave the docs untouched.

Change-Id: Ieceb79a6cbaa248e1b7a7d3c1d51eb26bb3a2d84

2 years agoMerge "Move exif messages to a separate i18n file"
jenkins-bot [Wed, 2 Jan 2019 11:03:18 +0000 (11:03 +0000)]
Merge "Move exif messages to a separate i18n file"

2 years agoMerge "Revert "build: Run minus-x to check for executable files that shouldn't be""
jenkins-bot [Wed, 2 Jan 2019 10:34:19 +0000 (10:34 +0000)]
Merge "Revert "build: Run minus-x to check for executable files that shouldn't be""

2 years agoRevert "build: Run minus-x to check for executable files that shouldn't be"
Jforrester [Wed, 2 Jan 2019 10:19:43 +0000 (10:19 +0000)]
Revert "build: Run minus-x to check for executable files that shouldn't be"

This reverts commit bd2a718cf09cc5826d5a1ef27b1fbb21741e4342.

Bug: T212766
Change-Id: Ic453d7e672ad6c1e39f33f7efd104483f95f5b89