Temporarily make ContribsPager properties public to unblock Flow
authorKosta Harlan <kharlan@wikimedia.org>
Wed, 2 Jan 2019 16:24:20 +0000 (11:24 -0500)
committerThiemo Kreuz <thiemo.kreuz@wikimedia.de>
Fri, 4 Jan 2019 09:44:27 +0000 (10:44 +0100)
commite22be242941b30d03a43bda0e98e21707677b859
tree75665d6f6216bae5aace38298b548db792682f93
parent9d7a2a625193e8e1c767629e3d01da72c3e8712d
Temporarily make ContribsPager properties public to unblock Flow

This partially "reverts" Ic2367ca by explicitely marking the properties
Flow depends on as public. Before, these properties have not been
declared, but dynamically created. PHP marks dynamically created
properties as public by default.

Note that before Ic2367ca it was not even documented that these properties
exist. Flow was using undocumented code.

This revert is done to unblock the currently broken Beta cluster and
give us more time to find cleaner solutions. Some much more sustainable
solutions are discussed in T212771.

Bug: T212771
Change-Id: I2295a3fefe874a59458e6ea7edd2cfdd9e912096
includes/specials/pagers/ContribsPager.php