Do not pass $archiveName two times to OldLocalFile
authorThiemo Kreuz <thiemo.kreuz@wikimedia.de>
Wed, 2 Jan 2019 14:51:40 +0000 (15:51 +0100)
committerThiemo Kreuz <thiemo.kreuz@wikimedia.de>
Thu, 3 Jan 2019 08:24:16 +0000 (09:24 +0100)
commitf170728105b0a6602551d8dfcc5be506125e0d71
treee227b93e5bff52b487c90c7b11c43d2f698838b4
parentd786ea73c0c6ed256f56f79d62c5c63bf834158e
Do not pass $archiveName two times to OldLocalFile

Check the first dozen lines in ImportableUploadRevisionImporter::import().
In all cases the $archiveName is passed as a parameter to
OldLocalFile::newFromArchiveName(), and available via
OldLocalFile::getArchiveName().

I used https://codesearch.wmflabs.org/search/?q=uploadOld to make sure
this method is not called anywhere else. I consider it "package private"
and suggest to not apply the deprecation policy on this particular code.

Change-Id: Ibe9fb55d7e0d6e87698a56f7cfbf31d3d44ba70c
includes/filerepo/file/OldLocalFile.php
includes/import/ImportableUploadRevisionImporter.php