4 years agoSkin: Make skins aware of their registered skin name
Timo Tijhof [Fri, 25 Aug 2017 21:25:57 +0000 (22:25 +0100)]
Skin: Make skins aware of their registered skin name

Remove the need for skin classes to have a hardcoded string as
skinname property value. This previously created the possibility
for the value to not match the skinname in the SkinFactory registry,
which creates confusing situations where message keys and load.php
urls are crafted with the internal skinname, but all other
handling (useskin, preferences, hooks, SkinFactory, ResourceLoader,
etc.) operate on the names in the registry.

We could enforce the matching by requiring a 1:1 relationship between
skinnames and Skin sub classes, but that is not backwards-compatible
with the 1:many map that wgValidSkinNames provides, and not compatible
SkinFactory either, which supports a factory function to return an
object. This makes a lot of sense and allows Skin-classees to be
re-used and composed with injection. If we do want to enforce 1:1,
we could validate it with a structure PHPUnit test, but instead this
change just uses the injected name from the constructor (passed by
ServiceWiring, previously unused).

The added unit test shows the new behaviour. Before this change,
getSkinName() on SkinFallback would always return 'fallback',
whereas now each instance of the class adheres to the registered
name (if it differs from the default).

Update the two direct uses of protected $skin->skinname to use
$skin->getSkinName() instead to enable sub-classes to optionally
implement an alternate source for the self-name (or to hardcode
it there as before).

Bug: T173546
Change-Id: I4383dcc3094da6e3c9ac12dc6c9311128db9db6e

4 years agoMerge "RCFilters: rephrase the feedback link text"
jenkins-bot [Wed, 30 Aug 2017 18:00:38 +0000 (18:00 +0000)]
Merge "RCFilters: rephrase the feedback link text"

4 years agoMerge "Fix index in PostgreSQL schema"
jenkins-bot [Wed, 30 Aug 2017 16:54:15 +0000 (16:54 +0000)]
Merge "Fix index in PostgreSQL schema"

4 years agoMerge "Prefix comment table when adding indexes"
jenkins-bot [Wed, 30 Aug 2017 16:54:12 +0000 (16:54 +0000)]
Merge "Prefix comment table when adding indexes"

4 years agoPrefix comment table when adding indexes
Reedy [Wed, 30 Aug 2017 15:33:14 +0000 (16:33 +0100)]
Prefix comment table when adding indexes

Change-Id: Ie87d2ef68050a402d6c81ca98cc7402f7c5f14aa
Follows-Up: Ic3a434c061ed6e443ea072bc62dda09acbeeed7f

4 years agoMerge "Use HTTPS protocol in resources/src/mediawiki.toolbar/images/ksh/LICENSE"
jenkins-bot [Wed, 30 Aug 2017 16:32:58 +0000 (16:32 +0000)]
Merge "Use HTTPS protocol in resources/src/mediawiki.toolbar/images/ksh/LICENSE"

4 years agoFix index in PostgreSQL schema
Brad Jorsch [Wed, 30 Aug 2017 16:27:33 +0000 (12:27 -0400)]
Fix index in PostgreSQL schema

Followup to Ic3a434c06

Change-Id: I68966726f91b1854e845b2a0757b599644749b4f

4 years agoMerge "RCFilters: Include invert param when reading default saved query"
jenkins-bot [Wed, 30 Aug 2017 12:08:18 +0000 (12:08 +0000)]
Merge "RCFilters: Include invert param when reading default saved query"

4 years agoMerge "SpecialRecentchanges: Restore ability to use language links in 'recentchangest...
jenkins-bot [Wed, 30 Aug 2017 07:26:43 +0000 (07:26 +0000)]
Merge "SpecialRecentchanges: Restore ability to use language links in 'recentchangestext' message"

4 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Wed, 30 Aug 2017 06:42:52 +0000 (08:42 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: Ia9564e3135fe8cc5ba61588cd921180af7489167

4 years agoparserTests: Improve class name guessing for PHPUnit
Kunal Mehta [Sat, 8 Jul 2017 07:14:13 +0000 (00:14 -0700)]
parserTests: Improve class name guessing for PHPUnit

Since we know the extension name, actually use it instead of trying to
guess it based on the directory name.

The new directory layout for autodiscovery encourages "tests/parser" so
the directory one level up is unlikely to be the extension name.

Change-Id: I352944a84197acba6fe425b6044b17c520e263d7

4 years agoAdd `comment` table and code to start using it
Brad Jorsch [Tue, 6 Jun 2017 17:39:14 +0000 (13:39 -0400)]
Add `comment` table and code to start using it

A subsequent patch will remove the old columns.

Bug: T166732
Change-Id: Ic3a434c061ed6e443ea072bc62dda09acbeeed7f

4 years agoRCFilters: Include invert param when reading default saved query
Moriel Schottlender [Tue, 29 Aug 2017 22:04:45 +0000 (15:04 -0700)]
RCFilters: Include invert param when reading default saved query

Bug: T174506
Change-Id: Ibca0e0c80d8069ac3e73533f1f342c2946cce6ca

4 years agoMerge "WLFilters: Use displaysOnUnstructuredUi instead of isVisible"
jenkins-bot [Tue, 29 Aug 2017 21:11:58 +0000 (21:11 +0000)]
Merge "WLFilters: Use displaysOnUnstructuredUi instead of isVisible"

4 years agoRCFilters: rephrase the feedback link text
Stephane Bisson [Tue, 29 Aug 2017 20:54:33 +0000 (16:54 -0400)]
RCFilters: rephrase the feedback link text

It now works fine whether the filters you are using
are in beta (WL) or not (RC, soon).

Bug: T174411
Change-Id: I1714d70f3f1016cba2d06ea0c11ca7c664735905

4 years agoMerge "Add @since tag to Title::canHaveTalkPage()"
jenkins-bot [Tue, 29 Aug 2017 20:14:03 +0000 (20:14 +0000)]
Merge "Add @since tag to Title::canHaveTalkPage()"

4 years agoAvoid using deprecated Title::canTalk()
Kunal Mehta [Tue, 29 Aug 2017 19:36:33 +0000 (12:36 -0700)]
Avoid using deprecated Title::canTalk()

Change-Id: Ibd224f9de595435524e683262882c9ebf2761abf

4 years agoAdd @since tag to Title::canHaveTalkPage()
Kunal Mehta [Tue, 29 Aug 2017 19:28:39 +0000 (12:28 -0700)]
Add @since tag to Title::canHaveTalkPage()

It was added in f8ac44cca56.

Change-Id: Iee3e074f5108a905b66c52305978c99b2604f2cd

4 years agoMerge "Rename IP::isValidBlock to isValidRange, deprecating the former"
jenkins-bot [Tue, 29 Aug 2017 18:50:15 +0000 (18:50 +0000)]
Merge "Rename IP::isValidBlock to isValidRange, deprecating the former"

4 years agoMerge "Get better error message for duplicate names in MagicWordArray"
jenkins-bot [Tue, 29 Aug 2017 18:50:11 +0000 (18:50 +0000)]
Merge "Get better error message for duplicate names in MagicWordArray"

4 years agoRename IP::isValidBlock to isValidRange, deprecating the former
MusikAnimal [Wed, 23 Aug 2017 00:07:35 +0000 (20:07 -0400)]
Rename IP::isValidBlock to isValidRange, deprecating the former

This is to remove confusion with the MediaWiki Block class.

All instances of isValidBlock within MediaWiki core have been updated.

Usage of this function will be more widespread with this patch:

Change-Id: Ice1bdae3d16cf365da14c6df0e8d91d2b914e067

4 years agoConvert UNIQUE keys into PRIMARY KEY
Reedy [Fri, 4 Aug 2017 12:43:50 +0000 (14:43 +0200)]
Convert UNIQUE keys into PRIMARY KEY

WMF DBAs have been doing a massive effort to convert UNIQUE KEYS into

Having a PK is essential to do maintenance, specially on large tasks.
By not having a PK it is impossible to add it in a safe way if not done
directly on the master.

Having a PK means that we can easily change the PK into another one if
needed in the future. The ones we chose might not be the best ones, but
will allow us to get them changed.

Bug: T172514
Change-Id: Id635297838938c7c5dfe65d45285a4d16d65152d

4 years agoUse HTTPS protocol in resources/src/mediawiki.toolbar/images/ksh/LICENSE
Suriyaa Kudo [Tue, 29 Aug 2017 15:07:47 +0000 (17:07 +0200)]
Use HTTPS protocol in resources/src/mediawiki.toolbar/images/ksh/LICENSE

Change-Id: I2a5eb6d09322d4bd93d901d30613bc6ed63a7363

4 years agoMerge "RCFilters: Target pushPin icon for size, not all icons"
jenkins-bot [Tue, 29 Aug 2017 12:27:26 +0000 (12:27 +0000)]
Merge "RCFilters: Target pushPin icon for size, not all icons"

4 years agoWLFilters: Use displaysOnUnstructuredUi instead of isVisible
Stephane Bisson [Tue, 29 Aug 2017 12:05:17 +0000 (08:05 -0400)]
WLFilters: Use displaysOnUnstructuredUi instead of isVisible

Follow up I3e48a9f2d9b70f0b9f6d7c6329db9c8e8001ee49

Bug: T171134
Change-Id: Ife0b10265c34d2dfd9a4d234f4a5409382530cc9

4 years agoMerge "Run Selenium tests for skins"
jenkins-bot [Tue, 29 Aug 2017 10:44:35 +0000 (10:44 +0000)]
Merge "Run Selenium tests for skins"

4 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Tue, 29 Aug 2017 06:13:33 +0000 (08:13 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I31af5076f228c31072f4fca54e049eb4cf54feb0

4 years agoMerge "WLFilters: set default values"
jenkins-bot [Tue, 29 Aug 2017 00:50:06 +0000 (00:50 +0000)]
Merge "WLFilters: set default values"

4 years agoRCFilters: Target pushPin icon for size, not all icons
Moriel Schottlender [Mon, 28 Aug 2017 22:31:23 +0000 (15:31 -0700)]
RCFilters: Target pushPin icon for size, not all icons


Bug: T173264
Change-Id: Icb92c55a5b067d77138bae93f4db96309c72a223

4 years agoEnable mediawiki.hlist on mobile
jdlrobson [Mon, 28 Aug 2017 21:14:37 +0000 (16:14 -0500)]
Enable mediawiki.hlist on mobile

Bug: T42062
Change-Id: Iee059a6605cf12a073954378f49ddc721a7e016a

4 years agoRCFilters: Minimize saved query before comparison
Moriel Schottlender [Mon, 28 Aug 2017 20:06:31 +0000 (13:06 -0700)]
RCFilters: Minimize saved query before comparison

Bug: T174193
Change-Id: I8e9345e8899fd27565930896e62c4d3be235ad58

4 years agoMerge "EditPage: Remove temporary OOUI page class name"
jenkins-bot [Mon, 28 Aug 2017 18:45:01 +0000 (18:45 +0000)]
Merge "EditPage: Remove temporary OOUI page class name"

4 years agoMerge "Making sister search sidebar links blue"
jenkins-bot [Mon, 28 Aug 2017 18:11:40 +0000 (18:11 +0000)]
Merge "Making sister search sidebar links blue"

4 years agoEnable mediawiki.special.userlogin.common.styles on mobile and allow skins to style it
jdlrobson [Fri, 18 Aug 2017 19:34:00 +0000 (14:34 -0500)]
Enable mediawiki.special.userlogin.common.styles on mobile and allow skins to style it

Depends-On: I0fe9efcf98bbd8e188d91a29d4cfda897d47808d
Bug: T173597
Change-Id: I36e596e4d6060ef168464732028cd0dcbf21d0f8

4 years agoWLFilters: set default values
Stephane Bisson [Mon, 21 Aug 2017 19:28:23 +0000 (15:28 -0400)]
WLFilters: set default values

* Respect different default values for 'limit' and 'day'
  in RC and WL.

* Make 'latestrevision' respect 'watchlistextended'

Introducing 2 properties to ChangesListBooleanFilter
* activeValue: The value that defines when a filter is active.
  Most filters are active when they are set to 'true' but
  'extended' has no effect when it is 'true' and applies
  filtering when it is set to false.

* isVisible: Whether this filter is visible anywhere.
  'extended' is not visible in the legacy form but
  it is activated from preference or URL. When
  understanding form submission, it should not be assume
  to be 'false' when not present in the request.

Bug: T171134
Change-Id: I3e48a9f2d9b70f0b9f6d7c6329db9c8e8001ee49

4 years agoMerge "Consistent behavior of read-only reason"
jenkins-bot [Mon, 28 Aug 2017 16:36:24 +0000 (16:36 +0000)]
Merge "Consistent behavior of read-only reason"

4 years agoSpecialRecentchanges: Restore ability to use language links in 'recentchangestext...
Bartosz Dziewoński [Mon, 28 Aug 2017 16:12:14 +0000 (18:12 +0200)]
SpecialRecentchanges: Restore ability to use language links in 'recentchangestext' message

Bug: T172461
Change-Id: I7b660c78f410f09815a82810824d56cb7a477280

4 years agoMerge "RCFilters: Adjust highlight for seen/unseen states in Watchlist"
jenkins-bot [Mon, 28 Aug 2017 16:05:56 +0000 (16:05 +0000)]
Merge "RCFilters: Adjust highlight for seen/unseen states in Watchlist"

4 years agoConsistent behavior of read-only reason
Florian Schmidt [Sat, 19 Aug 2017 16:21:40 +0000 (18:21 +0200)]
Consistent behavior of read-only reason

Before this commit, the reason set in the global $wgReadOnly was differently handled
on different special pages. While on most of them, like Special:Upload, the reason
is allowed to have HTML, which can be used in Wikitext, too, Special:CreateAccount
always outputted an escaped version of this reason.

Most special pages uses the ReadOnlyError exception to print a read-only error,
however, AuthManager uses Status objects to communicate between the backend and the
frontend. Therefore the same message and parameters were wrapped in a Status object
and, in the frontend, directly passed to the constructor of ErrorPageError. Unfortunately,
Status::getMessage() escapes the parameters of a message, which is the reason, why the
wiki is read-only. To bypass this restriction, AuthManager now creates a Message object
directly, does not escape the reason, and uses the resulting object to create a Status
object from.

Now the reason is not escaped on Special:CreateAccount anymore, like on most other
special pages.

The read-only message on the protection form is, also before this commit, not escaped and
already displayed correctly, as the read-only is checked in the constructor of the
protection form already and, if the Wiki is read only, handled as a permission error and
already displayed correctly. This commit fixes the behavior of WikiPage in case of it's used
somewhere else, subclassed or if the check in the frontend will be removed and the Status of
WikiPage will be used.

Bug: T157036
Change-Id: Idbfe556fcb90f8bda8fae9d728ca9dee5ea02f67

4 years agoRCFilters: Adjust highlight for seen/unseen states in Watchlist
Moriel Schottlender [Sat, 26 Aug 2017 01:02:48 +0000 (18:02 -0700)]
RCFilters: Adjust highlight for seen/unseen states in Watchlist

Bug: T171235
Change-Id: I33d059d2be83e4730e6dc82f689f49a514286874

4 years agoMerge "Add Atayal (tay) language"
jenkins-bot [Mon, 28 Aug 2017 13:33:06 +0000 (13:33 +0000)]
Merge "Add Atayal (tay) language"

4 years agoMerge "Produce RDF dump of all categories and subcategories in a wiki."
jenkins-bot [Mon, 28 Aug 2017 11:01:57 +0000 (11:01 +0000)]
Merge "Produce RDF dump of all categories and subcategories in a wiki."

4 years agoMerge "postEdit: Generate close button with CSS instead of HTML"
jenkins-bot [Mon, 28 Aug 2017 10:17:29 +0000 (10:17 +0000)]
Merge "postEdit: Generate close button with CSS instead of HTML"

4 years agoMerge "postEdit: Simplify close button"
jenkins-bot [Mon, 28 Aug 2017 10:16:38 +0000 (10:16 +0000)]
Merge "postEdit: Simplify close button"

4 years agoMerge "widgets: Replace outdated colors with WikimediaUI palette ones"
jenkins-bot [Mon, 28 Aug 2017 10:04:21 +0000 (10:04 +0000)]
Merge "widgets: Replace outdated colors with WikimediaUI palette ones"

4 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Mon, 28 Aug 2017 07:34:35 +0000 (09:34 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: If6db589c4d0fdbff5c23ab467424a1f7e9cdaa6f

4 years agoProduce RDF dump of all categories and subcategories in a wiki.
Stanislav Malyshev [Fri, 16 Dec 2016 22:48:46 +0000 (14:48 -0800)]
Produce RDF dump of all categories and subcategories in a wiki.

http://en.wiki.local.wmftest.net:8080/wiki/Category:Ducks> a mediawiki:Category ;
        rdfs:label "Ducks" ;
        mediawiki:isInCategory <http://en.wiki.local.wmftest.net:8080/wiki/Category:Birds> .

Bug: T157676
Change-Id: I59b9603581b37af59d17dd6c38247c85aee44911

4 years agoAdd 1.27.3 to RELEASE-NOTES
Reedy [Sun, 27 Aug 2017 23:11:09 +0000 (00:11 +0100)]
Add 1.27.3 to RELEASE-NOTES

Change-Id: I56fddd375352ad42a315bc078e33edde50bdae66

4 years agopostEdit: Generate close button with CSS instead of HTML
Fomafix [Sun, 27 Aug 2017 17:35:11 +0000 (19:35 +0200)]
postEdit: Generate close button with CSS instead of HTML

Also remove :hover for cursor:pointer because cursor:pointer is always
shown on hovering.

Change-Id: Ib44f927a1764f703a8c31af363ebd5a8fca27375

4 years agopostEdit: Simplify close button
Fomafix [Sun, 27 Aug 2017 16:45:25 +0000 (18:45 +0200)]
postEdit: Simplify close button

Use <span> instead of <a href="#"> for the close button. This makes
resetting the CSS style and the preventDefault() superfluous and
prevents open a new tab on middle click and does not show an
unnecessary status bar on hover.

Change-Id: I8c60aae454d64803686088f1dbe0228b1ecc70be

4 years agoMerge "importDump.php: Declare uploadCount property"
jenkins-bot [Sat, 26 Aug 2017 20:11:32 +0000 (20:11 +0000)]
Merge "importDump.php: Declare uploadCount property"

4 years agoimportDump.php: Declare uploadCount property
Mark A. Hershberger [Sat, 26 Aug 2017 15:28:01 +0000 (11:28 -0400)]
importDump.php: Declare uploadCount property

Bug: T174255
Change-Id: Ic5014821a8f10ab29b729104cd7d4e434085e2f2

4 years agoInstaller: Fix "Array to string conversion" notice
Mark A. Hershberger [Sat, 26 Aug 2017 16:53:44 +0000 (12:53 -0400)]
Installer: Fix "Array to string conversion" notice

PHP Notice: Array to string conversion in .../includes/installer/Installer.php on line 1392

Follows-up fd8d75c1fd26e.

Bug: T174258
Change-Id: I6f8497a74a83aec183684bcb441191c32c67ccde

4 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Sat, 26 Aug 2017 06:16:29 +0000 (08:16 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: Ia6cbcd04a82a4dc499bed0f9e94502631d4820db

4 years agoMerge "Fix old regression in HTMLCacheUpdate de-duplication"
jenkins-bot [Fri, 25 Aug 2017 23:29:02 +0000 (23:29 +0000)]
Merge "Fix old regression in HTMLCacheUpdate de-duplication"

4 years agoMerge "Avoid preemptive DB replication waits for farm cross-wiki redirects"
jenkins-bot [Fri, 25 Aug 2017 23:13:52 +0000 (23:13 +0000)]
Merge "Avoid preemptive DB replication waits for farm cross-wiki redirects"

4 years agoFix old regression in HTMLCacheUpdate de-duplication
Aaron Schulz [Fri, 25 Aug 2017 22:47:01 +0000 (15:47 -0700)]
Fix old regression in HTMLCacheUpdate de-duplication

* The condition timestamp should be the root job timestamp,
  as the comments imply, though that was not the case. Only
  the SET timestamp should be the current timestamp. As it
  was, jobs effectively did not "see" each other since each
  one would be expecting newer than the ones that ran prior.
  The page_touched condition for the UPDATE query was mostly
  useless, since it was always the current timestamp.
* This problem was a regression from f598ca81e3f40166.

Change-Id: I1398366e87c959be1c98e4db959c41309b0ac1b8

4 years agoMerge "WLFilters: Fix seen/unseen filters"
jenkins-bot [Fri, 25 Aug 2017 19:56:52 +0000 (19:56 +0000)]
Merge "WLFilters: Fix seen/unseen filters"

4 years agoMerge "Improve some timeout docs"
jenkins-bot [Fri, 25 Aug 2017 19:56:48 +0000 (19:56 +0000)]
Merge "Improve some timeout docs"

4 years agoAdd Atayal (tay) language
Amire80 [Thu, 17 Aug 2017 13:29:04 +0000 (16:29 +0300)]
Add Atayal (tay) language

Bug: T173383
Change-Id: Id0607ca4a748f88476fefd081864b1282e9bcb8d

4 years agoMerge "Ignore npm-debug.log"
jenkins-bot [Fri, 25 Aug 2017 19:44:34 +0000 (19:44 +0000)]
Merge "Ignore npm-debug.log"

4 years agoMerge "SpecialPageLanguage: Show current page language in the dropdown"
jenkins-bot [Fri, 25 Aug 2017 19:34:10 +0000 (19:34 +0000)]
Merge "SpecialPageLanguage: Show current page language in the dropdown"

4 years agoIgnore npm-debug.log
Arlo Breault [Fri, 25 Aug 2017 19:21:44 +0000 (15:21 -0400)]
Ignore npm-debug.log

Change-Id: Ia984f7baa2aa94e00b7be712d5dc4846d29ede85

4 years agoMerge "WLFilters: avoid querying the DB when filters are in conflict"
jenkins-bot [Fri, 25 Aug 2017 17:24:46 +0000 (17:24 +0000)]
Merge "WLFilters: avoid querying the DB when filters are in conflict"

4 years agoRun Selenium tests for skins
Željko Filipin [Fri, 25 Aug 2017 14:51:05 +0000 (16:51 +0200)]
Run Selenium tests for skins

So far, only extension had Selenium tests, but now MinervaNeue skin also has them.

Bug: T174018
Change-Id: I6bac14f44e677cb0b1fdefc6474d08fb17a0b911

4 years agoWLFilters: Fix seen/unseen filters
Stephane Bisson [Fri, 25 Aug 2017 12:59:26 +0000 (08:59 -0400)]
WLFilters: Fix seen/unseen filters

Handle the fact that wl_notificationtimestamp
can be null.

Always join with 'page' table to support highlight.

Bug: T171127
Change-Id: I150a41b131d64163e06bfa56bddbd762bb636655

4 years agoImprove some timeout docs
addshore [Fri, 25 Aug 2017 10:02:04 +0000 (13:02 +0300)]
Improve some timeout docs

Change-Id: I799ea1e647d4d67a3c7d0e8dfddff893aef32736

4 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Fri, 25 Aug 2017 06:44:10 +0000 (08:44 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I9e46d4a2a740433b768ef2d07139829de8bd587f

4 years agoMerge "widgets.TitleWidget: Use mediawiki.mixins `.box-sizing()`"
jenkins-bot [Fri, 25 Aug 2017 00:49:26 +0000 (00:49 +0000)]
Merge "widgets.TitleWidget: Use mediawiki.mixins `.box-sizing()`"

4 years agoMerge "widgets.StashedFileWidget: Simplify and reduce LESS code"
jenkins-bot [Fri, 25 Aug 2017 00:29:53 +0000 (00:29 +0000)]
Merge "widgets.StashedFileWidget: Simplify and reduce LESS code"

4 years agowidgets.TitleWidget: Use mediawiki.mixins `.box-sizing()`
Volker E [Fri, 25 Aug 2017 00:27:07 +0000 (17:27 -0700)]
widgets.TitleWidget: Use mediawiki.mixins `.box-sizing()`

Using general `box-sizing()` mixin from mediawiki.mixins instead of
decentral vendor prefixes.

Change-Id: I844dc28a627dc984540e9a013dae188187c4f151

4 years agowidgets.StashedFileWidget: Simplify and reduce LESS code
Volker E [Fri, 25 Aug 2017 00:13:22 +0000 (17:13 -0700)]
widgets.StashedFileWidget: Simplify and reduce LESS code

Simplifying and reducing LESS code where applicable.

Change-Id: Ic0f138d33064b4c8f2bb6253a20012a3b577372b

4 years agoAdd sslCAFile option to DatabaseMysqli
Aaron Schulz [Thu, 24 Aug 2017 23:54:19 +0000 (16:54 -0700)]
Add sslCAFile option to DatabaseMysqli

This makes all arguments to the mysqli::set_ssl() call be controllable.

Change-Id: I67ed742add633a77e97d08b812e420a73cd83a52

4 years agowidgets: Replace outdated colors with WikimediaUI palette ones
Volker E [Thu, 24 Aug 2017 23:19:20 +0000 (16:19 -0700)]
widgets: Replace outdated colors with WikimediaUI palette ones

Replacing outdated colors in core widgets with WikimediaUI color
palette ones. Also increasing contrast in one case ensuring
WCAG 2.0 level AA conformance.

Bug: T172850
Change-Id: Ic7cf0842275529372cdfbfddad4eb63fec4847ce

4 years agoMerge "Disable rebound CDN purges for backlinks in HTMLCacheUpdateJob"
jenkins-bot [Thu, 24 Aug 2017 22:37:16 +0000 (22:37 +0000)]
Merge "Disable rebound CDN purges for backlinks in HTMLCacheUpdateJob"

4 years agoMerge "RCFilters: Align remaining outdated greys to WikimediaUI palette ones"
jenkins-bot [Thu, 24 Aug 2017 22:32:32 +0000 (22:32 +0000)]
Merge "RCFilters: Align remaining outdated greys to WikimediaUI palette ones"

4 years agoMerge "RCFilters: Enable 'View newest'"
jenkins-bot [Thu, 24 Aug 2017 22:29:22 +0000 (22:29 +0000)]
Merge "RCFilters: Enable 'View newest'"

4 years agoDisable rebound CDN purges for backlinks in HTMLCacheUpdateJob
Aaron Schulz [Thu, 24 Aug 2017 22:10:19 +0000 (15:10 -0700)]
Disable rebound CDN purges for backlinks in HTMLCacheUpdateJob

These are there to handle regeneration race conditions due to
replication lag. If there happens to already be a huge amount
of purges, the cost of this can be too high. Also, if the queue
is backlogged, then it is already delayed, so extra delayed jobs
do not help and just add to the backlog in that scenario.

Bug: T173710
Change-Id: Ida0bf44233072e1356a9fe63866d522e4bb2d0ca

4 years agoRCFilters: Align remaining outdated greys to WikimediaUI palette ones
Volker E [Thu, 24 Aug 2017 19:42:56 +0000 (12:42 -0700)]
RCFilters: Align remaining outdated greys to WikimediaUI palette ones

Replacing abandoned grey colors with appropriate colors from WikimediaUI
color palette.

Additional changes:
* Also simplified selector specificity in one case as OOUI code has already

Bug: T172850
Change-Id: I01e84d9a4d03ba894cbb67114821036b0ffe1ddb

4 years agoRCFilters: Enable 'View newest'
Stephane Bisson [Thu, 24 Aug 2017 19:47:15 +0000 (15:47 -0400)]
RCFilters: Enable 'View newest'

Keep the feature flag for 'live update'
but enable 'view newest' by default on RC.

Bug: T163426
Change-Id: I733cf99bbeb6d90d3aa21e87507c513354b81791

4 years agoMerge "Prevent editing textarea from jumping when toolbar is loaded"
jenkins-bot [Thu, 24 Aug 2017 17:52:34 +0000 (17:52 +0000)]
Merge "Prevent editing textarea from jumping when toolbar is loaded"

4 years agoMerge "IP: Remove unused static member $proxyIpSet"
jenkins-bot [Thu, 24 Aug 2017 16:29:50 +0000 (16:29 +0000)]
Merge "IP: Remove unused static member $proxyIpSet"

4 years agoMerge "RCFilters: Truncate long saved query titles"
jenkins-bot [Thu, 24 Aug 2017 15:53:26 +0000 (15:53 +0000)]
Merge "RCFilters: Truncate long saved query titles"

4 years agoMerge "Skin: Remove more use of QuickTemplate::setRef()"
jenkins-bot [Thu, 24 Aug 2017 14:53:00 +0000 (14:53 +0000)]
Merge "Skin: Remove more use of QuickTemplate::setRef()"

4 years agoMerge "Make API multivalue limits configurable"
jenkins-bot [Thu, 24 Aug 2017 14:04:24 +0000 (14:04 +0000)]
Merge "Make API multivalue limits configurable"

4 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Thu, 24 Aug 2017 06:34:16 +0000 (08:34 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I4336d8b1d77bbdc7b169ec5fa0fdfe2518392b41

4 years agoMake API multivalue limits configurable
Gergő Tisza [Fri, 28 Jul 2017 17:41:13 +0000 (17:41 +0000)]
Make API multivalue limits configurable

Adds two new parameter settings, ApiBase::PARAM_ISMULTI_LIMIT1
and PARAM_ISMULTI_LIMIT2 for configuring the maximum number of values
that can be contained in a multivalue field (for unprivileged and
apihighlimits users, respectively). When present, these replace the
default 50/500.

Change-Id: Ic1b1bcc7ff556b7762c8d2375d910cc4fcb43087

4 years agoMerge "mediawiki.skinning: Vertical align inline media in Parsoid output"
jenkins-bot [Thu, 24 Aug 2017 01:55:10 +0000 (01:55 +0000)]
Merge "mediawiki.skinning: Vertical align inline media in Parsoid output"

4 years agomediawiki.skinning: Vertical align inline media in Parsoid output
Arlo Breault [Thu, 17 Aug 2017 16:01:33 +0000 (12:01 -0400)]
mediawiki.skinning: Vertical align inline media in Parsoid output

Change-Id: I56df80a25b43f9084e8cb5e537836ac773732259

4 years agoMerge "RCFilters: Adjust pushpin 'default' icon behavior and style"
jenkins-bot [Thu, 24 Aug 2017 00:23:47 +0000 (00:23 +0000)]
Merge "RCFilters: Adjust pushpin 'default' icon behavior and style"

4 years agoPrevent editing textarea from jumping when toolbar is loaded
Kaldari [Thu, 24 Aug 2017 00:16:32 +0000 (17:16 -0700)]
Prevent editing textarea from jumping when toolbar is loaded

If you're using the "classic" editor (not the WikiEditor editor),
the editing textarea jumps down when the toolbar loads, which can
take a few seconds on a slow connection. This can cause editors to
accidently click the toolbar instead of the editing textarea and
accidently insert markup into the article that they didn't mean to.

This rule has been on English Wikipedia's Common.css since 2007.

Change-Id: Ie4ac15c95554608c838ef0e112924fc6381a6f66

4 years agoRCFilters: Adjust pushpin 'default' icon behavior and style
Moriel Schottlender [Wed, 23 Aug 2017 23:10:23 +0000 (16:10 -0700)]
RCFilters: Adjust pushpin 'default' icon behavior and style

Bug: T173264
Change-Id: I8d977bb97e91a19c24527c66120f142738135730

4 years agoRCFilters: Hide saved queries from anonymous users
Moriel Schottlender [Wed, 23 Aug 2017 23:35:10 +0000 (16:35 -0700)]
RCFilters: Hide saved queries from anonymous users

Bug: T173992
Change-Id: I5acb9ca4dd20de83da5db42c7c9053fccb091da0

4 years agoMerge "Unit tests for CollationFa (0bfcbd724)"
jenkins-bot [Wed, 23 Aug 2017 22:46:40 +0000 (22:46 +0000)]
Merge "Unit tests for CollationFa (0bfcbd724)"

4 years agoAvoid preemptive DB replication waits for farm cross-wiki redirects
Aaron Schulz [Tue, 22 Aug 2017 21:36:15 +0000 (14:36 -0700)]
Avoid preemptive DB replication waits for farm cross-wiki redirects

This previously only worked if $wgLocalVirtualHosts was set, which
was too specific to check and not used by WMF. Use the more generic
WikiMap class.

Two methods have been added there to do the work of enumerating
canonical wiki farm URLs and checking them against a given URL.

Bug: T172357
Change-Id: Id2415bab5d7f5a08b9f536858c32d329138384a2

4 years agoSpecialPageLanguage: Show current page language in the dropdown
Bartosz Dziewoński [Wed, 23 Aug 2017 21:17:53 +0000 (23:17 +0200)]
SpecialPageLanguage: Show current page language in the dropdown

Also show canonical page title form while we're at it.

Bug: T74966
Change-Id: I52c19a0a018d76a4282c61c009b40b2f7e56b3d2

4 years agoMerge "RCFilters: Minimize vertical space"
jenkins-bot [Wed, 23 Aug 2017 21:07:23 +0000 (21:07 +0000)]
Merge "RCFilters: Minimize vertical space"

4 years agoMerge "mw.widgets.SelectWithInputWidget: Invisible invalid fields should not block...
jenkins-bot [Wed, 23 Aug 2017 20:54:02 +0000 (20:54 +0000)]
Merge "mw.widgets.SelectWithInputWidget: Invisible invalid fields should not block form submission"

4 years agoSkin: Remove more use of QuickTemplate::setRef()
Timo Tijhof [Wed, 23 Aug 2017 19:30:01 +0000 (20:30 +0100)]
Skin: Remove more use of QuickTemplate::setRef()

Follows-up 2c01147c13be.

* language_links: The local array variable is only used once to
  obtain the value from Skin::getLanguages(), and then never passed
  elsewhere or otherwise potentially changed, so this reference
  doesn't seem useful.
  The getLanguages() method itself also creates a new array every
  time it is called, so the reference from there can't change either.

* Same for content_navigation and content_actions. These are never
  modified, and the method that returns the array creates a new one
  on each call.
  Follows-up r3014 (f4755755daed1f8).

* Same for bodytext.

Presumably these were only set as references to save memory.

Bug: T140664
Change-Id: I1224a7a89c1d7ad05c73132ff73299fd78ade7fb

4 years agomw.widgets.SelectWithInputWidget: Invisible invalid fields should not block form...
Bartosz Dziewoński [Wed, 23 Aug 2017 18:55:20 +0000 (20:55 +0200)]
mw.widgets.SelectWithInputWidget: Invisible invalid fields should not block form submission

Same logic as in resources/src/mediawiki/htmlform/hide-if.js,
explanatory comment is copy-pasted from there.

Bug: T173839
Change-Id: I87603936d23165926d2ef4c64f3a61dca2062caf