Skin: Remove more use of QuickTemplate::setRef()
authorTimo Tijhof <krinklemail@gmail.com>
Wed, 23 Aug 2017 19:30:01 +0000 (20:30 +0100)
committerKrinkle <krinklemail@gmail.com>
Wed, 23 Aug 2017 19:48:12 +0000 (19:48 +0000)
commit429f557cc7f68a469f16cb9d5ce37a2cf33221c8
treebd7a8eb40a4e41a0ac157aa291602b97e8353ec3
parent2d7d468fc2197f7e03b91198ac82972482cffc39
Skin: Remove more use of QuickTemplate::setRef()

Follows-up 2c01147c13be.

* language_links: The local array variable is only used once to
  obtain the value from Skin::getLanguages(), and then never passed
  elsewhere or otherwise potentially changed, so this reference
  doesn't seem useful.
  The getLanguages() method itself also creates a new array every
  time it is called, so the reference from there can't change either.

* Same for content_navigation and content_actions. These are never
  modified, and the method that returns the array creates a new one
  on each call.
  Follows-up r3014 (f4755755daed1f8).

* Same for bodytext.

Presumably these were only set as references to save memory.

Bug: T140664
Change-Id: I1224a7a89c1d7ad05c73132ff73299fd78ade7fb
includes/skins/SkinTemplate.php