lhc/web/wiklou.git
8 years agoMerge "Don't send email notifs to blocked users if $wgBlockDisablesLogin is true"
jenkins-bot [Thu, 13 Aug 2015 16:44:05 +0000 (16:44 +0000)]
Merge "Don't send email notifs to blocked users if $wgBlockDisablesLogin is true"

8 years agoAdding documentation for new RandomPageQuery hook to hooks.txt
Kaldari [Thu, 13 Aug 2015 06:44:53 +0000 (23:44 -0700)]
Adding documentation for new RandomPageQuery hook to hooks.txt

Hook added in I91cd231d1

Change-Id: I448e0227b00e0e5b9390b144b9de360b8453f9ff

8 years agoAdding a new hook to allow modification of Special:Random query
Kaldari [Thu, 13 Aug 2015 02:27:20 +0000 (19:27 -0700)]
Adding a new hook to allow modification of Special:Random query

See: Ia84c54dcdadf54e9475c1dc7d0ec7c2c48afeaae
Bug: T9937
Change-Id: I91cd231d1cbf610f20134fd0271af46842a9a17d

8 years agoTry to make POSTs as transactional as possible
Aaron Schulz [Wed, 12 Aug 2015 23:08:14 +0000 (16:08 -0700)]
Try to make POSTs as transactional as possible

* WMF has has ignore_user_abort() for *all* request in configuration
  for many years. This brings this to default MediaWiki for all POST
  requests, which are likely to do writes. Of course, some do not,
  notably parse requests and previews, since GET cannot carry the
  payload. Avoiding data corruption is more important though.

Bug: T102890
Change-Id: I11c8b0d99583a682f756cef9747ec5ba9751c5e3

8 years agoMerge "Optimized notification timestamp clearing"
jenkins-bot [Wed, 12 Aug 2015 22:56:14 +0000 (22:56 +0000)]
Merge "Optimized notification timestamp clearing"

8 years agoMerge "Preferences: Don't load all default options for every default preference"
jenkins-bot [Wed, 12 Aug 2015 22:52:01 +0000 (22:52 +0000)]
Merge "Preferences: Don't load all default options for every default preference"

8 years agoOptimized notification timestamp clearing
Aaron Schulz [Wed, 12 Aug 2015 22:37:57 +0000 (15:37 -0700)]
Optimized notification timestamp clearing

* Hint that mariadb can avoid scanning already NULL rows since
  we want to set them all to NULL. This lets the index with the
  timestamp be used, which avoids logs of scanning for users with
  many rows. For non-parallel replication, this also avoids slave
  lag in particular.

Bug: T107923
Change-Id: I8cded5476ef6adb2f8fea57239afd6e9b2a49708

8 years agoPreferences: Don't load all default options for every default preference
Alex Monk [Wed, 12 Aug 2015 22:13:13 +0000 (23:13 +0100)]
Preferences: Don't load all default options for every default preference

Change-Id: Iaaebea56674dfaa48dbfedf6c7e5ad9eaa05759e

8 years agoAdded wfTransactionalTimeLimit() method and applied it
Aaron Schulz [Sat, 8 Aug 2015 00:08:33 +0000 (17:08 -0700)]
Added wfTransactionalTimeLimit() method and applied it

* Potentially long running POST requests often use multiple transactions,
  talk to multiple services, or defer updates. Try to make sure they have
  a chance to complete all of the work. WMF already sets ignore_user_abort()
  across the board in config, but this applies it to key spots for all
  installs, in addition to bumping the time limit.
* Eventually this can lower the need for high overall time limits.

Bug: T102890
Change-Id: I893ddd773064dcd63b5b24c84c6391974f4b5aee

8 years agoMerge "Made JobRunner bail more smoothly on near OOM"
jenkins-bot [Wed, 12 Aug 2015 20:47:39 +0000 (20:47 +0000)]
Merge "Made JobRunner bail more smoothly on near OOM"

8 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Wed, 12 Aug 2015 19:14:10 +0000 (21:14 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I02ea462b65c3d406bfc552dd2f6f09d3984bbeb1

8 years agoOutput stylesheet links before other link elements in <head>
Ori Livneh [Wed, 12 Aug 2015 15:52:39 +0000 (08:52 -0700)]
Output stylesheet links before other link elements in <head>

Since external CSS is render-blocking, it should be discoverable to the browser
as soon as possible. So move it up to the top of <head>.

Change-Id: I68a6cce2f33ceb7f6461fcbb7323ae13c413aa89

8 years agoMerge "Changed "archived (revisions)" to "deleted (revisions)""
jenkins-bot [Wed, 12 Aug 2015 15:14:20 +0000 (15:14 +0000)]
Merge "Changed "archived (revisions)" to "deleted (revisions)""

8 years agoRevert "mediawiki.page.ready: When infusing, infuse by id, not by element"
Bartosz Dziewoński [Thu, 6 Aug 2015 09:16:37 +0000 (09:16 +0000)]
Revert "mediawiki.page.ready: When infusing, infuse by id, not by element"

Infusing by element is better, since it avoids the
document.getElementById() lookup and behaves better in case
of duplicate ids (which is invalid HTML, but happens).

This reverts commit 803d89173fc3a56871767663907785cb3eaf7aa5.
Depends on I11fd1c7f2434f904b9ddc94b0903f8278e06f3a1 in OOjs UI.

Bug: T105828
Change-Id: I8c1f5015229db7b8a391f324cfd96be4ac158041

8 years agoUpdate OOjs UI to v0.12.3
James D. Forrester [Tue, 11 Aug 2015 22:39:37 +0000 (15:39 -0700)]
Update OOjs UI to v0.12.3

Release notes:
 https://git.wikimedia.org/blob/oojs%2Fui.git/v0.12.3/History.md

Change-Id: Idd3a4e41154837e84d1dcb4622d04b5765e6cbf9

8 years agoMerge "wikibits.js: Support multiple parameter in document.write"
jenkins-bot [Tue, 11 Aug 2015 21:58:08 +0000 (21:58 +0000)]
Merge "wikibits.js: Support multiple parameter in document.write"

8 years agowikibits.js: Support multiple parameter in document.write
Fomafix [Sat, 8 Aug 2015 20:57:25 +0000 (20:57 +0000)]
wikibits.js: Support multiple parameter in document.write

document.write and document.writeln supports multiple arguments:
http://www.w3.org/html/wg/drafts/html/CR/webappapis.html#document.write%28%29

Support this in the replacement code.

Change-Id: I0ffc51352278d434d8347502c778b16b34c7d73f

8 years agoRestored I4afaecd8: "Avoiding writing sessions for no reason"
Aaron Schulz [Tue, 11 Aug 2015 00:49:19 +0000 (17:49 -0700)]
Restored I4afaecd8: "Avoiding writing sessions for no reason"

* After 203d2c9c11643, the refresh updates should actually trigger

This reverts commit e48fec5a8ab5916735849d420f2dfeec7eb0fced.

Change-Id: I8427ed5b3a5bb80033cbdf071a33f8a3999ecb97

8 years agoMerge "Fixed @var doc in MultiWriteBagOStuff"
jenkins-bot [Tue, 11 Aug 2015 20:29:45 +0000 (20:29 +0000)]
Merge "Fixed @var doc in MultiWriteBagOStuff"

8 years agoFixed @var doc in MultiWriteBagOStuff
Aaron Schulz [Tue, 11 Aug 2015 20:10:28 +0000 (13:10 -0700)]
Fixed @var doc in MultiWriteBagOStuff

Change-Id: I53384460b7a6ccda50a23e3ab1fc614198e82d1a

8 years agoFix argument handling in MultiWriteBagOStuff::get()
Ori Livneh [Tue, 11 Aug 2015 20:02:44 +0000 (13:02 -0700)]
Fix argument handling in MultiWriteBagOStuff::get()

Follow-up for I7ea050a2ea.

Change-Id: Ibaa4cf01ee913c7a725d1719c00308ef3c6b0aff

8 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Tue, 11 Aug 2015 19:49:33 +0000 (21:49 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I204409f696639078b76df2de157e1a7a89086e1f

8 years agoMerge "refreshLinks.php: Don't wait for slaves if nothing found in a chunk"
jenkins-bot [Tue, 11 Aug 2015 19:01:35 +0000 (19:01 +0000)]
Merge "refreshLinks.php: Don't wait for slaves if nothing found in a chunk"

8 years agoMerge "ResourceLoader: make `cacheReport` option false by default"
jenkins-bot [Tue, 11 Aug 2015 18:57:05 +0000 (18:57 +0000)]
Merge "ResourceLoader: make `cacheReport` option false by default"

8 years agoResourceLoader: make `cacheReport` option false by default
Ori Livneh [Tue, 11 Aug 2015 16:24:03 +0000 (09:24 -0700)]
ResourceLoader: make `cacheReport` option false by default

In the three years or so that I have been around, we at Wikimedia have not to
my knowledge used the cache keys to manage the cache of ResourceLoader modules.
Instead, if we want to force a module to rebuild, we simply touch one of its
files. (Though even that is not often required these days.)

Change-Id: Ib62a792e053572f268d4be19a10f99f84c07abc5

8 years agoSECURITY: Don't disclose if an IP is autoblocked on Special:DeletedContributions
Kunal Mehta [Fri, 24 Jul 2015 21:23:46 +0000 (14:23 -0700)]
SECURITY: Don't disclose if an IP is autoblocked on Special:DeletedContributions

Same patch as dc2966bd05b, just for Special:DeletedContributions this
time.

Bug: T106893
Change-Id: I2089b21fc379b612fe9bf087b5f4ea75052bdbd3

8 years agothumb.php: Escape $rel404 in error message
Timo Tijhof [Tue, 28 Apr 2015 05:51:25 +0000 (06:51 +0100)]
thumb.php: Escape $rel404 in error message

Bug: T97391
Change-Id: I363686732fe9e5636c85c267c0728fc872c3e39d

8 years agoSECURITY: API: Use constant-time comparison for watchlist token
Brad Jorsch [Fri, 27 Mar 2015 15:49:58 +0000 (11:49 -0400)]
SECURITY: API: Use constant-time comparison for watchlist token

Avoids a theoretical timing attack.

Bug: T94116
Change-Id: Ia4a2b13bd5d3cd256c6b2deada224148dc2888a6

8 years agoMerge "Add mw.Upload.Dialog as a UI to mw.Upload"
jenkins-bot [Tue, 11 Aug 2015 12:46:03 +0000 (12:46 +0000)]
Merge "Add mw.Upload.Dialog as a UI to mw.Upload"

8 years agoAdd mw.Upload.Dialog as a UI to mw.Upload
Prateek Saxena [Mon, 3 Aug 2015 05:08:55 +0000 (10:38 +0530)]
Add mw.Upload.Dialog as a UI to mw.Upload

Change-Id: I5fcd0a5f8190134b87a75d3c22e7aefc619d3738

8 years agoMerge "Move pager inside searchresults div"
jenkins-bot [Tue, 11 Aug 2015 05:58:56 +0000 (05:58 +0000)]
Merge "Move pager inside searchresults div"

8 years agoCount API and hook calls, with 1:1000 sampling
Gergő Tisza [Tue, 21 Jul 2015 23:31:22 +0000 (16:31 -0700)]
Count API and hook calls, with 1:1000 sampling

Re-adds I6f807adc9cbf71c5d7b83c7eec43965dce1d2a16 and
Ic04daf475b936b942833362c7a979dde671b3ef4 (reverted in
35ccd9c2fe058ed76be905d9efe06c31c11fd696) with 1:1000 sampling
to avoid swamping the statsd hosts.

Also fixes query module logging.

Bug: T102079
Bug: T106450
Change-Id: I8b9366407c0d1713790d08e69aaa518130f01977

8 years agoMerge "MessageCache: use APC for local caching, rather than files"
jenkins-bot [Mon, 10 Aug 2015 20:47:38 +0000 (20:47 +0000)]
Merge "MessageCache: use APC for local caching, rather than files"

8 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Mon, 10 Aug 2015 19:41:06 +0000 (21:41 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I12216dc2ef2f270f19311ff52c76f78da8a09b3c

8 years agoMessageCache: use APC for local caching, rather than files
Ori Livneh [Sun, 9 Aug 2015 04:59:47 +0000 (21:59 -0700)]
MessageCache: use APC for local caching, rather than files

In addition to eliminating disk IO in a hot path, using APC spares us from
having to serialize and unserialize cache arrays. Since we're not serializing,
though, we don't have a string representation to hash, so use a random string
instead. (The code already treats the association of hash string to cache as
purely symbolic, so this is not problematic.)

Whereas the hash was previously stored as the first 32 bytes of each cache
file, we now store it as an array key instead (like VERSION and EXPIRY were
already). Because this changes the structure of cached data, we have to bump
MSG_CACHE_VERSION.

While we're here, make MessageCache::getLocalCache() and
MessageCache::saveToLocal() protected, make their signatures more
consistent with other methods in this class. While they were (implicitly)
public before, there are absolutely no external callers in Core or
extensions[0][1], so we can skip the standard deprecation process.

[0]: https://github.com/search?q=%40wikimedia+getlocalcache&type=Code&utf8=%E2%9C%93
[1]: https://github.com/search?utf8=%E2%9C%93&q=%40wikimedia+savetolocal&type=Code

Change-Id: I020617d2df2a8f0f243b85f3383dc7b16f15aaad

8 years agoMoved ObjectCacheSessionHandler renewal logic to wfSetupSession()
Aaron Schulz [Mon, 3 Aug 2015 20:35:50 +0000 (13:35 -0700)]
Moved ObjectCacheSessionHandler renewal logic to wfSetupSession()

* This should trigger more reliably than the shutdown function
  callback, which is really only there for sanity to make sure
  session close/write happens.

Change-Id: I9a1aa76de121ba8de33b3fa850bd223929fae404

8 years agoMerge "Removed ScopedPHPTimeout; unused"
jenkins-bot [Mon, 10 Aug 2015 18:37:48 +0000 (18:37 +0000)]
Merge "Removed ScopedPHPTimeout; unused"

8 years agoMerge "Avoid update.php suggestion on DB connection errors"
jenkins-bot [Mon, 10 Aug 2015 18:31:02 +0000 (18:31 +0000)]
Merge "Avoid update.php suggestion on DB connection errors"

8 years agoRemoved ScopedPHPTimeout; unused
Aaron Schulz [Fri, 7 Aug 2015 23:07:37 +0000 (16:07 -0700)]
Removed ScopedPHPTimeout; unused

Change-Id: Ic3a3500ddd410c68a30d3f3d1947f632e1aff5fd

8 years agoLoad 'mediawiki.legacy.commonPrint' styles with a media type property
Kunal Mehta [Mon, 10 Aug 2015 04:44:27 +0000 (21:44 -0700)]
Load 'mediawiki.legacy.commonPrint' styles with a media type property

Split the 'mediawiki.legacy.commonPrint' styles into a separate <style>
tag which sets media="print", which will make it a non-render blocking
resource.

Bug: T108413
Change-Id: Ife1d65b31bc79f96d7b89b94fdaeb2babf7ddf40

8 years agoMerge "Enforce an alphabetic default order for SiteList entries"
jenkins-bot [Mon, 10 Aug 2015 13:23:11 +0000 (13:23 +0000)]
Merge "Enforce an alphabetic default order for SiteList entries"

8 years agoMerge "A clearer wording for apihelp-query+info-paramvalue-prop-displaytitle"
jenkins-bot [Mon, 10 Aug 2015 11:32:02 +0000 (11:32 +0000)]
Merge "A clearer wording for apihelp-query+info-paramvalue-prop-displaytitle"

8 years agoMerge "Add MessagesSdh.php for Southern Kurdish"
jenkins-bot [Mon, 10 Aug 2015 09:24:16 +0000 (09:24 +0000)]
Merge "Add MessagesSdh.php for Southern Kurdish"

8 years agoMerge "Fix the display of the libraries in Special:Version for RTL wikis"
jenkins-bot [Sun, 9 Aug 2015 22:14:58 +0000 (22:14 +0000)]
Merge "Fix the display of the libraries in Special:Version for RTL wikis"

8 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Sun, 9 Aug 2015 18:34:22 +0000 (20:34 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: If3b0cef6be7f0f6bf684b178c237313e27af058b

8 years agoAdd MessagesSdh.php for Southern Kurdish
Amir E. Aharoni [Sun, 9 Aug 2015 13:27:09 +0000 (16:27 +0300)]
Add MessagesSdh.php for Southern Kurdish

This language has 18% of core localization and it's being exported,
but it also needs an entry in Names.php, and a definition of
direction and fallback. Adding them in MessagesSdh.php.

Change-Id: I47febc9252292d2bffa1aad5eb389c41c4c20450

8 years agoMerge "Improve the grammar of tooltip-search-go"
jenkins-bot [Sun, 9 Aug 2015 10:26:15 +0000 (10:26 +0000)]
Merge "Improve the grammar of tooltip-search-go"

8 years agoMerge "Remove all-caps emphasis from simpleantispam-label"
jenkins-bot [Sun, 9 Aug 2015 10:26:10 +0000 (10:26 +0000)]
Merge "Remove all-caps emphasis from simpleantispam-label"

8 years agoMerge "Improve the phrasing of tooltip-preview"
jenkins-bot [Sun, 9 Aug 2015 10:16:51 +0000 (10:16 +0000)]
Merge "Improve the phrasing of tooltip-preview"

8 years agoMerge "Remove use of deprecated TestUser->user"
jenkins-bot [Sun, 9 Aug 2015 05:32:54 +0000 (05:32 +0000)]
Merge "Remove use of deprecated TestUser->user"

8 years agoMerge "Match salt of WatchAction::show() and getWatchToken()"
jenkins-bot [Sun, 9 Aug 2015 03:27:50 +0000 (03:27 +0000)]
Merge "Match salt of WatchAction::show() and getWatchToken()"

8 years agoMerge "mediawiki.legacy: Use 'none' rather than 'initial' to remove border"
jenkins-bot [Sat, 8 Aug 2015 22:48:10 +0000 (22:48 +0000)]
Merge "mediawiki.legacy: Use 'none' rather than 'initial' to remove border"

8 years agoMerge "Use Config instead of globals"
jenkins-bot [Sat, 8 Aug 2015 20:12:08 +0000 (20:12 +0000)]
Merge "Use Config instead of globals"

8 years agoRemove all-caps emphasis from simpleantispam-label
Amir E. Aharoni [Sat, 8 Aug 2015 19:17:33 +0000 (22:17 +0300)]
Remove all-caps emphasis from simpleantispam-label

All-caps emphasis can't be used in most alphabets,
and there is already emphasis with <strong> in this message.

Change-Id: I99a7452c547c34c644b553dd29e55d47f07aa5b3

8 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Sat, 8 Aug 2015 18:29:43 +0000 (20:29 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I521b20120fc0bce1c38ed649ce168e35d918cde0

8 years agoMatch salt of WatchAction::show() and getWatchToken()
firebus [Mon, 3 Aug 2015 04:58:21 +0000 (21:58 -0700)]
Match salt of WatchAction::show() and getWatchToken()

Use getPrefixedDbkey() when generating salt, for consistency.

Bug: T106910
Change-Id: I93e22a2aaee8bf888fa613929c1027f5f0c2642f

8 years agomediawiki.legacy: Use 'none' rather than 'initial' to remove border
Bartosz Dziewoński [Sat, 8 Aug 2015 14:56:25 +0000 (16:56 +0200)]
mediawiki.legacy: Use 'none' rather than 'initial' to remove border

A browser could potentially support 'text-decoration: underline dotted'
(which we check for with '@supports'), but not 'initial' value (which
we don't check for), resulting in double underlining.

Follow-up to I6fb2d2b8016c1f3164999e25cbc058ccd9a2f121.

Change-Id: I13359e99010b524cf1a9f868374327b2c17399b7

8 years agoUse Config instead of globals
Florian [Sat, 8 Aug 2015 09:56:46 +0000 (11:56 +0200)]
Use Config instead of globals

Follow up: I7ed79942c242b1957d46bdcad59985f37466fb83

Change-Id: Iff666a8ecc1f5c5a3fa1a34601fb74206a66b578

8 years agoOverride document.writeln to prevent it from blanking pages
Ori Livneh [Sat, 8 Aug 2015 01:25:55 +0000 (18:25 -0700)]
Override document.writeln to prevent it from blanking pages

Follow-up for Ic9056d7a77. Same rationale.

Bug: T108423
Change-Id: I664ba9b0af4355ac83f2e5892e484a3f3aff0428

8 years agoMade JobRunner bail more smoothly on near OOM
Aaron Schulz [Fri, 7 Aug 2015 22:09:22 +0000 (15:09 -0700)]
Made JobRunner bail more smoothly on near OOM

* Use the regular limit-X style response instead of throwing an
  exception. This avoids loss of statd data and the like.

Change-Id: Ia08384a0d13c268f6e7a673b2265ab77772e5539

8 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Fri, 7 Aug 2015 19:32:35 +0000 (21:32 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: Ie6a5f12b6a526a812557aa80c5cd7d7765c5a26e

8 years agoMerge "mediawiki.legacy: Use CSS3 underlining for <abbr>"
jenkins-bot [Fri, 7 Aug 2015 19:00:21 +0000 (19:00 +0000)]
Merge "mediawiki.legacy: Use CSS3 underlining for <abbr>"

8 years agomediawiki.legacy: Use CSS3 underlining for <abbr>
Minh Nguyễn [Wed, 5 Aug 2015 06:42:37 +0000 (23:42 -0700)]
mediawiki.legacy: Use CSS3 underlining for <abbr>

Where supported, set text-decoration-style instead of border-bottom-style
to avoid double-underlining due to Firefox’s user agent style sheet.

Bug: T107560
Change-Id: I6fb2d2b8016c1f3164999e25cbc058ccd9a2f121

8 years agoRemove use of deprecated TestUser->user
addshore [Fri, 7 Aug 2015 16:10:26 +0000 (17:10 +0100)]
Remove use of deprecated TestUser->user

Change-Id: Iec47ea2609b4d407e827cec5bf2a834b75727005

8 years agoLog human-readable login status
Gergő Tisza [Fri, 7 Aug 2015 02:16:48 +0000 (02:16 +0000)]
Log human-readable login status

Bug: T91701
Change-Id: Ia73fcc21321990befb1d866f76102b24d67adbfa

8 years agoFix the display of the libraries in Special:Version for RTL wikis
Amir E. Aharoni [Fri, 7 Aug 2015 14:35:05 +0000 (17:35 +0300)]
Fix the display of the libraries in Special:Version for RTL wikis

Bug: T108325
Change-Id: I3c9a675fa7330d46090a64c003bcaf66ddf4260f

8 years agoMerge "Revert "Add executable rights for executable (bash) files""
jenkins-bot [Fri, 7 Aug 2015 07:38:00 +0000 (07:38 +0000)]
Merge "Revert "Add executable rights for executable (bash) files""

8 years agoAvoid update.php suggestion on DB connection errors
Aaron Schulz [Thu, 6 Aug 2015 22:09:54 +0000 (15:09 -0700)]
Avoid update.php suggestion on DB connection errors

Bug: T98788
Change-Id: I21974d6b775f13c33055f76c30142e937eb0e965

8 years agoRevert "Add executable rights for executable (bash) files"
Southparkfan [Mon, 3 Aug 2015 15:28:03 +0000 (15:28 +0000)]
Revert "Add executable rights for executable (bash) files"

These are not meant to be complete shell scripts, so
shebang lines don't really make sense here. Rather, as
noted by the author (Daniel Friesen), scripts in the
parent directory include these files using the "source"
or "." command.

This reverts commit 96e0ed45a81dfb4783c74353a8e70d0b926ad900.

Change-Id: I7a0b7bb2a5ea1b1c141cb36f38736fe562b22c10

8 years agoMade BagOStuff::merge() avoid retries on I/O errors
Aaron Schulz [Thu, 6 Aug 2015 23:08:41 +0000 (16:08 -0700)]
Made BagOStuff::merge() avoid retries on I/O errors

Change-Id: Ia2fd61132322ed3fa8909d60d9f7eb42e39cb443

8 years agoresourceloader: Restore anticipated loader states for hardcoded module requests
Timo Tijhof [Fri, 7 Aug 2015 00:44:38 +0000 (17:44 -0700)]
resourceloader: Restore anticipated loader states for hardcoded module requests

Follows-up Icba6d7a87b2 which removed this code in the
assumption that they're now taken care of by mw.loader.load.

While that is the case, they are still in the HTML and when earlier
modules require these modules the loader should not initiate a separate
request.

This was especially problematic for the 'user' module which mw.loader
was requesting with a version from the startup module which is
not associated with the current user. This would've caused edits
to a user's personal scripts post-Icba6d7a87b2 to not propagate
correctly. The second request would be ignored by mw.loader since
it implements a module that is already implemented.

This only affected wikis that were manually depending on the 'user'
module from Common.js or a default-loaded gadget.

Bug: T108275
Change-Id: I1b863a3ee23191adaf34f66b58973618487118b2

8 years agoMerge "Fixed deadlockLoop() IDE errors"
jenkins-bot [Thu, 6 Aug 2015 21:41:06 +0000 (21:41 +0000)]
Merge "Fixed deadlockLoop() IDE errors"

8 years agoFixed occasional MultiHttpClient "undefined index" errors
Aaron Schulz [Wed, 5 Aug 2015 23:49:12 +0000 (16:49 -0700)]
Fixed occasional MultiHttpClient "undefined index" errors

* These show sometimes in Swift FileBackend tests

Change-Id: I38c1817812282c94cab2011da7c322e92eec96ca

8 years agoMove pager inside searchresults div
Florian [Sun, 26 Jul 2015 14:03:07 +0000 (16:03 +0200)]
Move pager inside searchresults div

The pager is part of the searchresults page, but can't be styled
easily like the searchresults div container, because it's outside
the container. The pager should be in one block element with the
serach results.

This enables (e.g. extensions) to add content to the right side
of the search result page without having the problem with a pager,
that can't easily moved with CSS.

Change-Id: I52d9aacc1f396f42238318ae220266c7498b0824

8 years agoFixed deadlockLoop() IDE errors
Aaron Schulz [Thu, 6 Aug 2015 19:45:30 +0000 (12:45 -0700)]
Fixed deadlockLoop() IDE errors

Change-Id: I76bb9250bc8017756af4f2552cd48ab595a26297

8 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Thu, 6 Aug 2015 19:19:29 +0000 (21:19 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I7fa2dd76d17e2c0ed0e0314e4eaec1845abac4de

8 years agoMerge "Remove unused StatsdClient use from GlobalFunctions"
jenkins-bot [Thu, 6 Aug 2015 18:59:07 +0000 (18:59 +0000)]
Merge "Remove unused StatsdClient use from GlobalFunctions"

8 years agoMerge "Test index duplication in DatabaseSqlite"
jenkins-bot [Thu, 6 Aug 2015 18:29:22 +0000 (18:29 +0000)]
Merge "Test index duplication in DatabaseSqlite"

8 years agoMerge "Status: Correct documentation"
jenkins-bot [Thu, 6 Aug 2015 17:05:52 +0000 (17:05 +0000)]
Merge "Status: Correct documentation"

8 years agoRemove unused StatsdClient use from GlobalFunctions
addshore [Thu, 6 Aug 2015 17:00:43 +0000 (18:00 +0100)]
Remove unused StatsdClient use from GlobalFunctions

Change-Id: I5a773590e229f891298ff3d2eda5e4a258cc1f25

8 years agoAdd 'targets=desktop,mobile' to mediawiki.legacy.wikibits module
Timo Tijhof [Thu, 6 Aug 2015 16:32:38 +0000 (09:32 -0700)]
Add 'targets=desktop,mobile' to mediawiki.legacy.wikibits module

Follows-up 0ac4f99.

Bug: T108191
Change-Id: I88681eeef660301d9d739ee29f44ef5bb68f3293

8 years agoMerge "mediawiki.notify: Add JSDoc tags"
jenkins-bot [Thu, 6 Aug 2015 16:08:55 +0000 (16:08 +0000)]
Merge "mediawiki.notify: Add JSDoc tags"

8 years agomediawiki.notify: Add JSDoc tags
Thiemo Mättig [Thu, 6 Aug 2015 13:22:05 +0000 (15:22 +0200)]
mediawiki.notify: Add JSDoc tags

Change-Id: I8536e161f7c1911c78ad7dfafbc670e7ed42272b

8 years agoTest index duplication in DatabaseSqlite
addshore [Thu, 6 Aug 2015 09:25:16 +0000 (10:25 +0100)]
Test index duplication in DatabaseSqlite

Change-Id: I7b5c69aa68591e6f1105e6822d36c0c2149974d1

8 years agoEnforce an alphabetic default order for SiteList entries
Thiemo Mättig [Thu, 16 Jul 2015 16:48:05 +0000 (11:48 -0500)]
Enforce an alphabetic default order for SiteList entries

Bug: T106054
Change-Id: I8bf22d99b8304d7a6f40e384e8de00a4aca9313d

8 years agoMerge "Duplicate table indexes in DatabaseSqlite::duplicateTableStructure"
jenkins-bot [Thu, 6 Aug 2015 12:37:23 +0000 (12:37 +0000)]
Merge "Duplicate table indexes in DatabaseSqlite::duplicateTableStructure"

8 years agoStatus: Correct documentation
Bartosz Dziewoński [Thu, 6 Aug 2015 11:49:51 +0000 (13:49 +0200)]
Status: Correct documentation

Most of the docs for this class look misleading or downright incorrect...

Change-Id: I4c7397a5dfeca7447cb98611c4f3befaefaefaba

8 years agoDuplicate table indexes in DatabaseSqlite::duplicateTableStructure
Marius Hoch [Thu, 6 Aug 2015 00:55:18 +0000 (02:55 +0200)]
Duplicate table indexes in DatabaseSqlite::duplicateTableStructure

This is consistent with what we do with MySQL and is generally
convenient to have for certain integration tests.

Change-Id: Iaea79bd11263bf75061f19a94da9645ef634422f

8 years agoMerge "resourceloader: Fix undefined $filename in safeFileHash()"
jenkins-bot [Thu, 6 Aug 2015 08:48:04 +0000 (08:48 +0000)]
Merge "resourceloader: Fix undefined $filename in safeFileHash()"

8 years agoMerge "Allow to enable OOUI via a parser tag extension"
jenkins-bot [Thu, 6 Aug 2015 08:39:41 +0000 (08:39 +0000)]
Merge "Allow to enable OOUI via a parser tag extension"

8 years agoresourceloader: Fix undefined $filename in safeFileHash()
Timo Tijhof [Thu, 6 Aug 2015 05:51:06 +0000 (22:51 -0700)]
resourceloader: Fix undefined $filename in safeFileHash()

Follows-up 28f6d7fbdee.

This was causing versions to stay stuck at their current version.
It worked fine for the initial deployment since the rest of the
definition summary is still fine, but subsequent deploys that changed
only the file were ineffective due to these silently becoming
empty strings.

Thanks to suppressWarnings() we never saw these anywhere in the
tests or in production.

Change-Id: Ib4371255fe970442bcc0041219bce633a7f6f6dd

8 years agoReplace native "document.write" with deprecated fallback
Timo Tijhof [Thu, 6 Aug 2015 02:55:53 +0000 (19:55 -0700)]
Replace native "document.write" with deprecated fallback

In most browsers, calling "document.write" after the document is
ready results in the document being re-created with the specified
content (effectively replacing with blank page).

While this is a browser issue, mitigate this by replacing the
method with a fallback (wrapped in "mw.log.deprecate") that just
appends the given HTML to the document body.

Note that scripts do not execute when appended as HTML, they will
become dormant elements. It'll work for raw content as a basic
fallback, but it should become apparent to the end user that the
code needs to be upgraded.

Bug: T108139
Change-Id: Ic9056d7a779f234a28ddad005fd4d76f2e750fcc

8 years agoresourceloader: Restore "blocking" legacy modules
Timo Tijhof [Wed, 5 Aug 2015 22:42:26 +0000 (15:42 -0700)]
resourceloader: Restore "blocking" legacy modules

This ensures 'wikibits' and 'mediawiki.util' (if so configured)
finish loading before executing other modules.

This was previously implicitly provided for the bottom queue by
being in the top-queue, but since this is now asynchronous that
is no lower guaranteed. Fix this by making this explicit instead
of implicit.

Keep them in the top queue as-is to ensure consistency with cached
pages and it allows them to preload and batch in the same request
instead of being discovered later at run-time as a separate request.

Bug: T108124
Change-Id: I74e0cbe616404da927ea46d06308a7bae930eb69

8 years agoMerge "refreshLinks.php: Fix deletion of link entries from nonexistent pages"
jenkins-bot [Thu, 6 Aug 2015 02:28:54 +0000 (02:28 +0000)]
Merge "refreshLinks.php: Fix deletion of link entries from nonexistent pages"

8 years agoMerge "mediawiki.action.edit.stash: reduce idle time from 4k to 3k"
jenkins-bot [Wed, 5 Aug 2015 23:49:34 +0000 (23:49 +0000)]
Merge "mediawiki.action.edit.stash: reduce idle time from 4k to 3k"

8 years agomediawiki.action.edit.stash: reduce idle time from 4k to 3k
Ori Livneh [Wed, 5 Aug 2015 22:31:51 +0000 (15:31 -0700)]
mediawiki.action.edit.stash: reduce idle time from 4k to 3k

Deployed to Wikimedia cluster shortly after 23:00 UTC and led to an appreciable dip in save time.

Change-Id: I08fdda110b71bf7030a45afc3f3f5d7cc32c9b05

8 years agoMerge "qunit: Improved unfinished ajax detection"
jenkins-bot [Wed, 5 Aug 2015 22:34:24 +0000 (22:34 +0000)]
Merge "qunit: Improved unfinished ajax detection"

8 years agojsduck: Update eg-iframe.html to match MediaWiki environment
Timo Tijhof [Wed, 5 Aug 2015 20:55:25 +0000 (13:55 -0700)]
jsduck: Update eg-iframe.html to match MediaWiki environment

* Add 'resources/lib/phpjs-sha1/sha1.js' (follows-up f37cee996)
* Remove 'resources/src/startup.js' (follows-up b00cd0b12)
  This no longer works due to the $VARS placeholder. Either way
  it is redundant because we already define a 'startUp' function
  inside eg-iframe. We don't need anything from startup.js.

Bug: T107925
Change-Id: Iaf75850060556f03ebaa37b8e1dce0de6f1c16ce

8 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Wed, 5 Aug 2015 20:17:10 +0000 (22:17 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: Iee978afb2b638a484600ebd3e85881320e59e198

8 years agoMerge "Parser: Don't generate an external link on "http://)" and similar"
jenkins-bot [Wed, 5 Aug 2015 20:12:29 +0000 (20:12 +0000)]
Merge "Parser: Don't generate an external link on ")" and similar"