lhc/web/wiklou.git
6 years agoresourceloader: Allow modules to be registered via a factory callback
daniel [Thu, 4 May 2017 16:10:28 +0000 (18:10 +0200)]
resourceloader: Allow modules to be registered via a factory callback

This should work the same way as registering API modules via a factory callback.
Point in case: Ifb8611473a971 could avoid global state using this mechanism.

Change-Id: Ifbf29006141ce2a2dff42efa352f406502a06bc6

6 years agoMerge "Print: prefer JS print over printable version."
jenkins-bot [Sun, 21 May 2017 13:32:20 +0000 (13:32 +0000)]
Merge "Print: prefer JS print over printable version."

6 years agoPrint: prefer JS print over printable version.
Derk-Jan Hartman [Tue, 25 Apr 2017 13:05:42 +0000 (15:05 +0200)]
Print: prefer JS print over printable version.

Bug: T24256
Change-Id: Ic3dc15e578ce4a94959285c9ae579e9088423544

6 years agoMerge "Fix EnhancedChangesList::getDiffHistLinks null exception"
jenkins-bot [Sun, 21 May 2017 12:28:57 +0000 (12:28 +0000)]
Merge "Fix EnhancedChangesList::getDiffHistLinks null exception"

6 years agoMerge "Match Parsoid's attribute sanitization for video elements"
jenkins-bot [Sun, 21 May 2017 11:57:06 +0000 (11:57 +0000)]
Merge "Match Parsoid's attribute sanitization for video elements"

6 years agoMerge "HTMLUsersMultiselectField: Make auto-infusable when used inside a legacy HTMLForm"
jenkins-bot [Sun, 21 May 2017 10:07:20 +0000 (10:07 +0000)]
Merge "HTMLUsersMultiselectField: Make auto-infusable when used inside a legacy HTMLForm"

6 years agoFix EnhancedChangesList::getDiffHistLinks null exception
Brian Wolff [Fri, 19 May 2017 22:08:14 +0000 (22:08 +0000)]
Fix EnhancedChangesList::getDiffHistLinks null exception

If a page is deleted, rc_cur_id is missing, but it takes
a while before job queue deletes RC entries. If we encounter
something like that, just skip it since its bound for
deletion anyways.

Bug: T164059
Change-Id: I286109a9707e54939c0da31656ef54fd29acf481

6 years agoMerge "Allow namespaces defined in extension.json to be overwritten locally."
jenkins-bot [Sun, 21 May 2017 08:02:22 +0000 (08:02 +0000)]
Merge "Allow namespaces defined in extension.json to be overwritten locally."

6 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Sat, 20 May 2017 19:58:31 +0000 (21:58 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: Id9a991314902c759c4fac6202896c582e346737c

6 years agoMerge "ApiSandbox: Fix HTTP error handling"
jenkins-bot [Sat, 20 May 2017 19:35:34 +0000 (19:35 +0000)]
Merge "ApiSandbox: Fix HTTP error handling"

6 years agoMerge "Various test fixes for postgres"
jenkins-bot [Sat, 20 May 2017 19:11:35 +0000 (19:11 +0000)]
Merge "Various test fixes for postgres"

6 years agoMerge "Added increase editcount upon page move"
jenkins-bot [Sat, 20 May 2017 14:55:34 +0000 (14:55 +0000)]
Merge "Added increase editcount upon page move"

6 years agoMerge "Improve grammar of message on Special:GoToInterwiki"
jenkins-bot [Sat, 20 May 2017 14:46:30 +0000 (14:46 +0000)]
Merge "Improve grammar of message on Special:GoToInterwiki"

6 years agoMerge "Remove untranslated "editinguser" message from tyv (tuvinian)"
jenkins-bot [Sat, 20 May 2017 14:40:38 +0000 (14:40 +0000)]
Merge "Remove untranslated "editinguser" message from tyv (tuvinian)"

6 years agoMerge "Typofixes in two apihelp messages for search and templates"
jenkins-bot [Sat, 20 May 2017 14:37:07 +0000 (14:37 +0000)]
Merge "Typofixes in two apihelp messages for search and templates"

6 years agoImprove grammar of message on Special:GoToInterwiki
TTO [Sun, 9 Apr 2017 12:30:38 +0000 (12:30 +0000)]
Improve grammar of message on Special:GoToInterwiki

Change-Id: Idd19a8455b82c86cf5a891efb17199fc9f625286

6 years agoAdded increase editcount upon page move
Ad Huikeshoven [Sat, 20 May 2017 13:36:52 +0000 (15:36 +0200)]
Added increase editcount upon page move

Bug: T163966
Change-Id: Ie055f676534e98963c68f8b8185cca65fa8e76b1

6 years agoTypofixes in two apihelp messages for search and templates
Federico Leva [Sat, 20 May 2017 14:18:54 +0000 (16:18 +0200)]
Typofixes in two apihelp messages for search and templates

Spotted by Dgstranz:
* https://translatewiki.net/wiki/Thread:Support/MediaWiki:Apihelp-query%2Bsearch-param-enablerewrites/en
* https://translatewiki.net/wiki/Thread:Support/MediaWiki:Apihelp-query%2Btemplates-param-namespace/en

Change-Id: I5655d95c6cdd74433d358f15873d4a3a30738f50

6 years agoHTMLUsersMultiselectField: Make auto-infusable when used inside a legacy HTMLForm
Bartosz Dziewoński [Sat, 20 May 2017 14:07:35 +0000 (16:07 +0200)]
HTMLUsersMultiselectField: Make auto-infusable when used inside a legacy HTMLForm

Change-Id: I23b3a86f06a10b066e6671e398da37c62e3e61b1

6 years agoRemove untranslated "editinguser" message from tyv (tuvinian)
Federico Leva [Sat, 20 May 2017 14:11:30 +0000 (16:11 +0200)]
Remove untranslated "editinguser" message from tyv (tuvinian)

https://translatewiki.net/wiki/Thread:Support/MediaWiki:Editinguser/tyv

Change-Id: I7ac5da1d7bfeca09e88a8f7dc13073eed0195e69

6 years agoAllow more customization on the default toggle system
Moritz Oberhauser [Thu, 6 Apr 2017 10:43:18 +0000 (12:43 +0200)]
Allow more customization on the default toggle system

The naming convention remains unchainched. Default toggles are added if no mw-collapsible-toggle child element is present. Premade toggles have already one ore more mw-collapsible-toggle elements defined.

Default and premade toggles (mw-collapsible-toggle) still cannot be mixed/combined with remote toggles (mw-customtoggle).

* The default toggle got less rigid by removing dependency on <a> elements.
* Support for multiple premade toggles was introduced.
* The expand/collapse messages can be used by premade toggles via mw-collapsible-text.
* Removed the linksPassthru option. This step allowed merging premadeToggleHandler into actionHandler.
* The pass through functionality is now applied to all <a> elements since the default toggle does no longer depends on those.
* Removed mw-collapsible-bracket because it was not used and is deprecated by mw-collapsible-text.
* The test suite was adapted to reflect the latest changes.

Change-Id: Ic8627c4c185e8e4175e6fef1c8e1c2190e54edaa

6 years agoMerge "Disable broken TemplateCategoriesTest unit test"
jenkins-bot [Sat, 20 May 2017 12:01:13 +0000 (12:01 +0000)]
Merge "Disable broken TemplateCategoriesTest unit test"

6 years agoMerge "Add HHVM version check"
jenkins-bot [Sat, 20 May 2017 11:43:22 +0000 (11:43 +0000)]
Merge "Add HHVM version check"

6 years agoDisable broken TemplateCategoriesTest unit test
Timo Tijhof [Sat, 20 May 2017 11:35:43 +0000 (13:35 +0200)]
Disable broken TemplateCategoriesTest unit test

Bug: T165099
Change-Id: I370e48965fdfc948aa02533ebfeb0a540fb53c12

6 years agoApiSandbox: Fix HTTP error handling
Brad Jorsch [Sat, 20 May 2017 10:09:20 +0000 (12:09 +0200)]
ApiSandbox: Fix HTTP error handling

Since bf69459, ApiSandbox seems to stall out when an API request
results in an HTTP error (e.g. due to a PHP fatal error). Before that
revision, it displayed the 'apisandbox-results-error' message in this
situation.

Apparently the jQuery 3 changes to Deferred behavior caused it to be
impossible to have a then() filter return `this` (or anything else) in
order to avoid replacing the existing promise that's being resolved or
rejected.

Bug: T165857
Change-Id: I3f646cdfe7fe8987437980790788821f51e728d1

6 years agoMerge "Make sure all functions in Database.php are documented"
jenkins-bot [Sat, 20 May 2017 10:54:26 +0000 (10:54 +0000)]
Merge "Make sure all functions in Database.php are documented"

6 years agoMerge "Fix Closure detection in MediaWikiTestCase"
jenkins-bot [Sat, 20 May 2017 10:48:43 +0000 (10:48 +0000)]
Merge "Fix Closure detection in MediaWikiTestCase"

6 years agoMerge "Add \b to regexes in BlockLevelPass to avoid confusing tr & track"
jenkins-bot [Sat, 20 May 2017 10:24:55 +0000 (10:24 +0000)]
Merge "Add \b to regexes in BlockLevelPass to avoid confusing tr & track"

6 years agoMerge "More magic word translations for Catalan (ca)"
jenkins-bot [Sat, 20 May 2017 10:15:01 +0000 (10:15 +0000)]
Merge "More magic word translations for Catalan (ca)"

6 years agoAdd release notes for T151633
Sébastien Santoro [Sat, 20 May 2017 09:35:45 +0000 (09:35 +0000)]
Add release notes for T151633

This is a follow-up for f87b3b68860e.

Thanks to @Sfic to have submitted this solution.

Bug: T151633
Change-Id: Ia87d925f81be68a69b9b5f9893b7fc71afe950db

6 years agoMerge "Use Devanagari digits for list items on ne.wikipedia"
jenkins-bot [Sat, 20 May 2017 06:22:41 +0000 (06:22 +0000)]
Merge "Use Devanagari digits for list items on ne.wikipedia"

6 years agoMerge "Fix the web updater"
jenkins-bot [Sat, 20 May 2017 02:06:26 +0000 (02:06 +0000)]
Merge "Fix the web updater"

6 years agoAdd \b to regexes in BlockLevelPass to avoid confusing tr & track
Brion Vibber [Fri, 19 May 2017 22:45:48 +0000 (00:45 +0200)]
Add \b to regexes in BlockLevelPass to avoid confusing tr & track

With TimedMediaHandler in video.js mode, videos can be inline,
without a wrapper div.

Previously, in this mode two paragraphs where one contained a
video would end up merged into one paragraph, due to BlockLevelPass
matching "<track .../>" against "<tr" in its regexes.

Added \b to a couple of the regexes to protect against such errors,
and corrected a parser test case that had bad output listed, where
"<link .../>" matched against "<li".

Bug: T165817
Change-Id: I06e82b881f5ebddae5e7df7fb940adfa54f6b659

6 years agoHack around icu breakage for fa sorting
Brian Wolff [Fri, 19 May 2017 21:32:00 +0000 (21:32 +0000)]
Hack around icu breakage for fa sorting

Bug: T139110
Change-Id: I35bcdaf309f595258289f01bbe5713ce6d1ffad1

6 years agoFix Closure detection in MediaWikiTestCase
Marius Hoch [Fri, 19 May 2017 21:06:58 +0000 (23:06 +0200)]
Fix Closure detection in MediaWikiTestCase

Sometimes the closure are hidden in arrays, catch this.

The $maxDepth check is just for sanity, I don't think it's
actually needed.

Follows-Up: c2c7452577e

Bug: T111641
Change-Id: Id5e036ce4949b8106873fd938f54c2774d3d6a4a

6 years agoFix the web updater
Paladox [Fri, 19 May 2017 20:43:26 +0000 (20:43 +0000)]
Fix the web updater

It kept failing with Error: 1064 You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'ESCAPE '`'' at line 1 (localhost)

Bug: T165805
Change-Id: I2671415fc34b1e6226104c88ca21fafc860bb7fb

6 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Fri, 19 May 2017 20:08:33 +0000 (22:08 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: Icd2487d8cf826e9736277723e84e2520106b2a5c

6 years agoMerge "Add type hint to ThumbnailRenderJob::hitThumbUrl"
jenkins-bot [Fri, 19 May 2017 19:40:45 +0000 (19:40 +0000)]
Merge "Add type hint to ThumbnailRenderJob::hitThumbUrl"

6 years agoMerge "Add workaround for HHVM issue 6206"
jenkins-bot [Fri, 19 May 2017 19:33:48 +0000 (19:33 +0000)]
Merge "Add workaround for HHVM issue 6206"

6 years agoMerge "Add missing doUpdates() call to refreshLinks.php"
jenkins-bot [Fri, 19 May 2017 19:33:36 +0000 (19:33 +0000)]
Merge "Add missing doUpdates() call to refreshLinks.php"

6 years agoMerge "Avoid postgres PrefixSearchTest failures due to collation differences"
jenkins-bot [Fri, 19 May 2017 19:33:33 +0000 (19:33 +0000)]
Merge "Avoid postgres PrefixSearchTest failures due to collation differences"

6 years agoAdd type hint to ThumbnailRenderJob::hitThumbUrl
Aaron Schulz [Fri, 19 May 2017 19:17:27 +0000 (12:17 -0700)]
Add type hint to ThumbnailRenderJob::hitThumbUrl

Change-Id: Ifab9d74ae9147349b0a3417f35088b96ee47b6fa

6 years agoAdd missing doUpdates() call to refreshLinks.php
Aaron Schulz [Wed, 17 May 2017 18:56:40 +0000 (11:56 -0700)]
Add missing doUpdates() call to refreshLinks.php

Follows-up b8b01aa589ce which accidentally removed this call.

Bug: T157545
Change-Id: Id4efdccb60e7829269df601b83f64288f6190db4

6 years agoAdd workaround for HHVM issue 6206
Marius Hoch [Fri, 19 May 2017 18:50:58 +0000 (20:50 +0200)]
Add workaround for HHVM issue 6206

Just use the actual global on HHVM, like we do on
Zend, but avoid hitting the warning.

This is a workaround for https://github.com/facebook/hhvm/issues/6206

Bug: T111641
Change-Id: I15ef0e90827c94a8b2609484b0dddcb78f04284c

6 years agoUse Devanagari digits for list items on ne.wikipedia
Sébastien Santoro [Fri, 19 May 2017 13:17:20 +0000 (13:17 +0000)]
Use Devanagari digits for list items on ne.wikipedia

Nepalese uses Devanagari, so we wish to use this alphabet for
list items' digits.

Bug: T151633
Change-Id: Id9cb42932fd8b8aa2cfb5418c4a3cd16ec37a60e

6 years agoMerge "MediaSearchWidget: Only resize new results"
jenkins-bot [Fri, 19 May 2017 16:25:39 +0000 (16:25 +0000)]
Merge "MediaSearchWidget: Only resize new results"

6 years agoMake sure all functions in Database.php are documented
Kaldari [Sat, 13 May 2017 01:10:47 +0000 (18:10 -0700)]
Make sure all functions in Database.php are documented

Will add @inheritdoc in a follow-up commit for functions
documented in the parent classes.

Part of 2017 MediaWiki Documentation Day

Change-Id: I002a1f6451940ecbcacea7b3ca2fc6ad0f4eba47

6 years agoMerge "Improve HTTP logging"
jenkins-bot [Fri, 19 May 2017 15:48:47 +0000 (15:48 +0000)]
Merge "Improve HTTP logging"

6 years agoMediaSearchWidget: Only resize new results
Thalia [Wed, 17 May 2017 17:13:17 +0000 (19:13 +0200)]
MediaSearchWidget: Only resize new results

When repositioning images based on the "change" event,
ignore images that have already been assigned to a row.

Bug: T163727
Change-Id: Ida7556d8848f98d97d82aef9caf5c1d43bb47d7b

6 years agoMerge "Tests: correct order of assertEquals arguments"
jenkins-bot [Fri, 19 May 2017 12:47:11 +0000 (12:47 +0000)]
Merge "Tests: correct order of assertEquals arguments"

6 years agoMerge "MimeAnalyzer: Detect magic bytes for mp3"
jenkins-bot [Fri, 19 May 2017 12:14:27 +0000 (12:14 +0000)]
Merge "MimeAnalyzer: Detect magic bytes for mp3"

6 years agoTests: correct order of assertEquals arguments
Derk-Jan Hartman [Fri, 19 May 2017 10:38:36 +0000 (12:38 +0200)]
Tests: correct order of assertEquals arguments

Change-Id: Ib8d1e8aa92172a9abc0495dc0c18ea5df850dd5e

6 years agoMimeAnalyzer: Detect magic bytes for mp3
Derk-Jan Hartman [Fri, 19 May 2017 11:33:25 +0000 (13:33 +0200)]
MimeAnalyzer: Detect magic bytes for mp3

Unit tests in follow up patch

Bug: T115170
Change-Id: Ie1a63aa319cebbb2efb3cdc478416f5947078cbe

6 years agoMerge "ContribsPager: Use one TemplateParser instance"
jenkins-bot [Fri, 19 May 2017 10:08:15 +0000 (10:08 +0000)]
Merge "ContribsPager: Use one TemplateParser instance"

6 years agoMerge "EnhancedChangesList: Use one TemplateParser instance"
jenkins-bot [Fri, 19 May 2017 10:08:12 +0000 (10:08 +0000)]
Merge "EnhancedChangesList: Use one TemplateParser instance"

6 years agoAdd HHVM version check
Florian Schmidt [Tue, 13 Sep 2016 16:17:11 +0000 (18:17 +0200)]
Add HHVM version check

HHVM brings it's own version number, so relying on the PHP version
string in the PHP_VERSION const on an hhvm server maybe does not
increase in different versions of hhvm. Therefore, this change
implements a hhvm server version check, if MediaWiki runs on an
hhvm server, instead of checking the php version.

Bug: T123436
Change-Id: I91b0a4e1eded61d3ba63ecbd14cdc85c57295892

6 years agoMerge "TemplateParser: Improve cache integrity check failure scenario"
jenkins-bot [Fri, 19 May 2017 09:14:06 +0000 (09:14 +0000)]
Merge "TemplateParser: Improve cache integrity check failure scenario"

6 years agoImprove HTTP logging
Tim Starling [Fri, 28 Apr 2017 01:32:44 +0000 (11:32 +1000)]
Improve HTTP logging

* Log HTTP debug lines to the "http" channel instead of wfDebug()
* Add the ability to do debug logging to MultiHttpClient
* Add a static method Http::createMultiClient() which provides a
  MultiHttpClient configured similarly to the way individual requests
  are configured, respecting the wiki's $wgHTTPTimeout and writing debug
  logs.
* In EtcdConfig, pass the logger instance through to the MultiHttpClient
  backend.

Change-Id: Ic5bdcb0cae95d7b3715ab5261758be082751c3ff

6 years agoAvoid postgres PrefixSearchTest failures due to collation differences
Aaron Schulz [Fri, 19 May 2017 00:40:06 +0000 (17:40 -0700)]
Avoid postgres PrefixSearchTest failures due to collation differences

Bug: T75174
Change-Id: I6b1df27ca6ae5c2da46134be3dbd7aed404d9601

6 years agoVarious test fixes for postgres
Aaron Schulz [Wed, 17 May 2017 01:36:58 +0000 (18:36 -0700)]
Various test fixes for postgres

* Add another TS_MW timestamp coercion to WatchedItemStore.
* Do not expect timestamp conversion for pager mOffset.
  They have been used in Pager URLs for ages.
* Do not assume the user_id for UTSysop is 1; use the row value.

Bug: T75174
Change-Id: I590a4b7363ccff26d9ac9f51b95fc1aa072503b2

6 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Thu, 18 May 2017 19:58:13 +0000 (21:58 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I9a4201e523e0e37756d4b70c7b85fc670a6fa1d7

6 years agoMerge "Make sure unique keys carry over to postgres table duplicates"
jenkins-bot [Thu, 18 May 2017 18:09:25 +0000 (18:09 +0000)]
Merge "Make sure unique keys carry over to postgres table duplicates"

6 years agoMerge "Introduce wgRelevantPageIsProbablyEditable"
jenkins-bot [Thu, 18 May 2017 16:01:26 +0000 (16:01 +0000)]
Merge "Introduce wgRelevantPageIsProbablyEditable"

6 years agoIntroduce wgRelevantPageIsProbablyEditable
James D. Forrester [Mon, 15 May 2017 10:12:44 +0000 (11:12 +0100)]
Introduce wgRelevantPageIsProbablyEditable

This is equivalent to the existing variable wgIsProbablyEditable and in
keeping with wgRelevantPageName/wgRelevantArticleId; this is done as an
alternative to making a breaking change to the semantics of the former,
as that might cause issues for users who expect wgIsProbablyEditable to
return true on [[Foo]], but false on [[Special:Move/Foo]] and similar.

Change-Id: I6c6ca1cfd93e7be917952980f1e1d57aec3a1292

6 years agoRemove Selenium tests written in Ruby
Željko Filipin [Tue, 21 Mar 2017 11:10:46 +0000 (12:10 +0100)]
Remove Selenium tests written in Ruby

New Selenium tests in Node.js are in tests/selenium.

Bug: T164004
Change-Id: I3ddeecb4f012ba4a614b3ada81c5926da28556f4
Depends-On: I062d68458d8f472d636f1ae15f4fc37110460854

6 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Wed, 17 May 2017 20:37:00 +0000 (22:37 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: Ie2f793b769f66378edf72e616dfdd2a344e95987

6 years agoMerge "Apply EXIF rotation to X-Content-Dimensions"
jenkins-bot [Wed, 17 May 2017 19:34:42 +0000 (19:34 +0000)]
Merge "Apply EXIF rotation to X-Content-Dimensions"

6 years agoMerge "ApiLogin: i18n for 'Aborted' reasons"
jenkins-bot [Wed, 17 May 2017 18:00:53 +0000 (18:00 +0000)]
Merge "ApiLogin: i18n for 'Aborted' reasons"

6 years agoResources.php: Add missing dependencies to module 'mediawiki.user'
Fomafix [Wed, 17 May 2017 16:20:20 +0000 (18:20 +0200)]
Resources.php: Add missing dependencies to module 'mediawiki.user'

Change-Id: Ie68418a47d4b4b98fac2b275def392294bd01909

6 years agoMerge "RCFilters UI: Actually backwards-compat instead of overriding false"
jenkins-bot [Wed, 17 May 2017 09:40:09 +0000 (09:40 +0000)]
Merge "RCFilters UI: Actually backwards-compat instead of overriding false"

6 years agoMake sure unique keys carry over to postgres table duplicates
Aaron Schulz [Wed, 17 May 2017 02:20:42 +0000 (19:20 -0700)]
Make sure unique keys carry over to postgres table duplicates

This fixes BotPasswordTest failures.

Change-Id: I81003187af0c57020f9fc4cbcd2606e71907a903

6 years agoRCFilters UI: Actually backwards-compat instead of overriding false
Moriel Schottlender [Wed, 17 May 2017 00:35:43 +0000 (17:35 -0700)]
RCFilters UI: Actually backwards-compat instead of overriding false

Another typo in the code made highlight feature always load as false
when you loaded a saved filter.

Bug: T165437
Change-Id: I0e0efa3576659e4145b20013e4af7a06e4e7c0ff

6 years agoContribsPager: Use one TemplateParser instance
Kunal Mehta [Tue, 16 May 2017 22:49:03 +0000 (15:49 -0700)]
ContribsPager: Use one TemplateParser instance

TemplateParser has an instance cache to avoid reading from APC
repeatedly for the same template, but that only works if the code uses
the same TemplateParser object.

Change-Id: I59e37306c5a3216cf8ed3bfef9c80d50934a9146

6 years agoEnhancedChangesList: Use one TemplateParser instance
Kunal Mehta [Tue, 16 May 2017 22:43:35 +0000 (15:43 -0700)]
EnhancedChangesList: Use one TemplateParser instance

TemplateParser has an instance cache to avoid reading from APC
repeatedly for the same template, but that only works if the code uses
the same TemplateParser object.

Noticed while investigating T163154.

Change-Id: I645895a0965f7150e9a5aebc5a7788f27aa5a26d

6 years agoTemplateParser: Improve cache integrity check failure scenario
Kunal Mehta [Tue, 16 May 2017 22:40:08 +0000 (15:40 -0700)]
TemplateParser: Improve cache integrity check failure scenario

Previously, if the cache integrity check failed then it would emit a
warning but then continue to use the code. The integrity check could
genuinely fail if the secret key was changed, if the cache was
truncated, or other edge case scenarios.

Now TemplateParser will recompile if the cache fails the integrity
check, and then update the cache with the newly compiled version.

Bug: T163154
Change-Id: I9a6c8d528f84cfbabf402cfaf6468c162fab1f15

6 years agoUpdate OOjs UI to v0.21.4
James D. Forrester [Tue, 16 May 2017 22:34:01 +0000 (23:34 +0100)]
Update OOjs UI to v0.21.4

Release notes:
 https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/History.md;v0.21.4

Depends-On: I676c9aadbf4739437b94ec729cc4fe47ed19c886
Change-Id: Ie9f8e42c46948688495cbd80e778b484c7b03982

6 years agoMerge "Sync up with Parsoid parserTests.txt"
jenkins-bot [Tue, 16 May 2017 19:47:22 +0000 (19:47 +0000)]
Merge "Sync up with Parsoid parserTests.txt"

6 years agoSync up with Parsoid parserTests.txt
C. Scott Ananian [Tue, 16 May 2017 19:12:22 +0000 (15:12 -0400)]
Sync up with Parsoid parserTests.txt

This now aligns with Parsoid commit d163deefa3aaeb0926af09a91075d6a611b36363

Change-Id: I9e543f0803247ffc264e634bf66b6bd0e143f187

6 years agoMerge "Improve output of refreshImageMetadata and refreshFileHeaders"
jenkins-bot [Tue, 16 May 2017 19:12:02 +0000 (19:12 +0000)]
Merge "Improve output of refreshImageMetadata and refreshFileHeaders"

6 years agoApiLogin: i18n for 'Aborted' reasons
Brad Jorsch [Tue, 16 May 2017 14:14:03 +0000 (10:14 -0400)]
ApiLogin: i18n for 'Aborted' reasons

Ia6c402a4 did it for 'Failed', but overlooked 'Aborted'.

Change-Id: I3f7379af3609c30f10ea8c648f2ec840310e8d97

6 years agoApply EXIF rotation to X-Content-Dimensions
Gilles Dubuc [Tue, 16 May 2017 12:56:26 +0000 (14:56 +0200)]
Apply EXIF rotation to X-Content-Dimensions

Also adds integration tests for a few formats.

Bug: T150741
Change-Id: I686f7ef42457faf5bc688e60e6ce09a8550ca5aa

6 years agoMerge "Resources.php: Add missing dependencies to module 'mediawiki.util'"
jenkins-bot [Tue, 16 May 2017 09:02:00 +0000 (09:02 +0000)]
Merge "Resources.php: Add missing dependencies to module 'mediawiki.util'"

6 years agoImprove output of refreshImageMetadata and refreshFileHeaders
Gilles Dubuc [Mon, 15 May 2017 21:16:35 +0000 (23:16 +0200)]
Improve output of refreshImageMetadata and refreshFileHeaders

Bug: T150741
Change-Id: Ie5f787fd77ecd31b8852d0f66de912baced4ca46

6 years agoResources.php: Add missing dependencies to module 'mediawiki.util'
Fomafix [Mon, 15 May 2017 19:38:32 +0000 (21:38 +0200)]
Resources.php: Add missing dependencies to module 'mediawiki.util'

Change-Id: Iac3070adc36533ae046f57ecc7c772247b42420d

6 years agoMerge "registration: Move attributes out of the top level"
jenkins-bot [Tue, 16 May 2017 04:00:28 +0000 (04:00 +0000)]
Merge "registration: Move attributes out of the top level"

6 years agoregistration: Move attributes out of the top level
Kunal Mehta [Fri, 2 Dec 2016 06:02:28 +0000 (22:02 -0800)]
registration: Move attributes out of the top level

This moves attributes out of the top level, and namespaces them under
each extension. If the extension that it belongs to is not installed,
the attribute is not exported and dropped.

The full name of the attribute is the name of the extension plus the
name of the attribute key. This enforces the recommendation that the
attribute name start with the extension's name.

Add test coverage for attributes under manifest_version 1 and 2.

Bug: T133627
Depends-On: I5a148763f68989c8da313a4fb1d0213658ee4495
Depends-On: I5a148763f68989c8da313a4fb1d0213658ee4459
Change-Id: I8613a027c56e2c9d2c6a83ca14749eb1c8fc23be

6 years agoMerge "registration: Deprecate not having manifest_version set"
jenkins-bot [Tue, 16 May 2017 02:44:39 +0000 (02:44 +0000)]
Merge "registration: Deprecate not having manifest_version set"

6 years agoregistration: Deprecate not having manifest_version set
Kunal Mehta [Mon, 15 May 2017 23:33:22 +0000 (16:33 -0700)]
registration: Deprecate not having manifest_version set

Emit a wfDeprecated() warning for each extension that does not have
manifest_version set.

Because we don't have any mechanism to cache warnings, just disable the
cache if any deprecation warnings are emitted. This ensures that the
warnings are shown on every page load instead of probably once a day.

Bug: T155610
Change-Id: I163a84ae1d381ca5bd67b4b317c04f9f51c066ea

6 years agoMerge "OutputPage: Remove deprecated addParserOutputNoText, getHeadLinks methods"
jenkins-bot [Tue, 16 May 2017 00:21:07 +0000 (00:21 +0000)]
Merge "OutputPage: Remove deprecated addParserOutputNoText, getHeadLinks methods"

6 years agoMerge "Removed deprecated ExtractThumbParameters hook"
jenkins-bot [Tue, 16 May 2017 00:21:03 +0000 (00:21 +0000)]
Merge "Removed deprecated ExtractThumbParameters hook"

6 years agoMerge "EditPage: Preserve &ooui=1 / &ooui=0 from URL after preview"
jenkins-bot [Mon, 15 May 2017 23:19:24 +0000 (23:19 +0000)]
Merge "EditPage: Preserve &ooui=1 / &ooui=0 from URL after preview"

6 years agoMerge "ParserOptions: Include wrapping class in options hash"
jenkins-bot [Mon, 15 May 2017 23:12:28 +0000 (23:12 +0000)]
Merge "ParserOptions: Include wrapping class in options hash"

6 years agoRCFilters: Actually be consistent when storing 'highlight' state
Moriel Schottlender [Mon, 15 May 2017 19:10:07 +0000 (12:10 -0700)]
RCFilters: Actually be consistent when storing 'highlight' state

Saved queries are storing *filter* definitions, not parameters, so
highlight state (dictating whether highlights are enabled) are supposed
to be stored as boolean.

A previous fix that was meant to make sure we store and handle all
*parameters* as strings '0' and '1' was a bit overzealous, and stored
highlight state in saved queries as '1' and '0' too. The current state
then compared that to the filter-state, which produces false/true.

This resulting in saved queries only being matched to the current
state as never true, because the comparison goes by actual obejct
key-values, not symbolic values.

Bug: T165381
Change-Id: Ifdec3a8c058a0e004304e48a857c58639928b36f

6 years agoEditPage: Preserve &ooui=1 / &ooui=0 from URL after preview
Bartosz Dziewoński [Mon, 15 May 2017 18:33:37 +0000 (20:33 +0200)]
EditPage: Preserve &ooui=1 / &ooui=0 from URL after preview

Bug: T165237
Change-Id: Ia546159b45fabb1256f63f888412703ca3eba2e9

6 years agoMerge "RCFilters: Rephrase 'unset' to 'remove' in default option menu"
jenkins-bot [Mon, 15 May 2017 14:40:36 +0000 (14:40 +0000)]
Merge "RCFilters: Rephrase 'unset' to 'remove' in default option menu"

6 years agoMerge "RCFilters: Always put highlight values in the URL"
jenkins-bot [Mon, 15 May 2017 14:33:31 +0000 (14:33 +0000)]
Merge "RCFilters: Always put highlight values in the URL"

6 years agoMerge "RCFilters: Fix getFilterRepresentation to consider '0' as false"
jenkins-bot [Mon, 15 May 2017 12:45:55 +0000 (12:45 +0000)]
Merge "RCFilters: Fix getFilterRepresentation to consider '0' as false"

6 years agoOutputPage: Remove deprecated addParserOutputNoText, getHeadLinks methods
James D. Forrester [Thu, 13 Apr 2017 22:54:44 +0000 (15:54 -0700)]
OutputPage: Remove deprecated addParserOutputNoText, getHeadLinks methods

Change-Id: Idc55e7bb0f7bde8466192a81886f205de60c092c

6 years agoRemoved deprecated ExtractThumbParameters hook
James D. Forrester [Thu, 13 Apr 2017 22:49:47 +0000 (15:49 -0700)]
Removed deprecated ExtractThumbParameters hook

Depends-On: I827c61a5a340d4f107478174263e4a5d385398f4
Change-Id: I97e820d78d8041c40fb6e553c4081c676602462c

6 years agoParserOptions: Include wrapping class in options hash
Brad Jorsch [Fri, 12 May 2017 16:28:22 +0000 (12:28 -0400)]
ParserOptions: Include wrapping class in options hash

Avoids polluting the cache when things take advantage of the option.

Bug: T165115
Bug: T165161
Change-Id: I5be25c6de68012df58b6a0cbf92e2f972be2b68a