lhc/web/wiklou.git
2 years agoMerge "Fix AbstractBlock param types in documentation"
jenkins-bot [Tue, 14 May 2019 14:51:56 +0000 (14:51 +0000)]
Merge "Fix AbstractBlock param types in documentation"

2 years agoFix AbstractBlock param types in documentation
Thalia [Tue, 14 May 2019 12:42:50 +0000 (13:42 +0100)]
Fix AbstractBlock param types in documentation

Change-Id: I503375485956d3c05da445542419fb62684ae34a

2 years agoSearchResult: MW version number should be a string in wfDeprecated call
Derick Alangi [Tue, 14 May 2019 11:28:35 +0000 (12:28 +0100)]
SearchResult: MW version number should be a string in wfDeprecated call

Seems this was a typo and I think 1.32 which is a double/float will be
implicitly converted to true (bool) because it will resolve 1.32 to 1 as
integer and then 1 which maps to true (bool).

To avoid this, use '1.32' instead of the integer form of the version.

Change-Id: I2420396e110284f582cd79820ffc6064e247b4b9

2 years agoMerge "watchlist: fix nonsensical timestamp/boolean comparisons in EnhancedRecentChanges"
jenkins-bot [Mon, 13 May 2019 20:46:22 +0000 (20:46 +0000)]
Merge "watchlist: fix nonsensical timestamp/boolean comparisons in EnhancedRecentChanges"

2 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Mon, 13 May 2019 20:18:21 +0000 (22:18 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I2968beda4424a3eab0515fc1a8b597f2f8273e56

2 years agoMerge "Update release notes following the refactor of Block"
jenkins-bot [Mon, 13 May 2019 19:46:34 +0000 (19:46 +0000)]
Merge "Update release notes following the refactor of Block"

2 years agoUpdate release notes following the refactor of Block
Thalia [Mon, 13 May 2019 17:19:51 +0000 (18:19 +0100)]
Update release notes following the refactor of Block

This is a follow-up to I83bceb5.

Bug: T222737
Change-Id: Ic01a4bb196733a719860c21b7c9b8a41a2e1257a

2 years agoresources: Drop jquery.async, deprecated since 1.33
James D. Forrester [Sat, 27 Apr 2019 05:02:39 +0000 (00:02 -0500)]
resources: Drop jquery.async, deprecated since 1.33

Bug: T209699
Change-Id: Ia1a034de8d9996d9955744b7b2b453f4845d69d8

2 years agoMerge "feedback: Fix misplaced mw.Title.getNameText() call"
jenkins-bot [Mon, 13 May 2019 17:45:45 +0000 (17:45 +0000)]
Merge "feedback: Fix misplaced mw.Title.getNameText() call"

2 years agoMerge "Follow-up ee66a534: Drop reference to old 7zip.inc file name from phan config...
jenkins-bot [Mon, 13 May 2019 16:30:16 +0000 (16:30 +0000)]
Merge "Follow-up ee66a534: Drop reference to old 7zip.inc file name from phan config too"

2 years agoMerge "Make ApiQueryUserInfo::getBlockInfo accept an AbstractBlock"
jenkins-bot [Mon, 13 May 2019 15:46:44 +0000 (15:46 +0000)]
Merge "Make ApiQueryUserInfo::getBlockInfo accept an AbstractBlock"

2 years agoSearchEngine: Remove deprecated unused method `transformSearchTerm()`
Derick Alangi [Sat, 11 May 2019 15:21:18 +0000 (16:21 +0100)]
SearchEngine: Remove deprecated unused method `transformSearchTerm()`

I've checked around with code search tool and realized that SMW has
its own implementation of `transformSearchTerm()` which overwrites the
implementation of this method from core as it extends SearchEngine.

So removing this won't break SMW, see usage below;

Usage
=====

https://codesearch.wmflabs.org/search/?q=%5CbtransformSearchTerm%5Cb&i=nope&files=&repos=

Bug: T220656
Change-Id: I3dbe04ecba07700167c894673e23c1eead95460f

2 years agoFollow-up ee66a534: Drop reference to old 7zip.inc file name from phan config too
James D. Forrester [Mon, 13 May 2019 14:27:57 +0000 (15:27 +0100)]
Follow-up ee66a534: Drop reference to old 7zip.inc file name from phan config too

Change-Id: I4e018ab676f114a45edb9e7ca6025490134a2ef0

2 years agoMerge "Add tests for HttpRequestFactoryTest."
jenkins-bot [Mon, 13 May 2019 14:24:03 +0000 (14:24 +0000)]
Merge "Add tests for HttpRequestFactoryTest."

2 years agoMake ApiQueryUserInfo::getBlockInfo accept an AbstractBlock
Thalia [Mon, 13 May 2019 14:20:38 +0000 (15:20 +0100)]
Make ApiQueryUserInfo::getBlockInfo accept an AbstractBlock

This method was removed (I84ed216) before the Block class was
refactored (I83bceb5) and restored (If47a938) after the refactor.

After the refactor, this method should accept and AbstractBlock,
so it can handle a SystemBlock as well as a database Block.

Change-Id: Ice8a2e7c19e88406229bd836a45f377abdb72fb6

2 years agotests: Remove deprecated rarely used method stashMwGlobals()
Derick Alangi [Mon, 13 May 2019 13:02:19 +0000 (14:02 +0100)]
tests: Remove deprecated rarely used method stashMwGlobals()

This method was hard deprecated in 1.32 and seems it's no longer
used? Can we remove it now?

Usage
=====

https://codesearch.wmflabs.org/search/?q=%5CbstashMwGlobals%5Cb&i=nope&files=&repos=

Change-Id: I8d105a82093ea4cb3a38ed04e471e0213b29e8ec

2 years agoAdd tests for HttpRequestFactoryTest.
daniel [Mon, 13 May 2019 10:38:00 +0000 (12:38 +0200)]
Add tests for HttpRequestFactoryTest.

This also moves several tests out of HttpTest, so they are not lost when
the deprecated Http class is removed.

Bug: T222935
Change-Id: Ib4aac96ba1a978e8b6738ed446663afc3cc8c792

2 years agoMerge "move 7zip.inc to a regular php file"
jenkins-bot [Mon, 13 May 2019 11:55:30 +0000 (11:55 +0000)]
Merge "move 7zip.inc to a regular php file"

2 years agomove 7zip.inc to a regular php file
Ariel T. Glenn [Mon, 13 May 2019 10:38:37 +0000 (13:38 +0300)]
move 7zip.inc to a regular php file

Bug: T182814
Change-Id: I53746333fe3c1cdc357bf46d71a351231a845e2f

2 years agoMerge "jobqueue: Remove deprecated unused method pushLazyJobs()"
jenkins-bot [Mon, 13 May 2019 10:51:01 +0000 (10:51 +0000)]
Merge "jobqueue: Remove deprecated unused method pushLazyJobs()"

2 years agojobqueue: Remove deprecated unused method pushLazyJobs()
Derick Alangi [Sat, 11 May 2019 15:05:58 +0000 (16:05 +0100)]
jobqueue: Remove deprecated unused method pushLazyJobs()

Was deprecated in 1.33 and is no longer used anywhere. See usage
below;

Usage
=====

https://codesearch.wmflabs.org/search/?q=%5CbpushLazyJobs%5Cb&i=nope&files=&repos=

Bug: T220656
Change-Id: I4d3f6bc019b8ebc7e504d841fc75acdb08061cb4

2 years agoReturn result from HttpRequestFactory get and post methods
daniel [Mon, 13 May 2019 09:31:52 +0000 (11:31 +0200)]
Return result from HttpRequestFactory get and post methods

Bug: T222935
Change-Id: Idf1d00d04abbcf4e3391e3979bbab97e595916a5

2 years agofeedback: Fix misplaced mw.Title.getNameText() call
Thiemo Kreuz [Mon, 13 May 2019 08:21:10 +0000 (10:21 +0200)]
feedback: Fix misplaced mw.Title.getNameText() call

What is called "name" here is a file name without the extension. But
the feedback code is not about files. It's a regular page that might
contain a dot. If it does, the link will be broken, because everything
after the last dot will be stripped.

Change-Id: I9a7c7b73f5d899400ffdc4f4a92cb8b42e644b1c

2 years agomove most of dumpTextPass to an include file so it can be subclassed
Ariel T. Glenn [Sun, 11 Feb 2018 10:37:41 +0000 (12:37 +0200)]
move most of dumpTextPass to an include file so it can be subclassed

Bug: T164262
Change-Id: I9b3c54503dd9ad193af7765459613a7e73ffbb45

2 years agoMerge "allow xml page content or metadata dumps to target specific namespaces"
jenkins-bot [Mon, 13 May 2019 06:51:45 +0000 (06:51 +0000)]
Merge "allow xml page content or metadata dumps to target specific namespaces"

2 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Sun, 12 May 2019 19:56:52 +0000 (21:56 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I9dabebcc8d21def62949958e402e314797e71799

2 years agoUpdated special page name translations for Slovak language
zoranzoki21 [Thu, 9 May 2019 14:25:36 +0000 (16:25 +0200)]
Updated special page name translations for Slovak language

Bug: T222793
Change-Id: I738aaa9767f3062be8ad9357072ec5b942e3e7da

2 years agoMerge "changetags: Remove deprecated unused method `purgeTagUsageCache()`"
jenkins-bot [Sat, 11 May 2019 19:19:16 +0000 (19:19 +0000)]
Merge "changetags: Remove deprecated unused method `purgeTagUsageCache()`"

2 years agoMerge "api: Remove deprecated `prepareUrlQuerySearchString()` from core"
jenkins-bot [Sat, 11 May 2019 19:19:09 +0000 (19:19 +0000)]
Merge "api: Remove deprecated `prepareUrlQuerySearchString()` from core"

2 years agoMerge "Remove "Squiz.WhiteSpace.FunctionSpacing" from phpcs exclusions"
jenkins-bot [Sat, 11 May 2019 19:06:42 +0000 (19:06 +0000)]
Merge "Remove "Squiz.WhiteSpace.FunctionSpacing" from phpcs exclusions"

2 years agochangetags: Remove deprecated unused method `purgeTagUsageCache()`
Derick Alangi [Sat, 11 May 2019 15:00:56 +0000 (16:00 +0100)]
changetags: Remove deprecated unused method `purgeTagUsageCache()`

This method was hard deprecated in 1.33 in core and no longer used
anymore.

Usage
=====

https://codesearch.wmflabs.org/search/?q=%5CbpurgeTagUsageCache%5Cb&i=nope&files=&repos=

Bug: T220656
Change-Id: I79b364b8a95d9bbf9265c1efa844ff59d11f48aa

2 years agoapi: Remove deprecated `prepareUrlQuerySearchString()` from core
Derick Alangi [Sat, 11 May 2019 14:55:34 +0000 (15:55 +0100)]
api: Remove deprecated `prepareUrlQuerySearchString()` from core

This method was deprecated in 1.33 and is no longer used.

Usage
=====

https://codesearch.wmflabs.org/search/?q=%5CbprepareUrlQuerySearchString%5Cb&i=nope&files=&repos=

Bug: T220656
Change-Id: I15a476438f3a579db41a43658e13b6ddc4fc62d4

2 years agoMerge "Restore ApiQueryUserInfo::getBlockInfo() as a stub."
jenkins-bot [Sat, 11 May 2019 09:42:28 +0000 (09:42 +0000)]
Merge "Restore ApiQueryUserInfo::getBlockInfo() as a stub."

2 years agoRestore ApiQueryUserInfo::getBlockInfo() as a stub.
daniel [Thu, 9 May 2019 10:13:30 +0000 (12:13 +0200)]
Restore ApiQueryUserInfo::getBlockInfo() as a stub.

Fixes unintended breaking change made by I84ed21641c44b2f65ebe.
ApiQueryUserInfo::getBlockInfo() is restoed as a hard deprecated stub.

This renames the method in the new ApiBlockInfoTrait to
getBlockDetails.

Depends-On: I9f40666a31bd4af50762c197c2ce5bf089a5e68c
Change-Id: If47a93878f87d69800e5f305404c22528dac5e94

2 years agoRemove "Squiz.WhiteSpace.FunctionSpacing" from phpcs exclusions
Reedy [Sat, 11 May 2019 01:17:43 +0000 (02:17 +0100)]
Remove "Squiz.WhiteSpace.FunctionSpacing" from phpcs exclusions

Change-Id: I78b3315f26ab91b6b443f5b028a635552f82f5a3

2 years agoMerge "watchlist: cleanup various method/variable names and comments in watchlist...
jenkins-bot [Sat, 11 May 2019 01:37:01 +0000 (01:37 +0000)]
Merge "watchlist: cleanup various method/variable names and comments in watchlist/store code"

2 years agoUpdate cssjanus/cssjanus from 1.2.1 to 1.3.0
Reedy [Sat, 11 May 2019 00:20:15 +0000 (01:20 +0100)]
Update cssjanus/cssjanus from 1.2.1 to 1.3.0

https://github.com/cssjanus/php-cssjanus/releases/tag/v1.3.0
https://github.com/cssjanus/php-cssjanus/compare/v1.2.1...v1.3.0

Bug: T215746
Change-Id: I352f79f6f34279e669057aee7c2f1570800c8a11
Depends-On: Id8aba2d9e99671a9c45e02b271dbf290a11228d7

2 years agoUpdate some composer dependancies
Reedy [Fri, 10 May 2019 23:19:25 +0000 (00:19 +0100)]
Update some composer dependancies

Update composer/semver from 1.4.2 to 1.5.0

https://github.com/composer/semver/releases/tag/1.5.0
https://github.com/composer/semver/compare/1.4.2...1.5.0

Update composer/spdx-licenses from 1.4.0 to 1.5.1

https://github.com/composer/spdx-licenses/compare/1.4.0...1.5.1
https://github.com/composer/spdx-licenses/releases/tag/1.5.1

Update mediawiki/codesniffer from 25.0.0 to 26.0.0

https://github.com/wikimedia/mediawiki-tools-codesniffer/releases/tag/v26.0.0
https://github.com/wikimedia/mediawiki-tools-codesniffer/compare/25.0.0...v26.0.0

Disable failing Squiz.WhiteSpace.FunctionSpacing, can be fixed in a later
commit

Change-Id: I89062c8f28bef893f054650f2e81287291ba9ca0
Depends-On: I8f55e77283f83d853ce340f5c1b7704c65e45bc4

2 years agoMerge "selenium: Add jpeg-js to devDependencies"
jenkins-bot [Fri, 10 May 2019 17:19:18 +0000 (17:19 +0000)]
Merge "selenium: Add jpeg-js to devDependencies"

2 years agoMerge "Add another Bengali synonym for HIDDENCAT in MessagesBn.php"
jenkins-bot [Fri, 10 May 2019 17:03:17 +0000 (17:03 +0000)]
Merge "Add another Bengali synonym for HIDDENCAT in MessagesBn.php"

2 years agoMerge "user: Remove deprecated and unused method `getPasswordValidity()`"
jenkins-bot [Fri, 10 May 2019 17:00:15 +0000 (17:00 +0000)]
Merge "user: Remove deprecated and unused method `getPasswordValidity()`"

2 years agoMerge "Remove deprecated unused method `getModuleScripts()`"
jenkins-bot [Fri, 10 May 2019 17:00:06 +0000 (17:00 +0000)]
Merge "Remove deprecated unused method `getModuleScripts()`"

2 years agoMerge "Add 'avoidhours' option to Language#formatTimePeriod"
jenkins-bot [Fri, 10 May 2019 16:59:58 +0000 (16:59 +0000)]
Merge "Add 'avoidhours' option to Language#formatTimePeriod"

2 years agoMerge "Remove unused title parameter from EditPage::getEditToolbar()"
jenkins-bot [Fri, 10 May 2019 16:20:09 +0000 (16:20 +0000)]
Merge "Remove unused title parameter from EditPage::getEditToolbar()"

2 years agoselenium: Add jpeg-js to devDependencies
Željko Filipin [Fri, 10 May 2019 14:25:24 +0000 (16:25 +0200)]
selenium: Add jpeg-js to devDependencies

It is needed for I92739d84947ac146e in WikibaseMediaInfo Selenium tests.
It can not be added there because of T199116.

Bug: T219815
Bug: T199116
Change-Id: Ib7c3b1b49c280bdc38c40c6aef900a605c1e3cbe

2 years agoProperly output the name of the file in assertFileContains
David Causse [Fri, 10 May 2019 13:57:58 +0000 (15:57 +0200)]
Properly output the name of the file in assertFileContains

Change-Id: If02d094049bd8ec21d5f180382ccc4bc6202f981

2 years agoRemove unused title parameter from EditPage::getEditToolbar()
Thiemo Kreuz [Fri, 10 May 2019 13:23:20 +0000 (15:23 +0200)]
Remove unused title parameter from EditPage::getEditToolbar()

No code uses this parameter:
https://codesearch.wmflabs.org/search/?q=getEditToolbar
I suggest to skip any deprecation because of this.

It might be worth mentioning this in the release notes anyway, or is
it?

Change-Id: I5d47c22fa741df5f9c248e4e1bff2d6e97aca6a7

2 years agoMerge "Missing space between variable name and docstring"
jenkins-bot [Fri, 10 May 2019 08:51:37 +0000 (08:51 +0000)]
Merge "Missing space between variable name and docstring"

2 years agoMissing space between variable name and docstring
Adam Wight [Fri, 10 May 2019 08:25:56 +0000 (10:25 +0200)]
Missing space between variable name and docstring

Change-Id: I308a0de17da5058691ceea983e60c064b0bfc16c

2 years agoAdd 'avoidhours' option to Language#formatTimePeriod
Jack Phoenix [Sat, 4 May 2019 09:27:04 +0000 (12:27 +0300)]
Add 'avoidhours' option to Language#formatTimePeriod

Example use case: in some skins we want to show how many *days* ago a page was edited, but we don't really care about the precise _hours_.
Thus we'll set [ 'avoid' => 'avoidhours' ] when calling Language#formatTimePeriod to output something like "Page last edited 60 days ago" instead of "Page last edited 60 days 9 hours ago".

Change-Id: I0a737aab14ccb2b8d4eccdc41e1eb9232eedcb8a

2 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Fri, 10 May 2019 06:15:09 +0000 (08:15 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: Ie08ae3ddb5a880d39092ff0828d5059d3eb74724

2 years agowatchlist: fix nonsensical timestamp/boolean comparisons in EnhancedRecentChanges
Aaron Schulz [Fri, 10 May 2019 00:59:04 +0000 (17:59 -0700)]
watchlist: fix nonsensical timestamp/boolean comparisons in EnhancedRecentChanges

Also fix bug where the "changes since last visit" counter failed to show for pages
where their entire history is still in recent changes. Although the "new" flag is
set for the RCCacheEntry block, there can still be multiple revisions since the
last one seen by the user. This change accounts for that case.

Bug: T218511
Change-Id: I92060bd26d8642937cad7f8c1ace3c5e066790be

2 years agowatchlist: cleanup various method/variable names and comments in watchlist/store...
Aaron Schulz [Fri, 10 May 2019 00:37:58 +0000 (17:37 -0700)]
watchlist: cleanup various method/variable names and comments in watchlist/store code

Change-Id: I70a55d5b4ea38f92132a15da3feb314b6b5bb013

2 years agouser: Remove deprecated and unused method `getPasswordValidity()`
Derick Alangi [Thu, 9 May 2019 22:31:17 +0000 (23:31 +0100)]
user: Remove deprecated and unused method `getPasswordValidity()`

This method was deprecated in 1.33 and no longer used. See usage;

Usage
=====

https://codesearch.wmflabs.org/search/?q=%5CbgetPasswordValidity%5Cb&i=nope&files=&repos=

Bug: T220656
Change-Id: I28829f33d40b5568bedb9678fc43beb146b72e56

2 years agoRemove unused EventRelayer code from ObjectCache::newWANCacheFromParams()
Aaron Schulz [Thu, 9 May 2019 23:13:15 +0000 (16:13 -0700)]
Remove unused EventRelayer code from ObjectCache::newWANCacheFromParams()

Change-Id: I6c0f274e3c49312b63446732f22123af9dac8a2b

2 years agoMerge "Always validate uploads over api"
jenkins-bot [Thu, 9 May 2019 22:58:49 +0000 (22:58 +0000)]
Merge "Always validate uploads over api"

2 years agoRemove deprecated unused method `getModuleScripts()`
Derick Alangi [Thu, 9 May 2019 22:25:53 +0000 (23:25 +0100)]
Remove deprecated unused method `getModuleScripts()`

Deprecated in 1.33 and no longer used. Removed from OutputPage and
from ParserOutput.

Usage
=====

https://codesearch.wmflabs.org/search/?q=%5CbgetModuleScripts%5Cb&i=nope&files=&repos=

Bug: T220656
Change-Id: Ifddea94504d0c749d3a77daf967d5fec95b50339

2 years agoMWMessagePack: Deprecate MWMessagePack class and its method
Derick Alangi [Sat, 20 Apr 2019 21:54:28 +0000 (22:54 +0100)]
MWMessagePack: Deprecate MWMessagePack class and its method

Usage
=====

https://codesearch.wmflabs.org/search/?q=%5CbMWMessagePack%5Cb&i=nope&files=&repos=

Bug: T220313
Change-Id: I3648f8c14116f924d835f68077f46333d892a038

2 years agopage: Remove deprecated/unused methods in PageArchive class
Derick Alangi [Thu, 9 May 2019 15:19:53 +0000 (16:19 +0100)]
page: Remove deprecated/unused methods in PageArchive class

This code is no longer used per usage (below) and was to be actually
removed in 1.33. Methods are;

getLastRevisionText(), listAllPages() and getTextFromRow(), see example
search of usage below.

Usage
=====

https://codesearch.wmflabs.org/search/?q=%5CbgetTextFromRow%5Cb&i=nope&files=&repos=

Change-Id: I4b9675a9cf84442f08f125f4c23ec67d72b12c15

2 years agoLanguage: Remove deprecated initEncoding(), recodeForEdit() & recodeInput()
Derick Alangi [Mon, 29 Apr 2019 23:12:58 +0000 (00:12 +0100)]
Language: Remove deprecated initEncoding(), recodeForEdit() & recodeInput()

Language::initEncoding(), ::recodeForEdit(), and ::recodeInput() deprecated in
1.28 are now removed.

Usage
=====

* initEncoding() -
  https://codesearch.wmflabs.org/search/?q=initEncoding&i=nope&files=&repos=

* recodeForEdit() -
  https://codesearch.wmflabs.org/search/?q=recodeForEdit&i=nope&files=&repos=

* recodeInput() -
  https://codesearch.wmflabs.org/search/?q=recodeInput&i=nope&files=&repos=

Bug: T220656
Change-Id: I309ec5eebbdddd3b71541c446b15b15204abf8ca

2 years agoMerge "EditPage: Remove `::safeUnicodeInput()` and `::safeUnicodeOutput()`"
jenkins-bot [Thu, 9 May 2019 19:22:53 +0000 (19:22 +0000)]
Merge "EditPage: Remove `::safeUnicodeInput()` and `::safeUnicodeOutput()`"

2 years agoAlways validate uploads over api
Umherirrender [Mon, 25 Mar 2019 20:08:38 +0000 (21:08 +0100)]
Always validate uploads over api

filesize and title are validated in UploadBase::verifyUpload with more
accurate error message

Using stashed async with a long title can cause null errors later on

Bug: T208539
Change-Id: I545435e2baa222ae1544673011c5527874d1d2cb

2 years agoMerge "GlobalFunctions: Version for hard & soft deprecation must match"
jenkins-bot [Thu, 9 May 2019 19:11:39 +0000 (19:11 +0000)]
Merge "GlobalFunctions: Version for hard & soft deprecation must match"

2 years agoEditPage: Remove `::safeUnicodeInput()` and `::safeUnicodeOutput()`
Derick Alangi [Wed, 8 May 2019 19:33:51 +0000 (20:33 +0100)]
EditPage: Remove `::safeUnicodeInput()` and `::safeUnicodeOutput()`

These methods were deprecated in 1.30 are now being removed as there
are no longer any usage of them.

Usage
=====

https://codesearch.wmflabs.org/search/?q=%5Cb(safeUnicodeOutput%7CsafeUnicodeInput)%5Cb&i=nope&files=&repos=

Bug: T220656
Change-Id: Idd36a81593b9e4e48a43c497c620c3f7d0b0554b

2 years agoRemove several methods, deprecated in 1.32
Derick Alangi [Thu, 9 May 2019 16:03:57 +0000 (17:03 +0100)]
Remove several methods, deprecated in 1.32

I've checked and doubled checked that these methods are no longer used
anywhere in core or extensions, hence removed them. They were hard deprecated
in MediaWiki 1.32.

* OutputPage:
  ** `::showFileCopyError()`
  ** `::showFileRenameError()`
  ** `::showFileDeleteError()`
  ** `::showFileNotFoundError()`

* ApiBase:
  ** `::truncateArray()`

* IcuCollation:
  ** `::getICUVersion()`

* HTMLForm:
  ** `::setSubmitProgressive()`

* ResourceLoaderStartUpModules:
  ** `::getStartupModules()`
  ** `::getLegacyModules()`

* BaseTemplate:
  ** `::msgHtml()`

* QuickTemplate:
  ** `::msgHtml()`

* WatchAction:
  ** `::getUnwatchToken()`

Bug: T220656
Change-Id: Ic1a723a991f4ff63fcb5f045ddcda18d1f8c3c68

2 years agoMerge "IP: Hard deprecate `IP::isValidBlock()` in favor of `::isValidRange()`"
jenkins-bot [Thu, 9 May 2019 18:19:37 +0000 (18:19 +0000)]
Merge "IP: Hard deprecate `IP::isValidBlock()` in favor of `::isValidRange()`"

2 years agoMerge "Remove several deprecated unused methods from OutputPage & ParserOutput"
jenkins-bot [Thu, 9 May 2019 18:19:28 +0000 (18:19 +0000)]
Merge "Remove several deprecated unused methods from OutputPage & ParserOutput"

2 years agoIP: Hard deprecate `IP::isValidBlock()` in favor of `::isValidRange()`
Derick Alangi [Thu, 9 May 2019 14:31:26 +0000 (15:31 +0100)]
IP: Hard deprecate `IP::isValidBlock()` in favor of `::isValidRange()`

`IP::isValidRange()` replaces deprecated `IP::isValidBlock()` and after
Ic00f760a0a214f is landed, no usage will remain so hard deprecating it
in preparation for removal in after the 1.34 cut.

Depends-On: Ic00f760a0a214faba7a71dd088da1dc25ecb796c
Change-Id: I6943e45c06dbb954e2156dc4e796ddf3553b7a76

2 years agoMerge "htmlform: Use `::isValidRange()` instead of deprecated `::isValidBlock()`"
jenkins-bot [Thu, 9 May 2019 16:52:34 +0000 (16:52 +0000)]
Merge "htmlform: Use `::isValidRange()` instead of deprecated `::isValidBlock()`"

2 years agoMerge "foreign-resources.yaml: Add jquery.i18n"
jenkins-bot [Thu, 9 May 2019 16:43:10 +0000 (16:43 +0000)]
Merge "foreign-resources.yaml: Add jquery.i18n"

2 years agohtmlform: Use `::isValidRange()` instead of deprecated `::isValidBlock()`
Derick Alangi [Thu, 9 May 2019 14:27:43 +0000 (15:27 +0100)]
htmlform: Use `::isValidRange()` instead of deprecated `::isValidBlock()`

Only 1 usage of this call in everywhere, see usage below. Once this is merged,
the method can be hard deprecated and later killed.

Usage
=====

https://codesearch.wmflabs.org/search/?q=%5CbisValidBlock%5Cb&i=nope&files=&repos=

Change-Id: Ic00f760a0a214faba7a71dd088da1dc25ecb796c

2 years agoMerge "Simplify by using ?: operator"
jenkins-bot [Thu, 9 May 2019 16:25:22 +0000 (16:25 +0000)]
Merge "Simplify by using ?: operator"

2 years agoforeign-resources.yaml: Add jquery.i18n
James D. Forrester [Sat, 27 Apr 2019 05:08:10 +0000 (00:08 -0500)]
foreign-resources.yaml: Add jquery.i18n

Change-Id: I83ab62283828f54a4cf3d29dc0adbada08a5bc32

2 years agoAdd another Bengali synonym for HIDDENCAT in MessagesBn.php
Aftab [Tue, 30 Apr 2019 20:58:02 +0000 (20:58 +0000)]
Add another Bengali synonym for HIDDENCAT in MessagesBn.php

Bug: T222126
Change-Id: Ie54433ed32ed209d3cb0077c5c2e3f1c67a94444

2 years agotitle: Remove misplaced documentation from TitleParser
Thiemo Kreuz [Tue, 7 May 2019 15:07:47 +0000 (17:07 +0200)]
title: Remove misplaced documentation from TitleParser

There is no $form.

Change-Id: I1468f8dbaceaa78e12d7c23170ceba1fbb2b129e

2 years agoMerge "SearchEngine: Followup on I623b39e7ec791a66c4cf40"
jenkins-bot [Thu, 9 May 2019 15:51:35 +0000 (15:51 +0000)]
Merge "SearchEngine: Followup on I623b39e7ec791a66c4cf40"

2 years agoRemove several deprecated unused methods from OutputPage & ParserOutput
Derick Alangi [Thu, 9 May 2019 15:35:44 +0000 (16:35 +0100)]
Remove several deprecated unused methods from OutputPage & ParserOutput

Output::sectionEditLinksEnabled(), ParserOutput::getEditSectionTokens() and
::getTOCEnabled(), ::setEditSectionTokens(), ::setTOCEnabled have been removed.

Change-Id: I7fe927776e2451bafb96ef5c4ee500497ec3734c

2 years agoAvoid various phpstorm warnings in MediaWikiServices due to "object" return hint
Aaron Schulz [Mon, 22 Apr 2019 08:21:50 +0000 (01:21 -0700)]
Avoid various phpstorm warnings in MediaWikiServices due to "object" return hint

Change-Id: Icbd115104d34e3c7f4075902e75484c4779637eb

2 years agoGlobalFunctions: Version for hard & soft deprecation must match
Derick Alangi [Thu, 9 May 2019 14:56:40 +0000 (15:56 +0100)]
GlobalFunctions: Version for hard & soft deprecation must match

Per the deprecation policy, hard and soft deprecation version for
MW must match, so hard must match soft, in that order. The method
wfGetLBFactory() was soft deprecated in 1.27 so hard deprecation
version should be 1.27 and not 1.34

This is a follow up for 91a3f56.

Change-Id: I2b4b4c97dca3bc8ecadf7a53d68ea183b4a0de9c

2 years agoSearchEngine: Followup on I623b39e7ec791a66c4cf40
Derick Alangi [Thu, 9 May 2019 14:42:14 +0000 (15:42 +0100)]
SearchEngine: Followup on I623b39e7ec791a66c4cf40

Per https://www.mediawiki.org/wiki/Deprecation_policy#Deprecation,
the version for hard deprecation must be exactly the same as the
one it was soft deprecated in.

Bug: T221431
Change-Id: Ib7c2b569959194e15f50c62fe0eca1c3011bc50e

2 years agospecialPageAliases: Order BlockList at correct place per alphabet
zoranzoki21 [Thu, 9 May 2019 14:06:58 +0000 (16:06 +0200)]
specialPageAliases: Order BlockList at correct place per alphabet

Change-Id: Ia5b16cf43ec5ffca7872b90cf491bf66b814d677

2 years agoMerge "Extract default mediawiki.ui button styles into mixins"
jenkins-bot [Thu, 9 May 2019 13:30:34 +0000 (13:30 +0000)]
Merge "Extract default mediawiki.ui button styles into mixins"

2 years agoExtract default mediawiki.ui button styles into mixins
Jan Drewniak [Wed, 8 May 2019 11:18:00 +0000 (13:18 +0200)]
Extract default mediawiki.ui button styles into mixins

Move the default mediawiki.ui button styles into two mixins:
.mw-ui-button() and .mw-ui-button-states().

Change name of .button-colors-primary() mixin to .mw-ui-button-colors-primary().

These mixins are globally available and originally intended for use
on special pages in the MinervaNeue skin.

Bug: T219895
Change-Id: Ibeed271e143c062c6bfc48a6c4db74635dbc40e2

2 years agoselenium: Asynchronous methods should be returned to browser.call()
jdlrobson [Wed, 8 May 2019 21:05:44 +0000 (14:05 -0700)]
selenium: Asynchronous methods should be returned to browser.call()

Api.edit is asynchronous and is wrapped in a browser.call but
should be returned.

Follows-up 341320457cd67.

Bug: T220479
Change-Id: Id0e3549e93a967165bdc1bb758ddef8d59ccc300

2 years agoMerge "Hard deprecate Password::equals()"
jenkins-bot [Thu, 9 May 2019 02:09:42 +0000 (02:09 +0000)]
Merge "Hard deprecate Password::equals()"

2 years agoMerge "Make skins/README looks like extensions/README file"
jenkins-bot [Thu, 9 May 2019 01:37:58 +0000 (01:37 +0000)]
Merge "Make skins/README looks like extensions/README file"

2 years agoMerge "Make powersearch form use POST if JS is disabled"
jenkins-bot [Wed, 8 May 2019 21:52:33 +0000 (21:52 +0000)]
Merge "Make powersearch form use POST if JS is disabled"

2 years agoMerge "rdbms: remove unused SavepointPostgres class"
jenkins-bot [Wed, 8 May 2019 21:48:09 +0000 (21:48 +0000)]
Merge "rdbms: remove unused SavepointPostgres class"

2 years agoMerge "resourceloader: Remove redundant 'window' indirection"
jenkins-bot [Wed, 8 May 2019 21:46:00 +0000 (21:46 +0000)]
Merge "resourceloader: Remove redundant 'window' indirection"

2 years agoMerge "resourceloader: Move per-page function calls to startup.js"
jenkins-bot [Wed, 8 May 2019 21:40:19 +0000 (21:40 +0000)]
Merge "resourceloader: Move per-page function calls to startup.js"

2 years agoMerge "resourceloader: Add forward-compat to startup.js for I1c995a9572d"
jenkins-bot [Wed, 8 May 2019 21:38:29 +0000 (21:38 +0000)]
Merge "resourceloader: Add forward-compat to startup.js for I1c995a9572d"

2 years agordbms: remove unused SavepointPostgres class
Aaron Schulz [Tue, 7 May 2019 04:11:06 +0000 (21:11 -0700)]
rdbms: remove unused SavepointPostgres class

Change-Id: I45117c10d7f4ab779e95536807dad055c2970117

2 years agoresourceloader: Remove redundant 'window' indirection
Timo Tijhof [Sun, 14 Apr 2019 01:15:55 +0000 (02:15 +0100)]
resourceloader: Remove redundant 'window' indirection

Use global variables directly as globals, except for the specific
case of accessing it when it may not exist. In those cases we
use the fact that undefined properties of an object yield the
`undefined` value which we can cast to false. Accessing an undefined
variable would yield a ReferenceError exception.

Change-Id: I1d9e9aa5845ba3c756ad6e31358d8594e003b04b

2 years agoresourceloader: Move per-page function calls to startup.js
Timo Tijhof [Wed, 8 May 2019 17:24:07 +0000 (18:24 +0100)]
resourceloader: Move per-page function calls to startup.js

Turn these embedded function calls into variable declarations,
later consumed by startup.js.

This has a few benefits:

* Variables can be declared immediately, without needing to
  defer it to after mw.loader arrives from startup, via an RLQ
  callback. This makes the inline script simpler and a tiny
  bit smaller.

* By moving the actual function calls to startup.js, they could
  easily be re-arranged in the future or migrated in other ways
  without needing to worry about HTML caching and keeping concurrent
  compatibility with both orders of execution.

Change-Id: I1c995a9572d9eb3201a565341c19bdf81ab00eff

2 years agoresourceloader: Add forward-compat to startup.js for I1c995a9572d
Timo Tijhof [Wed, 8 May 2019 17:21:40 +0000 (18:21 +0100)]
resourceloader: Add forward-compat to startup.js for I1c995a9572d

This prepares startup.js to support the declarative format
for transporting values for mw.config, mw.loader.state, and
mw.loader.load.

These are currently applied as executable code in <head>, but after
I1c995a9572d these will instead be declarative allowing them
to be set without a closure and consolidating control over the
startup flow to startup.js.

We'll still have RLQ for two reasons: 1) compat with cached HTML,
and 2) for the use case of streaming load.php-like responses
as part of the HTML payload (e.g private modules, previews,
inline snippets).

Change-Id: I76a2c8d52fa782cd09d48d99b5fbb7be35e2b9a8

2 years agoMerge "Remove rcenhancedfilters from $wgDefaultUserOptions"
jenkins-bot [Wed, 8 May 2019 21:12:22 +0000 (21:12 +0000)]
Merge "Remove rcenhancedfilters from $wgDefaultUserOptions"

2 years agoMake powersearch form use POST if JS is disabled
Aaron Schulz [Wed, 8 May 2019 20:32:19 +0000 (13:32 -0700)]
Make powersearch form use POST if JS is disabled

This means that the rememberme checkbox will not result in DB
writes on HTTP GET. If JS is enabled, it becomes GET initially.

Bug: T151903
Change-Id: If700ba9d6d1fe582d3d7c5660fcefd6d2639e4ee

2 years agoRemove rcenhancedfilters from $wgDefaultUserOptions
Roan Kattouw [Wed, 8 May 2019 20:34:54 +0000 (13:34 -0700)]
Remove rcenhancedfilters from $wgDefaultUserOptions

This preference was removed earlier, but we forgot to clean this up.

Bug: T196033
Change-Id: I449bcaf8c031d9d26a6f6be3eb0ef4abc5892611

2 years agoMerge "Corrected grammatical error."
jenkins-bot [Wed, 8 May 2019 20:05:33 +0000 (20:05 +0000)]
Merge "Corrected grammatical error."

2 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Wed, 8 May 2019 19:59:53 +0000 (21:59 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: Iba0f23f9ad9f949e11b69d0e5348c5af3e15e6a2