Remove unused title parameter from EditPage::getEditToolbar()
authorThiemo Kreuz <thiemo.kreuz@wikimedia.de>
Fri, 10 May 2019 13:23:20 +0000 (15:23 +0200)
committerThiemo Kreuz <thiemo.kreuz@wikimedia.de>
Fri, 10 May 2019 13:23:20 +0000 (15:23 +0200)
No code uses this parameter:
https://codesearch.wmflabs.org/search/?q=getEditToolbar
I suggest to skip any deprecation because of this.

It might be worth mentioning this in the release notes anyway, or is
it?

Change-Id: I5d47c22fa741df5f9c248e4e1bff2d6e97aca6a7

includes/EditPage.php

index 2d5b9e2..edc1cbe 100644 (file)
@@ -2934,7 +2934,7 @@ ERROR;
                }
 
                if ( !$this->mTitle->isUserConfigPage() ) {
-                       $out->addHTML( self::getEditToolbar( $this->mTitle ) );
+                       $out->addHTML( self::getEditToolbar() );
                }
 
                if ( $this->blankArticle ) {
@@ -4101,10 +4101,9 @@ ERROR;
        /**
         * Allow extensions to provide a toolbar.
         *
-        * @param Title|null $title Title object for the page being edited (optional)
         * @return string|null
         */
-       public static function getEditToolbar( $title = null ) {
+       public static function getEditToolbar() {
                $startingToolbar = '<div id="toolbar"></div>';
                $toolbar = $startingToolbar;