lhc/web/wiklou.git
5 years agoMerge "resourceloader: Support TestModules registration via extension.json"
jenkins-bot [Wed, 6 Feb 2019 00:17:03 +0000 (00:17 +0000)]
Merge "resourceloader: Support TestModules registration via extension.json"

5 years agoMerge "Disallow user suppression in a partial block"
jenkins-bot [Tue, 5 Feb 2019 23:27:37 +0000 (23:27 +0000)]
Merge "Disallow user suppression in a partial block"

5 years agoresourceloader: Support TestModules registration via extension.json
Timo Tijhof [Fri, 18 Jan 2019 20:21:35 +0000 (12:21 -0800)]
resourceloader: Support TestModules registration via extension.json

Bug: T126091
Change-Id: I27ecebe27d7aaebe6d1317bc5eaea9cca368b45d

5 years agoDisallow user suppression in a partial block
Thalia [Mon, 14 Jan 2019 14:21:50 +0000 (14:21 +0000)]
Disallow user suppression in a partial block

Hide the "hide user" checkbox on Special:Block if the block
parameters specify a partial block. Return an error message
if a partial block with user suppression is specified via
the API. Also, make sure that an existing user suppression
is lifted if the user's block is reset to a partial block.

Bug: T210002
Change-Id: If42edfc85580d6bad6f4b397517e77e63deecc87

5 years agoResourceLoader: Add support for packageFiles
Roan Kattouw [Sat, 3 Nov 2018 00:53:17 +0000 (17:53 -0700)]
ResourceLoader: Add support for packageFiles

Package files are files that are part of a module, but are not
immediately executed when the module executes. Instead, they are
lazy-excecuted when require() is called on them. Package files can be
scripts (JS) or data (JSON), and can be real files on the file system,
or virtual files generated by a callback.

Using virtual data files, server-side data and config variables can be
bundled with a module. Support for file-based require() allows us to
import npm modules into ResourceLoader more easily.

The require function passed to each script execution context, which was
previously a reference to the global mw.loader.require() function, is
changed to one that is scoped to the module and the file being executed.
This is needed to support relative paths: require( '../foo.js' ) can
mean a different file depending on the path of the calling file.

The results of require()ing each file (i.e. the value of module.exports
after executing it) are stored, and calling require() on the same file a
second time won't execute it again, but will return the stored value.

Miscellaneous changes:
- Add XmlJsCode::encodeObject(), which combines an associative array of
  XmlJsCode objects into one larger XmlJsCode object. This is needed for
  encoding the packageFiles parameter in mw.loader.implement() calls.

Bug: T133462
Change-Id: I78cc86e626de0720397718cd2bed8ed279579112

5 years agoMerge "objectcache: avoid occasional test flakiness due to microtime()"
jenkins-bot [Tue, 5 Feb 2019 21:16:08 +0000 (21:16 +0000)]
Merge "objectcache: avoid occasional test flakiness due to microtime()"

5 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Tue, 5 Feb 2019 21:05:17 +0000 (22:05 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: I8431d4b4bd6c05fb77390e8b850edd88509fa41d

5 years agoMove interface ICacheHelper to own class
Umherirrender [Tue, 5 Feb 2019 19:04:12 +0000 (20:04 +0100)]
Move interface ICacheHelper to own class

Change-Id: I6f2b6507b0038f0988e4db5566ebddbe0d734a70

5 years agoMerge "ApiQuerySiteinfoTest: Conversion of $wgContLang to service"
jenkins-bot [Tue, 5 Feb 2019 17:49:05 +0000 (17:49 +0000)]
Merge "ApiQuerySiteinfoTest: Conversion of $wgContLang to service"

5 years agoMerge "Fix 'ipb_sitewide' not matching parent block after update"
jenkins-bot [Tue, 5 Feb 2019 14:01:53 +0000 (14:01 +0000)]
Merge "Fix 'ipb_sitewide' not matching parent block after update"

5 years agoMerge "Add option for confirmation prompts on rollbacks"
jenkins-bot [Tue, 5 Feb 2019 13:29:52 +0000 (13:29 +0000)]
Merge "Add option for confirmation prompts on rollbacks"

5 years agoMerge "Fix grammar of "config-db-host-help""
jenkins-bot [Tue, 5 Feb 2019 10:45:42 +0000 (10:45 +0000)]
Merge "Fix grammar of "config-db-host-help""

5 years agoMerge "Add BeforeResetNotificationTimestamp hook"
jenkins-bot [Tue, 5 Feb 2019 09:00:42 +0000 (09:00 +0000)]
Merge "Add BeforeResetNotificationTimestamp hook"

5 years agoAdd BeforeResetNotificationTimestamp hook
James Montalvo [Fri, 16 Nov 2018 00:09:11 +0000 (18:09 -0600)]
Add BeforeResetNotificationTimestamp hook

Allows prevention of clearing of notification timestamp when a user
views a page in their watchlist.

Change-Id: Id0af5c89c648ac6dce80012a1566426d5552942f

5 years agoMerge "Move interface IJobSpecification to own file"
jenkins-bot [Tue, 5 Feb 2019 05:44:30 +0000 (05:44 +0000)]
Merge "Move interface IJobSpecification to own file"

5 years agoobjectcache: avoid occasional test flakiness due to microtime()
Aaron Schulz [Tue, 5 Feb 2019 05:35:42 +0000 (21:35 -0800)]
objectcache: avoid occasional test flakiness due to microtime()

* Fix the timestamps to static hard-coded values
* Force the timestamps before various get/set tests so they do not
  use the microtime() value either.
* Remove the direct and duplicated (causing further risk) microtime()
  calls from testGetWithSeveralCheckKeys().

Bug: T207247
Change-Id: Id30a8127f11501dbe54e075b6e9d18490353f4a5

5 years agoApiQuerySiteinfoTest: Conversion of $wgContLang to service
Fomafix [Tue, 5 Feb 2019 03:52:00 +0000 (04:52 +0100)]
ApiQuerySiteinfoTest: Conversion of $wgContLang to service

Bug: T200246
Change-Id: Ibdf07adc7a4cf28f0f9f48f18985651a379bc10c

5 years agoMerge "Display translatable images in wiki language on image pages"
jenkins-bot [Tue, 5 Feb 2019 02:14:14 +0000 (02:14 +0000)]
Merge "Display translatable images in wiki language on image pages"

5 years agoMerge "specialpage: Fix login crash caused by unknown language via ?uselang"
jenkins-bot [Tue, 5 Feb 2019 01:33:00 +0000 (01:33 +0000)]
Merge "specialpage: Fix login crash caused by unknown language via ?uselang"

5 years agoDisplay translatable images in wiki language on image pages
Max Semenik [Wed, 9 Jan 2019 20:48:02 +0000 (12:48 -0800)]
Display translatable images in wiki language on image pages

We currently show SVGs in default languages unless overridden with
lang=... URL parameter (and we have UI for setting it). This change
makes it display thumbnails in wiki language, if translation is available.

Bug: T210814
Change-Id: Ieb0b5e9e27f45b71ef119bb3c1d3f2cd4d7100e5

5 years agoFix 'ipb_sitewide' not matching parent block after update
Dayllan Maza [Mon, 4 Feb 2019 22:31:55 +0000 (17:31 -0500)]
Fix 'ipb_sitewide' not matching parent block after update

Autoblocks ipb_sitewide was not being updated when changing the parent
block from sitewide to partial and vice-versa

Bug: T215205
Change-Id: Ied5a8361a733c47f0afea78cc955732261ede446

5 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Mon, 4 Feb 2019 20:56:39 +0000 (21:56 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: Ib354beb08668e1afe72246f382dc9e4396e96fea

5 years agoMove interface IJobSpecification to own file
Umherirrender [Mon, 4 Feb 2019 20:00:06 +0000 (21:00 +0100)]
Move interface IJobSpecification to own file

Change-Id: Iabb10f8473b2ef0f4aea2aaca0dad39745028ece

5 years agoMerge "Remove unused apihelp-createaccount messages"
jenkins-bot [Mon, 4 Feb 2019 19:44:36 +0000 (19:44 +0000)]
Merge "Remove unused apihelp-createaccount messages"

5 years agoRemove unused apihelp-createaccount messages
Umherirrender [Mon, 4 Feb 2019 18:53:57 +0000 (19:53 +0100)]
Remove unused apihelp-createaccount messages

Unused since I2b2c9693a275fcc026916bd97f303e7a5c8df341

Change-Id: Iaaadaef063ead5d2aa30d4e943ba72e4f4dfbf9a

5 years agoUse shorter ?: syntax in Revision class
Thiemo Kreuz [Wed, 9 Jan 2019 15:49:25 +0000 (16:49 +0100)]
Use shorter ?: syntax in Revision class

This is semantically the same because the returned object can't be
anything but an object (which can never be false), or null. Personlly,
I find the more expressive "=== null" check does not help here, but
makes the code a little harder to read.

Change-Id: Ib7390a7680f24fec7f5b9cea716603c14ad3f2dd

5 years agoMerge "Added future compat expectException to PHPUnit4And6Compat trait"
jenkins-bot [Mon, 4 Feb 2019 17:57:06 +0000 (17:57 +0000)]
Merge "Added future compat expectException to PHPUnit4And6Compat trait"

5 years agoMerge "Prevent undesired toggling on Special:NewPages"
jenkins-bot [Mon, 4 Feb 2019 17:57:00 +0000 (17:57 +0000)]
Merge "Prevent undesired toggling on Special:NewPages"

5 years agoAdd option for confirmation prompts on rollbacks
Tim Eulitz [Mon, 4 Feb 2019 15:32:52 +0000 (16:32 +0100)]
Add option for confirmation prompts on rollbacks

By default this option will be enabled in core, however, the option will
be overriden by a separate commit to mediawiki-config where it will be
disabled for all wikis for now.

Bug: T215019
Change-Id: I73f060fc954abb6ec02238b16c8598dd6ebd4ae4

5 years agoAdded future compat expectException to PHPUnit4And6Compat trait
Leszek Manicki [Wed, 30 Jan 2019 16:55:18 +0000 (17:55 +0100)]
Added future compat expectException to PHPUnit4And6Compat trait

This allows PHPUnit 6 ready tests asserting
the exception that is to be thrown (as setExpectedException
is removed in PHPUnit 6).

Bug: T208389
Change-Id: I13c58f37671092583a7fdfed7ccee9c2a4ecb136

5 years agoMerge "watcheditem: Replace error message strings with constant string"
jenkins-bot [Mon, 4 Feb 2019 10:08:04 +0000 (10:08 +0000)]
Merge "watcheditem: Replace error message strings with constant string"

5 years agoMerge "Equialization of Serbian Latin translations with Serbian Cyrillic translations"
jenkins-bot [Mon, 4 Feb 2019 07:03:56 +0000 (07:03 +0000)]
Merge "Equialization of Serbian Latin translations with Serbian Cyrillic translations"

5 years agoMerge "objectcache: avoid duplicate set() calls with lockTSE when no value is in...
jenkins-bot [Sun, 3 Feb 2019 22:04:26 +0000 (22:04 +0000)]
Merge "objectcache: avoid duplicate set() calls with lockTSE when no value is in cache"

5 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Sun, 3 Feb 2019 20:56:18 +0000 (21:56 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: Ic00ccbd3487d1861d3196670792ec529d1f81f73

5 years agoMerge "Add @coversNothing for left over tests and enable sniff"
jenkins-bot [Sun, 3 Feb 2019 20:28:49 +0000 (20:28 +0000)]
Merge "Add @coversNothing for left over tests and enable sniff"

5 years agoMerge "Add some missing @covers tags"
jenkins-bot [Sun, 3 Feb 2019 20:28:43 +0000 (20:28 +0000)]
Merge "Add some missing @covers tags"

5 years agoMerge "Title: Add null to @return type for getSubpage"
jenkins-bot [Sun, 3 Feb 2019 17:55:10 +0000 (17:55 +0000)]
Merge "Title: Add null to @return type for getSubpage"

5 years agoTitle: Add null to @return type for getSubpage
Fomafix [Sun, 3 Feb 2019 17:08:40 +0000 (18:08 +0100)]
Title: Add null to @return type for getSubpage

Title::makeTitleSafe can return null on an invalid title. Therefor
Title::getSubpage can also return null on an error.

Change-Id: I8f7d5125bd8bd609b6120b0f7682c6e519063476

5 years agoFix @param tags
Fomafix [Wed, 30 Jan 2019 20:24:06 +0000 (21:24 +0100)]
Fix @param tags

* Use 'callable' instead of 'callback'.
* Remove '$' as part of a type name.
* Add missing type.

Change-Id: Ic1b39a7d8cbbee000d8fb2f3a1f71a621bd01993

5 years agoPrevent undesired toggling on Special:NewPages
Matěj Suchánek [Sun, 3 Feb 2019 12:17:04 +0000 (13:17 +0100)]
Prevent undesired toggling on Special:NewPages

Bug: T211549
Change-Id: I09928674c66a6359a417a221049259cb318dd00a

5 years agoFinish FormatJson::encode() test coverage
Kunal Mehta [Sun, 3 Feb 2019 05:42:31 +0000 (21:42 -0800)]
Finish FormatJson::encode() test coverage

Change-Id: I3aced17da653216de2092e1d7986748c271c5b82

5 years agoAdd @coversNothing for left over tests and enable sniff
Umherirrender [Fri, 1 Feb 2019 19:46:59 +0000 (20:46 +0100)]
Add @coversNothing for left over tests and enable sniff

LessFileCompilationTest is checking less files for valid syntax
doc test is checking xml file for valid syntax
MediaWikiTest is testing a complex situation with many functions involved
SideBarTest is self checking, needs no coverage
structure tests not covers functions, there are covers global structures

Change-Id: I3ac65db561cae0be8418aa9c830e7a9f46ad11fe

5 years agoAdd some missing @covers tags
Kunal Mehta [Wed, 30 Jan 2019 08:23:48 +0000 (00:23 -0800)]
Add some missing @covers tags

Change-Id: Idb9af9515702ee9748755d7799663713b2283647

5 years agoobjectcache: avoid duplicate set() calls with lockTSE when no value is in cache
Aaron Schulz [Sun, 3 Feb 2019 02:13:17 +0000 (18:13 -0800)]
objectcache: avoid duplicate set() calls with lockTSE when no value is in cache

Each thread will still run the callback, but only one will save the value back

Bug: T203786
Change-Id: Idc4738aa005cc44ec0f1adc6dcf2e3f87d0c9480

5 years agoMerge "Add missing @covers to media related tests"
jenkins-bot [Sat, 2 Feb 2019 23:44:56 +0000 (23:44 +0000)]
Merge "Add missing @covers to media related tests"

5 years agoMerge "Add missing @covers to revision related tests"
jenkins-bot [Sat, 2 Feb 2019 23:39:36 +0000 (23:39 +0000)]
Merge "Add missing @covers to revision related tests"

5 years agoMerge "Add missing @covers to search related tests"
jenkins-bot [Sat, 2 Feb 2019 23:39:32 +0000 (23:39 +0000)]
Merge "Add missing @covers to search related tests"

5 years agoMerge "Add missing @covers to action related tests"
jenkins-bot [Sat, 2 Feb 2019 23:25:48 +0000 (23:25 +0000)]
Merge "Add missing @covers to action related tests"

5 years agoMerge "Add missing @covers to user related tests"
jenkins-bot [Sat, 2 Feb 2019 23:25:42 +0000 (23:25 +0000)]
Merge "Add missing @covers to user related tests"

5 years agoMerge "Add missing @covers to backend related tests"
jenkins-bot [Sat, 2 Feb 2019 23:20:26 +0000 (23:20 +0000)]
Merge "Add missing @covers to backend related tests"

5 years agoMerge "Add missing @covers to parser related tests"
jenkins-bot [Sat, 2 Feb 2019 23:20:21 +0000 (23:20 +0000)]
Merge "Add missing @covers to parser related tests"

5 years agoMerge "Add missing @covers to database related tests"
jenkins-bot [Sat, 2 Feb 2019 23:15:49 +0000 (23:15 +0000)]
Merge "Add missing @covers to database related tests"

5 years agoMerge "build: Update eslint-config-wikimedia to 0.10.1"
jenkins-bot [Sat, 2 Feb 2019 21:44:50 +0000 (21:44 +0000)]
Merge "build: Update eslint-config-wikimedia to 0.10.1"

5 years agoPrevent special block test failures with certain configs
Thalia [Sat, 2 Feb 2019 04:47:58 +0000 (20:47 -0800)]
Prevent special block test failures with certain configs

The checkbox for preventing a user from editing their own talk
page is only present for partial blocks if wgBlockAllowsUTEdit
is true, so set it to true for any tests that check for its
presence.

Change-Id: I0228f5787ad17130cbe015641c1142a7e52cef38

5 years agobuild: Update eslint-config-wikimedia to 0.10.1
Ed Sanders [Sat, 2 Feb 2019 19:05:04 +0000 (11:05 -0800)]
build: Update eslint-config-wikimedia to 0.10.1

Change-Id: Id98af16c1ec1c6c4a790948a35e96e2fe925ebb5

5 years agoEquialization of Serbian Latin translations with Serbian Cyrillic translations
Zoranzoki21 [Sat, 2 Feb 2019 15:35:29 +0000 (16:35 +0100)]
Equialization of Serbian Latin translations with Serbian Cyrillic translations

This was done already before at I3c79ded77f16beee404ca3005ae7678838ab9d60

Change-Id: I09e704d3051a6177f5f41eff8c8085e85ef4e02a

5 years agoMerge "Preload styles for 'jquery.tablesorter'"
jenkins-bot [Sat, 2 Feb 2019 04:14:07 +0000 (04:14 +0000)]
Merge "Preload styles for 'jquery.tablesorter'"

5 years agoMerge "Soft deprecate QuickTemplate::msgWiki()"
jenkins-bot [Fri, 1 Feb 2019 21:40:14 +0000 (21:40 +0000)]
Merge "Soft deprecate QuickTemplate::msgWiki()"

5 years agoMerge "Move interface ILocalizedException to own file"
jenkins-bot [Fri, 1 Feb 2019 21:38:42 +0000 (21:38 +0000)]
Merge "Move interface ILocalizedException to own file"

5 years agoMerge "Check for intl extension in updateCredits.php"
jenkins-bot [Fri, 1 Feb 2019 21:35:43 +0000 (21:35 +0000)]
Merge "Check for intl extension in updateCredits.php"

5 years agoAdd missing @covers to search related tests
Umherirrender [Fri, 1 Feb 2019 20:57:58 +0000 (21:57 +0100)]
Add missing @covers to search related tests

Change-Id: Iba122ad763a5728a7ddb487b3d01d679de6845e5

5 years agoSoft deprecate QuickTemplate::msgWiki()
Thiemo Kreuz [Mon, 14 Jan 2019 13:43:29 +0000 (14:43 +0100)]
Soft deprecate QuickTemplate::msgWiki()

This method just should not exist. It does have a bad name that does not
say much about what it does and how it is supposed to be used. And it
does horrible things: it accesses the global $wgOut, which currently
results in test failures, see
https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php70-docker/15200/console

Note how it was marked as @private, which is honorable, but doesn't
work for multiple reasons. First, an overload exists in the BaseTemplate
subclass. Second, calls from external code exist. Third, if it would be
really private, it could as well be deleted, because there is no private
caller.

Luckily the number of callers is extremely close to zero, see
https://codesearch.wmflabs.org/search/?q=>msgWiki%5C(

A patch for the Collection extension already exists.

Change-Id: I8d2c14f10fbf314735d1aa82bdc8edfb4fa9a0dd

5 years agoAdd missing @covers to user related tests
Umherirrender [Fri, 1 Feb 2019 19:44:21 +0000 (20:44 +0100)]
Add missing @covers to user related tests

Change-Id: Icebd692a37108e3c637648213896ededa588cecd

5 years agoAdd missing @covers to media related tests
Umherirrender [Fri, 1 Feb 2019 20:34:31 +0000 (21:34 +0100)]
Add missing @covers to media related tests

Change-Id: Ideb4fcf4e0c55c3720557b3d93eec06f671b3fd9

5 years agoAdd missing @covers to parser related tests
Umherirrender [Fri, 1 Feb 2019 20:48:33 +0000 (21:48 +0100)]
Add missing @covers to parser related tests

Change-Id: I615ba41c9a6f235f65991549cb27003438115fe9

5 years agoAdd missing @covers to revision related tests
Umherirrender [Fri, 1 Feb 2019 19:53:33 +0000 (20:53 +0100)]
Add missing @covers to revision related tests

Change-Id: Id95369208e988c16d626ca6f986898e3e84e8565

5 years agoAdd missing @covers to action related tests
Umherirrender [Fri, 1 Feb 2019 21:13:32 +0000 (22:13 +0100)]
Add missing @covers to action related tests

Change-Id: I7653b5fa6f6a3c247f735ac22fda12e7c9549786

5 years agoAdd missing @covers to backend related tests
Umherirrender [Fri, 1 Feb 2019 21:08:32 +0000 (22:08 +0100)]
Add missing @covers to backend related tests

Change-Id: I6ecbedf7d4f6c48b4f17331c31588f2c8b772054

5 years agoAdd missing @covers to database related tests
Umherirrender [Fri, 1 Feb 2019 19:59:16 +0000 (20:59 +0100)]
Add missing @covers to database related tests

Change-Id: I370275bb6c5d456b73f6a5f782e231f16c2b0fbe

5 years agoMerge "Remove require_once from maintenance tests"
jenkins-bot [Fri, 1 Feb 2019 19:08:36 +0000 (19:08 +0000)]
Merge "Remove require_once from maintenance tests"

5 years agoMove interface ILocalizedException to own file
Umherirrender [Fri, 1 Feb 2019 19:05:30 +0000 (20:05 +0100)]
Move interface ILocalizedException to own file

Change-Id: I66429a89633a74a22999775214aa23ae189b837e

5 years agoCheck for intl extension in updateCredits.php
Umherirrender [Fri, 1 Feb 2019 18:57:56 +0000 (19:57 +0100)]
Check for intl extension in updateCredits.php

Change-Id: Ifa2892b2f38fa73362c3ac60e1d90614cdbc0a93

5 years agoRemove require_once from maintenance tests
Umherirrender [Fri, 1 Feb 2019 18:45:12 +0000 (19:45 +0100)]
Remove require_once from maintenance tests

class FetchText and TextPassDumper part of autoloader

Change-Id: I307a9ac002d09e8fe05385e57d525055f5cb0b8a

5 years agoRename CategoryChangesRdfTest to match maintenance script
Umherirrender [Fri, 1 Feb 2019 18:40:22 +0000 (19:40 +0100)]
Rename CategoryChangesRdfTest to match maintenance script

Change-Id: Ib0ab880653f90df608d89a5f85c9949b380abe33

5 years agowatcheditem: Replace error message strings with constant string
Derick Alangi [Fri, 1 Feb 2019 15:55:29 +0000 (16:55 +0100)]
watcheditem: Replace error message strings with constant string

As the messages are the same and in addition using the same class
DBReadOnlyError, make the error message a constant and pass it as
self::DB_READONLY_ERROR argument to this class. Changing the error
will apply to the class as intended rather than change it in each
single place that this string appears.

Change-Id: I7f978cc334020746b4c4405fa2a0a73219bdacac

5 years agoMerge "Remove Revision::fetchRevision()"
jenkins-bot [Thu, 31 Jan 2019 22:43:20 +0000 (22:43 +0000)]
Merge "Remove Revision::fetchRevision()"

5 years agoUpdate type hints and documentation of RevisionDeleteUser
Thiemo Kreuz [Wed, 2 Jan 2019 09:30:34 +0000 (10:30 +0100)]
Update type hints and documentation of RevisionDeleteUser

Technically unrelated, but motivated by Ib59cf77.

Change-Id: I54cb9c396552d6982f5ca8463e00a0769e60a291

5 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Thu, 31 Jan 2019 20:53:43 +0000 (21:53 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: Ie2c639a0adbb91dc68109e58b6d74263e8ae0f0c

5 years agoFix grammar of "config-db-host-help"
Matěj Suchánek [Thu, 31 Jan 2019 20:32:43 +0000 (21:32 +0100)]
Fix grammar of "config-db-host-help"

Change-Id: Ie95baf3de0ff8221c6502d4d77c616b278586447

5 years agolanguages: Fix some soft type hints in the Language class
Thiemo Kreuz [Thu, 31 Jan 2019 11:26:13 +0000 (12:26 +0100)]
languages: Fix some soft type hints in the Language class

Change-Id: Ic9ffbc79c6932db97175d0a1da75df45ba3455e0

5 years agoMerge "Correct whitespace and parentheses typos in BlockLogFormatter"
jenkins-bot [Thu, 31 Jan 2019 14:50:49 +0000 (14:50 +0000)]
Merge "Correct whitespace and parentheses typos in BlockLogFormatter"

5 years agoMerge "Fix documentation for RevisionRecord::$mPageId"
jenkins-bot [Thu, 31 Jan 2019 11:59:42 +0000 (11:59 +0000)]
Merge "Fix documentation for RevisionRecord::$mPageId"

5 years agoCorrect whitespace and parentheses typos in BlockLogFormatter
Thalia [Thu, 31 Jan 2019 06:17:18 +0000 (22:17 -0800)]
Correct whitespace and parentheses typos in BlockLogFormatter

Change-Id: I9e79e9d274e8ed1fa94966f5e1ac01f8fcd6d96b

5 years agoMerge "Avoid making master connection from Skin::getUndeleteLink"
jenkins-bot [Thu, 31 Jan 2019 01:38:43 +0000 (01:38 +0000)]
Merge "Avoid making master connection from Skin::getUndeleteLink"

5 years agoMerge "build: Don't install symfony/polyfill-* that we require"
jenkins-bot [Thu, 31 Jan 2019 01:32:51 +0000 (01:32 +0000)]
Merge "build: Don't install symfony/polyfill-* that we require"

5 years agoMerge "docs: Remove 'code-coverage' placeholder directory"
jenkins-bot [Thu, 31 Jan 2019 00:01:57 +0000 (00:01 +0000)]
Merge "docs: Remove 'code-coverage' placeholder directory"

5 years agoMerge "Remove deprecated wgEnableParserCache"
jenkins-bot [Thu, 31 Jan 2019 00:00:50 +0000 (00:00 +0000)]
Merge "Remove deprecated wgEnableParserCache"

5 years agoRemove Revision::fetchRevision()
Max Semenik [Wed, 30 Jan 2019 23:08:56 +0000 (15:08 -0800)]
Remove Revision::fetchRevision()

Deprecated in 1.28, hard deprecated since 1.31. No callers, never had
callers outside of core.

Change-Id: I39721d12ad0d221931d23f2807f0a87cf05f0e3a

5 years agoMerge "RemexCompatMunger: Don't split p-wrapping on style/link tags"
jenkins-bot [Wed, 30 Jan 2019 23:39:34 +0000 (23:39 +0000)]
Merge "RemexCompatMunger: Don't split p-wrapping on style/link tags"

5 years agoMerge "Password: replace equals() with verify()"
jenkins-bot [Wed, 30 Jan 2019 23:04:08 +0000 (23:04 +0000)]
Merge "Password: replace equals() with verify()"

5 years agoAvoid making master connection from Skin::getUndeleteLink
Thalia [Wed, 30 Jan 2019 22:32:52 +0000 (14:32 -0800)]
Avoid making master connection from Skin::getUndeleteLink

Do this by calling Title:quickUserCan instead of Title::userCan
from Skin::getUndeleteLink.

Bug: T214735
Change-Id: I24dfd86275638e52012a5647ab3e5c848af840c2

5 years agoMerge "Localisation updates from https://translatewiki.net."
jenkins-bot [Wed, 30 Jan 2019 20:54:55 +0000 (20:54 +0000)]
Merge "Localisation updates from https://translatewiki.net."

5 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Wed, 30 Jan 2019 20:53:36 +0000 (21:53 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: If0c6e253be60e3b6b0b36f1281936b4719cb1eeb

5 years agoRemove a few obscure "done" and "empty" comments
Thiemo Kreuz [Wed, 9 Jan 2019 16:15:21 +0000 (17:15 +0100)]
Remove a few obscure "done" and "empty" comments

These don't add any knowledge to what is already obvious from the
code, I find.

Change-Id: Ia613b6a059f78dbeefdfd020899bd1a6e239a731

5 years agoRemexCompatMunger: Don't split p-wrapping on style/link tags
Brad Jorsch [Sun, 27 Jan 2019 22:13:10 +0000 (14:13 -0800)]
RemexCompatMunger: Don't split p-wrapping on style/link tags

<style> and <link> tags are metadata tags, they shouldn't split the <p>
tag when p-wrapping content.

Bug: T208901
Change-Id: I2ef5da68c9ccde4477d8295dfe4abf8497c5d26e

5 years agoRemove some exemptions that are no longer needed
Kunal Mehta [Wed, 30 Jan 2019 05:49:15 +0000 (21:49 -0800)]
Remove some exemptions that are no longer needed

Manually identified, it's possible that there are more.

Change-Id: Ifda5ecdb12915f4005161f1f98eae5f1162fbee1

5 years agoRequire ClassMatchesFilename sniff to pass for most of tests/
Kunal Mehta [Wed, 30 Jan 2019 05:47:05 +0000 (21:47 -0800)]
Require ClassMatchesFilename sniff to pass for most of tests/

phpunit-patch-coverage assumes that the filename matches the classname
as a performance optimization. And for most test cases, this is true. We
should enforce this with PHPCS, mostly to help developers not make
mistakes.

Test cases that have mock classes will need to ensure that the test case
class that matches the filename comes first, since that's the only class
the sniff will look at.

Tests in GlobalFunctions/ and maintenance/ are still exempted for now,
since they don't match yet.

Change-Id: Iede341504290f5ba2da1c81908069ba9d465600f

5 years agoRename FirejailCommandIntegrationTest to match class name
Kunal Mehta [Wed, 30 Jan 2019 07:56:46 +0000 (23:56 -0800)]
Rename FirejailCommandIntegrationTest to match class name

Change-Id: I581c0d95c38e6d22ab19d68e58e2f48c98b2379b

5 years agoRename UncategorizedCategoriesPageTest to match class name
Kunal Mehta [Wed, 30 Jan 2019 05:35:52 +0000 (21:35 -0800)]
Rename UncategorizedCategoriesPageTest to match class name

Change-Id: Iedf32a15e0a8cb79a2823ccffa3b486a38fb1dc6

5 years agoRename tests/phpunit/includes/media files to match class names
Kunal Mehta [Wed, 30 Jan 2019 05:35:11 +0000 (21:35 -0800)]
Rename tests/phpunit/includes/media files to match class names

The classes were renamed in 9bf39163, this updates the test cases to
match. Also take care of XCF while we're at it too.

Change-Id: Iaaeee93e496af6cdd610df5bc75302ecfe273f64