Remove dead code added in r36814

None of the constructors will set $this->mTitle but not $this->mName,
and those are both private member variables.  r69813 demonstrates that
no one had ever hit this code since it was first added in June 2008,
because it would have resulted in a fatal.

diff --git a/includes/Category.php b/includes/Category.php
index bbeb79b..44f266e 100644 (file)
--- a/includes/Category.php
+++ b/includes/Category.php
@@ -25,10 +25,6 @@ class Category {
         * @return bool True on success, false on failure.
         */
        protected function initialize() {
-               if ( $this->mName === null && $this->mTitle ) {
-                       $this->mName = $this->mTitle->getDBkey();
-               }
-
                if ( $this->mName === null && $this->mID === null ) {
                        throw new MWException( __METHOD__ . ' has both names and IDs null' );
                } elseif ( $this->mID === null ) {