From 9d7af3a00dd3eaf9a46ba0bb11b68a17031255f5 Mon Sep 17 00:00:00 2001 From: Aryeh Gregor Date: Tue, 27 Jul 2010 19:55:47 +0000 Subject: [PATCH] Remove dead code added in r36814 None of the constructors will set $this->mTitle but not $this->mName, and those are both private member variables. r69813 demonstrates that no one had ever hit this code since it was first added in June 2008, because it would have resulted in a fatal. --- includes/Category.php | 4 ---- 1 file changed, 4 deletions(-) diff --git a/includes/Category.php b/includes/Category.php index bbeb79b37f..44f266e9db 100644 --- a/includes/Category.php +++ b/includes/Category.php @@ -25,10 +25,6 @@ class Category { * @return bool True on success, false on failure. */ protected function initialize() { - if ( $this->mName === null && $this->mTitle ) { - $this->mName = $this->mTitle->getDBkey(); - } - if ( $this->mName === null && $this->mID === null ) { throw new MWException( __METHOD__ . ' has both names and IDs null' ); } elseif ( $this->mID === null ) { -- 2.20.1