lhc/web/wiklou.git
4 years agoRemove perf tracking code that was moved to WikimediaEvents in Ib300af5c
Roan Kattouw [Wed, 27 Sep 2017 22:57:29 +0000 (15:57 -0700)]
Remove perf tracking code that was moved to WikimediaEvents in Ib300af5c

Bug: T176652
Depends-On: Ib300af5caad5c6e0ca13554c20a2e4311743e176
Change-Id: I963431771556635ea3db28101470317ebd82906f

4 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Tue, 26 Sep 2017 19:57:23 +0000 (21:57 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: Idf6479521c3219958d6e50941b5876e735e9cf9b

4 years agoMerge "Make mw.widget.TitleWidget more flexible"
jenkins-bot [Tue, 26 Sep 2017 17:53:37 +0000 (17:53 +0000)]
Merge "Make mw.widget.TitleWidget more flexible"

4 years agoMerge "RCFilters: Log performance data"
jenkins-bot [Tue, 26 Sep 2017 17:25:47 +0000 (17:25 +0000)]
Merge "RCFilters: Log performance data"

4 years agoMake mw.widget.TitleWidget more flexible
Ed Sanders [Tue, 26 Sep 2017 16:31:38 +0000 (17:31 +0100)]
Make mw.widget.TitleWidget more flexible

* Factor out #createOptionWidget so different option
  widget subclasses can be constructed
* Factor out #getApiParams so extra data can be fetched
  from the API
* Pass through raw API data to pageData, so extra API
  data can be used in option widgets

Change-Id: I150c513e4144ad5b57643e98dd48866ce2d37850

4 years agoMerge "RCFilters: Also set toplinks-collapsed class if no cookie"
jenkins-bot [Tue, 26 Sep 2017 13:39:12 +0000 (13:39 +0000)]
Merge "RCFilters: Also set toplinks-collapsed class if no cookie"

4 years agoMerge "RCFilters: Cache ChangesListSpecialPage::buildChangeTagList()"
jenkins-bot [Tue, 26 Sep 2017 01:50:10 +0000 (01:50 +0000)]
Merge "RCFilters: Cache ChangesListSpecialPage::buildChangeTagList()"

4 years agoMerge "SpecialPages: Reduce selector specificity"
jenkins-bot [Mon, 25 Sep 2017 23:39:19 +0000 (23:39 +0000)]
Merge "SpecialPages: Reduce selector specificity"

4 years agoMerge "Allow two-queue style insertion in MapCacheLRU"
jenkins-bot [Mon, 25 Sep 2017 22:41:19 +0000 (22:41 +0000)]
Merge "Allow two-queue style insertion in MapCacheLRU"

4 years agoRCFilters: Log performance data
Roan Kattouw [Mon, 25 Sep 2017 22:28:47 +0000 (15:28 -0700)]
RCFilters: Log performance data

Just UI ready time and wgBackendResponseTime for now.
Sanitizing responseStart and especially firstPaint cross-browser
is too messy. NavigationTiming has code for it but that would
need to be exposed somewhere.

Bug: T176652
Change-Id: I6caf52fe8bc77fac0426d73549553301c5951c32

4 years agoRCFilters: Also set toplinks-collapsed class if no cookie
Roan Kattouw [Mon, 25 Sep 2017 21:50:04 +0000 (14:50 -0700)]
RCFilters: Also set toplinks-collapsed class if no cookie

If the cookie was not set, the PHP code treated that as
"expanded", but the JS code treated it as "collapsed".
Fix the PHP code.

Bug: T176380
Change-Id: Iff9b865bd20a571ade2ae619cbb5b3a70629003c

4 years agoGive thumbor swift user r/w access to containers
Gilles Dubuc [Wed, 6 Sep 2017 13:05:16 +0000 (15:05 +0200)]
Give thumbor swift user r/w access to containers

readUsers and writeUsers are new optional values
of the swift backend configuration. They allow
giving read and/or write rights to additional
users than the default swift user.

Bug: T144479
Change-Id: I0f81a013ec994eee3f156a89f29f4fcfc37c42b7

4 years agoAllow two-queue style insertion in MapCacheLRU
Aaron Schulz [Fri, 22 Sep 2017 16:26:50 +0000 (18:26 +0200)]
Allow two-queue style insertion in MapCacheLRU

Change-Id: I1cd98ea8965b51e43371efd990fb9302bb507928

4 years agoMerge "WLFilters: Live update and View newest"
jenkins-bot [Mon, 25 Sep 2017 21:06:45 +0000 (21:06 +0000)]
Merge "WLFilters: Live update and View newest"

4 years agoMerge "HTMLSelectAndOtherField/HTMLSelectOrOtherField: Change how ID is handled in...
jenkins-bot [Mon, 25 Sep 2017 20:18:04 +0000 (20:18 +0000)]
Merge "HTMLSelectAndOtherField/HTMLSelectOrOtherField: Change how ID is handled in OOUI mode"

4 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Mon, 25 Sep 2017 19:54:30 +0000 (21:54 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: Ic032757aa36350153e2df304b7636a4b66916f64

4 years agoMerge "Add print styles for gallery mode packed-hover"
jenkins-bot [Mon, 25 Sep 2017 19:49:56 +0000 (19:49 +0000)]
Merge "Add print styles for gallery mode packed-hover"

4 years agoRCFilters: Cache ChangesListSpecialPage::buildChangeTagList()
Roan Kattouw [Mon, 25 Sep 2017 19:39:12 +0000 (12:39 -0700)]
RCFilters: Cache ChangesListSpecialPage::buildChangeTagList()

Calling Message::parse() on 2 messages per tag (for 80+ tags)
is fairly expensive. It takes about 400ms in production, but
adding that to requests that normally take 150-400ms is a pretty
big hit.

Bug: T176652
Change-Id: I9114f69de8b18007735de3438809f5695e380738

4 years agoMerge "Block same-file reuploads"
jenkins-bot [Mon, 25 Sep 2017 19:22:53 +0000 (19:22 +0000)]
Merge "Block same-file reuploads"

4 years agoMerge "mw.special.preferences.timezone: Remove some very old unnecessary code"
jenkins-bot [Mon, 25 Sep 2017 19:14:46 +0000 (19:14 +0000)]
Merge "mw.special.preferences.timezone: Remove some very old unnecessary code"

4 years agoHTMLSelectAndOtherField/HTMLSelectOrOtherField: Change how ID is handled in OOUI...
Bartosz Dziewoński [Mon, 25 Sep 2017 18:49:51 +0000 (20:49 +0200)]
HTMLSelectAndOtherField/HTMLSelectOrOtherField: Change how ID is handled in OOUI mode

Set the ID on the main widget (mw.widgets.SelectWithInputWidget), so
that it can be infused by ID.

The dropdown/textbox by themselves can't be infused individually,
therefore IDs on them are pretty useless; remove those where they're
not necessary.

Follow-up to 8bd6605736c47259bd5f901284cbd2e639cef30c.

Change-Id: If54dd48f1000e3e0f5a978428a5b622797b4f765

4 years agoMerge "resourceloader: Remove deprecated MessageBlobStore::insertMessageBlob"
jenkins-bot [Mon, 25 Sep 2017 18:39:12 +0000 (18:39 +0000)]
Merge "resourceloader: Remove deprecated MessageBlobStore::insertMessageBlob"

4 years agomw.special.preferences.timezone: Remove some very old unnecessary code
Bartosz Dziewoński [Mon, 25 Sep 2017 18:34:30 +0000 (20:34 +0200)]
mw.special.preferences.timezone: Remove some very old unnecessary code

The first two removed blocks date to the pre-HTMLForm versions of the
preferences form (rSVN44915 / c672ce603272d5206f0967f70f2474b4c09ce43a),
where the dual dropdown/textbox field was implemented specially for
this form. Its behavior currently is handled by HTMLSelectOrOtherField
and selectorother.js, and this code is entirely unnecessary.

The third removed block was added as a workaround for an issue caused
by the second block, in e8d94f433c43982003fb0d008e1fc8ee04ed7744.
Looks like we didn't realize at the time that we can just delete the
buggy line.

This fixes a minor issue where no warning would be displayed when
exiting the preferences page without saving the changes after the user
changed the "Time zone" field from "Other" to "Fill in from the
browser" and the guessed value was different from the saved one.

Change-Id: I9b5317111aaf7f6039d476b263ee9e54c4b4cf52

4 years agoMerge "Unify monospace font family stack"
jenkins-bot [Mon, 25 Sep 2017 17:45:00 +0000 (17:45 +0000)]
Merge "Unify monospace font family stack"

4 years agoMerge "Update documentation for IApiMessage interface"
jenkins-bot [Mon, 25 Sep 2017 17:44:27 +0000 (17:44 +0000)]
Merge "Update documentation for IApiMessage interface"

4 years agoresourceloader: Remove deprecated MessageBlobStore::insertMessageBlob
Timo Tijhof [Mon, 25 Sep 2017 17:37:35 +0000 (18:37 +0100)]
resourceloader: Remove deprecated MessageBlobStore::insertMessageBlob

Deprecated since MediaWiki 1.27. No uses in Wikimedia Git.

Follows-up 5d5b269e0e63. (T113092)

Change-Id: I98c4db4fb0a3909d25d0fcd587e0f34391612423

4 years agoAdd print styles for gallery mode packed-hover
Cormac Parle [Mon, 25 Sep 2017 13:44:26 +0000 (14:44 +0100)]
Add print styles for gallery mode packed-hover

Bug: T140346
Change-Id: Ifd94706c427c6bb7577040bbfecfdc6a303e0d8b

4 years agoMerge "getConfiguration: Don't bail when a valid variable is set null"
jenkins-bot [Mon, 25 Sep 2017 16:30:57 +0000 (16:30 +0000)]
Merge "getConfiguration: Don't bail when a valid variable is set null"

4 years agoUpdate documentation for IApiMessage interface
Brad Jorsch [Mon, 25 Sep 2017 16:14:55 +0000 (12:14 -0400)]
Update documentation for IApiMessage interface

It was created for a specific purpose, and apparently this is confusing
some people who're inexplicably trying to implement it outside of that
purpose. So, this patch more clearly documents that purpose.

Change-Id: I638482327370522bedea1ec514ecbb9d98207382

4 years agoMerge "Make `ApiUploadTest` up to date so it passes"
jenkins-bot [Mon, 25 Sep 2017 16:11:01 +0000 (16:11 +0000)]
Merge "Make `ApiUploadTest` up to date so it passes"

4 years agoMerge "resourceloader: Implement isKnownEmpty for user.options module"
jenkins-bot [Mon, 25 Sep 2017 15:43:07 +0000 (15:43 +0000)]
Merge "resourceloader: Implement isKnownEmpty for user.options module"

4 years agoMerge "resourceloader: Support isKnownEmpty for general modules"
jenkins-bot [Mon, 25 Sep 2017 15:42:33 +0000 (15:42 +0000)]
Merge "resourceloader: Support isKnownEmpty for general modules"

4 years agoMerge "registration: Fix caching of load_composer_autoloader"
jenkins-bot [Mon, 25 Sep 2017 15:22:39 +0000 (15:22 +0000)]
Merge "registration: Fix caching of load_composer_autoloader"

4 years agoMerge "EditPage: Disable preview on open if $wgRawHtml is enabled"
jenkins-bot [Mon, 25 Sep 2017 15:07:40 +0000 (15:07 +0000)]
Merge "EditPage: Disable preview on open if $wgRawHtml is enabled"

4 years agoUnify monospace font family stack
Volker E [Mon, 25 Sep 2017 15:07:09 +0000 (16:07 +0100)]
Unify monospace font family stack

Bug: T176636
Change-Id: I4bab7f13b5bd641df9a2a9638e60e14951313d52

4 years agoMerge "WikiPage: Hard deprecate second arg of prepareContentForEdit() as an int"
jenkins-bot [Mon, 25 Sep 2017 14:51:39 +0000 (14:51 +0000)]
Merge "WikiPage: Hard deprecate second arg of prepareContentForEdit() as an int"

4 years agoWLFilters: Live update and View newest
Stephane Bisson [Thu, 21 Sep 2017 19:44:02 +0000 (15:44 -0400)]
WLFilters: Live update and View newest

Moved handling for 'from', 'days' and 'limit'
to base class (ChangesListSpecialPage)

I moved 'days' because its implementation
is related to 'from'.

I moved 'limit' because it was getting lonely
and it's identical in all cases.

Bug: T176348
Change-Id: If6280ad6fbad65909e1d0b2a48344e24d485aca2

4 years agoMerge "EditPage: Hard-deprecate isOouiEnabled(), getCheckboxes(), getCheckboxesOOUI()"
jenkins-bot [Sun, 24 Sep 2017 20:43:41 +0000 (20:43 +0000)]
Merge "EditPage: Hard-deprecate isOouiEnabled(), getCheckboxes(), getCheckboxesOOUI()"

4 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Sun, 24 Sep 2017 19:56:32 +0000 (21:56 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I690f31abfbbfaff56761bde38a0813d12c949f39

4 years agoMerge "RCFilters: Don't load all of OOUI"
jenkins-bot [Sun, 24 Sep 2017 14:57:00 +0000 (14:57 +0000)]
Merge "RCFilters: Don't load all of OOUI"

4 years agoEditPage: Disable preview on open if $wgRawHtml is enabled
Kunal Mehta [Sat, 23 Sep 2017 21:07:15 +0000 (14:07 -0700)]
EditPage: Disable preview on open if $wgRawHtml is enabled

Otherwise the user will see a session failure message since their
request wasn't posted with a token, which doesn't make sense since they
just clicked on an edit link.

Bug: T172251
Change-Id: Id4a20818c737886f5a7ec72dba52c531f1ba78a0

4 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Sat, 23 Sep 2017 19:58:19 +0000 (21:58 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I41d3d09b418676e2b1171c02ac72182455ba5e16

4 years agoSpecialPages: Reduce selector specificity
Volker E [Sat, 23 Sep 2017 15:54:03 +0000 (08:54 -0700)]
SpecialPages: Reduce selector specificity

Reducing unneeded selector specificity.

Change-Id: I96b46b4e8b267c239c9a2cb73f65848c9fff9be1

4 years agoSpecialPages: Align subtle and disabled text color to WikimediaUI palette
Volker E [Sat, 23 Sep 2017 15:28:00 +0000 (08:28 -0700)]
SpecialPages: Align subtle and disabled text color to WikimediaUI palette

Aligning ProtectedPages unknown and disabled user rights text colors
to WikimediaUI color palette and make them conforming to WCAG level AA.

Bug: T152025
Change-Id: Id10477f92dd8b43caa26659cb63352637b436bda

4 years agoMerge "HTMLForm: Do not generate wrappers for empty sections"
jenkins-bot [Sat, 23 Sep 2017 12:13:36 +0000 (12:13 +0000)]
Merge "HTMLForm: Do not generate wrappers for empty sections"

4 years agoregistration: Fix caching of load_composer_autoloader
Kunal Mehta [Sat, 23 Sep 2017 05:20:16 +0000 (22:20 -0700)]
registration: Fix caching of load_composer_autoloader

Move the file_exists() check out of the extension processor and into the
extension registry so that it is evaluated at run time instead of during
caching. The prior way is problematic since we don't invalidate the
cache if the existence of the file were to change.

Bug: T176534
Change-Id: I98e4ffdfac9f98397a103966824519afe1375356

4 years agoMerge "Use native ES5 Array prototype methods instead of jQuery"
jenkins-bot [Sat, 23 Sep 2017 00:03:02 +0000 (00:03 +0000)]
Merge "Use native ES5 Array prototype methods instead of jQuery"

4 years agoRCFilters: Don't load all of OOUI
Roan Kattouw [Fri, 22 Sep 2017 23:33:31 +0000 (16:33 -0700)]
RCFilters: Don't load all of OOUI

Just the widgets module is enough, we don't need
the windows or toolbars modules.

Change-Id: Ie8ce45f0d46fbc759d4579d619ab8c99c13cb0d5

4 years agoMerge "Improve "selfmove" message's wording"
jenkins-bot [Fri, 22 Sep 2017 21:59:38 +0000 (21:59 +0000)]
Merge "Improve "selfmove" message's wording"

4 years agoImprove "selfmove" message's wording
Egbe Eugene [Thu, 13 Jul 2017 20:40:15 +0000 (21:40 +0100)]
Improve "selfmove" message's wording

The error shown when a page is to be moved (renamed) with the same
title is not immediately obvious to the user, so use simpler
and clearer language.

Bug: T164987
Change-Id: I639c4ae27866234fed9bcc5f2afc4684155418f8

4 years agoUse native ES5 Array prototype methods instead of jQuery
Fomafix [Fri, 22 Sep 2017 04:46:40 +0000 (06:46 +0200)]
Use native ES5 Array prototype methods instead of jQuery

Replace
* $.each( array, function ( index, value ) { ... } ) by
  array.forEach( function ( value ) { ... } )

* $.grep( array, function ( value ) { ... } ) by
  array.filter( function ( value ) { ... } )

* $.map( array, function ( value ) { ... } ) by
  array.map( function ( value ) { ... } )

Change-Id: I985ddf710e13c9ae788245349e2791571aeec97e

4 years agoSpecialSearch: Fix unintended `margin` when zoom level is above 100%
Volker E [Fri, 22 Sep 2017 20:30:19 +0000 (13:30 -0700)]
SpecialSearch: Fix unintended `margin` when zoom level is above 100%

With zoom level > 100% on Firefox, `#mw-searchoptions` which is a
`fieldset` element adds unintended `margin` with negative `margin-top`
applied. This is a workaround for wrong browser behaviour and
regression of I4bda42c03a5.

Bug: T176499
Change-Id: I329f83e6063460dc11ff45583e335280c9257ef7

4 years agoMerge "Remove duplicate release note for $wgOOUIEditPage removal"
jenkins-bot [Fri, 22 Sep 2017 20:10:10 +0000 (20:10 +0000)]
Merge "Remove duplicate release note for $wgOOUIEditPage removal"

4 years agoMerge "EditPage: Mark getSubmitButtonLabel() as @since 1.30"
jenkins-bot [Fri, 22 Sep 2017 20:06:48 +0000 (20:06 +0000)]
Merge "EditPage: Mark getSubmitButtonLabel() as @since 1.30"

4 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Fri, 22 Sep 2017 19:56:06 +0000 (21:56 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: If2bdcb141ae02cc0c5324a9a1b10440edf1f6235

4 years agoRemove duplicate release note for $wgOOUIEditPage removal
Kunal Mehta [Fri, 22 Sep 2017 19:52:35 +0000 (12:52 -0700)]
Remove duplicate release note for $wgOOUIEditPage removal

And capitalize Unicode properly.

Follows-up b2441fc57d6e.

Change-Id: I2d68ff1abb0497eae046bd984d2a182066956325

4 years agoEditPage: Mark getSubmitButtonLabel() as @since 1.30
Kunal Mehta [Fri, 22 Sep 2017 19:51:20 +0000 (12:51 -0700)]
EditPage: Mark getSubmitButtonLabel() as @since 1.30

Change-Id: I801e98b9f42636a46cdfa5cf7de4de2b59f9e46d

4 years agoMake `ApiUploadTest` up to date so it passes
Aleksey Bekh-Ivanov (WMDE) [Fri, 22 Sep 2017 18:49:03 +0000 (20:49 +0200)]
Make `ApiUploadTest` up to date so it passes

Although the test is still might fail from time to time
and needs refactoring.

Bug: T28169
Change-Id: Ib27a36e0d76495a133eb8941300e4940e5eb670e

4 years agoMerge "Remove use of MWException in MapCacheLRU"
jenkins-bot [Fri, 22 Sep 2017 18:27:23 +0000 (18:27 +0000)]
Merge "Remove use of MWException in MapCacheLRU"

4 years agoMerge "RCFilters: Make 'lastRevision' filter include non-rev types"
jenkins-bot [Fri, 22 Sep 2017 17:52:13 +0000 (17:52 +0000)]
Merge "RCFilters: Make 'lastRevision' filter include non-rev types"

4 years agoMerge "RCFilters: Make live update polling configurable"
jenkins-bot [Fri, 22 Sep 2017 17:38:59 +0000 (17:38 +0000)]
Merge "RCFilters: Make live update polling configurable"

4 years agoMerge "RCFilters: remove wgStructuredChangeFiltersEnableExperimentalViews"
jenkins-bot [Fri, 22 Sep 2017 17:35:07 +0000 (17:35 +0000)]
Merge "RCFilters: remove wgStructuredChangeFiltersEnableExperimentalViews"

4 years agoRCFilters: Make live update polling configurable
Stephane Bisson [Thu, 21 Sep 2017 20:43:23 +0000 (16:43 -0400)]
RCFilters: Make live update polling configurable

Introducing $wgStructuredChangeFiltersLiveUpdatePollingRate
to configure the polling rate for live update.

Allows disabling polling completely by setting it to 0.

Change-Id: I13d3a4bb642c55a16e442f8f8d650c637f13f72c

4 years agoMerge "RCFilters: restore watch/unwatch link"
jenkins-bot [Fri, 22 Sep 2017 17:17:53 +0000 (17:17 +0000)]
Merge "RCFilters: restore watch/unwatch link"

4 years agoMerge "EditPage: Avoid unnecessary calls to Article::getContext()"
jenkins-bot [Fri, 22 Sep 2017 16:21:26 +0000 (16:21 +0000)]
Merge "EditPage: Avoid unnecessary calls to Article::getContext()"

4 years agoRemove use of MWException in MapCacheLRU
Aaron Schulz [Fri, 22 Sep 2017 15:38:46 +0000 (17:38 +0200)]
Remove use of MWException in MapCacheLRU

Change-Id: I830555ffcb1b50bdc54e552daa469e2c5e00611d

4 years agoMerge "RCFilters: Start the toplinks collapsed/expanded by cookie value"
jenkins-bot [Fri, 22 Sep 2017 10:55:34 +0000 (10:55 +0000)]
Merge "RCFilters: Start the toplinks collapsed/expanded by cookie value"

4 years agoRCFilters: restore watch/unwatch link
Stephane Bisson [Fri, 22 Sep 2017 10:35:58 +0000 (06:35 -0400)]
RCFilters: restore watch/unwatch link

Use jQuery event delegation to handle all
present and future watch/unwatch links.

Bug: T176264
Change-Id: If372c480e3e3809485027744b99caa6d4c94f86a

4 years agoEditPage: Avoid unnecessary calls to Article::getContext()
Kunal Mehta [Fri, 22 Sep 2017 09:05:15 +0000 (02:05 -0700)]
EditPage: Avoid unnecessary calls to Article::getContext()

Change-Id: I18a7f3b3eb1a9b18ea6ca20ad43878f4740f4e47

4 years agoAdd release notes for EditPage changes in 1.30
Kunal Mehta [Fri, 22 Sep 2017 09:20:19 +0000 (02:20 -0700)]
Add release notes for EditPage changes in 1.30

Change-Id: I42368cd97a2b25fb5d31c551442a527465157ce8

4 years agoRCFilters: Start the toplinks collapsed/expanded by cookie value
Moriel Schottlender [Thu, 21 Sep 2017 23:15:47 +0000 (16:15 -0700)]
RCFilters: Start the toplinks collapsed/expanded by cookie value

Prevent "jumping" of the content by initializing the top links already
collapsed or expanded depending on the cookie value.

Bug: T176380
Change-Id: I6c494b42ec6f029b60182607faa37feba062b597

4 years agoMerge "mw.loader: Simplify getVersion and getState"
jenkins-bot [Fri, 22 Sep 2017 00:16:32 +0000 (00:16 +0000)]
Merge "mw.loader: Simplify getVersion and getState"

4 years agomw.loader: Simplify getVersion and getState
Timo Tijhof [Thu, 21 Sep 2017 23:10:45 +0000 (00:10 +0100)]
mw.loader: Simplify getVersion and getState

This undefined check no longer makes sense since there are now
defaults for these in register(). There is no supported scenario
in which a module would have a key in the registry but not
have these properties defined, or have them defined with
the undefined value.

Change-Id: I945871861ccf3659c2d7dd021aa87dfd747f22b9

4 years agoresourceloader: Use ES5 Array#filter instead of jQuery.grep
Timo Tijhof [Thu, 21 Sep 2017 22:31:48 +0000 (23:31 +0100)]
resourceloader: Use ES5 Array#filter instead of jQuery.grep

Same or better performance in Chrome Canary and latest WebKit.
Further reduces reliance on jQuery in base module.

Change-Id: I691b73b837178b76cff665cbd52f5e5067672a6e

4 years agoRCFilters: remove wgStructuredChangeFiltersEnableExperimentalViews
Stephane Bisson [Thu, 21 Sep 2017 20:24:38 +0000 (16:24 -0400)]
RCFilters: remove wgStructuredChangeFiltersEnableExperimentalViews

Not used anymore.

Change-Id: I1afe736db76eef6ddae5c602d8e24fddfd807a3a

4 years agoRCFilters: Make 'lastRevision' filter include non-rev types
Stephane Bisson [Thu, 21 Sep 2017 20:17:22 +0000 (16:17 -0400)]
RCFilters: Make 'lastRevision' filter include non-rev types

Make 'lastRevision' filter behave like its predecessor (expanded)
by including the non-rev types (RC_LOG and others added via hook).

Bug: T176328
Change-Id: I2312fd536716f0b07637ed4caf225650a4ffe70c

4 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Thu, 21 Sep 2017 20:05:48 +0000 (22:05 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I4587d08701d8d44621e69077ef4a1b1fcce09025

4 years agogetConfiguration: Don't bail when a valid variable is set null
Erik Bernhardson [Thu, 21 Sep 2017 19:18:57 +0000 (12:18 -0700)]
getConfiguration: Don't bail when a valid variable is set null

isset() will return false with a value is null. Null is an acceptable
result for a configuration variable, so switch to array_key_exists.

Change-Id: I11a3feb07d2bdc7ee30975014db29365086f89bc

4 years agoMerge "RCFilters: Use findRelativeSelectableItem instead of getRelativeSelectableitem"
jenkins-bot [Thu, 21 Sep 2017 18:21:19 +0000 (18:21 +0000)]
Merge "RCFilters: Use findRelativeSelectableItem instead of getRelativeSelectableitem"

4 years agoMerge "apisandbox.js: Use findFirstSelectableitem instead of getFirstSelectableItem"
jenkins-bot [Thu, 21 Sep 2017 18:14:24 +0000 (18:14 +0000)]
Merge "apisandbox.js: Use findFirstSelectableitem instead of getFirstSelectableItem"

4 years agoMerge "RCFilters: Make the interface not jump around while loading"
jenkins-bot [Thu, 21 Sep 2017 18:03:34 +0000 (18:03 +0000)]
Merge "RCFilters: Make the interface not jump around while loading"

4 years agoMerge "WLFilters: Don't hide .watchlistDetails while loading"
jenkins-bot [Thu, 21 Sep 2017 18:00:33 +0000 (18:00 +0000)]
Merge "WLFilters: Don't hide .watchlistDetails while loading"

4 years agoMerge "Clean up X-Content-Dimensions"
jenkins-bot [Thu, 21 Sep 2017 17:36:57 +0000 (17:36 +0000)]
Merge "Clean up X-Content-Dimensions"

4 years agoClean up X-Content-Dimensions
Gilles Dubuc [Thu, 21 Sep 2017 13:17:10 +0000 (15:17 +0200)]
Clean up X-Content-Dimensions

Bug: T175689
Change-Id: I20d93afd85b4d35c67c60193fa3026cebde71b0e

4 years agoRCFilters: Make the interface not jump around while loading
Roan Kattouw [Thu, 21 Sep 2017 00:11:22 +0000 (17:11 -0700)]
RCFilters: Make the interface not jump around while loading

* Move the "show new changes" widget into the .rcfilters-head container
** It doesn't conceptually belong here, but this way the min-height
   trick can capture it
* Increase the min-height to account for "show new changes" and drift
* Set a different (higher) min-height on the watchlist
* Adjust the loading spinner position to account for "show new changes" having moved
* Don't apply a margin-top to the first table in WatchlistTopSectionWidget,
  only the second one
* Make .watchlistDetails float while loading
** This is because it starts outside rcfilters-head but is then moved into it.
   Floating it makes it not take any space, which makes the min-height math
   a lot easier (and tolerant to taller .watchlistDetails divs like on enwiki)
* Don't remove the margin and padding from the first h4, this causes jumpiness
** This does increase whitespace slightly, if we want to fix that we could
   set a negative margin-bottom on rcfilters-head instead
* Move the margin-left rules making space for the highlights into a mixin,
  and apply it before initialization instead of after

Bug: T176300
Change-Id: I353deab90cd944209d7540559c6b41decad20e7d

4 years agoMerge "EditPage: Stop using globals for configuration in non-static functions"
jenkins-bot [Thu, 21 Sep 2017 16:45:44 +0000 (16:45 +0000)]
Merge "EditPage: Stop using globals for configuration in non-static functions"

4 years agoMerge "EditPage: Deprecate $mArticle and $mTitle for public usage"
jenkins-bot [Thu, 21 Sep 2017 16:45:40 +0000 (16:45 +0000)]
Merge "EditPage: Deprecate $mArticle and $mTitle for public usage"

4 years agoMerge "EditPage: Deprecate public isCssJsSubpage related member variables"
jenkins-bot [Thu, 21 Sep 2017 16:45:37 +0000 (16:45 +0000)]
Merge "EditPage: Deprecate public isCssJsSubpage related member variables"

4 years agoMerge "EditPage: Don't allow clients that mangle unicode to edit"
jenkins-bot [Thu, 21 Sep 2017 16:45:33 +0000 (16:45 +0000)]
Merge "EditPage: Don't allow clients that mangle unicode to edit"

4 years agoMerge "registration: Fix typo in validator"
jenkins-bot [Thu, 21 Sep 2017 13:02:34 +0000 (13:02 +0000)]
Merge "registration: Fix typo in validator"

4 years agoEditPage: Stop using globals for configuration in non-static functions
Kunal Mehta [Thu, 21 Sep 2017 02:53:11 +0000 (19:53 -0700)]
EditPage: Stop using globals for configuration in non-static functions

Bug: T144366
Change-Id: Ie884527b64f86b6a989117a45c6ffa6d1893d2b7

4 years agoEditPage: Deprecate $mArticle and $mTitle for public usage
Kunal Mehta [Thu, 21 Sep 2017 02:02:30 +0000 (19:02 -0700)]
EditPage: Deprecate $mArticle and $mTitle for public usage

Change-Id: I2a931826ea142f2214c5f29944c3c3b18da19bad

4 years agoEditPage: Deprecate public isCssJsSubpage related member variables
Kunal Mehta [Wed, 20 Sep 2017 05:06:43 +0000 (22:06 -0700)]
EditPage: Deprecate public isCssJsSubpage related member variables

Just use the functions directly.

Change-Id: Ie374a5cd4c9255b595ff4a88025738720434a802

4 years agoEditPage: Don't allow clients that mangle unicode to edit
Max Semenik [Mon, 28 Aug 2017 21:14:44 +0000 (14:14 -0700)]
EditPage: Don't allow clients that mangle unicode to edit

Get rid of the hack that turns unicode into hexadecimal codes for
browsers that don't support unicode, and prevent their edits entirely.

And instead of relying on $wgBrowserBlacklist, use a hidden HTML form
field - if the contents are mangled and don't match the original, then
reject the edit.

Bug: T67297
Change-Id: I20c2e396d7dfd6a3b23b94b218f94a847522576b

4 years agoWLFilters: Don't hide .watchlistDetails while loading
Roan Kattouw [Wed, 20 Sep 2017 22:37:19 +0000 (15:37 -0700)]
WLFilters: Don't hide .watchlistDetails while loading

It doesn't actually get replaced, just relocated slightly.
Also, watchlist-details is abused for community tools on some wikis,
including enwiki. (watchlist-summary is the right place for that though.)

Bug: T176300
Change-Id: Ic9605b9910c1953ef2536de4ab1b57ec125f0539

4 years agoMerge "Lazy creation for heavy menu"
jenkins-bot [Wed, 20 Sep 2017 22:06:27 +0000 (22:06 +0000)]
Merge "Lazy creation for heavy menu"

4 years agoMerge "Fix case of SpecialRecentChanges class"
jenkins-bot [Wed, 20 Sep 2017 21:29:47 +0000 (21:29 +0000)]
Merge "Fix case of SpecialRecentChanges class"

4 years agoMerge "Prepare for 1.31 branch"
jenkins-bot [Wed, 20 Sep 2017 21:10:08 +0000 (21:10 +0000)]
Merge "Prepare for 1.31 branch"

4 years agoFix ip_changes insert counting
Max Semenik [Wed, 20 Sep 2017 20:39:49 +0000 (13:39 -0700)]
Fix ip_changes insert counting

Change-Id: I02b457d9dcaadc97eead623e42a5a1ccf8335724

4 years agoMerge "Do not depend on PHP_EOL in HTMLRestrictionsField"
jenkins-bot [Wed, 20 Sep 2017 20:18:19 +0000 (20:18 +0000)]
Merge "Do not depend on PHP_EOL in HTMLRestrictionsField"