Fix ip_changes insert counting
authorMax Semenik <maxsem.wiki@gmail.com>
Wed, 20 Sep 2017 20:39:49 +0000 (13:39 -0700)
committerMax Semenik <maxsem.wiki@gmail.com>
Wed, 20 Sep 2017 20:39:49 +0000 (13:39 -0700)
Change-Id: I02b457d9dcaadc97eead623e42a5a1ccf8335724

maintenance/populateIpChanges.php

index 2b2a2b4..40a596c 100644 (file)
@@ -110,14 +110,11 @@ TEXT
                                }
                        }
 
-                       $dbw->insert(
-                               'ip_changes',
-                               $insertRows,
-                               __METHOD__,
-                               'IGNORE'
-                       );
+                       if ( $insertRows ) {
+                               $dbw->insert( 'ip_changes', $insertRows, __METHOD__, 'IGNORE' );
 
-                       $inserted += $dbw->affectedRows();
+                               $inserted += $dbw->affectedRows();
+                       }
 
                        $lbFactory->waitForReplication();
                        usleep( $throttle * 1000 );