lhc/web/wiklou.git
8 years agoPrevent "Failed to create..." warnings when session loading fails
Gergő Tisza [Wed, 2 Mar 2016 23:36:02 +0000 (15:36 -0800)]
Prevent "Failed to create..." warnings when session loading fails

If there is an existing session for a given ID but loading it fails,
there is no point in trying to create a new empty session with that
ID. Just fail silently (the reason for not loading the session
should be logged elsewhere), don't spam the logs and don't slow
down execution by throwing and catching an exception.

Change-Id: I8299872cc29c32cb245686ed0bca6b9a5902cdc1

8 years agoapi: Fix "PHP Notice: Undefined variable: config"
Timo Tijhof [Wed, 2 Mar 2016 21:52:21 +0000 (21:52 +0000)]
api: Fix "PHP Notice: Undefined variable: config"

Follows-up 362c220aa1, which split the method up but didn't
re-create a local $config variable.

Change-Id: Ic32ac3c600d0b4d69e8129fa50ea47d9a6a54b20

8 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Wed, 2 Mar 2016 21:36:58 +0000 (22:36 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: Ib781f4c698a70de2afd5db1c3a0c58bf8f4285f0

8 years agoMerge "Add ContentHandler::supportsCategories method"
jenkins-bot [Wed, 2 Mar 2016 21:24:28 +0000 (21:24 +0000)]
Merge "Add ContentHandler::supportsCategories method"

8 years agoMerge "AutoloadGenerator: Account for PHP 5.5 syntax like "self::static""
jenkins-bot [Wed, 2 Mar 2016 20:22:37 +0000 (20:22 +0000)]
Merge "AutoloadGenerator: Account for PHP 5.5 syntax like "self::static""

8 years agoFix trivial PHPCS violations in */skins/* directories
Bartosz Dziewoński [Wed, 2 Mar 2016 19:57:35 +0000 (20:57 +0100)]
Fix trivial PHPCS violations in */skins/* directories

Due to T127238, files in various */skins/* directories are not checked
by PHPCS. Temporarily removed the exclude rule from phpcs.xml and ran:

  composer fix includes/skins/* tests/phpunit/includes/skins/* tests/phpunit/skins/*

Change-Id: I9240c1cee825920b6634903282be6252cce55686

8 years agoMerge "Revert "Deprecating: Consolidating `progressive` & `constructive` buttons""
jenkins-bot [Wed, 2 Mar 2016 19:40:01 +0000 (19:40 +0000)]
Merge "Revert "Deprecating: Consolidating `progressive` & `constructive` buttons""

8 years agoRevert "Deprecating: Consolidating `progressive` & `constructive` buttons"
Bartosz Dziewoński [Wed, 2 Mar 2016 19:27:52 +0000 (19:27 +0000)]
Revert "Deprecating: Consolidating `progressive` & `constructive` buttons"

I merged it too early, sorry. Deployment is planned for a week later.

This reverts commit cb8fa5fd173f4cfdb9945019fa9ac894eafa3ffe.

Bug: T110555
Change-Id: I369fa6d2b4f6531f7ec475c08cba283d323a0ffb

8 years agoMerge "Add help link for Special:ChangeContentModel"
jenkins-bot [Wed, 2 Mar 2016 19:25:15 +0000 (19:25 +0000)]
Merge "Add help link for Special:ChangeContentModel"

8 years agoAutoloadGenerator: Account for PHP 5.5 syntax like "self::static"
Timo Tijhof [Wed, 2 Mar 2016 19:17:42 +0000 (19:17 +0000)]
AutoloadGenerator: Account for PHP 5.5 syntax like "self::static"

Bug: T128625
Change-Id: I905b549a738b76c07c56ec92f500553c1d48f558

8 years agoMerge "Allow FSFile objects for src in FileBackend::do*Operations"
jenkins-bot [Wed, 2 Mar 2016 19:14:25 +0000 (19:14 +0000)]
Merge "Allow FSFile objects for src in FileBackend::do*Operations"

8 years agoAllow FSFile objects for src in FileBackend::do*Operations
Aaron Schulz [Sat, 27 Feb 2016 01:33:42 +0000 (17:33 -0800)]
Allow FSFile objects for src in FileBackend::do*Operations

Convenience aside, this lets multiwrite backends do async replication for
"store" operations safely, buy keeping a handle to the source file that
prevents it from getting prematurely deleted before the post-send writes
to the secondary backends can happen.

Bug: T91869
Change-Id: I1254de527c47835c35fed6e526b42953c1b2b2ca

8 years agoAdd help link for Special:ChangeContentModel
Kunal Mehta [Wed, 2 Mar 2016 08:47:04 +0000 (00:47 -0800)]
Add help link for Special:ChangeContentModel

Bug: T128556
Change-Id: Id55a463cf6eac4f20e800ae49448e6007f68a3c4

8 years agoFix use of RawMessage in Status::getMessage()
Brad Jorsch [Wed, 2 Mar 2016 17:17:55 +0000 (12:17 -0500)]
Fix use of RawMessage in Status::getMessage()

RawMessage::__construct() takes a single array of params, it's not
varargs-style like wfMessage().

Change-Id: I63950ee16e359aa2627228350e27d9e94bb6e8ce

8 years agoMerge "Deprecating: Consolidating `progressive` & `constructive` buttons"
jenkins-bot [Wed, 2 Mar 2016 16:39:17 +0000 (16:39 +0000)]
Merge "Deprecating: Consolidating `progressive` & `constructive` buttons"

8 years agoAdd ContentHandler::supportsCategories method
aude [Mon, 15 Feb 2016 15:19:58 +0000 (16:19 +0100)]
Add ContentHandler::supportsCategories method

and check for this in WikiPage::doEditUpdates before
inserting a new CategoryMembershipChangeJob.

Some content models like the Wikibase ones do not
have categories and it's wasteful to add these jobs
for all Wikibase edits.

Bug: T126977
Change-Id: I2c54a4ba1546445dc41101e15cb83a2c6cc2b1c9

8 years agoMerge "Fix comment in SearchEngine.php"
jenkins-bot [Wed, 2 Mar 2016 12:19:54 +0000 (12:19 +0000)]
Merge "Fix comment in SearchEngine.php"

8 years agoMerge "objectcache: Fix MultiWriteBagOStuff docs ('asyncHandler', not 'asyncCallback')"
jenkins-bot [Wed, 2 Mar 2016 05:07:09 +0000 (05:07 +0000)]
Merge "objectcache: Fix MultiWriteBagOStuff docs ('asyncHandler', not 'asyncCallback')"

8 years agoobjectcache: Fix MultiWriteBagOStuff docs ('asyncHandler', not 'asyncCallback')
Timo Tijhof [Wed, 2 Mar 2016 02:49:53 +0000 (02:49 +0000)]
objectcache: Fix MultiWriteBagOStuff docs ('asyncHandler', not 'asyncCallback')

Follows-up 1171cc00cd.

Change-Id: I97189e916d0aba507273216e3e9ab28ce0d5ffec

8 years agoMerge "Convert remaining array() to [] in API"
jenkins-bot [Wed, 2 Mar 2016 02:27:58 +0000 (02:27 +0000)]
Merge "Convert remaining array() to [] in API"

8 years agoMerge "mw.Upload.BookletLayout/Dialog: Add determinate progress bar"
jenkins-bot [Wed, 2 Mar 2016 01:48:19 +0000 (01:48 +0000)]
Merge "mw.Upload.BookletLayout/Dialog: Add determinate progress bar"

8 years agoMerge "findHooks.php: Use recursive directory iterator"
jenkins-bot [Tue, 1 Mar 2016 23:14:46 +0000 (23:14 +0000)]
Merge "findHooks.php: Use recursive directory iterator"

8 years agoMerge "WebRequestUpload: Use canonical header name in getHeader()"
jenkins-bot [Tue, 1 Mar 2016 23:07:15 +0000 (23:07 +0000)]
Merge "WebRequestUpload: Use canonical header name in getHeader()"

8 years agofindHooks.php: Use recursive directory iterator
Timo Tijhof [Fri, 26 Feb 2016 18:51:40 +0000 (18:51 +0000)]
findHooks.php: Use recursive directory iterator

The following dirs were not previously included:
* includes/compat/
* includes/compat/normal/
* includes/composer/
* includes/config/
* includes/db/loadbalancer/
* includes/debug/logger/
* includes/filebackend/filejournal/
* includes/filebackend/lockmanager/
* includes/jobqueue/aggregator/
* includes/jobqueue/jobs/
* includes/jobqueue/utils/
* includes/libs/
* includes/objectcache/
* includes/pager/
* includes/poolcounter/
* includes/profiler/output/
* includes/profiler/
* includes/registration/
* includes/templates/
* includes/tidy/
* includes/title/
* includes/utils/iterators/
* includes/widget/
* maintenance/ subdirectories

Change-Id: I6c01b8768f9f70152e320d254f8025a0ffde8c62

8 years agouser: Remove obsolete note in docs/memcached.txt
Timo Tijhof [Sat, 27 Feb 2016 19:35:21 +0000 (19:35 +0000)]
user: Remove obsolete note in docs/memcached.txt

The User object cache hasn't been that since b3acd4f.

Change-Id: Ia7ab78ef22c24a7421ea25db1440e7267f0a725d

8 years agoUpdate OOjs UI to v0.16.1
James D. Forrester [Tue, 1 Mar 2016 22:00:31 +0000 (14:00 -0800)]
Update OOjs UI to v0.16.1

Release notes:
 https://git.wikimedia.org/blob/oojs%2Fui.git/v0.16.1/History.md

Change-Id: I4bd51d4c105a09d71a911e04538b51f58c3ea721

8 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Tue, 1 Mar 2016 20:18:57 +0000 (21:18 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: I7c15b259b0f88dbc05ce1520ecb319a66eed6f73

8 years agoMerge "Add mobile target to mediawiki.special"
jenkins-bot [Tue, 1 Mar 2016 18:16:33 +0000 (18:16 +0000)]
Merge "Add mobile target to mediawiki.special"

8 years agoMerge "Add access modifiers to MagicWordArray.php"
jenkins-bot [Tue, 1 Mar 2016 18:16:29 +0000 (18:16 +0000)]
Merge "Add access modifiers to MagicWordArray.php"

8 years agoMerge "Add access modifiers to MagicWord.php"
jenkins-bot [Tue, 1 Mar 2016 18:13:19 +0000 (18:13 +0000)]
Merge "Add access modifiers to MagicWord.php"

8 years agoMerge "Move MagicWordArray class to own file"
jenkins-bot [Tue, 1 Mar 2016 17:40:07 +0000 (17:40 +0000)]
Merge "Move MagicWordArray class to own file"

8 years agoMerge "Rm unused $config from SpecialRecentChanges::getDefaultOptions"
jenkins-bot [Tue, 1 Mar 2016 16:49:49 +0000 (16:49 +0000)]
Merge "Rm unused $config from SpecialRecentChanges::getDefaultOptions"

8 years agoRm unused $config from SpecialRecentChanges::getDefaultOptions
addshore [Tue, 1 Mar 2016 11:55:58 +0000 (11:55 +0000)]
Rm unused $config from SpecialRecentChanges::getDefaultOptions

Change-Id: I5dc8f091c06b0d32d5d84af885608a57ca9c054a

8 years agoAdd mobile target to mediawiki.special
Alex Monk [Sun, 14 Feb 2016 20:01:44 +0000 (20:01 +0000)]
Add mobile target to mediawiki.special

Bug: T126935
Change-Id: I1135397d150b5ad978da88bfd9d85c1d9e294eb7

8 years agoMerge "Reset scoped session for upload jobs after deferred updates"
jenkins-bot [Tue, 1 Mar 2016 11:30:55 +0000 (11:30 +0000)]
Merge "Reset scoped session for upload jobs after deferred updates"

8 years agoMerge "Allow API action=logout with BotPasswords"
jenkins-bot [Tue, 1 Mar 2016 11:12:20 +0000 (11:12 +0000)]
Merge "Allow API action=logout with BotPasswords"

8 years agoMerge "Unpersist the session on session load failure"
jenkins-bot [Tue, 1 Mar 2016 11:02:48 +0000 (11:02 +0000)]
Merge "Unpersist the session on session load failure"

8 years agoAdd access modifiers to MagicWordArray.php
addshore [Tue, 1 Mar 2016 10:56:55 +0000 (10:56 +0000)]
Add access modifiers to MagicWordArray.php

Change-Id: Ib5fe0fd22a6f24142f1e87338298c1bdef45cc4a

8 years agoAdd access modifiers to MagicWord.php
addshore [Tue, 1 Mar 2016 10:56:04 +0000 (10:56 +0000)]
Add access modifiers to MagicWord.php

Change-Id: I3588d9d2c17203ec3ff11736cd6ce84f687677a5

8 years agoMove MagicWordArray class to own file
addshore [Tue, 1 Mar 2016 10:49:29 +0000 (10:49 +0000)]
Move MagicWordArray class to own file

Change-Id: I9ba602da77f1c8d4270d8ae10d03e82a3197e5b1

8 years agoFix comment in SearchEngine.php
aude [Tue, 1 Mar 2016 09:48:55 +0000 (10:48 +0100)]
Fix comment in SearchEngine.php

Change-Id: Ib00b42d2210be5bc1125fa7ba74c27a5d7fbf36c

8 years agoMerge "Unpersist the session on logout"
jenkins-bot [Tue, 1 Mar 2016 02:37:47 +0000 (02:37 +0000)]
Merge "Unpersist the session on logout"

8 years agoAllow API action=logout with BotPasswords
Brad Jorsch [Mon, 29 Feb 2016 17:12:17 +0000 (12:12 -0500)]
Allow API action=logout with BotPasswords

Since login is handled specially, do the same for logout.

Bug: T128335
Change-Id: Ib3b12d7045449b5c44f5ff7d1ecfce14416e8400

8 years agoMerge "Use static::class instead of get_called_class()"
jenkins-bot [Tue, 1 Mar 2016 00:34:45 +0000 (00:34 +0000)]
Merge "Use static::class instead of get_called_class()"

8 years agoCache user data in memory
Gergő Tisza [Mon, 29 Feb 2016 23:41:56 +0000 (15:41 -0800)]
Cache user data in memory

Stores user data looked up in WAN cache in memory so that lookups in the
same request do not result in new memcached lookups.

Quick and dirty solution, but nicer ones are more difficult:
* no idea what replacing WANObjectCache::get/set with getWithSetCallback
  (which has its own in-process cache) would do, the code is complex
  and completely different
* would be nice to wrap the logic into a proxy object (like CachedBagOStuff)
  but WANObjectCache calls set() internally (and marks it final), so
  inheriting is not safe; the interface and implementation should be
  separated, and that means updating all external callers which do a type
  check.
* ObjectCache::getInstance('hash') cannot be used because it has no
  item limit and this could eat up the memory with a script that iterates
  through lots of users

The patch does not attempt to replicate tombstoning for
User::clearSharedCache('refresh').

Based on Iec1504700a and Idef9a9d3.

Change-Id: I419f356b0c306d16711b433da95dccdb44645154
Co-Authored-By: Ori Livneh <ori@wikimedia.org>
Bug: T128157

8 years agoMerge "Revert "Add type hint against LinkTarget""
jenkins-bot [Mon, 29 Feb 2016 23:58:59 +0000 (23:58 +0000)]
Merge "Revert "Add type hint against LinkTarget""

8 years agoMerge "Add CategoryMembershipChangeJobTest"
jenkins-bot [Mon, 29 Feb 2016 23:44:52 +0000 (23:44 +0000)]
Merge "Add CategoryMembershipChangeJobTest"

8 years agoMerge "CategoryViewer: Do opportunistic category recounts for mismatched file counts...
jenkins-bot [Mon, 29 Feb 2016 23:33:15 +0000 (23:33 +0000)]
Merge "CategoryViewer: Do opportunistic category recounts for mismatched file counts, too"

8 years agoMerge "mail: Turn UserMailer::quotedPrintableCallback into an inline closure"
jenkins-bot [Mon, 29 Feb 2016 23:33:10 +0000 (23:33 +0000)]
Merge "mail: Turn UserMailer::quotedPrintableCallback into an inline closure"

8 years agoMerge "media: Fix casing of IPTC::parse() in tests"
jenkins-bot [Mon, 29 Feb 2016 23:32:00 +0000 (23:32 +0000)]
Merge "media: Fix casing of IPTC::parse() in tests"

8 years agoRevert "Add type hint against LinkTarget"
Brian Wolff [Mon, 29 Feb 2016 23:31:48 +0000 (23:31 +0000)]
Revert "Add type hint against LinkTarget"

Can cause fatal if your database has invalid titles
stored in it (Title::makeTitleSafe is fed to $lb->addObj()
without checking that the result is non-null)

This reverts commit 0e5a1f8879b211b44416e3762bf2d76c28f3f569.

Change-Id: I4174b2fdcc3d8e24ecf0bcc39cd0f0f2e8bfd6b2

8 years agoAdd CategoryMembershipChangeJobTest
addshore [Mon, 29 Feb 2016 22:54:01 +0000 (22:54 +0000)]
Add CategoryMembershipChangeJobTest

Change-Id: Ia04bb85260be7d2aaaf171a2c886633b66ee6e77

8 years agomail: Turn UserMailer::quotedPrintableCallback into an inline closure
Reedy [Thu, 25 Feb 2016 20:36:32 +0000 (20:36 +0000)]
mail: Turn UserMailer::quotedPrintableCallback into an inline closure

Change-Id: I1b11a95d47caeaf02291a5ab522b57d7570ca738

8 years agomedia: Fix casing of IPTC::parse() in tests
Reedy [Sun, 24 Jan 2016 12:21:07 +0000 (12:21 +0000)]
media: Fix casing of IPTC::parse() in tests

Change-Id: Id7271fe635c92f2c82c6e45c64a8b23b69bc3c03

8 years agomail: Change $wgNoReplyAddress default to $wgPasswordSender
Derk-Jan Hartman [Thu, 30 Apr 2015 21:38:05 +0000 (23:38 +0200)]
mail: Change $wgNoReplyAddress default to $wgPasswordSender

Stop using a TLD in the EmailNotification class that can now
potentially become a valid domainname.

Bug: T97711
Change-Id: If69d5f32b97320986b14260c851d4aca0d28aa69

8 years agoConvert remaining array() to [] in API
Reedy [Sat, 20 Feb 2016 20:16:20 +0000 (20:16 +0000)]
Convert remaining array() to [] in API

Change-Id: Ib44d59ff0cf0d6d8efc462671cac716dbead8ffc

8 years agoUse static::class instead of get_called_class()
Timo Tijhof [Thu, 25 Feb 2016 20:00:22 +0000 (20:00 +0000)]
Use static::class instead of get_called_class()

Available as of PHP 5.5 and more idomatic. Foo::class (explicit),
self::class (defined), and static::class (late bound).

Change-Id: I66937f32095a4e4ecde94ca20a935a3c3efc9cee

8 years agoUnpersist the session on session load failure
Brad Jorsch [Fri, 26 Feb 2016 21:37:52 +0000 (16:37 -0500)]
Unpersist the session on session load failure

There's no point in keeping broken cookies around, it just means all
future requests will continue to flood the logs.

Change-Id: Ib10c9ed9049b71ed434950fc731ea77960ceca0c

8 years agoCategoryViewer: Do opportunistic category recounts for mismatched file counts, too
Bartosz Dziewoński [Mon, 29 Feb 2016 22:05:32 +0000 (23:05 +0100)]
CategoryViewer: Do opportunistic category recounts for mismatched file counts, too

There are some categories on Commons that have no files, but are
recorded to have some, e.g. [1] appears to have 15 files [2]. We have
logic to fix these, but it wasn't being checked for file counts (only
pages and subcats).

[1] https://commons.wikimedia.org/wiki/Category:Police_of_Mexico,_D._F._vehicles
[2] https://commons.wikimedia.org/w/index.php?title=Category:Police_of_Mexico,_D._F._vehicles&action=info

Change-Id: If88fc15347eb592e957452884c2179d7c237bd2c

8 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Mon, 29 Feb 2016 21:28:03 +0000 (22:28 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: I5da9bd040f15c0ded7c5b507c36f6d31a1dd049a

8 years agoUnpersist the session on logout
Brad Jorsch [Fri, 26 Feb 2016 21:17:37 +0000 (16:17 -0500)]
Unpersist the session on logout

Clearing the cookies in this case is probably a good idea.

This also clears cookies when a non-persisted session's metadata is
dirty, for parallelism with what happens to persisted sessions.

Bug: T127436
Change-Id: I76897eaac063e5e3c3563398d0f4cb36cf93783b

8 years agoRevert "Prevent duplicate memcached lookups for user record"
Ori.livneh [Mon, 29 Feb 2016 19:04:09 +0000 (19:04 +0000)]
Revert "Prevent duplicate memcached lookups for user record"

This reverts commit 7d67b4d9195346e1.
Caused T128246, T128263, T128275.

Change-Id: I639ea59e2d42ffbbf700451074174720f2f45cf4

8 years agoMerge "MimeMagic: Recognise font files"
jenkins-bot [Mon, 29 Feb 2016 19:19:46 +0000 (19:19 +0000)]
Merge "MimeMagic: Recognise font files"

8 years agoMerge "resourceloader: Remove PHP4-compat code"
jenkins-bot [Mon, 29 Feb 2016 19:18:42 +0000 (19:18 +0000)]
Merge "resourceloader: Remove PHP4-compat code"

8 years agoMerge "Add request error state to ApiBase::logRequest"
jenkins-bot [Mon, 29 Feb 2016 16:49:00 +0000 (16:49 +0000)]
Merge "Add request error state to ApiBase::logRequest"

8 years agoMerge "Update ApiAction logging channel values"
jenkins-bot [Mon, 29 Feb 2016 16:41:08 +0000 (16:41 +0000)]
Merge "Update ApiAction logging channel values"

8 years agoMerge "Remove fix for a 5.3 problem"
jenkins-bot [Mon, 29 Feb 2016 14:46:40 +0000 (14:46 +0000)]
Merge "Remove fix for a 5.3 problem"

8 years agoMerge "Remove useless PHP version comparison from wfDebugBacktrace()"
jenkins-bot [Mon, 29 Feb 2016 14:40:59 +0000 (14:40 +0000)]
Merge "Remove useless PHP version comparison from wfDebugBacktrace()"

8 years agoCleanup Cucumber tags in Selenium tests
Željko Filipin [Fri, 19 Feb 2016 14:08:44 +0000 (15:08 +0100)]
Cleanup Cucumber tags in Selenium tests

Removing no longer used @login tag. We are no longer running tests
using internet explorer or phantomjs, so removing those tags too.

Renamed @clean tag with @vagrant, since it makes more sense and is used
in other repositories.

Bug: T127423
Change-Id: Ib5e0a1600c3df45889e97d5ff52cd0a77a15001f

8 years agoMerge "Improve code suffering from PHP 5.3's lack of support for foo()[]"
jenkins-bot [Mon, 29 Feb 2016 09:53:31 +0000 (09:53 +0000)]
Merge "Improve code suffering from PHP 5.3's lack of support for foo()[]"

8 years agoMerge "Fix case of id on EditPage for label"
jenkins-bot [Mon, 29 Feb 2016 09:40:28 +0000 (09:40 +0000)]
Merge "Fix case of id on EditPage for label"

8 years agoMerge "Add mw-changeslist-(log|ns)-* class to OldChangesList as well"
jenkins-bot [Mon, 29 Feb 2016 08:25:50 +0000 (08:25 +0000)]
Merge "Add mw-changeslist-(log|ns)-* class to OldChangesList as well"

8 years agoOOjs UI: CapsuleItemWidget: Revert regression on remove button in Firefox
James D. Forrester [Sun, 28 Feb 2016 23:59:53 +0000 (15:59 -0800)]
OOjs UI: CapsuleItemWidget: Revert regression on remove button in Firefox

Manual application of changes from up-stream ahead of v0.16.1 release, which
will miss the -wmf.15 cut, given the severity of the issue for Firefox users
and the simplicity of the change. Fix made by VolkerE in Ieac469d.

Bug: T128074
Change-Id: If43b86e27970ae0fe75a654a63f06cc19bcac865

8 years agoGrant 'editcontentmodel' to all sysops by default
Kunal Mehta [Mon, 16 Mar 2015 01:33:09 +0000 (18:33 -0700)]
Grant 'editcontentmodel' to all sysops by default

This is the first step before this userright can be granted to everyone
(or at least 'user').

There were a few issues with granting this permission at all on public
wikis (tracked at T85847) which are now all fixed.

Bug: T85847
Change-Id: Idcaaaaa5cc3fd7c3efca6c57698767689b9a1d09

8 years agoImprove code suffering from PHP 5.3's lack of support for foo()[]
Bartosz Dziewoński [Wed, 17 Feb 2016 19:54:59 +0000 (20:54 +0100)]
Improve code suffering from PHP 5.3's lack of support for foo()[]

I searched for /\$(\S+) = (.+?\(.*?\);)\n.*?\$\1\[/, ignored
everything involving isset(), unset() or array assigments, then
skimmed through the remaining results and changed things where they
made sense. These changes were not automated, so please review them.

Change-Id: Ib37b4c66fc57648470f151ad412210b3629c2538

8 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Sun, 28 Feb 2016 20:26:44 +0000 (21:26 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: I5504186079857415cde8051d6433f96604a22109

8 years agoMerge "Special:NewFiles: Explicitly list needed table fields in query"
jenkins-bot [Sun, 28 Feb 2016 20:21:54 +0000 (20:21 +0000)]
Merge "Special:NewFiles: Explicitly list needed table fields in query"

8 years agoMerge "Special:NewFiles: Make 'hidepatrolled' query less slow"
jenkins-bot [Sun, 28 Feb 2016 20:16:26 +0000 (20:16 +0000)]
Merge "Special:NewFiles: Make 'hidepatrolled' query less slow"

8 years agoFix case of id on EditPage for label
umherirrender [Sun, 28 Feb 2016 11:54:14 +0000 (12:54 +0100)]
Fix case of id on EditPage for label

Avoids validation error:
The for attribute of the label element must refer to a non-hidden form
control.

Change-Id: I9501fda9ca1dbff3db530f5d9e0c2504b94b0ff3

8 years agoMerge "Localisation updates from https://translatewiki.net."
Translation updater bot [Sat, 27 Feb 2016 20:28:00 +0000 (20:28 +0000)]
Merge "Localisation updates from https://translatewiki.net."

8 years agoMerge "Remove double emphasis in strings"
jenkins-bot [Sat, 27 Feb 2016 20:23:43 +0000 (20:23 +0000)]
Merge "Remove double emphasis in strings"

8 years agoMerge "Replace wikitext bold and italics with <strong> and <em>"
jenkins-bot [Sat, 27 Feb 2016 20:23:39 +0000 (20:23 +0000)]
Merge "Replace wikitext bold and italics with <strong> and <em>"

8 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Sat, 27 Feb 2016 20:21:37 +0000 (21:21 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: I17a79c788bb4cb2c4674bb8f82e723d90ef62d29

8 years agoRemove double emphasis in strings
Siebrand Mazeland [Sat, 27 Feb 2016 20:03:16 +0000 (21:03 +0100)]
Remove double emphasis in strings

Change-Id: I03d7511e620fb76fcf090c8b8c399b29a245640b

8 years agoMimeMagic: Recognise font files
Timo Tijhof [Sat, 27 Feb 2016 19:52:08 +0000 (19:52 +0000)]
MimeMagic: Recognise font files

Supported by http://blog.symbolset.com/properly-serve-webfonts
> WOFF application/x-font-woff
> TTF application/x-font-ttf
> EOT application/vnd.ms-fontobject

Default nginx registry only contains EOT:
https://github.com/wikimedia/operations-debs-nginx/blob/be600c8b/debian/conf/mime.types
> application/octet-stream              eot;

Wikimedia config for Apache:
https://github.com/wikimedia/operations-puppet/blob/812f280/modules/mediawiki/files/apache/modules/mime.conf#L53-L57
> AddType application/font-woff .woff
> AddType application/font-woff2 .woff2
> AddType application/vnd.ms-fontobject .eot
> AddType application/x-font-ttf .ttf

Without these changes, wmfstatic is unable to serve UniversalLanguageSelector
TFF, EOT, and WOFF font files (currently responds with HTTP 400 error).

Example urls:

* Content-Type: application/font-woff
  https://en.wikipedia.org/static/current/extensions/UniversalLanguageSelector/data/fontrepo/fonts/amiri/amiri-bold.woff
  https://en.wikipedia.org/w/extensions/UniversalLanguageSelector/data/fontrepo/fonts/amiri/amiri-bold.woff

* Content-Type: application/x-font-ttf
  https://en.wikipedia.org/static/current/extensions/UniversalLanguageSelector/data/fontrepo/fonts/amiri/amiri-bold.ttf
  https://en.wikipedia.org/w/extensions/UniversalLanguageSelector/data/fontrepo/fonts/amiri/amiri-bold.ttf

* Content-Type: application/vnd.ms-fontobject
  https://en.wikipedia.org/static/current/extensions/UniversalLanguageSelector/data/fontrepo/fonts/amiri/amiri-bold.eot
  https://en.wikipedia.org/w/extensions/UniversalLanguageSelector/data/fontrepo/fonts/amiri/amiri-bold.eot

Change-Id: Iec9459c9217cc0b09517e279189b4b36f0cd1f74

8 years agoReplace wikitext bold and italics with <strong> and <em>
Siebrand Mazeland [Sat, 27 Feb 2016 19:00:50 +0000 (20:00 +0100)]
Replace wikitext bold and italics with <strong> and <em>

Was done for all of core at some point, but apparently new strings
re-introduced inconsistencies.

Change-Id: I607f779d1c4f0e6ef0b9c2563ac229baee590dcc

8 years agoMerge "installer: Remove obsolete config-no-cache message"
jenkins-bot [Sat, 27 Feb 2016 18:59:57 +0000 (18:59 +0000)]
Merge "installer: Remove obsolete config-no-cache message"

8 years agoFix comment
Florian [Sat, 27 Feb 2016 15:51:38 +0000 (16:51 +0100)]
Fix comment

According to comment on I2c7fc71d19cefaa16a6cc4526af05be9cd32366e
by @Majr.

Change-Id: I743699831554f9e51157a9c9e3405ebc222cdb15

8 years agoRemove useless PHP version comparison from wfDebugBacktrace()
Ricordisamoa [Sat, 27 Feb 2016 04:21:03 +0000 (05:21 +0100)]
Remove useless PHP version comparison from wfDebugBacktrace()

MediaWiki 1.27 only supports PHP 5.5.9 and above, therefore
it is no more necessary to check that the running PHP version
is equal to or greater than 5.4.0.

Change-Id: I819c625e173cbf2a54ef614d742fe01f70be8efc

8 years agoMerge "Use sync writes for replication of 'store' operations"
jenkins-bot [Sat, 27 Feb 2016 00:39:01 +0000 (00:39 +0000)]
Merge "Use sync writes for replication of 'store' operations"

8 years agoUse sync writes for replication of 'store' operations
Aaron Schulz [Fri, 26 Feb 2016 23:55:09 +0000 (15:55 -0800)]
Use sync writes for replication of 'store' operations

The local temporary file might not live long enough to be
copied into storage during post-send.

Bug: T128124
Change-Id: Ifb5260958db008ec8b9f4db90f95a42e5ecaeadc

8 years agoMerge "Localisation updates from https://translatewiki.net."
Translation updater bot [Fri, 26 Feb 2016 22:42:32 +0000 (22:42 +0000)]
Merge "Localisation updates from https://translatewiki.net."

8 years agoMerge "Allow more fine-grained throttling of login attempts"
jenkins-bot [Fri, 26 Feb 2016 22:40:15 +0000 (22:40 +0000)]
Merge "Allow more fine-grained throttling of login attempts"

8 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Fri, 26 Feb 2016 22:39:53 +0000 (23:39 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: I336f644352738cba31da93b21c8544cf2defb594

8 years agoImprove SessionManager unit test coverage, and fix two namespacing bugs
Brad Jorsch [Fri, 26 Feb 2016 20:02:56 +0000 (15:02 -0500)]
Improve SessionManager unit test coverage, and fix two namespacing bugs

Change-Id: Ie0bcba77625e04ca3e89eb400626f63024c6e1a1

8 years agoMerge "Implement HTMLTitleTextField with suggestions for non-OOUI forms, too"
jenkins-bot [Fri, 26 Feb 2016 20:11:46 +0000 (20:11 +0000)]
Merge "Implement HTMLTitleTextField with suggestions for non-OOUI forms, too"

8 years agoMerge "Consistently use Html class for form generation"
jenkins-bot [Fri, 26 Feb 2016 19:52:27 +0000 (19:52 +0000)]
Merge "Consistently use Html class for form generation"

8 years agoMerge "Prevent duplicate memcached lookups for user record"
jenkins-bot [Fri, 26 Feb 2016 18:38:09 +0000 (18:38 +0000)]
Merge "Prevent duplicate memcached lookups for user record"

8 years agoMerge "ApiSandbox: Blur before sending request"
jenkins-bot [Fri, 26 Feb 2016 18:13:19 +0000 (18:13 +0000)]
Merge "ApiSandbox: Blur before sending request"

8 years agoMerge "Add type hint against LinkTarget"
jenkins-bot [Fri, 26 Feb 2016 18:13:14 +0000 (18:13 +0000)]
Merge "Add type hint against LinkTarget"