lhc/web/wiklou.git
3 years agoMerge "Move $.byteLength and $.trimByteLength to new module 'mediawiki.String'"
jenkins-bot [Thu, 22 Feb 2018 05:15:34 +0000 (05:15 +0000)]
Merge "Move $.byteLength and $.trimByteLength to new module 'mediawiki.String'"

3 years agoMove $.byteLength and $.trimByteLength to new module 'mediawiki.String'
Bartosz Dziewoński [Mon, 19 Feb 2018 20:23:36 +0000 (21:23 +0100)]
Move $.byteLength and $.trimByteLength to new module 'mediawiki.String'

These methods do not belong on the jQuery object. And to resolve
T185948, we need to also add codePointLength and trimCodePointLength,
and this new module seems like a good place to put them.

There is no `mw.String` global, this module has to be used via `require()`.

Deprecations:
* Function `$.byteLength` (from module 'jquery.byteLength') is
  deprecated, use `require( 'mediawiki.String' ).byteLength` instead.
* Function `$.trimByteLength` (from module 'jquery.byteLimit') is
  deprecated, use `require( 'mediawiki.String' ).trimByteLength` instead.
* Module 'jquery.byteLength' is deprecated, use 'mediawiki.String' instead.

Note that `$.fn.byteLimit` and the 'jquery.byteLimit' module are not
deprecated.

Change-Id: I2501a79efee644e5f4a9f5c977fe49c8c05c6eb3

3 years agotests: Remove IE9 mobile from Grade A
Ed Sanders [Wed, 21 Feb 2018 12:40:50 +0000 (12:40 +0000)]
tests: Remove IE9 mobile from Grade A

Change-Id: I0e1da9d155c778edaa85d19a3e556fe14f83fdd2

3 years agoFix infinite loop in JpegMetadataExtractor
Brion Vibber [Wed, 21 Feb 2018 22:45:35 +0000 (22:45 +0000)]
Fix infinite loop in JpegMetadataExtractor

One of the skip-over loops was missing an feof() check and could
cause infinite loops.

Includes test file created by truncating a tiny tiny .jpeg at
the right place...

With the fix, it doesn't loop but dies on an exception, which
is good!

Bug: T184048
Change-Id: Ica13d6b68c3c12f7ce414edd081bf0886714e465

3 years agoAdd TimedMediaHandler's images/transcoded to .gitignore
Brion Vibber [Wed, 21 Feb 2018 21:14:27 +0000 (21:14 +0000)]
Add TimedMediaHandler's images/transcoded to .gitignore

Avoids git looking in your transcoded audio/video files
for changes...

Change-Id: I5610354a1575bb97f4523d58d3e9713512416305

3 years agoMerge "sql.php: Provide --json output mode"
jenkins-bot [Wed, 21 Feb 2018 21:14:19 +0000 (21:14 +0000)]
Merge "sql.php: Provide --json output mode"

3 years agoMerge "Drop Grade A support for IE10"
jenkins-bot [Wed, 21 Feb 2018 20:15:37 +0000 (20:15 +0000)]
Merge "Drop Grade A support for IE10"

3 years agoDrop Grade A support for IE10
Ed Sanders [Wed, 21 Feb 2018 12:09:57 +0000 (12:09 +0000)]
Drop Grade A support for IE10

Bug: T187869
Change-Id: I68c882e64fba95d5e1bf41f64658fcef7524dcf5

3 years agoMerge "Contributions: Only add form JS when the form is added"
jenkins-bot [Wed, 21 Feb 2018 19:25:51 +0000 (19:25 +0000)]
Merge "Contributions: Only add form JS when the form is added"

3 years agoMerge "Update README file for Selenium tests"
jenkins-bot [Wed, 21 Feb 2018 17:37:47 +0000 (17:37 +0000)]
Merge "Update README file for Selenium tests"

3 years agoMerge "Truncate tag filter descriptions"
jenkins-bot [Wed, 21 Feb 2018 12:52:22 +0000 (12:52 +0000)]
Merge "Truncate tag filter descriptions"

3 years agoMerge "Fix English name for lb"
jenkins-bot [Wed, 21 Feb 2018 11:42:23 +0000 (11:42 +0000)]
Merge "Fix English name for lb"

3 years agoUpdate README file for Selenium tests
Željko Filipin [Wed, 21 Feb 2018 11:28:49 +0000 (12:28 +0100)]
Update README file for Selenium tests

Bug: T187862
Change-Id: Iadd41307a48a1b50f64a495e7efcee3b88d0ff68

3 years agoFix English name for lb
Niklas Laxström [Wed, 21 Feb 2018 11:12:20 +0000 (12:12 +0100)]
Fix English name for lb

This version has been in MediaWiki longer than my email history,
since 2005 at least. This spelling is not present in
https://en.wikipedia.org/wiki/Luxembourgish

Change-Id: Ibda7e6428a2c79b9f7d88892ef1c16e9921ae934

3 years agoMerge "Factor OldRevisionImporter & ImportableOldRevision out of WikiRevision"
jenkins-bot [Wed, 21 Feb 2018 10:31:32 +0000 (10:31 +0000)]
Merge "Factor OldRevisionImporter & ImportableOldRevision out of WikiRevision"

3 years agoMerge "Factor UploadRevisionImporter & ImportableUploadRevision out of WikiRevision"
jenkins-bot [Wed, 21 Feb 2018 09:53:30 +0000 (09:53 +0000)]
Merge "Factor UploadRevisionImporter & ImportableUploadRevision out of WikiRevision"

3 years agoContributions: Only add form JS when the form is added
Derk-Jan Hartman [Mon, 19 Feb 2018 11:53:47 +0000 (12:53 +0100)]
Contributions: Only add form JS when the form is added

Special:Contributions can be transcluded ('including') on to another
page. In this mode, the form is not present, but the OOUI JS infusing,
payload and styling, was added regardless. This caused errors on pages
transcluding such lists, as the OOUI HTML was missing, causing the JS to
throw errors.

Bug: T187710
Change-Id: I7d45dd3ddd3ba75d44f7d24e03cef5e95301f4ed

3 years agordbms: make sure non-native replace() uses one transaction
Aaron Schulz [Wed, 21 Feb 2018 03:16:51 +0000 (19:16 -0800)]
rdbms: make sure non-native replace() uses one transaction

This is similar to what upsert() already does

Change-Id: Ide83eefe0d937fb2cdc20aa3c7dc9654c4d34beb

3 years agoMerge "mw.Title: Use $.trimByteLength from jquery.byteLimit module"
jenkins-bot [Tue, 20 Feb 2018 22:15:50 +0000 (22:15 +0000)]
Merge "mw.Title: Use $.trimByteLength from jquery.byteLimit module"

3 years agoMerge "tests: Remove dead code in jquery.byteLimit tests"
jenkins-bot [Tue, 20 Feb 2018 22:15:47 +0000 (22:15 +0000)]
Merge "tests: Remove dead code in jquery.byteLimit tests"

3 years agoMerge "Switch the sidebar cache to using checkKeys"
jenkins-bot [Tue, 20 Feb 2018 22:09:50 +0000 (22:09 +0000)]
Merge "Switch the sidebar cache to using checkKeys"

3 years agomw.Title: Use $.trimByteLength from jquery.byteLimit module
Bartosz Dziewoński [Mon, 19 Feb 2018 19:53:11 +0000 (20:53 +0100)]
mw.Title: Use $.trimByteLength from jquery.byteLimit module

Change-Id: I39ebd559a72ce72743cbe3bb86abe679d108d94a

3 years agotests: Remove dead code in jquery.byteLimit tests
Bartosz Dziewoński [Mon, 19 Feb 2018 20:56:08 +0000 (21:56 +0100)]
tests: Remove dead code in jquery.byteLimit tests

These options do nothing.

Change-Id: I15cc91b9208e8cfd3f3f42bb0a9c91514d6532e3

3 years agoMerge "parser: Deprecate string type for $lang arg in DateFormatter::getInstance"
jenkins-bot [Tue, 20 Feb 2018 21:16:34 +0000 (21:16 +0000)]
Merge "parser: Deprecate string type for $lang arg in DateFormatter::getInstance"

3 years agoMerge "jquery.byteLimit: Handle characters outside BMP (surrogate pairs) when trimming"
jenkins-bot [Tue, 20 Feb 2018 21:14:51 +0000 (21:14 +0000)]
Merge "jquery.byteLimit: Handle characters outside BMP (surrogate pairs) when trimming"

3 years agoparser: Deprecate string type for $lang arg in DateFormatter::getInstance
Fomafix [Wed, 13 Sep 2017 12:57:44 +0000 (14:57 +0200)]
parser: Deprecate string type for $lang arg in DateFormatter::getInstance

The parameter $lang is not used with type string in the Git repository:
https://codesearch.wmflabs.org/search/?q=DateFormatter%3A%3AgetInstance
This function is only used with type Language and without parameter.

The support for the language as string will be removed with Change-ID
I677ab561d67b63f0c86f65fadf9319e41444a22a.

The removal of the support for the type string simplifies the code.

Change-Id: I0c0ab46ffc0fab6b68672940e979ad7e5754a7d1

3 years agoMerge "Localisation updates from https://translatewiki.net."
L10n-bot [Tue, 20 Feb 2018 21:02:55 +0000 (21:02 +0000)]
Merge "Localisation updates from https://translatewiki.net."

3 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Tue, 20 Feb 2018 21:02:45 +0000 (22:02 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: Iea6405478e926c0bce200213a211bb66da7efbf3

3 years agoMerge "mediawiki.cldr: Use require() for pluralruleparser"
jenkins-bot [Tue, 20 Feb 2018 20:59:55 +0000 (20:59 +0000)]
Merge "mediawiki.cldr: Use require() for pluralruleparser"

3 years agoFix for Ia97b750b
MarcoAurelio [Tue, 20 Feb 2018 19:19:28 +0000 (19:19 +0000)]
Fix for Ia97b750b

Change-Id: I2eb5ba754334864f65dede92b138f9a81a210e70

3 years agoMerge "Add support for 'es-formal'"
jenkins-bot [Tue, 20 Feb 2018 19:05:24 +0000 (19:05 +0000)]
Merge "Add support for 'es-formal'"

3 years agoMerge "mw.loader: Document mw.loader.require() as private"
jenkins-bot [Tue, 20 Feb 2018 17:07:51 +0000 (17:07 +0000)]
Merge "mw.loader: Document mw.loader.require() as private"

3 years agoFactor OldRevisionImporter & ImportableOldRevision out of WikiRevision
addshore [Tue, 4 Jul 2017 21:46:46 +0000 (22:46 +0100)]
Factor OldRevisionImporter & ImportableOldRevision out of WikiRevision

This is to be used within the FileImporter extension to allow
adding custom loggers to this import process.

Change-Id: Ib094d4829764ccc8e5bd2619fb827d701ae06d43

3 years agoFactor UploadRevisionImporter & ImportableUploadRevision out of WikiRevision
addshore [Tue, 4 Jul 2017 21:07:04 +0000 (22:07 +0100)]
Factor UploadRevisionImporter & ImportableUploadRevision out of WikiRevision

This is to be used within the FileImporter extension to allow
adding custom loggers to this import process.

Change-Id: I4a6c573fc0a69b06d696cd2afca9226fb492a9bc

3 years agomediawiki.cldr: Use require() for pluralruleparser
Fomafix [Fri, 16 Feb 2018 15:18:10 +0000 (16:18 +0100)]
mediawiki.cldr: Use require() for pluralruleparser

Use require( 'mediawiki.libs.pluralruleparser' ) instead of
mw.libs.pluralRuleParser. (Added in 1.27, with bc4e07b6f63b0)

Change-Id: I7388cf631068458596250b8da82edec3f7cbd98b

3 years agomw.loader: Document mw.loader.require() as private
Timo Tijhof [Tue, 20 Feb 2018 04:47:39 +0000 (20:47 -0800)]
mw.loader: Document mw.loader.require() as private

Only public for debugging purposes.

Change-Id: Icc44e11ec6874d7f74ed527e87a80dd06b4edb3a

3 years agoMerge "Cleanup IDEA warnings in MessageCache"
jenkins-bot [Tue, 20 Feb 2018 04:33:22 +0000 (04:33 +0000)]
Merge "Cleanup IDEA warnings in MessageCache"

3 years agoGD zero filesize error
Dan Mattern [Mon, 19 Feb 2018 22:59:17 +0000 (17:59 -0500)]
GD zero filesize error

Checking if the filesize is zero before passing to GD. This can result
in a fatal error.

Bug: T182387
Change-Id: I26a24286f3035f233de682caed21a8e8c2d5aaad

3 years agoMerge "Pass change tags to NewRevisionFromEditComplete hook"
jenkins-bot [Mon, 19 Feb 2018 22:55:53 +0000 (22:55 +0000)]
Merge "Pass change tags to NewRevisionFromEditComplete hook"

3 years agoMerge "rdbms: tweak var names in LoadMonitor::scaleLoads()/getLagTimes()"
jenkins-bot [Mon, 19 Feb 2018 22:55:51 +0000 (22:55 +0000)]
Merge "rdbms: tweak var names in LoadMonitor::scaleLoads()/getLagTimes()"

3 years agoMerge "tests: Remove verbose logging settings from DevelopmentSettings.php"
jenkins-bot [Mon, 19 Feb 2018 22:27:45 +0000 (22:27 +0000)]
Merge "tests: Remove verbose logging settings from DevelopmentSettings.php"

3 years agotests: Remove verbose logging settings from DevelopmentSettings.php
Timo Tijhof [Mon, 19 Feb 2018 22:17:11 +0000 (14:17 -0800)]
tests: Remove verbose logging settings from DevelopmentSettings.php

Follows-up fdb7d36903. It seems these make unit tests on Travis CI
fail, per T187581. And when we briefly enabled DevelopmentSettings.php
in our Jenkins setup, the PHPUnit tests also failed.

Remove these from DevelopmentSettings.php to confirm that the
tests pass that way. Then, once our own Jenkins setup has switched
back to using DevelopmentSettings.php, we can re-consider adding
these in a way that is verified by Gerrit/Jenkins before merging.

Bug: T187581
Change-Id: Ib81c5909849598bdad02955f6414d68c038742c5

3 years agojquery.byteLimit: Handle characters outside BMP (surrogate pairs) when trimming
Bartosz Dziewoński [Mon, 5 Feb 2018 18:38:10 +0000 (19:38 +0100)]
jquery.byteLimit: Handle characters outside BMP (surrogate pairs) when trimming

Bug: T186364
Change-Id: I6282d97bcd637ae8e86d70996adb468582c8f02f

3 years agoAdd support for 'es-formal'
MarcoAurelio [Mon, 19 Feb 2018 21:19:13 +0000 (22:19 +0100)]
Add support for 'es-formal'

Spanish formal address. First exported on Id132ebc6.

Bug: T187750
Change-Id: Ia97b750bde01ceee7db0ea826e4f87bb9a2f0a93

3 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Mon, 19 Feb 2018 20:56:27 +0000 (21:56 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: I11bbae1702de3352fd8b59efa3abe3ad47b49acc

3 years agoMerge "Update links in comments to developer.mozilla.org"
jenkins-bot [Mon, 19 Feb 2018 19:08:10 +0000 (19:08 +0000)]
Merge "Update links in comments to developer.mozilla.org"

3 years agoMerge "build: Updating mediawiki/mediawiki-codesniffer to 16.0.0"
jenkins-bot [Mon, 19 Feb 2018 19:07:12 +0000 (19:07 +0000)]
Merge "build: Updating mediawiki/mediawiki-codesniffer to 16.0.0"

3 years agoSwitch the sidebar cache to using checkKeys
Aaron Schulz [Mon, 19 Feb 2018 11:50:29 +0000 (03:50 -0800)]
Switch the sidebar cache to using checkKeys

The avoids the long delete() loop in MessageCache::replace()
and has better separation of concern.

Change-Id: I0acb0119058fa92fcafb52a5850f5dad4aaa94d2

3 years agoCleanup IDEA warnings in MessageCache
Aaron Schulz [Mon, 19 Feb 2018 11:21:24 +0000 (03:21 -0800)]
Cleanup IDEA warnings in MessageCache

Change-Id: I0ced7c7289918f78bb6f3682ae974fe0c04a1e04

3 years agoUpdate links in comments to developer.mozilla.org
Fomafix [Mon, 19 Feb 2018 08:54:25 +0000 (09:54 +0100)]
Update links in comments to developer.mozilla.org

Change-Id: I2310cf73ab494375655067833cea11b18483a396

3 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Sun, 18 Feb 2018 20:57:57 +0000 (21:57 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: I613493a91cd01032529bd161947b9231819b99cb

3 years agordbms: tweak var names in LoadMonitor::scaleLoads()/getLagTimes()
Aaron Schulz [Fri, 16 Feb 2018 21:50:08 +0000 (13:50 -0800)]
rdbms: tweak var names in LoadMonitor::scaleLoads()/getLagTimes()

Also mark the methods as "final" due to their delegation

Change-Id: Ie32f53445f749d9a00e77fce43d75830e260c039

3 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Sat, 17 Feb 2018 20:59:21 +0000 (21:59 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: Idc8c6ef5a94c61cac176895e089f9624428dc2af

3 years agobuild: Updating mediawiki/mediawiki-codesniffer to 16.0.0
Umherirrender [Sat, 17 Feb 2018 12:29:13 +0000 (13:29 +0100)]
build: Updating mediawiki/mediawiki-codesniffer to 16.0.0

Change-Id: I59b59f79bbf3ce4feff3b3a20c1c31bc16370531

3 years agoMerge "rdbms: make DatabaseMysql::masterPosWait() handle inactive GTIDs"
jenkins-bot [Sat, 17 Feb 2018 04:11:53 +0000 (04:11 +0000)]
Merge "rdbms: make DatabaseMysql::masterPosWait() handle inactive GTIDs"

3 years agordbms: remove "m" member prefix from various classes
Aaron Schulz [Fri, 16 Feb 2018 19:16:10 +0000 (11:16 -0800)]
rdbms: remove "m" member prefix from various classes

Change-Id: Iade8e8f70bb1307b96683d979d7e3650f4107515

3 years agoMerge "rdbms: remove "m" member prefix from DatabaseMssql"
jenkins-bot [Fri, 16 Feb 2018 23:37:08 +0000 (23:37 +0000)]
Merge "rdbms: remove "m" member prefix from DatabaseMssql"

3 years agoMerge "objectcache: add IExpiringStore::TTL_SECOND constant"
jenkins-bot [Fri, 16 Feb 2018 23:37:05 +0000 (23:37 +0000)]
Merge "objectcache: add IExpiringStore::TTL_SECOND constant"

3 years agoMerge "Soft deprecate DeferredStringifier class"
jenkins-bot [Fri, 16 Feb 2018 23:15:37 +0000 (23:15 +0000)]
Merge "Soft deprecate DeferredStringifier class"

3 years agoSoft deprecate DeferredStringifier class
星耀晨曦 [Wed, 14 Feb 2018 10:27:44 +0000 (10:27 +0000)]
Soft deprecate DeferredStringifier class

As of 3041b5c, the DeferredStringifier class is no longer used in MediaWiki core or any Gerrit-hosted extensions.

Bug: T187290
Change-Id: Ic363daf0847c0371a6b4c4041f9ea394377185f3

3 years agoMerge "RCLFilters: make sticky filters default and current value equal"
jenkins-bot [Fri, 16 Feb 2018 22:39:55 +0000 (22:39 +0000)]
Merge "RCLFilters: make sticky filters default and current value equal"

3 years agoobjectcache: add IExpiringStore::TTL_SECOND constant
Aaron Schulz [Fri, 16 Feb 2018 22:23:49 +0000 (14:23 -0800)]
objectcache: add IExpiringStore::TTL_SECOND constant

Change-Id: Iec59ce72f3dbb0de68c8f6704d86f1522f86827e

3 years agoMerge "site_stats: Unbreak counting newly created pages"
jenkins-bot [Fri, 16 Feb 2018 21:36:35 +0000 (21:36 +0000)]
Merge "site_stats: Unbreak counting newly created pages"

3 years agosql.php: Provide --json output mode
Chad Horohoe [Fri, 16 Feb 2018 21:21:38 +0000 (13:21 -0800)]
sql.php: Provide --json output mode

stdObject is a pretty useless format unless you're working with PHP

Change-Id: I7549347a630768223fba5b282a930361dfe6f2d3

3 years agosite_stats: Unbreak counting newly created pages
Eddie Greiner-Petter [Fri, 16 Feb 2018 21:18:48 +0000 (22:18 +0100)]
site_stats: Unbreak counting newly created pages

Fixes a bug introduced on 331c9f9e2e that stopped newly created pages
from incrementing the counter of ss_total_pages in site_stats. The array
accepted by SiteStatsUpdate::factory is not meant to take a value with
the key 'total'. What's meant here is 'pages'. Let's change the variable
name as well to avoid confusion in the future.

Change-Id: I9c82d926206d9b46f333c6f6cb9d3c7d41db3a53

3 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Fri, 16 Feb 2018 21:03:24 +0000 (22:03 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: Ib373192166d7f9d43bbd15df341f8ad770353685

3 years agordbms: make DatabaseMysql::masterPosWait() handle inactive GTIDs
Aaron Schulz [Fri, 9 Feb 2018 23:01:40 +0000 (15:01 -0800)]
rdbms: make DatabaseMysql::masterPosWait() handle inactive GTIDs

Change-Id: I543deef24f6cbf99094a4f3bee7cabe768fa221a

3 years agordbms: remove "m" member prefix from DatabaseMssql
Aaron Schulz [Fri, 16 Feb 2018 19:23:30 +0000 (11:23 -0800)]
rdbms: remove "m" member prefix from DatabaseMssql

Change-Id: I270cd4f4048e0ae751ea1c078d31d45c9db59690

3 years agoMerge "Follow-up I0bb4ed7f7: Use correct 'this'"
jenkins-bot [Fri, 16 Feb 2018 12:26:17 +0000 (12:26 +0000)]
Merge "Follow-up I0bb4ed7f7: Use correct 'this'"

3 years agoFollow-up I0bb4ed7f7: Use correct 'this'
Ed Sanders [Fri, 16 Feb 2018 11:55:00 +0000 (11:55 +0000)]
Follow-up I0bb4ed7f7: Use correct 'this'

Bug: T187523
Change-Id: I7ced05b239d3ce0da1bcd6acdb3a30f65872645c

3 years agoDon't write exceptions to STDERR from BadTitleErrorTest or ThrottledErrorTest
Brad Jorsch [Wed, 14 Feb 2018 18:01:19 +0000 (13:01 -0500)]
Don't write exceptions to STDERR from BadTitleErrorTest or ThrottledErrorTest

It's annoying and pointless. Instead, have MWException write them to
standard output where we can catch them with ob_start().

Bug: T170028
Bug: T170029
Change-Id: Icd99c1c39d4a30d78c511d33948ef639e1b92455

3 years agoMerge "rdbms: do not bother making DBO_TRX transactions in IDatabase::lock()"
jenkins-bot [Fri, 16 Feb 2018 00:50:54 +0000 (00:50 +0000)]
Merge "rdbms: do not bother making DBO_TRX transactions in IDatabase::lock()"

3 years agoUpdate wikimedia/php-session-serializer from 1.0.4 to 1.0.5
Reedy [Sun, 11 Feb 2018 15:39:45 +0000 (15:39 +0000)]
Update wikimedia/php-session-serializer from 1.0.4 to 1.0.5

https://github.com/wikimedia/php-session-serializer/releases/tag/v1.0.5
https://github.com/wikimedia/php-session-serializer/compare/v1.0.4...v1.0.5

Change-Id: Ib9f301f8f86031faed698beca65a56407859a1aa
Depends-On: I0f85f206fdd5566641784037132d2a6046de2c2d

3 years agordbms: do not bother making DBO_TRX transactions in IDatabase::lock()
Aaron Schulz [Wed, 14 Feb 2018 08:27:14 +0000 (00:27 -0800)]
rdbms: do not bother making DBO_TRX transactions in IDatabase::lock()

Named locks are session-level constructs and this transaction agnostic.
Also make lockIsFree() a bit more consistent when the thread has the
lock itself.

Change-Id: Ief51196161bbc50c798740f3c738fd0e39880508

3 years agoMerge "rdbms: remove "m" prefix from Database fields"
jenkins-bot [Fri, 16 Feb 2018 00:15:04 +0000 (00:15 +0000)]
Merge "rdbms: remove "m" prefix from Database fields"

3 years agoMerge "rdbms: make MySQLMasterPos handle inactive GTIDs"
jenkins-bot [Fri, 16 Feb 2018 00:11:48 +0000 (00:11 +0000)]
Merge "rdbms: make MySQLMasterPos handle inactive GTIDs"

3 years agoMerge "tests: Commit initial version of DevelopmentSettings.php"
jenkins-bot [Thu, 15 Feb 2018 23:52:26 +0000 (23:52 +0000)]
Merge "tests: Commit initial version of DevelopmentSettings.php"

3 years agordbms: remove "m" prefix from Database fields
Aaron Schulz [Tue, 13 Feb 2018 06:58:57 +0000 (22:58 -0800)]
rdbms: remove "m" prefix from Database fields

Done using the PhpStorm refactor->rename tool.

Also move "defaultBigSelects" declaration to DatabaseMysqlBase
as no other classes uses that.

Change-Id: I424a2d9815de3a5d4cca2522f3db23a5efe6b592

3 years agoMerge "rdbms: improve ILoadBalancer comments about reuseConnection()"
jenkins-bot [Thu, 15 Feb 2018 23:07:08 +0000 (23:07 +0000)]
Merge "rdbms: improve ILoadBalancer comments about reuseConnection()"

3 years agoMerge "rdbms: remove leading table name space hack in Database"
jenkins-bot [Thu, 15 Feb 2018 23:05:07 +0000 (23:05 +0000)]
Merge "rdbms: remove leading table name space hack in Database"

3 years agoMerge "Salvage site_stats row with negative values in miser mode"
jenkins-bot [Thu, 15 Feb 2018 23:02:11 +0000 (23:02 +0000)]
Merge "Salvage site_stats row with negative values in miser mode"

3 years agoMerge "rdbms: remove "m" prefix from LoadBalancer fields"
jenkins-bot [Thu, 15 Feb 2018 23:02:08 +0000 (23:02 +0000)]
Merge "rdbms: remove "m" prefix from LoadBalancer fields"

3 years agordbms: make MySQLMasterPos handle inactive GTIDs
Aaron Schulz [Fri, 9 Feb 2018 22:12:44 +0000 (14:12 -0800)]
rdbms: make MySQLMasterPos handle inactive GTIDs

Change-Id: I328142a9fe10bccb2717a0a392e0c50d0c070390

3 years agordbms: remove leading table name space hack in Database
Aaron Schulz [Thu, 15 Feb 2018 10:30:12 +0000 (02:30 -0800)]
rdbms: remove leading table name space hack in Database

This was added in r19879 (3de6fd8c8) with no provided use case.
There also appears to be nothing exploiting this.

Change-Id: I1641d4ed16d612ab6f08ee1eeca1580af73888bf

3 years agordbms: remove "m" prefix from LoadBalancer fields
Aaron Schulz [Wed, 14 Feb 2018 10:03:45 +0000 (02:03 -0800)]
rdbms: remove "m" prefix from LoadBalancer fields

Change-Id: I68fc74859bd58ef0c7591beef1c21411198d45e9

3 years agoUse `lock(,,0)` instead of `lockIsFree && lock(,,1)` for non-blocking locks
Timo Tijhof [Thu, 15 Feb 2018 22:30:26 +0000 (14:30 -0800)]
Use `lock(,,0)` instead of `lockIsFree && lock(,,1)` for non-blocking locks

This pattern is already used elsewhere and seems like a more efficient
way to acquire locks in a non-blocking way.

Change-Id: Idb369e7cb03b793d5f8295e956fecd8d1f849e17

3 years agordbms: improve ILoadBalancer comments about reuseConnection()
Aaron Schulz [Thu, 15 Feb 2018 21:28:58 +0000 (13:28 -0800)]
rdbms: improve ILoadBalancer comments about reuseConnection()

Change-Id: I94f8e95f5ed9c3357d118e9bc66c55b389061e7f

3 years agoMerge "Drop the 'CategorizedRecentChanges' feature"
jenkins-bot [Thu, 15 Feb 2018 21:12:23 +0000 (21:12 +0000)]
Merge "Drop the 'CategorizedRecentChanges' feature"

3 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Thu, 15 Feb 2018 21:05:09 +0000 (22:05 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: I820327da7a4aa07879b4fa23f8187783bf35befa

3 years agoMerge "objectcache: improve WANObjectCache reap method comments"
jenkins-bot [Thu, 15 Feb 2018 20:51:06 +0000 (20:51 +0000)]
Merge "objectcache: improve WANObjectCache reap method comments"

3 years agoobjectcache: improve WANObjectCache reap method comments
Aaron Schulz [Thu, 15 Feb 2018 19:48:48 +0000 (11:48 -0800)]
objectcache: improve WANObjectCache reap method comments

Change-Id: Icec0846b0e66229af39bb819d75144734fd111bf

3 years agoMerge "Be more db-friendly when purging expired userrights"
jenkins-bot [Thu, 15 Feb 2018 19:47:47 +0000 (19:47 +0000)]
Merge "Be more db-friendly when purging expired userrights"

3 years agoMerge "build: Add grunt target for 'karma:firefox'"
jenkins-bot [Thu, 15 Feb 2018 18:46:32 +0000 (18:46 +0000)]
Merge "build: Add grunt target for 'karma:firefox'"

3 years agoDrop the 'CategorizedRecentChanges' feature
James D. Forrester [Sat, 18 Mar 2017 01:17:17 +0000 (18:17 -0700)]
Drop the 'CategorizedRecentChanges' feature

It is off by default, it's very rarely used (GitHub finds four config
users setting it true), it has over time had fatals going unnoticed or
fixed for years. Let's just kill it.

Change-Id: Idac2341ed7ecf053ee84069df657e424e50b896c

3 years agoRevisionStore logging use wfBacktrace instead of wfDebugBacktrace
addshore [Thu, 15 Feb 2018 14:15:45 +0000 (14:15 +0000)]
RevisionStore logging use wfBacktrace instead of wfDebugBacktrace

wfDebugBacktrace doesn't work very will with logstash.
The whole message ends up being too long and the log ends
up in the 'jsonTruncated' channel.
Instead use wfBacktrace which will be smaller as it just gives
us a string.

Change-Id: I5309ac2ad4592fb6dbb1474526d382893fb7e6c1

3 years agoMerge "EditPage::getBaseRevision can return null. (fix phpdoc)"
jenkins-bot [Thu, 15 Feb 2018 11:03:16 +0000 (11:03 +0000)]
Merge "EditPage::getBaseRevision can return null. (fix phpdoc)"

3 years agoEditPage::getBaseRevision can return null. (fix phpdoc)
addshore [Thu, 15 Feb 2018 10:08:20 +0000 (10:08 +0000)]
EditPage::getBaseRevision can return null. (fix phpdoc)

If !$this->mBaseRevision then the code to populte $this->mBaseRevision
is run.
This code either calls Revision::newFromId or Revision::loadFromTimestamp
both of which are documented as being able to return null.
As a result EditPage::getBaseRevision can alos return null.

Bug: T187378
Change-Id: I60ad9ddcfbe6e1060cab1ad6aa2194c1a3406cbf

3 years agoMerge "Hard-deprecate ParserOutput stateful transform methods"
jenkins-bot [Thu, 15 Feb 2018 02:14:07 +0000 (02:14 +0000)]
Merge "Hard-deprecate ParserOutput stateful transform methods"

3 years agoMerge "resourceloader: Fix comment on Mobile Safari requirement"
jenkins-bot [Thu, 15 Feb 2018 00:37:22 +0000 (00:37 +0000)]
Merge "resourceloader: Fix comment on Mobile Safari requirement"

3 years agoresourceloader: Fix comment on Mobile Safari requirement
Ed Sanders [Tue, 13 Feb 2018 11:03:07 +0000 (11:03 +0000)]
resourceloader: Fix comment on Mobile Safari requirement

Mobile Safari 5.1 doesn't support Function#bind.

Change-Id: Ifdbd593352ab6d682a37010b17a13370f3c96176