lhc/web/wiklou.git
5 years agoMerge "filecache: Use current action instead of "view" only in outage mode"
jenkins-bot [Fri, 30 Jun 2017 07:49:47 +0000 (07:49 +0000)]
Merge "filecache: Use current action instead of "view" only in outage mode"

5 years agoMerge "SearchInputWidget: Fix documented default for 'pushPending' option"
jenkins-bot [Fri, 30 Jun 2017 07:48:16 +0000 (07:48 +0000)]
Merge "SearchInputWidget: Fix documented default for 'pushPending' option"

5 years agoMerge "Clean up release notes"
jenkins-bot [Fri, 30 Jun 2017 07:32:32 +0000 (07:32 +0000)]
Merge "Clean up release notes"

5 years agoMerge "UsersMultiSelectWidget: Port from CapsuleMultiselectWidget to MenuTagMultisele...
jenkins-bot [Fri, 30 Jun 2017 02:21:17 +0000 (02:21 +0000)]
Merge "UsersMultiSelectWidget: Port from CapsuleMultiselectWidget to MenuTagMultiselectWidget"

5 years agoMerge "Fix \n handling for HTMLUsersMultiselectField"
jenkins-bot [Fri, 30 Jun 2017 02:21:13 +0000 (02:21 +0000)]
Merge "Fix \n handling for HTMLUsersMultiselectField"

5 years agoUsersMultiSelectWidget: Port from CapsuleMultiselectWidget to MenuTagMultiselectWidget
Roan Kattouw [Fri, 9 Jun 2017 02:13:45 +0000 (19:13 -0700)]
UsersMultiSelectWidget: Port from CapsuleMultiselectWidget to MenuTagMultiselectWidget

Bonus:
* Remove puzzling code that claimed to fix a bug that I couldn't reproduce
  but instead made single-character searches never display suggestions
* Clear the input after choosing a menu item

Change-Id: I44e72205880d152639ee823238dc5ab84d34402b

5 years agoFix \n handling for HTMLUsersMultiselectField
Matthew Flaschen [Sun, 21 May 2017 13:28:59 +0000 (15:28 +0200)]
Fix \n handling for HTMLUsersMultiselectField

Bug: T166836
Change-Id: I51b772946f1e50a21fb86cab969defb4647b820b

5 years agoMerge "resourceloader: Restrict addModuleStyles() to type=styles modules"
jenkins-bot [Fri, 30 Jun 2017 01:53:26 +0000 (01:53 +0000)]
Merge "resourceloader: Restrict addModuleStyles() to type=styles modules"

5 years agoMerge "resourceloader: Improve ResourceLoaderClientHtmlTest tests"
jenkins-bot [Fri, 30 Jun 2017 01:43:09 +0000 (01:43 +0000)]
Merge "resourceloader: Improve ResourceLoaderClientHtmlTest tests"

5 years agoMerge "jsminplus: Fix JSNode memory leak from 'continue' statements"
jenkins-bot [Fri, 30 Jun 2017 00:23:01 +0000 (00:23 +0000)]
Merge "jsminplus: Fix JSNode memory leak from 'continue' statements"

5 years agoMerge "SpecialPageFactory::getPage can return null"
jenkins-bot [Thu, 29 Jun 2017 22:33:46 +0000 (22:33 +0000)]
Merge "SpecialPageFactory::getPage can return null"

5 years agoMerge "API: Don't handle non-preflight OPTIONS as CORS"
jenkins-bot [Thu, 29 Jun 2017 22:03:39 +0000 (22:03 +0000)]
Merge "API: Don't handle non-preflight OPTIONS as CORS"

5 years agoSearchInputWidget: Fix documented default for 'pushPending' option
Bartosz Dziewoński [Thu, 29 Jun 2017 19:57:05 +0000 (21:57 +0200)]
SearchInputWidget: Fix documented default for 'pushPending' option

Change-Id: Iadee48af255498c6608cfd00fca29eed9b14f1be

5 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Thu, 29 Jun 2017 20:17:37 +0000 (22:17 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I420c049cd13179f6780c6a7f85857e2bf1389f99

5 years agoRCFilters: Followup I5cede87633147: Set actual value rather than object
Moriel Schottlender [Thu, 29 Jun 2017 18:53:05 +0000 (11:53 -0700)]
RCFilters: Followup I5cede87633147: Set actual value rather than object

Bug: T169042
Change-Id: Ib99981c212dbe1522defc1c1cc34fa01fff91dba

5 years agoClean up release notes
TTO [Thu, 29 Jun 2017 14:50:38 +0000 (14:50 +0000)]
Clean up release notes

Change-Id: Ief5b9a69a5ace43efe8a221e3118c09059361d36

5 years agoUpdate OOjs UI to v0.22.2
James D. Forrester [Thu, 29 Jun 2017 07:34:54 +0000 (08:34 +0100)]
Update OOjs UI to v0.22.2

Release notes:
 https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/History.md;v0.22.2

Depends-On: If6a7aa1d924b416fc95831e1a1b26313e6482cbf
Change-Id: I36a5329fe7d6e134ec1f7b5583017ddff64ca03a

5 years agoresourceloader: Restrict addModuleStyles() to type=styles modules
Timo Tijhof [Thu, 29 Jun 2017 02:18:06 +0000 (19:18 -0700)]
resourceloader: Restrict addModuleStyles() to type=styles modules

If a type=general module is enqueued, don't try to load it as a
stylesheet.

* Per a464d1d41d69f12fe, state tracking is already disabled for
  these loads (as otherwise we wrongly claim state=ready, when in
  fact only the styles and not the scripts were loaded).

* The warning was added in a464d1d41d69f12fe.

* Default install (tested in Vagrant), Wikimedia Beta cluster, and
  Wikimedia production have seen zero violations of this warning
  in the past 7 days.

Raise severity to ERROR and add the 'continue' statement so that
these are now not loaded at all.

Bug: T92459
Change-Id: I211d56ac2df479ebf5b98667c613ecf81489539b

5 years agoresourceloader: Improve ResourceLoaderClientHtmlTest tests
Timo Tijhof [Thu, 29 Jun 2017 02:11:11 +0000 (19:11 -0700)]
resourceloader: Improve ResourceLoaderClientHtmlTest tests

The example for a mixed user module is outdated. Current user modules
all separate styles and scripts.

To make the effective change by the next commit easier to review,
update these tests first seperately.

Change-Id: I76a8a96eed8a8c39863c535362b1d0144ef2f866

5 years agojsminplus: Fix JSNode memory leak from 'continue' statements
Timo Tijhof [Thu, 29 Jun 2017 01:19:20 +0000 (18:19 -0700)]
jsminplus: Fix JSNode memory leak from 'continue' statements

During parsing of scripts containing a 'continue' statement,
the JSNode for that statements, and all containing blocks (e.g. conditional
blocks, for-loop/white-loop statements , etc.) were being held
in memory indefinitely.

Bug: T31784
Change-Id: Id7006c264a470ba665434f6f275e49a1516b73ae

5 years agoMerge "Remove space after cast"
jenkins-bot [Thu, 29 Jun 2017 01:11:32 +0000 (01:11 +0000)]
Merge "Remove space after cast"

5 years agoMerge "clone keyword must not be used as a function"
jenkins-bot [Thu, 29 Jun 2017 01:11:20 +0000 (01:11 +0000)]
Merge "clone keyword must not be used as a function"

5 years agoMerge "RCFilters: Fix typo in removing a saved query"
jenkins-bot [Thu, 29 Jun 2017 00:25:07 +0000 (00:25 +0000)]
Merge "RCFilters: Fix typo in removing a saved query"

5 years agoMerge "RCFilters: Correct display of save filter popup"
jenkins-bot [Thu, 29 Jun 2017 00:14:15 +0000 (00:14 +0000)]
Merge "RCFilters: Correct display of save filter popup"

5 years agoRCFilters: Fix typo in removing a saved query
Moriel Schottlender [Thu, 29 Jun 2017 00:06:12 +0000 (17:06 -0700)]
RCFilters: Fix typo in removing a saved query

Bug: T169107
Change-Id: I7c1535f6ae75159a069ebde7db781f6a875fcb3c

5 years agoRCFilters: Followup I200720ffde8ad: Hide extended footer if gater is disabled
Moriel Schottlender [Wed, 28 Jun 2017 23:44:54 +0000 (16:44 -0700)]
RCFilters: Followup I200720ffde8ad: Hide extended footer if gater is disabled

Bug: T169163
Change-Id: I62f63cbf06a7e42864faca1a196903eb34ea077b

5 years agoMerge "resourceloader: Use "\n" instead of ";" as separator for scripts"
jenkins-bot [Wed, 28 Jun 2017 23:30:19 +0000 (23:30 +0000)]
Merge "resourceloader: Use "\n" instead of ";" as separator for scripts"

5 years agoMerge "Add SearchIndexField::getEngineHints()"
jenkins-bot [Wed, 28 Jun 2017 20:37:13 +0000 (20:37 +0000)]
Merge "Add SearchIndexField::getEngineHints()"

5 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Wed, 28 Jun 2017 20:01:23 +0000 (22:01 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I889cf1f5e93554486b452922edd474ef865bec7f

5 years agoParamaterize TransactionProfiler log entries
Aaron Schulz [Thu, 22 Jun 2017 21:08:05 +0000 (14:08 -0700)]
Paramaterize TransactionProfiler log entries

Change-Id: I4e468d818af48dba21cd2c567f4e6a58beb0924b

5 years agoSpecialPageFactory::getPage can return null
Umherirrender [Wed, 28 Jun 2017 18:22:20 +0000 (20:22 +0200)]
SpecialPageFactory::getPage can return null

Change-Id: I12b4969ec0c6b8d5a1d8feeda27152ba6075c4fd

5 years agoRecord PostSend master queries via TransactionProfiler
Aaron Schulz [Thu, 22 Jun 2017 20:58:54 +0000 (13:58 -0700)]
Record PostSend master queries via TransactionProfiler

Bug: T166199
Change-Id: Ib2f858f09aae65af6aa8324edb72d8a16094f2b3

5 years agoRCFilters: Correct display of save filter popup
Moriel Schottlender [Wed, 28 Jun 2017 17:35:53 +0000 (10:35 -0700)]
RCFilters: Correct display of save filter popup

- Correct language in the 'apply' button
- Add a placeholder to the input
- Make the 'apply' button disabled if the input is empty
- Remove the use of the OOUI-built-in validation, since all
  we do is "validate" that the input isn't empty, and there's
  no need to show error mode (red border) for that, especially
  since the 'apply' button is disabled in that case.

Bug: T169042
Change-Id: I5e3600b1ac8e63d8a25c0540468fe42febfc3a70

5 years agoclone keyword must not be used as a function
Umherirrender [Tue, 27 Jun 2017 19:44:12 +0000 (21:44 +0200)]
clone keyword must not be used as a function

Also changed a require_once

Change-Id: Ib8030ea5320a62ee4f114d8d506382c5665e3e02

5 years agoMerge "Use Devanagari digits for list items on mai.wikipedia"
jenkins-bot [Wed, 28 Jun 2017 14:06:37 +0000 (14:06 +0000)]
Merge "Use Devanagari digits for list items on mai.wikipedia"

5 years agoMerge "User: Avoid deprecated Linker::link()"
jenkins-bot [Wed, 28 Jun 2017 12:49:55 +0000 (12:49 +0000)]
Merge "User: Avoid deprecated Linker::link()"

5 years agoUse visibleByteLimit on Special:MovePage
Ed Sanders [Fri, 23 Jun 2017 06:57:46 +0000 (23:57 -0700)]
Use visibleByteLimit on Special:MovePage

Change-Id: Ie9e2bef8397851ca5899bfb7a3849853d07590ff

5 years agoMerge "Factor out byte limit label logic from edit page to utility function"
jenkins-bot [Wed, 28 Jun 2017 12:31:29 +0000 (12:31 +0000)]
Merge "Factor out byte limit label logic from edit page to utility function"

5 years agoUse Devanagari digits for list items on mai.wikipedia
Sfic [Wed, 28 Jun 2017 08:15:52 +0000 (08:15 +0000)]
Use Devanagari digits for list items on mai.wikipedia

Bug: T168781
Change-Id: I0f715daaacbe2cee236d28866b23893c342922a2

5 years agoMerge "Remove exception and drop cloned tables in PostgresSQL too"
jenkins-bot [Wed, 28 Jun 2017 08:43:08 +0000 (08:43 +0000)]
Merge "Remove exception and drop cloned tables in PostgresSQL too"

5 years agoRCFilters: Followup I436f00bc87db: Remove onPopupToggle listener
Moriel Schottlender [Wed, 28 Jun 2017 08:10:25 +0000 (01:10 -0700)]
RCFilters: Followup  I436f00bc87db: Remove onPopupToggle listener

Bug: T168828
Change-Id: Ie6d73f38335ff1c5bc88602119ddf3e2138eba60

5 years agoresourceloader: Use "\n" instead of ";" as separator for scripts
Timo Tijhof [Wed, 28 Jun 2017 02:51:03 +0000 (19:51 -0700)]
resourceloader: Use "\n" instead of ";" as separator for scripts

This fixes two bugs:

* 1) When two modules are requested, and the first one ends with ";"
     inside a comment, the second module might become part of
     that comment.
* 2) A request with script=only where the requested module content
     ends in a statement without ";", but has a comment after it
     that does ends with a semicolon, then in debug=false, mw.loader.state()
     would be appended directly after the semicolon-less statement because
     the check is performed before minification.
     Previously:
     script> foo()
     script> // bar();
     states> mw.loader.state( {} );
     Became (minified separately):
     script> foo()
     states> mw.loader.state({});
     Became (concatenated)
     > foo()mw.loader.state();
     Which is invalid code.

Both of these are now fixed.

Bug: T162719
Change-Id: Ic8114c46ce232f5869400eaa40d3027003550533

5 years agofilecache: Use current action instead of "view" only in outage mode
Timo Tijhof [Wed, 28 Jun 2017 03:52:23 +0000 (20:52 -0700)]
filecache: Use current action instead of "view" only in outage mode

Regression from 3ad9e41be9. Prior, $action was also passed to HTMLFileCache.

Change-Id: Ie0f1c8b73d306bc710c346ad97868c53fb59809d

5 years agoresourceloader: Add more concat test cases for makeModuleResponse
Timo Tijhof [Wed, 28 Jun 2017 02:10:03 +0000 (19:10 -0700)]
resourceloader: Add more concat test cases for makeModuleResponse

Bug: T162719
Change-Id: Ic8d4a022dbe8c7998924fb20d727936e68cb11d2

5 years agoMerge "Record TransactionProfiler violations beyond the first-by-type"
jenkins-bot [Wed, 28 Jun 2017 01:13:14 +0000 (01:13 +0000)]
Merge "Record TransactionProfiler violations beyond the first-by-type"

5 years agoMerge "Allow SVGs using an older proposed recommendation DTD"
Brian Wolff [Wed, 28 Jun 2017 00:53:53 +0000 (00:53 +0000)]
Merge "Allow SVGs using an older proposed recommendation DTD"

5 years agoRemove ParserOptions::optionsHashPre30()
Brad Jorsch [Wed, 21 Jun 2017 15:35:32 +0000 (11:35 -0400)]
Remove ParserOptions::optionsHashPre30()

The pre-1.30 version of ParserOptions::optionsHash() was kept
temporarily as ParserOptions::optionsHashPre30() to prevent a cache
stampede on WMF sites when the hash format was changed in I7fb9ffca9.

Now that the cache has been rebuilt, it's no longer needed and we should
clean it up instead of leaving it forever to bitrot.

Change-Id: I037d8dfdefe72a295547bd331bc1454e69cb418d

5 years agoMerge "Add constants for schema migration feature flags"
jenkins-bot [Wed, 28 Jun 2017 00:11:05 +0000 (00:11 +0000)]
Merge "Add constants for schema migration feature flags"

5 years agoMerge "benchmarks: Add benchmark for JSMinPlus"
jenkins-bot [Wed, 28 Jun 2017 00:00:12 +0000 (00:00 +0000)]
Merge "benchmarks: Add benchmark for JSMinPlus"

5 years agoRecord TransactionProfiler violations beyond the first-by-type
Aaron Schulz [Thu, 22 Jun 2017 20:56:02 +0000 (13:56 -0700)]
Record TransactionProfiler violations beyond the first-by-type

Beyond giving a more complete picture, this can be used to adjust
the PostSend criteria to log master queries under the restInPeace()
entry point.

Bug: T166199
Change-Id: If5cf704ba10291d0eba63e66b388666fde3ca649

5 years agoMerge "Fix SearchEngineTest test descriptions"
jenkins-bot [Tue, 27 Jun 2017 23:44:30 +0000 (23:44 +0000)]
Merge "Fix SearchEngineTest test descriptions"

5 years agoMerge "Fix highlighting for phrase queries"
jenkins-bot [Tue, 27 Jun 2017 23:44:27 +0000 (23:44 +0000)]
Merge "Fix highlighting for phrase queries"

5 years agoMerge "Remove "@author Aaron Schulz" annotations"
jenkins-bot [Tue, 27 Jun 2017 22:39:10 +0000 (22:39 +0000)]
Merge "Remove "@author Aaron Schulz" annotations"

5 years agoMerge "resourceloader: Add basic tests for getScript() and buildContent()"
jenkins-bot [Tue, 27 Jun 2017 22:35:52 +0000 (22:35 +0000)]
Merge "resourceloader: Add basic tests for getScript() and buildContent()"

5 years agoRemove "@author Aaron Schulz" annotations
Aaron Schulz [Tue, 27 Jun 2017 06:14:22 +0000 (23:14 -0700)]
Remove "@author Aaron Schulz" annotations

Bug: T139301
Change-Id: Ib5248e8e27d60611c7373bce4b29dd5e85aa3489

5 years agoMerge "benchmarks: Add reporting of resource usage"
jenkins-bot [Tue, 27 Jun 2017 22:19:19 +0000 (22:19 +0000)]
Merge "benchmarks: Add reporting of resource usage"

5 years agobenchmarks: Add benchmark for JSMinPlus
Timo Tijhof [Thu, 15 Jun 2017 17:06:10 +0000 (18:06 +0100)]
benchmarks: Add benchmark for JSMinPlus

Example usage

> mwscript maintenance/benchmarks/benchmarkJSMinPlus.php --file resources/lib/jquery/jquery.js -v

Bug: T31784
Change-Id: I3c11574adb864a4bfbfceba137e285fdb8dc66d2

5 years agoMerge "Fix typo in comment."
jenkins-bot [Tue, 27 Jun 2017 22:10:51 +0000 (22:10 +0000)]
Merge "Fix typo in comment."

5 years agoMerge "tests: Use TestingAccessWrapper to reload LanguageConverter tables"
jenkins-bot [Tue, 27 Jun 2017 22:08:42 +0000 (22:08 +0000)]
Merge "tests: Use TestingAccessWrapper to reload LanguageConverter tables"

5 years agoMerge "tests: Reset LanguageConverter conversion tables between test cases"
jenkins-bot [Tue, 27 Jun 2017 22:08:39 +0000 (22:08 +0000)]
Merge "tests: Reset LanguageConverter conversion tables between test cases"

5 years agoMerge "RCFilters: Move legend into results (both js and nojs output)"
jenkins-bot [Tue, 27 Jun 2017 21:15:10 +0000 (21:15 +0000)]
Merge "RCFilters: Move legend into results (both js and nojs output)"

5 years agoFix typo in comment.
C. Scott Ananian [Tue, 27 Jun 2017 21:11:31 +0000 (17:11 -0400)]
Fix typo in comment.

Change-Id: Ia656c55ca22fa30b5a911b8cb3a6218c916d3316

5 years agotests: Use TestingAccessWrapper to reload LanguageConverter tables
C. Scott Ananian [Tue, 27 Jun 2017 21:09:12 +0000 (17:09 -0400)]
tests: Use TestingAccessWrapper to reload LanguageConverter tables

Make the LanguageConverter::reloadTables method actually private,
and use the TestingAccessWrapper to call it when running parser tests.

Follow-up to I65736520cd04bfe8949b29ade07338a6e1b88a4d.

Change-Id: I43b81b8fef6441ad50b858ff7757732ecb5eef91

5 years agoMerge "Fix border-radii on FilterTagMultiselectWidget"
jenkins-bot [Tue, 27 Jun 2017 20:07:08 +0000 (20:07 +0000)]
Merge "Fix border-radii on FilterTagMultiselectWidget"

5 years agoMerge "RangeChronologicalPager: Don't clear $offset when $this->rangeConds is set"
jenkins-bot [Tue, 27 Jun 2017 20:01:28 +0000 (20:01 +0000)]
Merge "RangeChronologicalPager: Don't clear $offset when $this->rangeConds is set"

5 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Tue, 27 Jun 2017 19:54:39 +0000 (21:54 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I27707dbaae9edf04ef400300801c339a22df3eb3

5 years agoMerge "RCFilters: Always use the filled bookmark icon (unClip)"
jenkins-bot [Tue, 27 Jun 2017 19:47:39 +0000 (19:47 +0000)]
Merge "RCFilters: Always use the filled bookmark icon (unClip)"

5 years agoMerge "RCFilters: Simplify "Saved filter settings" to "Saved filters""
jenkins-bot [Tue, 27 Jun 2017 19:47:04 +0000 (19:47 +0000)]
Merge "RCFilters: Simplify "Saved filter settings" to "Saved filters""

5 years agoMerge "Downgrade 'found writes/callbacks pending.' from error to info"
jenkins-bot [Tue, 27 Jun 2017 19:20:54 +0000 (19:20 +0000)]
Merge "Downgrade 'found writes/callbacks pending.' from error to info"

5 years agoRCFilters: Move legend into results (both js and nojs output)
Moriel Schottlender [Tue, 27 Jun 2017 18:19:31 +0000 (11:19 -0700)]
RCFilters: Move legend into results (both js and nojs output)

Move the legend from the fieldset area to the results area.

Bug: T168043
Change-Id: I40454b194fe3975d8d4ac13d96774bfa5b5d5a46

5 years agoMerge "RCFilters: Make extra filters footer non-sticky"
jenkins-bot [Tue, 27 Jun 2017 19:14:08 +0000 (19:14 +0000)]
Merge "RCFilters: Make extra filters footer non-sticky"

5 years agoMerge "RCFilters: Correct default view title"
jenkins-bot [Tue, 27 Jun 2017 19:10:51 +0000 (19:10 +0000)]
Merge "RCFilters: Correct default view title"

5 years agoMerge "RCFilters: Remove <hr> if extension table is empty"
jenkins-bot [Tue, 27 Jun 2017 19:08:59 +0000 (19:08 +0000)]
Merge "RCFilters: Remove <hr> if extension table is empty"

5 years agoRCFilters: Make extra filters footer non-sticky
Moriel Schottlender [Tue, 27 Jun 2017 00:17:19 +0000 (17:17 -0700)]
RCFilters: Make extra filters footer non-sticky

Bug: T168851
Change-Id: I504847e4b07d473786a4026b053a55ae460897e8

5 years agoAvoid checking double-prefixed table names in mysql tableExists()
Aaron Schulz [Tue, 27 Jun 2017 18:31:35 +0000 (11:31 -0700)]
Avoid checking double-prefixed table names in mysql tableExists()

Change-Id: I9d91a5305227171d0776ffa443d4e538fbe1b15f

5 years agoRemove space after cast
Umherirrender [Tue, 27 Jun 2017 18:13:04 +0000 (20:13 +0200)]
Remove space after cast

One remaining file was fixed

Change-Id: I95f77028219046e14c887cd2e0d5f6ffe98b9cd8

5 years agoFix SearchEngineTest test descriptions
David Causse [Tue, 27 Jun 2017 13:58:16 +0000 (15:58 +0200)]
Fix SearchEngineTest test descriptions

These should describe the test not the failure.

Change-Id: I82601795d925d3dd7548909f18c325eeaebd83ff

5 years agoAllow SVGs using an older proposed recommendation DTD
Matthias Mullie [Tue, 27 Jun 2017 13:47:36 +0000 (15:47 +0200)]
Allow SVGs using an older proposed recommendation DTD

Dia software seems to use this DTD (at least in some versions)

Bug: T168856
Change-Id: I51ad7ff4a935d4edb78e091142be9c58017dd3af

5 years agoMerge "resourceloader: Add @covers for stripBom and makeModuleResponse tests"
jenkins-bot [Tue, 27 Jun 2017 13:18:10 +0000 (13:18 +0000)]
Merge "resourceloader: Add @covers for stripBom and makeModuleResponse tests"

5 years agoMerge "resourceloader: Add @covers for stripBom() test"
jenkins-bot [Tue, 27 Jun 2017 13:18:07 +0000 (13:18 +0000)]
Merge "resourceloader: Add @covers for stripBom() test"

5 years agoMerge "resourceloader: Complete test coverage for FileModule::getTemplates()"
jenkins-bot [Tue, 27 Jun 2017 13:16:46 +0000 (13:16 +0000)]
Merge "resourceloader: Complete test coverage for FileModule::getTemplates()"

5 years agoMerge "build: Prepare for mediawiki/mediawiki-codesniffer to 0.9.0"
jenkins-bot [Tue, 27 Jun 2017 08:57:28 +0000 (08:57 +0000)]
Merge "build: Prepare for mediawiki/mediawiki-codesniffer to 0.9.0"

5 years agoMerge "Remove "@author Bryan Davis" and "Brad Jorsch" annotations"
jenkins-bot [Tue, 27 Jun 2017 06:02:23 +0000 (06:02 +0000)]
Merge "Remove "@author Bryan Davis" and "Brad Jorsch" annotations"

5 years agoresourceloader: Add basic tests for getScript() and buildContent()
Timo Tijhof [Tue, 27 Jun 2017 05:04:21 +0000 (22:04 -0700)]
resourceloader: Add basic tests for getScript() and buildContent()

Bug: T162719
Change-Id: I37d64da77682adfef61e78033d639b623d7c9c2b

5 years agoresourceloader: Add @covers for stripBom and makeModuleResponse tests
Timo Tijhof [Tue, 27 Jun 2017 04:44:11 +0000 (21:44 -0700)]
resourceloader: Add @covers for stripBom and makeModuleResponse tests

Change-Id: Ie32178cdd03a79a0ab871122acf081c65e5a9f4d

5 years agoresourceloader: Add @covers for stripBom() test
Timo Tijhof [Tue, 27 Jun 2017 04:44:11 +0000 (21:44 -0700)]
resourceloader: Add @covers for stripBom() test

Change-Id: I3403b6617121f5965ef7aa125eb2528db7c89e95

5 years agoresourceloader: Complete test coverage for FileModule::getTemplates()
Timo Tijhof [Tue, 27 Jun 2017 04:21:36 +0000 (21:21 -0700)]
resourceloader: Complete test coverage for FileModule::getTemplates()

* Add coverage for the 'else' branch for file not existing and
  an exception being thrown.

Change-Id: Ia7d608f1ed72f07f46b969046d9c9910fbfd738d

5 years agoUser: Avoid deprecated Linker::link()
Kunal Mehta [Tue, 27 Jun 2017 02:19:27 +0000 (19:19 -0700)]
User: Avoid deprecated Linker::link()

Change-Id: Id50615c1cd4c49ea7b04747f15e353448e971b66

5 years agoRCFilters: Remove <hr> if extension table is empty
Moriel Schottlender [Tue, 27 Jun 2017 00:37:18 +0000 (17:37 -0700)]
RCFilters: Remove <hr> if extension table is empty

Bug: T168325
Change-Id: I5f537722aeef8d52cd5b0555519be97a7675491f

5 years agoMerge "RCFilters: Add 'single_option' group type"
jenkins-bot [Tue, 27 Jun 2017 00:29:48 +0000 (00:29 +0000)]
Merge "RCFilters: Add 'single_option' group type"

5 years agoRCFilters: Correct default view title
Moriel Schottlender [Tue, 27 Jun 2017 00:25:14 +0000 (17:25 -0700)]
RCFilters: Correct default view title

The key was changed from "label" to "title" but that was not changed
in the default view. Change the definition key and adjust the name
of the method so it isn't confusing.

Bug: T168855
Change-Id: Ib94f57d3bcce94a02fac25d66b893a68aa648e84

5 years agoRCFilters: Add 'single_option' group type
Moriel Schottlender [Fri, 23 Jun 2017 20:30:42 +0000 (13:30 -0700)]
RCFilters: Add 'single_option' group type

Group type that only allows a single option to be selected
from its range of items.

Bonus: Add the ability to have a view that is hidden from
the menus

Bug: T162784
Bug: T162786
Change-Id: Ide93491a49c1405926ac171c7924a469e94c0e0a

5 years agoRCFilters: Simplify "Saved filter settings" to "Saved filters"
Roan Kattouw [Tue, 27 Jun 2017 00:00:56 +0000 (17:00 -0700)]
RCFilters: Simplify "Saved filter settings" to "Saved filters"

Bug: T167876
Change-Id: I5beb2433a9fb0ba8493ec571c1c4d37cd4ee26ba

5 years agoRCFilters: Always use the filled bookmark icon (unClip)
Roan Kattouw [Mon, 26 Jun 2017 23:49:52 +0000 (16:49 -0700)]
RCFilters: Always use the filled bookmark icon (unClip)

Bug: T168828
Change-Id: I436f00bc87db143116125a185abd8000132df195

5 years agoMerge "Replace some usages of Linker::link with LinkRenderer"
jenkins-bot [Mon, 26 Jun 2017 22:56:45 +0000 (22:56 +0000)]
Merge "Replace some usages of Linker::link with LinkRenderer"

5 years agoMerge "RCFilters: Invert the muted state of inverted namespace options"
jenkins-bot [Mon, 26 Jun 2017 22:46:47 +0000 (22:46 +0000)]
Merge "RCFilters: Invert the muted state of inverted namespace options"

5 years agoRCFilters: Invert the muted state of inverted namespace options
Moriel Schottlender [Wed, 21 Jun 2017 21:16:51 +0000 (14:16 -0700)]
RCFilters: Invert the muted state of inverted namespace options

Since the inversion happened, the background of selected items was
overridden by "muted" background, so we had to change a few more
details to get things to work properly:
- Override selected color even if the item is muted (previously,
  'selected' cannot be muted by definition, but this patch changes
  that and hence needs to make sure selected color overrides the
  muted color state)
- Set correct muted state on the namespace items to be reversed.
- The highlight/select/mute background issue exposed a secondary
  issue when switching views by clicking the 'tag' item, whereby
  the change of view itself causes the input to empty, and triggers
  the updateItemVisibility in MenuSelectWidget, which then selects
  the first item. This shouldn't happen when the user is actively
  selecting an item from the tags, so a method of recognizing that
  the user is actively selecting an item was added.

Change-Id: Idf5c2232216ad6a38b29bbc103bbca66f56533b7

5 years agoRemove "@author Bryan Davis" and "Brad Jorsch" annotations
Bryan Davis [Tue, 13 Jun 2017 16:51:53 +0000 (10:51 -0600)]
Remove "@author Bryan Davis" and "Brad Jorsch" annotations

Undo traces of a practice we carried over from past projects and
existing examples that is neither universal nor actively encouraged in
the MediaWiki codebase.

Bug: T139301
Change-Id: I5c9c89b72a45a44aa4264a5e57b003c1a86cdf6e
Co-Authored-By: Brad Jorsch <bjorsch@wikimedia.org>
5 years agoMerge "mw.filewarning: Increase the area of the warning button"
jenkins-bot [Mon, 26 Jun 2017 20:25:38 +0000 (20:25 +0000)]
Merge "mw.filewarning: Increase the area of the warning button"

5 years agoMerge "mediawiki.Title: Remove needless $.type() and minor clean up"
jenkins-bot [Mon, 26 Jun 2017 20:21:18 +0000 (20:21 +0000)]
Merge "mediawiki.Title: Remove needless $.type() and minor clean up"