lhc/web/wiklou.git
4 years agoMerge "Remove useless StatusTest::testCanConstruct()"
jenkins-bot [Thu, 28 Dec 2017 10:42:14 +0000 (10:42 +0000)]
Merge "Remove useless StatusTest::testCanConstruct()"

4 years agoMerge "Remove resolved todo from MWNamespace test"
jenkins-bot [Thu, 28 Dec 2017 10:40:10 +0000 (10:40 +0000)]
Merge "Remove resolved todo from MWNamespace test"

4 years agoMerge "Improve @covers for TemplateParserTest"
jenkins-bot [Thu, 28 Dec 2017 10:34:47 +0000 (10:34 +0000)]
Merge "Improve @covers for TemplateParserTest"

4 years agoMerge "make 7zip wrapper usable for dumping text revisions again"
jenkins-bot [Thu, 28 Dec 2017 09:59:10 +0000 (09:59 +0000)]
Merge "make 7zip wrapper usable for dumping text revisions again"

4 years agoMerge "Change php extract() to explicit code"
jenkins-bot [Thu, 28 Dec 2017 09:44:58 +0000 (09:44 +0000)]
Merge "Change php extract() to explicit code"

4 years agoMerge "Add HTML attributes lang and dir to toctitle"
jenkins-bot [Thu, 28 Dec 2017 09:37:47 +0000 (09:37 +0000)]
Merge "Add HTML attributes lang and dir to toctitle"

4 years agoMerge "maintenance: Add unit test for Benchmarker class"
jenkins-bot [Thu, 28 Dec 2017 09:22:01 +0000 (09:22 +0000)]
Merge "maintenance: Add unit test for Benchmarker class"

4 years agoImprove @covers for TemplateParserTest
Kunal Mehta [Thu, 28 Dec 2017 08:31:08 +0000 (00:31 -0800)]
Improve @covers for TemplateParserTest

The current @covers tags for TemplateParserTest are an incomplete call
stack for TemplateParser::processTemplate, and miss out on some
functions that are called. Those functions could be repeated in @covers
tags, but it would be burdensome to keep it up to date.

Instead, just use class level @covers for the whole test case. This also
takes care of the previously uncovered testEnableRecursivePartials().

Change-Id: I475ceba26b70a115b40d7735834a07f298f7bf99

4 years agoRemove resolved todo from MWNamespace test
Kunal Mehta [Thu, 28 Dec 2017 08:27:40 +0000 (00:27 -0800)]
Remove resolved todo from MWNamespace test

The todo was added by Addshore in aea1b27db02 at the same time he added
all the @covers tags, so it appears to all be resolved.

Change-Id: I03d866fdd1ca382ca2b1699e01a0dd9a28eef1ec

4 years agoRemove useless StatusTest::testCanConstruct()
Kunal Mehta [Thu, 28 Dec 2017 08:25:25 +0000 (00:25 -0800)]
Remove useless StatusTest::testCanConstruct()

Neither Status, nor StatusValue have constructors, so there's not much
point testing whether the object can be constructed.

Change-Id: I170940889b5da5198ef4576d04786f84c293dd01

4 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Thu, 28 Dec 2017 08:04:14 +0000 (09:04 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: Icc11f7ae67c7a70f4c59eec632c74926700a69c9

4 years agomaintenance: Add unit test for Benchmarker class
Timo Tijhof [Wed, 27 Dec 2017 20:44:38 +0000 (21:44 +0100)]
maintenance: Add unit test for Benchmarker class

Change-Id: I3f835fc07741fd42b8adb5b019f72589429cc14f

4 years agoMerge "phpunit: Remove outdated comment about calling of LinkCache::clear()"
jenkins-bot [Wed, 27 Dec 2017 22:04:37 +0000 (22:04 +0000)]
Merge "phpunit: Remove outdated comment about calling of LinkCache::clear()"

4 years agoMerge "mw.rcfilters.ui.SaveFiltersPopupButtonWidget: Remove pointless option"
jenkins-bot [Wed, 27 Dec 2017 21:39:36 +0000 (21:39 +0000)]
Merge "mw.rcfilters.ui.SaveFiltersPopupButtonWidget: Remove pointless option"

4 years agoMerge "Add grep comment for js vars wgRestriction*"
jenkins-bot [Wed, 27 Dec 2017 21:14:54 +0000 (21:14 +0000)]
Merge "Add grep comment for js vars wgRestriction*"

4 years agophpunit: Remove outdated comment about calling of LinkCache::clear()
Timo Tijhof [Wed, 27 Dec 2017 20:52:44 +0000 (21:52 +0100)]
phpunit: Remove outdated comment about calling of LinkCache::clear()

This is actually being called now, from resetDB() between tests.

Change-Id: I5aa15ce3fd57b6fc90b424fde8691ff33c7ddf45

4 years agoAdd HTML attributes lang and dir to toctitle
Fomafix [Fri, 29 May 2015 17:07:55 +0000 (17:07 +0000)]
Add HTML attributes lang and dir to toctitle

The toctitle is in user interface language. This change add the
HTML attributes lang and dir to the toctitle.

This allows to copy (a part of) the rendered HTML to a word processing
and the language for spell checking has the right language.

Change-Id: I17730869f81744560672d7d0acb67ced71e69c4e

4 years agoAdd tests for TextboxBuilder
Kunal Mehta [Mon, 25 Dec 2017 01:35:00 +0000 (17:35 -0800)]
Add tests for TextboxBuilder

Change-Id: I305e0bce902fb027bf02cc8a28e8846808f6437c

4 years agoAdd @covers tags to ContentHandler tests
Kunal Mehta [Mon, 25 Dec 2017 01:08:48 +0000 (17:08 -0800)]
Add @covers tags to ContentHandler tests

Change-Id: I4d0994e91f63a0921343f34ef81a82463b4ab969

4 years agoAdd @covers tags to jobqueue tests
Kunal Mehta [Mon, 25 Dec 2017 04:06:06 +0000 (20:06 -0800)]
Add @covers tags to jobqueue tests

Change-Id: I030634ac87139011e5b3d461064a8c10f10cea84

4 years agoAdd @covers tags to HTMLForm test
Kunal Mehta [Mon, 25 Dec 2017 04:05:52 +0000 (20:05 -0800)]
Add @covers tags to HTMLForm test

Change-Id: I41cc4867b071ee9a58a43760fc4a8b301cda558e

4 years agoAdd @covers tags to filerepo tests
Kunal Mehta [Mon, 25 Dec 2017 04:05:41 +0000 (20:05 -0800)]
Add @covers tags to filerepo tests

Change-Id: I696e03f9ab3934b6cd04e88e1d611060846d32a4

4 years agoAdd @covers tags to LinksUpdate test
Kunal Mehta [Mon, 25 Dec 2017 04:04:47 +0000 (20:04 -0800)]
Add @covers tags to LinksUpdate test

Change-Id: I65ebce434f00a42e06be5168acbaa8fbf637995f

4 years agoAdd @covers tags to includes/debug tests
Kunal Mehta [Mon, 25 Dec 2017 04:04:36 +0000 (20:04 -0800)]
Add @covers tags to includes/debug tests

Change-Id: Ida6562c87204f1680239d0bdbfde4d6fdc9bf748

4 years agoAdd @covers tags for RevisionStoreDbTest
Kunal Mehta [Mon, 25 Dec 2017 04:04:11 +0000 (20:04 -0800)]
Add @covers tags for RevisionStoreDbTest

Change-Id: Ie7ce23d5ad67816c1ae8c2c838f8263fca17b4f8

4 years agoMerge "Add @covers tags to miscellaneous tests"
jenkins-bot [Wed, 27 Dec 2017 17:40:44 +0000 (17:40 +0000)]
Merge "Add @covers tags to miscellaneous tests"

4 years agoMerge "Add @covers tags to utils tests"
jenkins-bot [Wed, 27 Dec 2017 17:36:14 +0000 (17:36 +0000)]
Merge "Add @covers tags to utils tests"

4 years agoMerge "Add @covers tags to user tests"
jenkins-bot [Wed, 27 Dec 2017 17:36:11 +0000 (17:36 +0000)]
Merge "Add @covers tags to user tests"

4 years agoMerge "Add @covers tags to specials tests"
jenkins-bot [Wed, 27 Dec 2017 17:30:27 +0000 (17:30 +0000)]
Merge "Add @covers tags to specials tests"

4 years agoMerge "Add @covers tags to parser tests"
jenkins-bot [Wed, 27 Dec 2017 17:27:02 +0000 (17:27 +0000)]
Merge "Add @covers tags to parser tests"

4 years agoMerge "Add @covers tags to page tests"
jenkins-bot [Wed, 27 Dec 2017 17:26:59 +0000 (17:26 +0000)]
Merge "Add @covers tags to page tests"

4 years agoMerge "Add @covers tags to objectcache tests"
jenkins-bot [Wed, 27 Dec 2017 17:19:57 +0000 (17:19 +0000)]
Merge "Add @covers tags to objectcache tests"

4 years agoMerge "Add @covers tags to media tests"
jenkins-bot [Wed, 27 Dec 2017 17:19:28 +0000 (17:19 +0000)]
Merge "Add @covers tags to media tests"

4 years agoMerge "Add @covers tags to logging tests"
jenkins-bot [Wed, 27 Dec 2017 17:19:25 +0000 (17:19 +0000)]
Merge "Add @covers tags to logging tests"

4 years agoDocument "arrays of UserGroupMembership objects" as such
Thiemo Mättig [Wed, 27 Dec 2017 11:40:19 +0000 (12:40 +0100)]
Document "arrays of UserGroupMembership objects" as such

Change-Id: I3c60fb977a329e39933d50e275a738296bc17599

4 years agoMerge "Simplify ApiQueryRecentChangesIntegrationTest"
jenkins-bot [Wed, 27 Dec 2017 12:51:53 +0000 (12:51 +0000)]
Merge "Simplify ApiQueryRecentChangesIntegrationTest"

4 years agoMerge "Integration tests for ApiQueryRecentChanges"
jenkins-bot [Wed, 27 Dec 2017 12:33:27 +0000 (12:33 +0000)]
Merge "Integration tests for ApiQueryRecentChanges"

4 years agoSimplify ApiQueryRecentChangesIntegrationTest
Thiemo Mättig [Wed, 27 Dec 2017 12:23:17 +0000 (13:23 +0100)]
Simplify ApiQueryRecentChangesIntegrationTest

This patch does two major things to the newly introduced
ApiQueryRecentChangesIntegrationTest:

* It rips the confusingly complicated assertArraySubsetsEqual appart.

* It removes all wikitext content. Note that no assertion is done on this
content (not even in the test that is about adding a category). The tests
run just fine with automatically generated content. I had to introduce the
$i counter to make sure consecutive edits are done with different content.
Otherwise the later edit is not stored.

Change-Id: Iae585be86f3fd9bff7d2b4b7b218d5b0b4258603

4 years agoresources: Upgrade jquery.chosen from 0.9.14 to 1.8.2
James D. Forrester [Mon, 27 Nov 2017 23:44:40 +0000 (15:44 -0800)]
resources: Upgrade jquery.chosen from 0.9.14 to 1.8.2

Change-Id: If9c720ebca8ca663869d0f73b0cd3ea415262cff

4 years agoFix inconsistent capitalization of different method calls
Thiemo Mättig [Wed, 27 Dec 2017 11:33:38 +0000 (12:33 +0100)]
Fix inconsistent capitalization of different method calls

Change-Id: I9f5b9e59e8cdadf65e80077fe2d3a9822b4592fe

4 years agoAdd grep comment for js vars wgRestriction*
Umherirrender [Wed, 27 Dec 2017 02:04:45 +0000 (03:04 +0100)]
Add grep comment for js vars wgRestriction*

Change-Id: I974841acf97e9426ed2338f210821e91d7f94286

4 years agoMerge "Special:ProtectedPages: Use HTMLForm"
jenkins-bot [Wed, 27 Dec 2017 10:38:08 +0000 (10:38 +0000)]
Merge "Special:ProtectedPages: Use HTMLForm"

4 years agoSpecial:ProtectedPages: Use HTMLForm
Prateek Saxena [Fri, 8 Sep 2017 12:57:07 +0000 (22:57 +1000)]
Special:ProtectedPages: Use HTMLForm

We could easily get rid of functions like getExpiryCheck
and getCascadeCheck if required.

Bug: T117722
Change-Id: Ia964192b50464ebec00e0812e14b804fe91132ca

4 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Wed, 27 Dec 2017 09:01:20 +0000 (10:01 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: I9f3aca4cca70f4e0d747eeec0020948298cc14fc

4 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Tue, 26 Dec 2017 09:00:05 +0000 (10:00 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: I495ab349530db87303fc33f06b2610681ba3efc5

4 years agotests: Use checkPHPExtension() instead of re-implementing it
Kunal Mehta [Mon, 25 Dec 2017 03:13:51 +0000 (19:13 -0800)]
tests: Use checkPHPExtension() instead of re-implementing it

Change-Id: I7f5e8684d556befc0aefa302187c573e7a3cff62

4 years agoAdd @covers tags for Collation tests
Kunal Mehta [Mon, 25 Dec 2017 03:10:14 +0000 (19:10 -0800)]
Add @covers tags for Collation tests

Change-Id: I8b0623a6b716acdc9d369349fd4e306dbdc91d18

4 years agoIntegration tests for ApiQueryRecentChanges
Amir Sarabadani [Mon, 25 Dec 2017 02:41:49 +0000 (03:41 +0100)]
Integration tests for ApiQueryRecentChanges

It looks big but it's mostly copy from ApiQueryWatchlistIntegrationTest

Change-Id: I96ccd3e2813e77f47a4432ca434c1c6a212d90ea

4 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Mon, 25 Dec 2017 08:31:53 +0000 (09:31 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: I69b50503f8a9db7b3883f664f2703ab16f9132dc

4 years agoAdd @covers tags to miscellaneous tests
Kunal Mehta [Mon, 25 Dec 2017 07:28:03 +0000 (23:28 -0800)]
Add @covers tags to miscellaneous tests

Change-Id: I7e65c1734aef01cd6395ee65204a0158d1635b0c

4 years agoAdd @covers tags to utils tests
Kunal Mehta [Mon, 25 Dec 2017 07:27:22 +0000 (23:27 -0800)]
Add @covers tags to utils tests

Change-Id: Iee44762696120c63fec986de1da76f12849f5957

4 years agoAdd @covers tags to user tests
Kunal Mehta [Mon, 25 Dec 2017 07:27:12 +0000 (23:27 -0800)]
Add @covers tags to user tests

Change-Id: I9ec5644e6b780937492eb5e0ea9e27ebad15ad43

4 years agoAdd @covers tags to specials tests
Kunal Mehta [Mon, 25 Dec 2017 07:27:02 +0000 (23:27 -0800)]
Add @covers tags to specials tests

Change-Id: I626155b890580af38c09795b2b31f625fe942358

4 years agoAdd @covers tags to parser tests
Kunal Mehta [Mon, 25 Dec 2017 07:26:52 +0000 (23:26 -0800)]
Add @covers tags to parser tests

Change-Id: I7bce04bef5e981fd203ad819882482e72ca3f61b

4 years agoAdd @covers tags to page tests
Kunal Mehta [Mon, 25 Dec 2017 07:26:41 +0000 (23:26 -0800)]
Add @covers tags to page tests

Change-Id: Iadb7e8697e9992ca281b7dfe70cf832c82e194de

4 years agoAdd @covers tags to objectcache tests
Kunal Mehta [Mon, 25 Dec 2017 07:26:26 +0000 (23:26 -0800)]
Add @covers tags to objectcache tests

Change-Id: I5db623a582a0424f50d939aaa14fe29da9358b4f

4 years agoAdd @covers tags to media tests
Kunal Mehta [Mon, 25 Dec 2017 07:26:10 +0000 (23:26 -0800)]
Add @covers tags to media tests

Change-Id: Ibd3439f677dec5177b53317f113ed2aa8ddc2633

4 years agoAdd @covers tags to logging tests
Kunal Mehta [Mon, 25 Dec 2017 07:26:01 +0000 (23:26 -0800)]
Add @covers tags to logging tests

Change-Id: Ibb14291a75423ddbb7502a5a0ee24ff0c554a876

4 years agoMerge "Allow fallbacks for $wgReferrerPolicy"
jenkins-bot [Mon, 25 Dec 2017 03:27:42 +0000 (03:27 +0000)]
Merge "Allow fallbacks for $wgReferrerPolicy"

4 years agoFix @covers in XmlTest
Kunal Mehta [Mon, 25 Dec 2017 03:16:26 +0000 (19:16 -0800)]
Fix @covers in XmlTest

Follows up 389fa13ff875.

Change-Id: I32ddf37b24a6b5162b383260233d616cb49f7ddb

4 years agoAdd tests for several methods of Xml
Amir Sarabadani [Mon, 25 Dec 2017 01:54:25 +0000 (02:54 +0100)]
Add tests for several methods of Xml

Added tests for methods: monthSelector, span, buildTable, buildTableRow

Change-Id: I5ca6bb231b5ed95f57f649a92d659245a4852c85

4 years agoMerge "[MCR] Don't require $title to be passed to Revision::newFromId"
jenkins-bot [Sun, 24 Dec 2017 23:42:56 +0000 (23:42 +0000)]
Merge "[MCR] Don't require $title to be passed to Revision::newFromId"

4 years agoMerge "[MCR] Introduce BlobStoreFactory"
jenkins-bot [Sun, 24 Dec 2017 23:39:58 +0000 (23:39 +0000)]
Merge "[MCR] Introduce BlobStoreFactory"

4 years agoMerge "Add `margin-bottom` for editButtons (EditPage)"
jenkins-bot [Sun, 24 Dec 2017 23:38:57 +0000 (23:38 +0000)]
Merge "Add `margin-bottom` for editButtons (EditPage)"

4 years agoAdd @covers tags to CategoriesRdfTest
Kunal Mehta [Sun, 24 Dec 2017 23:23:49 +0000 (15:23 -0800)]
Add @covers tags to CategoriesRdfTest

Change-Id: I6e2eae3fc2ac722dc94bee1a7aa6632e08a4d097

4 years ago[MCR] Introduce BlobStoreFactory
addshore [Sat, 23 Dec 2017 17:14:28 +0000 (17:14 +0000)]
[MCR] Introduce BlobStoreFactory

This allows Revision::getRevisionText to get
a different BlobStore instance when $wiki is passed in
restoring the behaviour for $wiki before the MCR Revision
overhaul patch was merged.
Ia4c20a91e98df0b9b14b138eb4825c55e5200384

Bug: T183634
Bug: T183631
bug: T183583
Change-Id: Ib0949454e9a003c2965adc1aab38e31fcf121afe

4 years agoAllow fallbacks for $wgReferrerPolicy
Gergő Tisza [Sat, 23 Dec 2017 17:35:59 +0000 (09:35 -0800)]
Allow fallbacks for $wgReferrerPolicy

For browsers that support older versions of the Referrer Policy
specification (Edge and Safari), using a value from a newer version of
the specification will result in those browsers falling back to a
default of "default".

So allow $wgReferrerPolicy to have fallbacks if the browser does not
recognize the currently set value. It will emit <meta> tags for each
value in the array, but in reverse order, as browsers will use the last
one that they recognize.

Bug: T180921
Change-Id: Ie0f523fc6937c9ecffc8a6fc791c6b54d5a1cb06

4 years agoMerge "Improve documentation of $wgReferrerPolicy"
jenkins-bot [Sun, 24 Dec 2017 22:56:00 +0000 (22:56 +0000)]
Merge "Improve documentation of $wgReferrerPolicy"

4 years agoMerge "JavaScriptMinifier: Improve docs around parsing of regexp literals"
jenkins-bot [Sun, 24 Dec 2017 21:57:01 +0000 (21:57 +0000)]
Merge "JavaScriptMinifier: Improve docs around parsing of regexp literals"

4 years agoMerge "JavaScriptMinifier: Remove support for unused $statementsOnOwnLine flag"
jenkins-bot [Sun, 24 Dec 2017 21:54:45 +0000 (21:54 +0000)]
Merge "JavaScriptMinifier: Remove support for unused $statementsOnOwnLine flag"

4 years agoJavaScriptMinifier: Improve docs around parsing of regexp literals
Timo Tijhof [Fri, 22 Dec 2017 18:00:42 +0000 (19:00 +0100)]
JavaScriptMinifier: Improve docs around parsing of regexp literals

Bug: T75556
Change-Id: Ifcb6bc21418dfc2e1d3e44dbd2497a0f5f691bf3

4 years agoAdd `margin-bottom` for editButtons (EditPage)
Phantom42 [Wed, 20 Dec 2017 15:18:55 +0000 (17:18 +0200)]
Add `margin-bottom` for editButtons (EditPage)

Bug: T179040
Change-Id: I9e6c04556e4ff7f0cc567877041449f50abf4b4c

4 years agoMerge "Remove duplicate ServiceWiring definitions"
jenkins-bot [Sun, 24 Dec 2017 15:01:11 +0000 (15:01 +0000)]
Merge "Remove duplicate ServiceWiring definitions"

4 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Sat, 23 Dec 2017 20:55:31 +0000 (21:55 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: I26ca1588d1f8063a673809759e5b05728e4dc550

4 years agoRemove duplicate ServiceWiring definitions
addshore [Sat, 23 Dec 2017 17:16:09 +0000 (17:16 +0000)]
Remove duplicate ServiceWiring definitions

Change-Id: I70b377c417ce6937e5d52d1790cf0b6f2ed33c15

4 years agoMerge "Set wgCommentTableSchemaMigrationStage in RevisionStoreTest"
jenkins-bot [Sat, 23 Dec 2017 12:08:42 +0000 (12:08 +0000)]
Merge "Set wgCommentTableSchemaMigrationStage in RevisionStoreTest"

4 years ago[MCR] Don't require $title to be passed to Revision::newFromId
addshore [Fri, 22 Dec 2017 17:32:54 +0000 (17:32 +0000)]
[MCR] Don't require $title to be passed to Revision::newFromId

If the title is not passed in as a param (already known) then select
it in Revision::newFromId instead of waiting for it to be selected
further down the tree.
This means that we can use the same Title object to pass into the
RevisionRecord as well as our legacy Revision object.

The selection chooses either a slave or master depending on
recent writes.

This logic used to be in Revision::getTitle and also in
Revision::newFromConds which was called by newFromId

Bug: T183505
Change-Id: I9cf4ce2c3c86d6bf979a3c88eb423b942b9a1ba4

4 years agomake 7zip wrapper usable for dumping text revisions again
Ariel T. Glenn [Fri, 22 Dec 2017 20:56:28 +0000 (22:56 +0200)]
make 7zip wrapper usable for dumping text revisions again

Change-Id: Ic9c5ad284b542c15f4ab48b5459f00e188a4301a

4 years agoImprove documentation of $wgReferrerPolicy
Gergő Tisza [Sun, 19 Nov 2017 22:19:44 +0000 (14:19 -0800)]
Improve documentation of $wgReferrerPolicy

Reference current version of the spec.

Change-Id: I1cca89b9e46a2b5ae8242715eddfdbd23ccb2d83

4 years agoUpdate reference to DatabaseBase in hooks.txt
Umherirrender [Fri, 22 Dec 2017 22:40:57 +0000 (23:40 +0100)]
Update reference to DatabaseBase in hooks.txt

Change-Id: I65f84c0deadb611380e17a5b1b7593876894c099

4 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Fri, 22 Dec 2017 20:59:32 +0000 (21:59 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: I1edcc9b4af56fb6b66961a14e38d878ff97843e9

4 years agoMerge "RCLFilters: support longer page names"
jenkins-bot [Fri, 22 Dec 2017 20:39:09 +0000 (20:39 +0000)]
Merge "RCLFilters: support longer page names"

4 years agoMerge "resourceloader: Improve JavaScriptMinifier code coverage"
jenkins-bot [Fri, 22 Dec 2017 18:46:27 +0000 (18:46 +0000)]
Merge "resourceloader: Improve JavaScriptMinifier code coverage"

4 years agoJavaScriptMinifier: Remove support for unused $statementsOnOwnLine flag
Timo Tijhof [Fri, 22 Dec 2017 17:47:21 +0000 (18:47 +0100)]
JavaScriptMinifier: Remove support for unused $statementsOnOwnLine flag

The $wgResourceLoaderMinifierStatementsOnOwnLine config var was deprecated
in MediaWiki 1.27. The parameter of minify() was not used by other code, and
no new usage has been introduced since then, either.

Remove the feature from JavaScriptMinifier, and add a release note for that.
The same 1.31 release notes also contain a note already about the removal
of the configuration variable.

The feature was not covered by unit tests.

The following private variables have been removed, that are no longer used
due to this change: $newlineBefore, $newlineAfter, $newlineAdded.

Change-Id: I2cbf271156c1954abb982531d0125b4b9573b12c

4 years agoRCLFilters: support longer page names
Stephane Bisson [Fri, 22 Dec 2017 17:13:12 +0000 (12:13 -0500)]
RCLFilters: support longer page names

* Make target page selector at least 400px wide
* Set the page name as title (tooltip)

Bug: T183484
Change-Id: Ife806c0b5e5c2ab6e9be32194804e89daaf8b71c

4 years agoRCFilters: Move product-specific rules into RCFilters styles
Moriel Schottlender [Fri, 22 Dec 2017 17:53:40 +0000 (09:53 -0800)]
RCFilters: Move product-specific rules into RCFilters styles

Afterwards, the fix in Vector skin should be merged:
Ie36eeddc46c8ea3d154a006fed2fe578be1cd05c

Change-Id: I8357ef2ff0fe4f46b9ee665ef068624de0afd2e5

4 years agoresourceloader: Improve JavaScriptMinifier code coverage
Timo Tijhof [Fri, 22 Dec 2017 17:36:09 +0000 (18:36 +0100)]
resourceloader: Improve JavaScriptMinifier code coverage

Change-Id: I234b996cfec8ef48ce3dc48aabbdf88bc9439c15

4 years ago[MCR] Revision::newFromArchiveRow convert overrides for rows
addshore [Fri, 22 Dec 2017 16:39:00 +0000 (16:39 +0000)]
[MCR] Revision::newFromArchiveRow convert overrides for rows

This method used to overwrite attributes, then passed to
Revision::__construct
RevisionStore::newRevisionFromArchiveRow instead overrides row field
names

This patch adds a conversion for the one field that we need to care
about which is 'page' -> 'page_id'.

After looking through the usages in core and extensions it looks
like this will also fix a bug in the following classes which also
passes in 'page'.
 - RevDelArchivedRevisionItem
 - RevDelArchiveItem

Bug: T183564
Change-Id: I6a472b93663a0599abb55453c6939463ff56275d

4 years agoMerge "[MCR] Add and use $title param to RevisionStore getPrevious/Next"
jenkins-bot [Fri, 22 Dec 2017 14:50:04 +0000 (14:50 +0000)]
Merge "[MCR] Add and use $title param to RevisionStore getPrevious/Next"

4 years ago[MCR] Add and use $title param to RevisionStore getPrevious/Next
addshore [Fri, 22 Dec 2017 14:25:12 +0000 (14:25 +0000)]
[MCR] Add and use $title param to RevisionStore getPrevious/Next

When the title is already known use it.

This is similar to the issue fixed in
I714ee391caac9bc56ce4c037967e424b44d9c2fe.

As of this patch all methods within RevisionStore
that call getTitle internally also have an option
to pass in an already known Title object.

Bug: T183548
Change-Id: Ieabca1cf157fb667c75fc907b9da2917f71c61b3

4 years agoMerge "Remove ESLint inline comments in WebdriverIO configuration files"
jenkins-bot [Fri, 22 Dec 2017 13:43:44 +0000 (13:43 +0000)]
Merge "Remove ESLint inline comments in WebdriverIO configuration files"

4 years ago[MCR] Add optional $title param to Revision byId methods
addshore [Fri, 22 Dec 2017 11:05:31 +0000 (11:05 +0000)]
[MCR] Add optional $title param to Revision byId methods

Bug: T183505
Change-Id: I714ee391caac9bc56ce4c037967e424b44d9c2fe

4 years agoMerge "Improve coverage of PageArchive"
jenkins-bot [Fri, 22 Dec 2017 12:28:16 +0000 (12:28 +0000)]
Merge "Improve coverage of PageArchive"

4 years agoImprove coverage of PageArchive
Amir Sarabadani [Fri, 22 Dec 2017 11:00:13 +0000 (12:00 +0100)]
Improve coverage of PageArchive

Some minor tests

Change-Id: I5c455d6665febc20304e278828ddf8fb3cb5e709

4 years agoMerge "RCFilters: Create one single source of truth for item display"
jenkins-bot [Fri, 22 Dec 2017 11:50:15 +0000 (11:50 +0000)]
Merge "RCFilters: Create one single source of truth for item display"

4 years agoMerge "[WikiImporter::notice] use wfDebug instead of echo in notice()"
jenkins-bot [Fri, 22 Dec 2017 11:33:27 +0000 (11:33 +0000)]
Merge "[WikiImporter::notice] use wfDebug instead of echo in notice()"

4 years agojquery.tablesorter.less: Simplify by using less syntax
Fomafix [Fri, 22 Dec 2017 11:11:26 +0000 (12:11 +0100)]
jquery.tablesorter.less: Simplify by using less syntax

Change-Id: I4f7ee23c02c6ef0d39cb0135e6669f23b6977c59

4 years agoRevisionTest: Fix @covers tags
Kunal Mehta [Fri, 22 Dec 2017 07:29:08 +0000 (23:29 -0800)]
RevisionTest: Fix @covers tags

Namespaced classes need to be absolutely named.

Change-Id: I48a4b356835e9edf3151a0c8d3bed08ea8cfb452

4 years agoRevisionTest: Make @covers tags absolute (re-apply)
Kunal Mehta [Tue, 19 Dec 2017 06:01:02 +0000 (22:01 -0800)]
RevisionTest: Make @covers tags absolute (re-apply)

PHPUnit requires @covers tags to be absolute, they cannot depend
upon `use ...` statements.

Change-Id: I06efa94be3a814acbcb116162db162dcbf36432e

4 years ago[WikiImporter::notice] use wfDebug instead of echo in notice()
Yifei He [Fri, 22 Dec 2017 03:12:28 +0000 (11:12 +0800)]
[WikiImporter::notice] use wfDebug instead of echo in notice()

Make the default notice implementation of notice() function to
send the notice to wfDebug() instead of simply echo to prevent XSS

Bug: T177997
Change-Id: I9ffb597e0642afc1603cdd15e2d09c6f2584b448