lhc/web/wiklou.git
13 years agoFollowup to r81507: Call to undefined method StandardTemplate::showEmailUser()
Marcin Cieślak [Mon, 14 Mar 2011 17:59:31 +0000 (17:59 +0000)]
Followup to r81507: Call to undefined method StandardTemplate::showEmailUser()

Fixes:

PHP Fatal error:  Call to undefined method StandardTemplate::showEmailUser() in skins/Standard.php on line 262

13 years agoComplete the trinity of blocking frontend interfaces by rewriting SpecialIpblocklist:
Happy-melon [Mon, 14 Mar 2011 16:09:44 +0000 (16:09 +0000)]
Complete the trinity of blocking frontend interfaces by rewriting SpecialIpblocklist:
* Move and rename to SpecialBlockList
* Use an HTMLForm in GET mode for the options form
* Use TablePager to organise the results more nicely
* Standardise the filtration for IPs and IP ranges, so looking at blocks for a range will now also show rangeblocks which contain the range
* General tidy up

13 years agoFollow-up r83907: some CSS to achieve flat lists
Happy-melon [Mon, 14 Mar 2011 15:56:51 +0000 (15:56 +0000)]
Follow-up r83907: some CSS to achieve flat lists

13 years agoSome tweaks to HTMLMultiSelect form to make it play nicely with GET forms, and also...
Happy-melon [Mon, 14 Mar 2011 15:50:26 +0000 (15:50 +0000)]
Some tweaks to HTMLMultiSelect form to make it play nicely with GET forms, and also to allow a 'flat list' of options

13 years ago(bug 27564) Timestamp of site module embedded in Squid-cached page HTML
Roan Kattouw [Mon, 14 Mar 2011 15:16:43 +0000 (15:16 +0000)]
(bug 27564) Timestamp of site module embedded in Squid-cached page HTML

13 years ago(bug 27052) CSSMin generated URLs like foo//../bar in some cases, which apparently...
Roan Kattouw [Mon, 14 Mar 2011 15:01:50 +0000 (15:01 +0000)]
(bug 27052) CSSMin generated URLs like foo//../bar in some cases, which apparently resolves to foo/bar rather than foo/../bar or bar . Fixed by eliminating duplicate slashes from the file URL when remapping

13 years ago(bug 27054) Implicit end of statement can break stuff when files are combined. Applie...
Roan Kattouw [Mon, 14 Mar 2011 14:25:23 +0000 (14:25 +0000)]
(bug 27054) Implicit end of statement can break stuff when files are combined. Applied patch by Paul Copperman: add a semicolon to the end of every module when combining; this'll terminate any unterminated final statement, and otherwise create a harmless empty statement.

13 years agoPer Nikerabbit, add some minifier tests for historic failure cases that I had lying...
Roan Kattouw [Mon, 14 Mar 2011 13:55:42 +0000 (13:55 +0000)]
Per Nikerabbit, add some minifier tests for historic failure cases that I had lying around

13 years agoFollowup r83885: implement maximum line length and statement termination (each statem...
Roan Kattouw [Mon, 14 Mar 2011 13:24:30 +0000 (13:24 +0000)]
Followup r83885: implement maximum line length and statement termination (each statement on its own line) in JavaScriptMinifier. Also add globals for these things and update minify.php for these new config vars.

13 years agoFix for r83855: Add new messages to avoid lt;block> <unblock> on Special...
Raimond Spekking [Mon, 14 Mar 2011 12:20:34 +0000 (12:20 +0000)]
Fix for r83855: Add new messages to avoid lt;block> <unblock> on Special:SpecialPages

13 years ago(bug 27528) Incorporate Paul Copperman's minifier
Roan Kattouw [Mon, 14 Mar 2011 11:44:33 +0000 (11:44 +0000)]
(bug 27528) Incorporate Paul Copperman's minifier

13 years agoExpand r83882.
Happy-melon [Mon, 14 Mar 2011 11:22:48 +0000 (11:22 +0000)]
Expand r83882.

13 years agoFollowup r83849, fix join to be on indexed user_name
Sam Reed [Mon, 14 Mar 2011 11:07:58 +0000 (11:07 +0000)]
Followup r83849, fix join to be on indexed user_name

13 years agoFollow-up r83855: MessagesQqq documentation
Happy-melon [Mon, 14 Mar 2011 11:07:14 +0000 (11:07 +0000)]
Follow-up r83855: MessagesQqq documentation

13 years agoFixup whitespace
Sam Reed [Mon, 14 Mar 2011 11:06:57 +0000 (11:06 +0000)]
Fixup whitespace

13 years agoPartial revert r83845, use indexed fields for join
Sam Reed [Mon, 14 Mar 2011 11:05:35 +0000 (11:05 +0000)]
Partial revert r83845, use indexed fields for join

13 years agoRequire at least PHP 5.2.3. There's not much point increasing the minimum to 5.2...
Tim Starling [Mon, 14 Mar 2011 10:42:07 +0000 (10:42 +0000)]
Require at least PHP 5.2.3. There's not much point increasing the minimum to 5.2.0, as I argued at lists.wikimedia.org/pipermail/wikitech-l/2010-November/050138.html . But requiring 5.2.3 is a significant win. Updates r83217.

13 years agoFix r83140: 'ObjectCache::newAnything' is not a valid callback, use array( 'ObjectCac...
Roan Kattouw [Mon, 14 Mar 2011 10:27:24 +0000 (10:27 +0000)]
Fix r83140: 'ObjectCache::newAnything' is not a valid callback, use array( 'ObjectCache', 'newAnything' ) . Apparently this explodes in some versions of PHP but not in others

13 years agoRevert r67661 (change Title::makeTitle(NS_SPECIAL, $foo) to SpecialPage::getTitleFor...
Roan Kattouw [Mon, 14 Mar 2011 10:03:07 +0000 (10:03 +0000)]
Revert r67661 (change Title::makeTitle(NS_SPECIAL, $foo) to SpecialPage::getTitleFor($foo)), caused bug 27671 (search suggestions no longer list canonical names for special pages). Went with makeTitleSafe() instead of makeTitle() just in case weird things make their way into the special page aliases.

13 years ago(bug 27975) Fix r83529 (slave catchup in updateCollation.php) to not try to wait...
Roan Kattouw [Mon, 14 Mar 2011 09:30:56 +0000 (09:30 +0000)]
(bug 27975) Fix r83529 (slave catchup in updateCollation.php) to not try to wait for slaves if there are none. Reporter was getting a permission error for getting the master position on a single-server setup

13 years agoRevert r79122, causes bug 27891 (old version seen immediately after edit).
Tim Starling [Mon, 14 Mar 2011 04:26:52 +0000 (04:26 +0000)]
Revert r79122, causes bug 27891 (old version seen immediately after edit).

13 years ago(bug 28020) Moving pages causes the cl_sortkey thats appropriate for one of the categ...
Brian Wolff [Mon, 14 Mar 2011 02:19:28 +0000 (02:19 +0000)]
(bug 28020) Moving pages causes the cl_sortkey thats appropriate for one of the categorylinks, to be set for all of them.
But the cl_sortkey_prefix are kept to the right value for the cl_sortkey's that are set to the wrong value, totally messing things up.

End result is: Have a page, with some categories having different sortkeys, move that page, now all the categories have the same
sortkey, but still have their original prefix, so linksupdate things the sortkey is correct. End result is null edits don't fix
the sortkey, nothing but removing and re-adding category will reset sortkey to correct value.

13 years agoCommit last of my w/c
Sam Reed [Mon, 14 Mar 2011 01:04:16 +0000 (01:04 +0000)]
Commit last of my w/c

Documentation, braces, explicit variable definitions

13 years agoBug 2557: Sidebar items missing from classic, cologne blue, simple skins
Marcin Cieślak [Sun, 13 Mar 2011 23:12:59 +0000 (23:12 +0000)]
Bug 2557: Sidebar items missing from classic, cologne blue, simple skins

* Simple skin support multiple sidebar items
* Standard (a.k.a. Classic) likes to add "my watchlist" and "my contributions"
  links at the bottom of the first sidebar box. It also has no titles for boxes.
* Cologne blue supports multiple sidebar boxes with titles.

13 years ago* (bug 27585) add pagecount to list=filearchive
Sam Reed [Sun, 13 Mar 2011 23:04:51 +0000 (23:04 +0000)]
* (bug 27585) add pagecount to list=filearchive

13 years ago* (bug 28031) Add pageCount support to ArchivedFile
Sam Reed [Sun, 13 Mar 2011 22:58:41 +0000 (22:58 +0000)]
* (bug 28031) Add pageCount support to ArchivedFile

Apply my patch

Add documentation to File

13 years agoSome braces, and also return type documentation
Sam Reed [Sun, 13 Mar 2011 22:26:56 +0000 (22:26 +0000)]
Some braces, and also return type documentation

13 years ago(no commit message)
Sam Reed [Sun, 13 Mar 2011 22:23:57 +0000 (22:23 +0000)]

13 years agoFollowup r83856
Sam Reed [Sun, 13 Mar 2011 22:12:57 +0000 (22:12 +0000)]
Followup r83856

Per BRYAN (;P) don't use a conditional parameter, just die if miser mode and prefix set

13 years agoDon't reinvent the wheel in SpecialMIMEsearch.php to "parseMIME", use File::splitMime
Sam Reed [Sun, 13 Mar 2011 22:02:40 +0000 (22:02 +0000)]
Don't reinvent the wheel in SpecialMIMEsearch.php to "parseMIME", use File::splitMime

13 years ago* (bug 27020) API: Allow title prefix search of logevents (only when not in miser...
Sam Reed [Sun, 13 Mar 2011 21:43:20 +0000 (21:43 +0000)]
* (bug 27020) API: Allow title prefix search of logevents (only when not in miser mode)

Won't work on WMF wiki's as miser mode is enabled, but won't show as an available option either

13 years agoFurther massive rewrite of the blocking frontend: spin out unblocking into a new...
Happy-melon [Sun, 13 Mar 2011 21:33:52 +0000 (21:33 +0000)]
Further massive rewrite of the blocking frontend: spin out unblocking into a new SpecialUnblock.php.  This leaves IPBlockList as, astonishingly enough, a list of blocks... :D

13 years agoFix undefined $p from r83797
Sam Reed [Sun, 13 Mar 2011 21:33:35 +0000 (21:33 +0000)]
Fix undefined $p from r83797

13 years agoDocumentation
Sam Reed [Sun, 13 Mar 2011 21:17:37 +0000 (21:17 +0000)]
Documentation

13 years agoFollowup r33162, use $this->pager to fix undefined $pager
Sam Reed [Sun, 13 Mar 2011 21:12:57 +0000 (21:12 +0000)]
Followup r33162, use $this->pager to fix undefined $pager

13 years agoAdd missing group by from r83849 per Bryan
Sam Reed [Sun, 13 Mar 2011 19:35:08 +0000 (19:35 +0000)]
Add missing group by from r83849 per Bryan

13 years agoFollowup r83843, r83837, per brian, addOption unconditionally replaces ORDER BY etc...
Sam Reed [Sun, 13 Mar 2011 19:28:44 +0000 (19:28 +0000)]
Followup r83843, r83837, per brian, addOption unconditionally replaces ORDER BY etc, so fix that

Simplify addFields call, remove un-needed array for 1 element

13 years ago* (bug 26630) Add api for Special:ActiveUsers
Sam Reed [Sun, 13 Mar 2011 19:07:22 +0000 (19:07 +0000)]
* (bug 26630) Add api for Special:ActiveUsers

Not sure if this would be better having been done as list=activeusers or something...

Meh, done! :P

13 years agosetting servername with an IPv6 request must ensure we have both brackets
Antoine Musso [Sun, 13 Mar 2011 18:31:00 +0000 (18:31 +0000)]
setting servername with an IPv6 request must ensure we have both brackets

On lighttpd 1.4.28, the SERVER_NAME CGI variable is truncated at the first
colon. This makes it return an incorrect value for SERVER_NAME when the user
make the request to an IPv6, it outputs something like [2001.

This patch make sure we have either both opening and closing brackets or no
brackets at all (hence the 'xor' boolean check).

+ipv6

13 years agoJoin user table to recentchanges on user id, rather than user_text
Sam Reed [Sun, 13 Mar 2011 18:23:33 +0000 (18:23 +0000)]
Join user table to recentchanges on user id, rather than user_text

Add some documentation

13 years agoBug 27341 - Add drto param to list=deletedrevs
Sam Reed [Sun, 13 Mar 2011 17:59:27 +0000 (17:59 +0000)]
Bug 27341 - Add drto param to list=deletedrevs

Tidy code up a little bit

13 years ago* (bug 27203) add fato param to list=filearchive
Sam Reed [Sun, 13 Mar 2011 17:41:47 +0000 (17:41 +0000)]
* (bug 27203) add fato param to list=filearchive

Cleanup some whitespace also

13 years agoCleanup/simplify code added to alllinks in r70584
Sam Reed [Sun, 13 Mar 2011 17:36:31 +0000 (17:36 +0000)]
Cleanup/simplify code added to alllinks in r70584

13 years agoFixup a couple more hardcoded module prefixes in help
Sam Reed [Sun, 13 Mar 2011 17:28:53 +0000 (17:28 +0000)]
Fixup a couple more hardcoded module prefixes in help

13 years agoMinor followup to r83814, also fix some other existances
Sam Reed [Sun, 13 Mar 2011 17:26:29 +0000 (17:26 +0000)]
Minor followup to r83814, also fix some other existances

Don't hardcode module prefixes (just incase they're subclassed at somepoint... :) )

13 years ago* (bug 27342) Add audir param to list=allusers
Sam Reed [Sun, 13 Mar 2011 17:23:45 +0000 (17:23 +0000)]
* (bug 27342) Add audir param to list=allusers

13 years ago* (bug 27340) API: Allow listing of "small" categories
Sam Reed [Sun, 13 Mar 2011 17:16:07 +0000 (17:16 +0000)]
* (bug 27340) API: Allow listing of "small" categories

13 years agoFollow-up r83825: fix fatal in API
Happy-melon [Sun, 13 Mar 2011 17:02:50 +0000 (17:02 +0000)]
Follow-up r83825: fix fatal in API

13 years ago* (bug 27183) API: Add filter by customisation state for meta=allmessages
Sam Reed [Sun, 13 Mar 2011 16:36:51 +0000 (16:36 +0000)]
* (bug 27183) API: Add filter by customisation state for meta=allmessages

13 years agoFollow-up r83827: a Block object will never be internally of TYPE_ID.
Happy-melon [Sun, 13 Mar 2011 15:44:49 +0000 (15:44 +0000)]
Follow-up r83827: a Block object will never be internally of TYPE_ID.

13 years agoSort special pages in MessagesEn::$specialPageAliases
Happy-melon [Sun, 13 Mar 2011 15:22:59 +0000 (15:22 +0000)]
Sort special pages in MessagesEn::$specialPageAliases

13 years agoFollow-up r83825: fix Block::parseTarget to recognise autoblocks separately, and...
Happy-melon [Sun, 13 Mar 2011 15:14:33 +0000 (15:14 +0000)]
Follow-up r83825: fix Block::parseTarget to recognise autoblocks separately, and change Block::getRedactedName() to run the string through a system message for localisation

13 years agoImplement __toString() magic method for Message objects
Happy-melon [Sun, 13 Mar 2011 15:12:54 +0000 (15:12 +0000)]
Implement __toString() magic method for Message objects

13 years agoSome refactoring in Block.php and SpecialBlock.php: move backend stuff into Block...
Happy-melon [Sun, 13 Mar 2011 14:47:34 +0000 (14:47 +0000)]
Some refactoring in Block.php and SpecialBlock.php: move backend stuff into Block.php, and expand the parseTargetAndType() functions to recognise blocks referenced by their block id.

13 years agoFix totally-broken r83810.
Happy-melon [Sun, 13 Mar 2011 14:41:57 +0000 (14:41 +0000)]
Fix totally-broken r83810.

13 years agoMake Parser::makeKnownLinkHolder() call Linker::linkKnown() instead of deprecated...
Alexandre Emsenhuber [Sun, 13 Mar 2011 14:00:38 +0000 (14:00 +0000)]
Make Parser::makeKnownLinkHolder() call Linker::linkKnown() instead of deprecated Linker::makeKnownLinkObj()

13 years agoFollowup r83812, add /*_*/ to allow for prefixed tables
Sam Reed [Sun, 13 Mar 2011 13:10:40 +0000 (13:10 +0000)]
Followup r83812, add /*_*/ to allow for prefixed tables

13 years agoFix for r83698: pass the Title object to the skin so that we are sure to show the...
Alexandre Emsenhuber [Sun, 13 Mar 2011 11:24:27 +0000 (11:24 +0000)]
Fix for r83698: pass the Title object to the skin so that we are sure to show the correct context

13 years ago(bug 27965) Paging in list=categorymembers was completely broken. It was paging by...
Roan Kattouw [Sun, 13 Mar 2011 10:39:57 +0000 (10:39 +0000)]
(bug 27965) Paging in list=categorymembers was completely broken. It was paging by cl_from alone, while the index is on (cl_to, cl_type, cl_sortkey, cl_from) and only cl_to is constant. Fixed by paging on (type, sortkey, from), but using type|from|sortkey for clcontinue so any pipe characters in the sortkey are easier to handle. This needs the schema change in r83812 to work correctly, otherwise rows with cl_type=file will be skipped in certain cases.

13 years agobug 27948: namespace translations for Odia (from translatewiki.net)
Antoine Musso [Sun, 13 Mar 2011 10:36:51 +0000 (10:36 +0000)]
bug 27948: namespace translations for Odia (from translatewiki.net)

13 years agoSchema change: change cl_type from ENUM('page', 'subcat', 'file') to varchar(6)....
Roan Kattouw [Sun, 13 Mar 2011 10:35:06 +0000 (10:35 +0000)]
Schema change: change cl_type from ENUM('page', 'subcat', 'file') to varchar(6). This is needed because MySQL sorts 'page' < 'subcat' < 'file' when using ORDER BY cl_type but uses 'file' < 'page' < 'subcat' for the purposes of WHERE clauses, making paging impossible. Changing the ENUM() order to be alphabetical would fix the order discrepancy, but leave range scans like WHERE cl_type > 'page' unindexed. Varchars do behave correctly. Changing to an int was not an option because existing data would have to be migrated.

This commit does not include a patch for SQLite, because ALTER TABLE MODIFY is apparently not supported by SQLite as far as I could tell by Googling. Leaving resolution of this issue for SQLite to the SQLite experts; maybe SQLite's enum implementation is saner than MySQL and it doesn't even need this schema change, I don't know.

13 years agoFollow-up r83809 r83810: improved documentation
Niklas Laxström [Sun, 13 Mar 2011 10:02:56 +0000 (10:02 +0000)]
Follow-up r83809 r83810: improved documentation

13 years ago* Moved Target field validation into a field validation callback to show erros next...
Niklas Laxström [Sun, 13 Mar 2011 09:57:02 +0000 (09:57 +0000)]
* Moved Target field validation into a field validation callback to show erros next to the field
* Some changes to comments and one addHtml -> addWikiMsg

13 years agoHTMLForm:
Niklas Laxström [Sun, 13 Mar 2011 09:51:47 +0000 (09:51 +0000)]
HTMLForm:
* Allow field validators to return multiple errors
* Allow field validators to return Message objects
* Add a class for fields for invalid input
* Style invalid <input> fields with red border color

Done with http://www.mediawiki.org/wiki/StyleGuide/Forms in mind

13 years ago(follow-up r83716) fix parser test for the entities being decoded into numeric entiti...
Brian Wolff [Sun, 13 Mar 2011 00:34:54 +0000 (00:34 +0000)]
(follow-up r83716) fix parser test for the entities being decoded into numeric entities thing.

13 years agoTweak comment format
Sam Reed [Sun, 13 Mar 2011 00:31:01 +0000 (00:31 +0000)]
Tweak comment format

Fix space/brace

Define member variable

13 years agoBit of explicit parameter definition.
Sam Reed [Sun, 13 Mar 2011 00:24:24 +0000 (00:24 +0000)]
Bit of explicit parameter definition.

Spaces, braces

13 years ago* (bug 27182) API: Add filter by prefix for meta=allmessages
Sam Reed [Sun, 13 Mar 2011 00:15:02 +0000 (00:15 +0000)]
* (bug 27182) API: Add filter by prefix for meta=allmessages

Patch by Harry Burt (Jarry1250)

Comment tweaked, logic inversed ( so skip == true means we skip ), makes a bit more sense then :)

13 years ago* (bug 27670) Ordering by timestamp (and usage of start and end) isn't as clear in...
Sam Reed [Sun, 13 Mar 2011 00:07:22 +0000 (00:07 +0000)]
* (bug 27670) Ordering by timestamp (and usage of start and end) isn't as clear in auto generated document, as it is on mw.org

Followup r83797, closing. Adding bit of documentation, + RELEASE-NOTES

13 years ago(bug 28017) Unblocking a user with a space in their name does not work. This fix...
Happy-melon [Sat, 12 Mar 2011 23:54:32 +0000 (23:54 +0000)]
(bug 28017) Unblocking a user with a space in their name does not work.  This fix is no more ghastly than the rest of the code in the file; the whole thing (as usual) needs a complete rewrite...

13 years ago* (bug 27670) Ordering by timestamp (and usage of start and end) isn't as clear in...
Sam Reed [Sat, 12 Mar 2011 23:39:15 +0000 (23:39 +0000)]
* (bug 27670) Ordering by timestamp (and usage of start and end) isn't as clear in auto generated document, as it is on mw.org

where dir = (newer|older)

Will look at doing (asc|desc)(ending)?

13 years agoFollow-up r83786: update references in SpecialPage::getTitleFor() and friends to...
Happy-melon [Sat, 12 Mar 2011 23:22:34 +0000 (23:22 +0000)]
Follow-up r83786: update references in SpecialPage::getTitleFor() and friends to point to 'Block' rather than 'Blockip'; should fix errors on translatewiki.

13 years agoFollow-up r83794, r83792: restore new SpecialBlock.php code from r83786. This revisi...
Happy-melon [Sat, 12 Mar 2011 22:53:15 +0000 (22:53 +0000)]
Follow-up r83794, r83792: restore new SpecialBlock.php code from r83786.  This revision should *not* be broken :D

13 years agoFollow-up r83790: svn-move SpecialBlockip.php to SpecialBlock.php. This revision...
Happy-melon [Sat, 12 Mar 2011 22:51:48 +0000 (22:51 +0000)]
Follow-up r83790: svn-move SpecialBlockip.php to SpecialBlock.php.  This revision will be broken

13 years agoFollow-up r83792: Remove left in debugging
Bryan Tong Minh [Sat, 12 Mar 2011 22:51:45 +0000 (22:51 +0000)]
Follow-up r83792: Remove left in debugging

13 years agoFollow-up r83778: Need to de-rotate, so use 360 - angle instead of angle.
Bryan Tong Minh [Sat, 12 Mar 2011 22:50:43 +0000 (22:50 +0000)]
Follow-up r83778: Need to de-rotate, so use 360 - angle instead of angle.

13 years ago(bug 2581, bug 6834) Added links to thumbnail in several resolutions to the file...
Bryan Tong Minh [Sat, 12 Mar 2011 22:49:31 +0000 (22:49 +0000)]
(bug 2581, bug 6834) Added links to thumbnail in several resolutions to the file description page. The sizes are set by $wgImageLimits.
Not really happy about how it looks, perhaps only the numbers should be linked? See http://www.mediawiki.org/wiki/User:Bryan/Bug_2581 for options.
Removed message show-big-image-thumb, added show-big-image-preview, show-big-image-other, show-big-image-size.

13 years agoFollow-up r83786, try to keep the svn history of SpecialBlockip. This rev will be...
Happy-melon [Sat, 12 Mar 2011 22:48:58 +0000 (22:48 +0000)]
Follow-up r83786, try to keep the svn history of SpecialBlockip.  This rev will be broken.

13 years agoSpin out all the CSS used on special pages into their own mediawiki.special module...
Happy-melon [Sat, 12 Mar 2011 22:42:58 +0000 (22:42 +0000)]
Spin out all the CSS used on special pages into their own mediawiki.special module.  This comprises about a third of /skins/common/shared.css, so it's definitely worthwhile not loading it for the 99.9% of pageviews which aren't special pages.

13 years ago* (bug 28010) Passing a non existant user to list=users gives internal error
Sam Reed [Sat, 12 Mar 2011 22:23:43 +0000 (22:23 +0000)]
* (bug 28010) Passing a non existant user to list=users gives internal error
* (bug 27549) action=query&list=users&usprop=groups doesn't show implicit groups if a user doesn't have explicit groups

Also follows up r79556, where I'd done a couple of daft things... (accessing undefined objects)

13 years agoDivert a river through the Augean Stables that is SpecialBlockip.php.
Happy-melon [Sat, 12 Mar 2011 21:54:35 +0000 (21:54 +0000)]
Divert a river through the Augean Stables that is SpecialBlockip.php.
* Move to SpecialBlock.php, and rename class appropriately
* Complete refactor
* Use HTMLForm in block form.  This changes most of the ids and field names on the form, but allows proper validation, nicer formatting, clears up several fixmes, and is generally Better(TM).
* Spin various parts out into static functions, several of which properly belong in the backend (but Block.php is a worse mess still)
* Invert some of the block options so that every checkbox makes the block more severe (so "check to disable email" is fine, but "check to allow usertalk edit" (default true) is inverted to "check to disable usertalk edit" (default false).
* revert r40359 (move doMassUserBlock() to core).  No one seems to be using this function, which has nothing to do with the frontend UI in SpecialBlock (it might perhaps belong in Block.php); it is pretty bespoke for CheckUser, doesn't seem to have very much utility elsewhere.

13 years agoFix switch fail in r83778: add missing break.
Bryan Tong Minh [Sat, 12 Mar 2011 21:35:27 +0000 (21:35 +0000)]
Fix switch fail in r83778: add missing break.

13 years agoLocalisation updates for core and extension messages from translatewiki.net (2011...
Raimond Spekking [Sat, 12 Mar 2011 21:02:43 +0000 (21:02 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-03-12 20:34:00 UTC)

13 years agoFollow-up r83747, forgot to commit a file
Happy-melon [Sat, 12 Mar 2011 20:47:52 +0000 (20:47 +0000)]
Follow-up r83747, forgot to commit a file

13 years agoLocalization fix for he.
Rotem Liss [Sat, 12 Mar 2011 20:11:19 +0000 (20:11 +0000)]
Localization fix for he.

13 years ago(bug 18691) Added support for SVG rasterization using the Imagick PHP extension....
Bryan Tong Minh [Sat, 12 Mar 2011 19:59:41 +0000 (19:59 +0000)]
(bug 18691) Added support for SVG rasterization using the Imagick PHP extension. Based on patch by Yesid Carrillo. Set $wgSVGConverter = 'ImagickExt' to use it. Note that the results are extremely ugly, but I believe that happens with the command line scaler as well.
Introduced new syntax for $wgSVGConverters, if the selected converter is an array, it is assumed to be a PHP callable. Imagick support is done by SvgHandler::rasterizeImagickExt.

13 years ago(bug 14706) Added support for the Imagick PHP extension. Based on patch by Leslie...
Bryan Tong Minh [Sat, 12 Mar 2011 19:32:39 +0000 (19:32 +0000)]
(bug 14706) Added support for the Imagick PHP extension. Based on patch by Leslie Hoare.
Scaler type is "imext". Rotation is supported.
Logic mostly copied from transformImagemagick() and ported to Imagick calls.
Resizing animated gifs is broken; it only shows the first frame and I can't find out why it does not work, but otherwise it is fully working.

13 years agoRELEASE-NOTES for r83755
Happy-melon [Sat, 12 Mar 2011 18:51:51 +0000 (18:51 +0000)]
RELEASE-NOTES for r83755

13 years agoFollow-up r83755: @deprecated @since is wrong, doesn't have the expected semantic...
Happy-melon [Sat, 12 Mar 2011 18:14:33 +0000 (18:14 +0000)]
Follow-up r83755: @deprecated @since is wrong, doesn't have the expected semantic meaning.

13 years agoSkip a part of useless code when redirecting because of getOldIDFromRequest() or...
Alexandre Emsenhuber [Sat, 12 Mar 2011 14:21:41 +0000 (14:21 +0000)]
Skip a part of useless code when redirecting because of getOldIDFromRequest() or showing a diff page

13 years agoUse Html::element() to generate the element; the url and the title attribute are...
Alexandre Emsenhuber [Sat, 12 Mar 2011 13:45:12 +0000 (13:45 +0000)]
Use Html::element() to generate the element; the url and the title attribute are now build only when really necessary

13 years agoFollow-up r83755: Message 'ipaddress' is unused now, in core and extensions
Raimond Spekking [Sat, 12 Mar 2011 13:42:22 +0000 (13:42 +0000)]
Follow-up r83755: Message 'ipaddress' is unused now, in core and extensions

13 years agoDeprecate $wgSysopUserBans and $wgSysopRangeBans, both of which are pre-1.2, and...
Happy-melon [Sat, 12 Mar 2011 12:13:22 +0000 (12:13 +0000)]
Deprecate $wgSysopUserBans and $wgSysopRangeBans, both of which are pre-1.2, and totally antiquated.  Can't think of any reason why a modern wiki might want to make blocks IP-only; syadmins can still disable rangeblocks by setting $wgBlockCIDRLimit to the maximum for each IP mode (32 for IP4, 128 for IP6).

13 years agoDo the filearchive updates too; index is there now
Aaron Schulz [Sat, 12 Mar 2011 11:51:33 +0000 (11:51 +0000)]
Do the filearchive updates too; index is there now

13 years agoFollow-up r83298: keep the two elements of the message separate in an array in HTMLSe...
Happy-melon [Sat, 12 Mar 2011 11:08:20 +0000 (11:08 +0000)]
Follow-up r83298: keep the two elements of the message separate in an array in HTMLSelectAndOtherField::loadDataFromRequest(), fixes various bugs with validation, defaults, and normalisation.

13 years agoadd __toString() call for User objects, returning User->getName(). Now that we requi...
Happy-melon [Fri, 11 Mar 2011 23:42:53 +0000 (23:42 +0000)]
add __toString() call for User objects, returning User->getName().  Now that we require PHP 5.2+, we can do this with all our major classes... :D

13 years agoFirst little bit of cleaning out the Augean stables of SpecialBlockip.php: spin out...
Happy-melon [Fri, 11 Mar 2011 23:33:36 +0000 (23:33 +0000)]
First little bit of cleaning out the Augean stables of SpecialBlockip.php: spin out the suppressUserName/unsuppressUserName functions into their own file, to keep them with the rest of the RevDel stuff.

13 years agoRemove HISTORY for r70526
Aryeh Gregor [Fri, 11 Mar 2011 21:01:46 +0000 (21:01 +0000)]
Remove HISTORY for r70526

Removed from 1.17 RELEASE-NOTES in r83720.

13 years agoLocalisation updates for core and extension messages from translatewiki.net (2011...
Raimond Spekking [Fri, 11 Mar 2011 20:59:31 +0000 (20:59 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-03-11 20:34:00 UTC)

13 years agoNormalize named entities to numeric
Aryeh Gregor [Fri, 11 Mar 2011 20:50:17 +0000 (20:50 +0000)]
Normalize named entities to numeric

We should never be outputting named entities other than the ones in XML,
&lt; &gt; &amp; &quot;, because that will break well-formedness unless
we have a DTD in the doctype, which we don't in HTML5 mode.

I stuck with outputting numeric entities here instead of UTF-8 because
some characters are hard to read in UTF-8 (e.g., &nbsp;).  Maybe it
would be nicer if we decoded to UTF-8 except for whitespace and control
characters, or something like that, but it's a detail.

I'll backport to 1.17 and add RELEASE-NOTES there, which is why I added
the line to HISTORY instead of RELEASE-NOTES.