3 years agoMerge "Remove perf tracking code that was moved to WikimediaEvents in Ib300af5c"
jenkins-bot [Wed, 4 Oct 2017 21:04:52 +0000 (21:04 +0000)]
Merge "Remove perf tracking code that was moved to WikimediaEvents in Ib300af5c"

3 years agoMerge "RCFilters: Allows specifying default highlights from the server"
jenkins-bot [Wed, 4 Oct 2017 20:58:42 +0000 (20:58 +0000)]
Merge "RCFilters: Allows specifying default highlights from the server"

3 years agoRCFilters: Allows specifying default highlights from the server
Stephane Bisson [Wed, 4 Oct 2017 12:52:25 +0000 (08:52 -0400)]
RCFilters: Allows specifying default highlights from the server

Bug: T172757
Change-Id: I0545b4e0222e14be99d567e7890ccf33722a5d1e

3 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Wed, 4 Oct 2017 19:54:24 +0000 (21:54 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I348badd5ddcd70157dd07c87717b6f64cfcafb3e

3 years agoMerge "RCFilters: Avoid adding raw filter and group objects to js vars"
jenkins-bot [Wed, 4 Oct 2017 19:06:12 +0000 (19:06 +0000)]
Merge "RCFilters: Avoid adding raw filter and group objects to js vars"

3 years agoMerge "Update OOjs UI to v0.23.3"
jenkins-bot [Wed, 4 Oct 2017 15:57:11 +0000 (15:57 +0000)]
Merge "Update OOjs UI to v0.23.3"

3 years agoRCFilters: Avoid adding raw filter and group objects to js vars
Stephane Bisson [Wed, 4 Oct 2017 15:06:16 +0000 (11:06 -0400)]
RCFilters: Avoid adding raw filter and group objects to js vars

Bug: T176236
Change-Id: I0c68ea0e090cfb065d2e3e8acad7025c61c344ca

3 years agoRemove some old mysql 4 messages from installer i18n files
Reedy [Wed, 4 Oct 2017 13:13:26 +0000 (14:13 +0100)]
Remove some old mysql 4 messages from installer i18n files

Bug: T34217
Change-Id: Id9859769235a03229f962545cef6786f5e700c71

3 years agoInject dependencies into Shell\Command
Max Semenik [Sat, 9 Sep 2017 06:10:09 +0000 (23:10 -0700)]
Inject dependencies into Shell\Command

This slightly changes how execution time limits fall back on each other.

Change-Id: I7754a9e6be9638eebe90cb953adb8e2a6ee97cef

3 years agoUpdate OOjs UI to v0.23.3
Volker E [Wed, 4 Oct 2017 01:41:52 +0000 (18:41 -0700)]
Update OOjs UI to v0.23.3

Release notes:

Depends-on: Ica85dce164ab0ff269ca26ac078ea245219ad4c1
Change-Id: Ied8d6d6dfa9965912c17e0573fec33d2b67a5027

3 years agoMerge "Support uploads with UTF-8 names on Windows"
jenkins-bot [Tue, 3 Oct 2017 23:28:38 +0000 (23:28 +0000)]
Merge "Support uploads with UTF-8 names on Windows"

3 years agoSupport uploads with UTF-8 names on Windows
Brion Vibber [Tue, 3 Oct 2017 22:15:15 +0000 (15:15 -0700)]
Support uploads with UTF-8 names on Windows

On PHP 7.1 and later, filesystem functions on Windows
use the Unicode system functions, which makes our file
handling work for non-ASCII file names.

Previously this was blacklisted for Windows on all PHP
versions. Versions before 7.1 will still reject Unicode
filenames with non-ASCII chars.

Bug: T3780
Change-Id: I94377faa5185f133be2dfb7b9b6aeacbd582834f

3 years agoRemove some remaining mentions of unstubbing from core
Chad Horohoe [Tue, 3 Oct 2017 22:50:12 +0000 (15:50 -0700)]
Remove some remaining mentions of unstubbing from core

Change-Id: Ife34335db7afd9bd4f0936cb90be227d7c4c9651

3 years agoMerge "RCFilters: Init highlight button based on model state"
jenkins-bot [Tue, 3 Oct 2017 22:09:15 +0000 (22:09 +0000)]
Merge "RCFilters: Init highlight button based on model state"

3 years agoStop stubbing StubUserLang
Chad Horohoe [Tue, 3 Oct 2017 21:26:18 +0000 (14:26 -0700)]
Stop stubbing StubUserLang

Stub objects are confusing as heck and are a performance optimization
that really aren't fit for the modern era. They were designed to avoid
loading the actual code from the disk back in the days when bytecode
caching wasn't always gonna be there.

It's 2017. If you're using HHVM, you've got a bytecode cache. If you're
using any reasonably recent version of PHP then you've got the opcode
caching enabled by default in basically every distro-related build.

Nothing actually relies on this object being a stub (that'd be silly),
so only references are basically things force unstubbing (also kind of
silly) the object. Once remaining code referencing this in extensions
are all cleaned up then we can remove the class itself.

Change-Id: I15df24aeeb729e8e764792daa933377f35042fab

3 years agoMerge "RCFilters: Convert saved queries from filters to parameters"
jenkins-bot [Tue, 3 Oct 2017 20:51:51 +0000 (20:51 +0000)]
Merge "RCFilters: Convert saved queries from filters to parameters"

3 years agoMerge "Add SECURITY"
jenkins-bot [Tue, 3 Oct 2017 20:30:29 +0000 (20:30 +0000)]
Merge "Add SECURITY"

3 years agoRCFilters: Init highlight button based on model state
Stephane Bisson [Tue, 3 Oct 2017 15:29:04 +0000 (11:29 -0400)]
RCFilters: Init highlight button based on model state

Bug: T177028
Change-Id: Idea7e09152e3176084f0634d24615a79364d77bb

3 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Tue, 3 Oct 2017 20:11:24 +0000 (22:11 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: Id856ec22448bbe6d788185bbfbe020bb387d8a56

3 years agoAdd SECURITY
Kunal Mehta [Tue, 3 Oct 2017 20:03:35 +0000 (13:03 -0700)]

Intended for people who aren't familiar with our projects. To avoid
duplicating any information, just link to the wiki page that contains
information on how to report security issues.

Bug: T158119
Change-Id: I8eb05688cc028ba2b4b467fc464b590da0e60b0b

3 years agoMerge "TitleWidget: Only apply padding fix to withImages mode"
jenkins-bot [Tue, 3 Oct 2017 20:02:19 +0000 (20:02 +0000)]
Merge "TitleWidget: Only apply padding fix to withImages mode"

3 years agoMerge "TitleOptionWidget: Don't show an icon when showImages=false"
jenkins-bot [Tue, 3 Oct 2017 19:49:48 +0000 (19:49 +0000)]
Merge "TitleOptionWidget: Don't show an icon when showImages=false"

3 years agoMerge "mw.widgets.SearchInputWidget: Avoid overriding getOptionWidgetData"
jenkins-bot [Tue, 3 Oct 2017 19:49:44 +0000 (19:49 +0000)]
Merge "mw.widgets.SearchInputWidget: Avoid overriding getOptionWidgetData"

3 years agoMerge "Remove 'Browser default' editfont option"
jenkins-bot [Tue, 3 Oct 2017 18:46:52 +0000 (18:46 +0000)]
Merge "Remove 'Browser default' editfont option"

3 years agoMerge "mediawiki.searchSuggest: Add support for search namespace preferences"
jenkins-bot [Tue, 3 Oct 2017 18:12:37 +0000 (18:12 +0000)]
Merge "mediawiki.searchSuggest: Add support for search namespace preferences"

3 years agomediawiki.searchSuggest: Add support for search namespace preferences
Paladox [Sun, 15 Jan 2017 18:18:29 +0000 (18:18 +0000)]
mediawiki.searchSuggest: Add support for search namespace preferences

This way it allows namespaces other then NS_MAIN.

Bug: T26214
Change-Id: I6a545eb8563e81a66de39a8295ef2e40c3e73f95

3 years agoOutputPage: Turn html5shiv into a raw ResourceLoader module
Kunal Mehta [Tue, 15 Aug 2017 20:00:27 +0000 (13:00 -0700)]
OutputPage: Turn html5shiv into a raw ResourceLoader module

This lets us take advantage of ResourceLoader's on the fly minification
rather than needing to ship a minified copy, which is problematic for
other distributions like Debian.

Because the startup module excludes raw modules, it is not possible to
load or depend upon this module, and trying to use
`mw.loader.load('html5shiv')` for example will throw an exception.

This follows-up 3a30e03645f895b.

Change-Id: I635e224fb043c614c4918771c7c8f836575c683b

3 years agoresourceloader: Add unit test for ClientHtml::makeLoad sync=>true
Timo Tijhof [Tue, 3 Oct 2017 17:18:49 +0000 (18:18 +0100)]
resourceloader: Add unit test for ClientHtml::makeLoad sync=>true

Used by Special:JavaScriptTest, and we may need to use this
in OutputPage as well (for html5shiv).

Change-Id: If7d7c12056dc3aab78486050f0798d42b158d9a9

3 years agophpunit: Include all raw modules in detection of illegal dependencies
Timo Tijhof [Tue, 3 Oct 2017 17:10:02 +0000 (18:10 +0100)]
phpunit: Include all raw modules in detection of illegal dependencies

* Use getStartupModules() instead of hardcoding these two module names.
* Also collect any other module that is registered with raw=>true.

Change-Id: I5f75cc8f99b90f58d76b7e87f068f50f9f608ed0

3 years agoMerge "Add a help button to the Tagged Edits menu"
jenkins-bot [Tue, 3 Oct 2017 15:57:09 +0000 (15:57 +0000)]
Merge "Add a help button to the Tagged Edits menu"

3 years agoMerge "Change "Advanced filters" label color"
jenkins-bot [Tue, 3 Oct 2017 15:52:29 +0000 (15:52 +0000)]
Merge "Change "Advanced filters" label color"

3 years agoMerge "SpecialBlock: Tweaks for OOUI HTMLForm"
jenkins-bot [Tue, 3 Oct 2017 15:06:13 +0000 (15:06 +0000)]
Merge "SpecialBlock: Tweaks for OOUI HTMLForm"

3 years agoTitleWidget: Only apply padding fix to withImages mode
Ed Sanders [Tue, 3 Oct 2017 15:04:54 +0000 (16:04 +0100)]
TitleWidget: Only apply padding fix to withImages mode

Change-Id: I60d0c3169cede2251595d68649c76823ea77afe9

3 years agoTitleOptionWidget: Don't show an icon when showImages=false
Ed Sanders [Tue, 3 Oct 2017 14:52:13 +0000 (15:52 +0100)]
TitleOptionWidget: Don't show an icon when showImages=false

Change-Id: Ib4262bc15a3845ec9e7af484dbdfa4277f2f4014

3 years agomw.widgets.SearchInputWidget: Avoid overriding getOptionWidgetData
Ed Sanders [Tue, 3 Oct 2017 14:42:19 +0000 (15:42 +0100)]
mw.widgets.SearchInputWidget: Avoid overriding getOptionWidgetData

This means we don't have to track upstream changes to the method.

Change-Id: I44739eefae4d47aeee9f506e0d99e605da4fb961

3 years agoSpecialBlock: Tweaks for OOUI HTMLForm
Bartosz Dziewoński [Tue, 3 Oct 2017 13:44:30 +0000 (15:44 +0200)]
SpecialBlock: Tweaks for OOUI HTMLForm

* Expand both the dropdown and textfield of "Reason" field to the
  usual maximum width and display them on separate lines.
* Fix autohiding of form fields where applicable (checkboxes that only
  apply when blocking a user or an IP address).
* Fix bolding of the "Confirm block" label when blocking yourself.

Follow-up to d56758e134358fdac3f8dda16417bfd30f78bab9.

Bug: T107036
Change-Id: Ia5c54e518de99a79f5319c42ccf1a9a0e31ad471

3 years agoChange "Advanced filters" label color
petarpetkovic [Tue, 3 Oct 2017 11:45:03 +0000 (13:45 +0200)]
Change "Advanced filters" label color

Change "Advanced filters" label color to Base20 (#54595D),
fixing monobook skin low contrast.

Bug: T172733
Change-Id: Idb1b9ad7120c387482f8df7fcad8508f2a95139e

3 years agoAdd a help button to the Tagged Edits menu
petarpetkovic [Tue, 3 Oct 2017 11:04:55 +0000 (13:04 +0200)]
Add a help button to the Tagged Edits menu

Bug: T176661
Change-Id: Ia295633dcf96a5466650620ef6e5cef766d19988

3 years agoSelenium tests should log in before creating pages
Željko Filipin [Tue, 3 Oct 2017 09:17:39 +0000 (11:17 +0200)]
Selenium tests should log in before creating pages

MediaWiki Vagrant by default allows creating pages to anonymous users,
but other environments, like Beta Cluster, require user to log in
before creating pages.

Bug: T176315
Change-Id: I34eeaf3cc22a64be6580aa483b28885137ba60b6

3 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Mon, 2 Oct 2017 20:14:52 +0000 (22:14 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I75b3048eb0491d6e67a2a3cdf34b47791bd6baed

3 years agoReapply "RCFilters: Don't apply/clear highlights 66 times"
Roan Kattouw [Mon, 2 Oct 2017 19:07:57 +0000 (12:07 -0700)]
Reapply "RCFilters: Don't apply/clear highlights 66 times"

Reverts 84ddcd5d23, reapplies 212d67c67.

The original version broke the highlight color circles, this fixes it
by using enable instead of this.highlightEnabled to pass down to the
items. The former was always false, so it didn't actually propagate
the state down correctly.

Bug: T177107
Change-Id: I341d9bcd39252eac07bfebfa6d46895bc62c372f

3 years agoMerge "Revert "RCFilters: Don't apply/clear highlights 66 times""
jenkins-bot [Mon, 2 Oct 2017 18:34:38 +0000 (18:34 +0000)]
Merge "Revert "RCFilters: Don't apply/clear highlights 66 times""

3 years agoRevert "RCFilters: Don't apply/clear highlights 66 times"
Catrope [Mon, 2 Oct 2017 18:24:33 +0000 (18:24 +0000)]
Revert "RCFilters: Don't apply/clear highlights 66 times"

Breaks highlight display

This reverts commit 212d67c67e153f95fd2eb49a75b7ece27d794b53.

Change-Id: Ia0111bd35a40df56122a5b8c483de1be35609911

3 years agoMerge "Updated type and function docs for MagicWord.php"
jenkins-bot [Mon, 2 Oct 2017 17:41:41 +0000 (17:41 +0000)]
Merge "Updated type and function docs for MagicWord.php"

3 years agoMerge "TitleWidget: Use OOUI query highlighting, instead of jQuery lib"
jenkins-bot [Mon, 2 Oct 2017 16:36:49 +0000 (16:36 +0000)]
Merge "TitleWidget: Use OOUI query highlighting, instead of jQuery lib"

3 years agoUpdated type and function docs for MagicWord.php
Umherirrender [Mon, 2 Oct 2017 11:52:17 +0000 (13:52 +0200)]
Updated type and function docs for MagicWord.php

Change-Id: I46ebd315a99b1677ff89ba392c0072b41bbeb36d

3 years agoMerge "SpecialBlock: Switch to OOUI form"
jenkins-bot [Mon, 2 Oct 2017 09:09:19 +0000 (09:09 +0000)]
Merge "SpecialBlock: Switch to OOUI form"

3 years agoMerge "Enable IP ranges in HTMLUserTextField"
jenkins-bot [Mon, 2 Oct 2017 09:06:58 +0000 (09:06 +0000)]
Merge "Enable IP ranges in HTMLUserTextField"

3 years agoMerge "Remove unneeded js module in SpecialUnblock"
jenkins-bot [Mon, 2 Oct 2017 04:44:08 +0000 (04:44 +0000)]
Merge "Remove unneeded js module in SpecialUnblock"

3 years agoImprove GitInfo for reading packed refs
Seb35 [Fri, 15 Sep 2017 08:29:13 +0000 (10:29 +0200)]
Improve GitInfo for reading packed refs

GitInfo only reads branches in files /refs/heads/*; it should also
read those in /.git/packed-refs.

There are 4 tests in this commit to test this new "feature" and add some
code coverage to other methods. Given this class tests Git behaviour and
MediaWiki itself is versioned with Git, the test data are created during
the tests and removed at the end to avoid interference with Git as CVS.

Bug: T155747
Change-Id: Icccdf3ec797788582f836e2d8e267a1d714d50dc

3 years agoMerge "mw.loader: Return consistent object shape from splitModuleKey()"
jenkins-bot [Sun, 1 Oct 2017 21:59:39 +0000 (21:59 +0000)]
Merge "mw.loader: Return consistent object shape from splitModuleKey()"

3 years agoMerge "Avoid double escaping headers in InfoAction"
jenkins-bot [Sun, 1 Oct 2017 20:51:31 +0000 (20:51 +0000)]
Merge "Avoid double escaping headers in InfoAction"

3 years agoMerge "Clean up wiki ID and DB domain ID handling"
jenkins-bot [Sun, 1 Oct 2017 20:50:07 +0000 (20:50 +0000)]
Merge "Clean up wiki ID and DB domain ID handling"

3 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Sun, 1 Oct 2017 19:55:27 +0000 (21:55 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I9d12a53dfbb3eb90cae81cd670f94cb5305e3ff4

3 years agoTitleWidget: Use OOUI query highlighting, instead of jQuery lib
Ed Sanders [Sun, 1 Oct 2017 12:14:40 +0000 (13:14 +0100)]
TitleWidget: Use OOUI query highlighting, instead of jQuery lib

Change-Id: I75ee7b3da74bdf9638c442322b699d22b4fee74c

3 years agoMerge "Check requirements for parser test suite in phpunit tests"
jenkins-bot [Sat, 30 Sep 2017 23:45:11 +0000 (23:45 +0000)]
Merge "Check requirements for parser test suite in phpunit tests"

3 years agoMerge "build: Updating mediawiki/mediawiki-codesniffer to 13.0.0"
jenkins-bot [Sat, 30 Sep 2017 23:44:57 +0000 (23:44 +0000)]
Merge "build: Updating mediawiki/mediawiki-codesniffer to 13.0.0"

3 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Sat, 30 Sep 2017 19:54:25 +0000 (21:54 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: Ic025a6a40c6af463475b0e50ce14a20ea17243f6

3 years agomw.loader: Use Array#indexOf directly instead of jQuery.inArray
Timo Tijhof [Sat, 30 Sep 2017 17:50:53 +0000 (18:50 +0100)]
mw.loader: Use Array#indexOf directly instead of jQuery.inArray

Unlike other jQuery methods (which are quite often significantly
faster or slower than native methods), jQuery.inArray is quite
literally a wrapper around Array#indexOf. Use it directly where

* Replace `$.inArray(val, [a, b]) !== -1` pattern
  with `val === a || val === b` which is upto 10x faster.
* mw.loader.store.set.: Remove redundant parenthesis in nested expression.

Change-Id: Ia2b922b3245bfb39b609b57e84938317e9c89cd6

3 years agomw.loader: Return consistent object shape from splitModuleKey()
Timo Tijhof [Sat, 30 Sep 2017 17:35:13 +0000 (18:35 +0100)]
mw.loader: Return consistent object shape from splitModuleKey()

This is used in mw.loader.implement() in a truthy check before
assigning as value of `registry[module].version`.

Both implicit undefined and empty string are falsey so the
behaviour is unchanged.

This reduces shape variability for JS engines, and also avoid
potential mistakes if the function is used elsewhere since
internally the registry, as maintained by mw.loader.register(),
uses empty string as default for version, not undefined.

Change-Id: I067137557a55d521fefa40986373e55b6bbb59ff

3 years agoClean up wiki ID and DB domain ID handling
Aaron Schulz [Mon, 25 Sep 2017 10:37:13 +0000 (12:37 +0200)]
Clean up wiki ID and DB domain ID handling

Bug: T174017
Change-Id: I42299a393c6691d39817db1d83a176a17df2474b

3 years agoMerge "RCFilters: Don't apply/clear highlights 66 times"
jenkins-bot [Sat, 30 Sep 2017 02:09:46 +0000 (02:09 +0000)]
Merge "RCFilters: Don't apply/clear highlights 66 times"

3 years agoRCFilters: Don't apply/clear highlights 66 times
Roan Kattouw [Sat, 30 Sep 2017 00:35:43 +0000 (17:35 -0700)]
RCFilters: Don't apply/clear highlights 66 times

Applying highlights on init was very slow, because applyHighlights
was called 66 times and clearHighlights 64 times.

We first call toggleHighlight() on each filter item, which
leads to update events being emitted by each item, and onItemUpdate
calls clearHighlights() followed by applyHighlights().
There are 64 filter items in my setup, so that's 64 pairs of
clear+apply calls. Then we emit highlightChange, which causes
another apply call, and onModelUpdate calls apply as well.

This change makes sure that the model-wide ("global") highlight
flag is always set to false while we're toggling the highlight
flags on the individual items, so that onItemUpdate short-circuits
and doesn't call clear/apply. There are still other issues (too many
places call clear/apply, too many events emitted), but running the
highlight code twice instead of 130 times on init fixes most
of the performance problems.

Bug: T177107
Change-Id: I65c409ccfabd974ef0b5e2bddff70c9e78e8fd60

3 years agoSanitizer: hard deprecate passing $options to escapeIdReferenceList()
Kunal Mehta [Sat, 30 Sep 2017 00:24:37 +0000 (17:24 -0700)]
Sanitizer: hard deprecate passing $options to escapeIdReferenceList()

Change-Id: I22743102e75614bba848e09f032586923cef0f60

3 years agoMerge "Remove "only newlines in trailer" special case for category/language links"
jenkins-bot [Fri, 29 Sep 2017 22:20:52 +0000 (22:20 +0000)]
Merge "Remove "only newlines in trailer" special case for category/language links"

3 years agoAvoid double escaping headers in InfoAction
Matěj Suchánek [Wed, 20 Sep 2017 14:41:40 +0000 (16:41 +0200)]
Avoid double escaping headers in InfoAction

Bug: T111763
Change-Id: I4f582ce5785448a4cb48f3a1d56371eddf38a232

3 years agoSpecialBlock: Switch to OOUI form
Bartosz Dziewoński [Sun, 26 Jul 2015 23:44:25 +0000 (01:44 +0200)]
SpecialBlock: Switch to OOUI form

* Remove additional wrapper, and the 'blockip-legend' message.
* Replace autocompletion using 'mediawiki.userSuggest' with OOUI,
  by using 'type' => 'user' for the username field

Bug: T107036
Change-Id: Ib8f7e03388073450ecff28ad2c0d3f9161f259d8

3 years agoRCFilters: Convert saved queries from filters to parameters
Moriel Schottlender [Fri, 18 Aug 2017 21:06:09 +0000 (14:06 -0700)]
RCFilters: Convert saved queries from filters to parameters

This will allow us to load them in the backend, and to keep
consistency between RecentChanges and Watchlist if needed.

Added also a 'backup' preference to keep the previous version
before the conversion, in case of mangling of the queries.

Bug: T166908
Change-Id: I8e26b66e43bd16282b7bdb52abc152f92a9c877d

3 years agoEnable IP ranges in HTMLUserTextField
Florian [Tue, 25 Aug 2015 18:05:35 +0000 (20:05 +0200)]
Enable IP ranges in HTMLUserTextField

Like an existing user and a single IP, allow to use an IP range, too.

Bug: T107039
Change-Id: I9137f71f6119c68d787f508a3f57b476404315d8

3 years agoRemove unneeded js module in SpecialUnblock
Amir Sarabadani [Fri, 29 Sep 2017 17:44:30 +0000 (19:44 +0200)]
Remove unneeded js module in SpecialUnblock

Followup to I3c51183c0275dd2f9522ba60990852cc96409e2d

Bug: T107036
Change-Id: I6d1ca8b07e40950480344a106558a98a5bf5d341

3 years agoMerge "Revert "CSSMin: Improve encoding of quotes in embedded SVGs""
jenkins-bot [Fri, 29 Sep 2017 17:13:04 +0000 (17:13 +0000)]
Merge "Revert "CSSMin: Improve encoding of quotes in embedded SVGs""

3 years agoMerge "Revert "CSSMin: Mangle whitespace in embedded SVGs""
jenkins-bot [Fri, 29 Sep 2017 17:10:44 +0000 (17:10 +0000)]
Merge "Revert "CSSMin: Mangle whitespace in embedded SVGs""

3 years agoMerge "TitleWidget: Upstream generic page icons from VE"
jenkins-bot [Fri, 29 Sep 2017 16:34:23 +0000 (16:34 +0000)]
Merge "TitleWidget: Upstream generic page icons from VE"

3 years agoTweak layout of TitleWidget results
Ed Sanders [Fri, 29 Sep 2017 15:30:40 +0000 (16:30 +0100)]
Tweak layout of TitleWidget results

Bug: T177085
Change-Id: I663e63e89b1be2d377de28ba74ad43519ff04741

3 years agoTitleWidget: Upstream generic page icons from VE
Ed Sanders [Fri, 29 Sep 2017 14:42:47 +0000 (15:42 +0100)]
TitleWidget: Upstream generic page icons from VE

Change-Id: I297648d14b4a2540a40f3a0b7d22a7905ef7c035

3 years agoRevert "CSSMin: Improve encoding of quotes in embedded SVGs"
VolkerE [Fri, 29 Sep 2017 11:53:02 +0000 (11:53 +0000)]
Revert "CSSMin: Improve encoding of quotes in embedded SVGs"

This reverts commit 5e3165f0080961e637e9ed600b696786aee7eda4.

Bug: T176884
Change-Id: I8bd9af67aeb11cb478ba402205ce834b1bec17a7

3 years agoRevert "CSSMin: Mangle whitespace in embedded SVGs"
Esanders [Fri, 29 Sep 2017 13:39:50 +0000 (13:39 +0000)]
Revert "CSSMin: Mangle whitespace in embedded SVGs"

This reverts commit dfd42d2653ea9ff2ca05dab7cd6f2285abba9d08.

Bug: T176884
Change-Id: Iddc98332d0b5a31d3a1c56c14014a53a06393f21

3 years agoMerge "Migrate Special:Unblock to OOUI"
jenkins-bot [Fri, 29 Sep 2017 11:08:39 +0000 (11:08 +0000)]
Merge "Migrate Special:Unblock to OOUI"

3 years agoMerge "Update cleanupSpam.php to hide its activity from RecentChanges"
jenkins-bot [Fri, 29 Sep 2017 05:37:43 +0000 (05:37 +0000)]
Merge "Update cleanupSpam.php to hide its activity from RecentChanges"

3 years agoMerge "Improve namespace handling in tests"
jenkins-bot [Fri, 29 Sep 2017 05:33:26 +0000 (05:33 +0000)]
Merge "Improve namespace handling in tests"

3 years agoMerge "Fix patchfile used to add newtalk table on mysql"
jenkins-bot [Fri, 29 Sep 2017 05:31:59 +0000 (05:31 +0000)]
Merge "Fix patchfile used to add newtalk table on mysql"

3 years agoUpdate cleanupSpam.php to hide its activity from RecentChanges
MarcoAurelio [Tue, 19 Sep 2017 20:26:14 +0000 (22:26 +0200)]
Update cleanupSpam.php to hide its activity from RecentChanges

Spam cleanup activities, mostly when it comes from automated processes
(the so called 'spambots') can involve a fair ammount of edits and log
actions to accomplish.

As such, to avoid flooding Special:RecentChanges, this script will now
set a bot flag on the script run so its edits and actions won't show
up in that special page.

To prepare this patch I had the help of Bartosz Dziewoński which I'd
also like to thank and I'll credit as co-author as well.

Bug: T176206
Co-Authored-By: Bartosz Dziewoński <matma.rex@gmail.com>
Change-Id: Ifde08056a7481b877b4b82699cc0a5ea3f962dd9

3 years agoMerge "Do not include RC_EXTERNAL in number active users on Special:Statistics"
jenkins-bot [Fri, 29 Sep 2017 05:25:22 +0000 (05:25 +0000)]
Merge "Do not include RC_EXTERNAL in number active users on Special:Statistics"

3 years agoImprove namespace handling in tests
Brad Jorsch [Mon, 11 Sep 2017 20:37:18 +0000 (16:37 -0400)]
Improve namespace handling in tests

MWNamespace has three internal caches, only one of which can be cleared
(and that somewhat oddly by passing a boolean to

This change introduces a MWNamespace::clearCaches() method to clear all
three caches. It also adds some resetting in tests that seemed to be
missing it.

Change-Id: I1dcfcd8713888b3ff8fc75e95329ba72bd95d0c9

3 years agoMerge "Revert "DumpFilter is autoloaded. No need to require in maintenance script""
jenkins-bot [Fri, 29 Sep 2017 05:18:09 +0000 (05:18 +0000)]
Merge "Revert "DumpFilter is autoloaded. No need to require in maintenance script""

3 years agoMerge "Consistently preserve anchors in the title specified in 'mainpage' message"
jenkins-bot [Fri, 29 Sep 2017 05:16:10 +0000 (05:16 +0000)]
Merge "Consistently preserve anchors in the title specified in 'mainpage' message"

3 years agoMerge "Fix CreditsAction when user has no real name set but real names enabled"
jenkins-bot [Fri, 29 Sep 2017 05:15:56 +0000 (05:15 +0000)]
Merge "Fix CreditsAction when user has no real name set but real names enabled"

3 years agoMerge "objectcache: Improve WANObjectCache test coverage"
jenkins-bot [Fri, 29 Sep 2017 05:15:53 +0000 (05:15 +0000)]
Merge "objectcache: Improve WANObjectCache test coverage"

3 years agoDo not include RC_EXTERNAL in number active users on Special:Statistics
Brian Wolff [Tue, 26 Sep 2017 21:40:04 +0000 (21:40 +0000)]
Do not include RC_EXTERNAL in number active users on Special:Statistics

We already exclude external (mostly Wikidata) actions from counting on
Special:ActiveUsers as of 56524c05. Should be consistent.

Change-Id: Ib69a614a65246a0f4f47365751f9bef130f47475

3 years agoFollow-up 67f04373d fix stupid typo
Brian Wolff [Thu, 28 Sep 2017 21:35:44 +0000 (21:35 +0000)]
Follow-up 67f04373d fix stupid typo

Fot should be For

Change-Id: I3cb87a94feea32f1c98345ceaa19f9a75fde266d

3 years agoMerge "Make the RC/Watchlist legend not jump when initially collapsed"
jenkins-bot [Thu, 28 Sep 2017 20:26:44 +0000 (20:26 +0000)]
Merge "Make the RC/Watchlist legend not jump when initially collapsed"

3 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Thu, 28 Sep 2017 19:54:45 +0000 (21:54 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I02b4624b999123b0841af96adf9f6c3467fa9b3b

3 years agoMake the RC/Watchlist legend not jump when initially collapsed
Roan Kattouw [Thu, 28 Sep 2017 00:09:05 +0000 (17:09 -0700)]
Make the RC/Watchlist legend not jump when initially collapsed

Look at the collapsed/expanded cookie and add class="mw-collapsed"
if it's going to be collapsed.

This is kind of a prelude to T42812.

Change-Id: Icaca762a9d7b000c973d9275f395623129f67979

3 years agoMerge "Distinguish GET from POST for PostSend expectations"
jenkins-bot [Thu, 28 Sep 2017 18:11:58 +0000 (18:11 +0000)]
Merge "Distinguish GET from POST for PostSend expectations"

3 years agoMerge "Add more ProcessCacheLRU comments"
jenkins-bot [Thu, 28 Sep 2017 18:11:55 +0000 (18:11 +0000)]
Merge "Add more ProcessCacheLRU comments"

3 years agoobjectcache: Improve WANObjectCache test coverage
Timo Tijhof [Mon, 25 Sep 2017 23:21:40 +0000 (00:21 +0100)]
objectcache: Improve WANObjectCache test coverage

class WANObjectCache (methods: 40% -> 67%, lines: 65% -> 88%)

* Allow indirect coverage of protected/private utility methods from
  existing tests.
* Add basic test for setLogger().
* Add basic test for newEmpty().
* Add basic test for getQoS().

Change-Id: Ifb79ed2ff1febbd2f5477b8ed6319992ce88eb29

3 years agoMerge "HTMLFormField: Treat weird '&#160;' labels as empty in OOUI mode"
jenkins-bot [Thu, 28 Sep 2017 17:53:50 +0000 (17:53 +0000)]
Merge "HTMLFormField: Treat weird '&#160;' labels as empty in OOUI mode"

3 years agoMerge "LogFormatter: Don't return a non-array from formatParameterValueForApi"
jenkins-bot [Thu, 28 Sep 2017 17:12:51 +0000 (17:12 +0000)]
Merge "LogFormatter: Don't return a non-array from formatParameterValueForApi"

3 years agoUnregister hooks that interfere with unit testing
Huji Lee [Thu, 28 Sep 2017 15:20:45 +0000 (11:20 -0400)]
Unregister hooks that interfere with unit testing

Id7403f57cc9d751ada85b611193c1d8f3503e713 did not properly
reference the hook

Bug: T176102
Change-Id: Ibff72c0efe82ba6fd4458e3c8a96179f50ca21b0

3 years agoLogFormatter: Don't return a non-array from formatParameterValueForApi
Brad Jorsch [Thu, 28 Sep 2017 14:06:53 +0000 (10:06 -0400)]
LogFormatter: Don't return a non-array from formatParameterValueForApi

If the title for a 'title' or 'title-link' type is invalid, the code
still must not return a non-array from the method.

I'm not sure this is what was behind T176938, but it's the only thing I
can find that might cause the errors I saw logged at about the same

Change-Id: Iae77eb6ad9a64d8b67074164ff0c0fea36826f3c