lhc/web/wiklou.git
5 years agoApiPageSet::initFromPageIds: Default $filterIds to true
Brad Jorsch [Wed, 12 Dec 2018 18:12:57 +0000 (13:12 -0500)]
ApiPageSet::initFromPageIds: Default $filterIds to true

I have no idea why that was false in Ic1975220. Particularly when, of
the three calls, only one was changed to specify the parameter and that
was changed to pass false explicitly.

If it hadn't been false, it would have prevented T211804.

Bug: T211804
Change-Id: I8eea8936e9f57bf3e336f81b62bb11b9e2668788

5 years agoMerge "mw.Title.newFromUserInput: Rename vars, improve docs for double signature"
jenkins-bot [Wed, 12 Dec 2018 17:55:34 +0000 (17:55 +0000)]
Merge "mw.Title.newFromUserInput: Rename vars, improve docs for double signature"

5 years agoMerge "Replace $.type with typeof"
jenkins-bot [Wed, 12 Dec 2018 17:50:37 +0000 (17:50 +0000)]
Merge "Replace $.type with typeof"

5 years agomw.Title.newFromUserInput: Rename vars, improve docs for double signature
Ed Sanders [Wed, 12 Dec 2018 13:20:25 +0000 (13:20 +0000)]
mw.Title.newFromUserInput: Rename vars, improve docs for double signature

Also add tests to cover this usage.

Change-Id: I61c7e7377ac7d75073dac025f5f7ff4e599756cb

5 years agoReplace $.type with typeof
Ed Sanders [Wed, 12 Dec 2018 13:18:08 +0000 (13:18 +0000)]
Replace $.type with typeof

Change-Id: I75857eb205ce2fc3ba8f836f3f2ee66987b45748

5 years agoMerge "Remove unused /* global console */"
jenkins-bot [Wed, 12 Dec 2018 16:32:32 +0000 (16:32 +0000)]
Merge "Remove unused /* global console */"

5 years agoMerge "Link log entries to Special:Log on ApiFeedWatchlist"
jenkins-bot [Wed, 12 Dec 2018 16:20:36 +0000 (16:20 +0000)]
Merge "Link log entries to Special:Log on ApiFeedWatchlist"

5 years agoImageListPager: Don't query by oi_user
Brad Jorsch [Wed, 12 Dec 2018 15:31:40 +0000 (10:31 -0500)]
ImageListPager: Don't query by oi_user

For some reason we have indexes for `image` on `(img_user_text,img_timestamp)` and
`(img_user,img_timestamp)`, but for `oldimage` we only have
`(oi_user_text,oi_timestamp)`. Thus, when building the query in
ImageListPager, we have to be sure to avoid trying to use `oi_user`
rather than `oi_user_text` in the WHERE part.

Bug: T211774
Change-Id: Ibea058031f1cb3421e92e09f0a705ea00fb22008

5 years agoLink log entries to Special:Log on ApiFeedWatchlist
LukBukkit [Tue, 11 Dec 2018 22:17:53 +0000 (23:17 +0100)]
Link log entries to Special:Log on ApiFeedWatchlist

This prevents RSS readers from breaking, because there aren't
entries which contain a link to a zero diff anymore.

Bug: T210920
Change-Id: Ia5f57b4ab60873bf5d7b2fcf2a2b4f6f90c135b3

5 years agoRemove unused /* global console */
Ed Sanders [Wed, 12 Dec 2018 14:42:48 +0000 (14:42 +0000)]
Remove unused /* global console */

Change-Id: I330208689281cae251c1da9c147611a79b9b153a

5 years agoApiBase: Pass empty string, not null, for $conds to ->select
Brad Jorsch [Wed, 12 Dec 2018 14:25:00 +0000 (09:25 -0500)]
ApiBase: Pass empty string, not null, for $conds to ->select

Bug: T211769
Change-Id: I4cf224c19b340fac5fc895bbee7507d77fd3fdfa

5 years agoAPI: Use parenthesized join in ApiQueryBase::showHiddenUsersAddBlockInfo
Brad Jorsch [Mon, 3 Dec 2018 14:29:50 +0000 (09:29 -0500)]
API: Use parenthesized join in ApiQueryBase::showHiddenUsersAddBlockInfo

The query is LEFT JOINing ipblocks, so we need to properly scope the new
JOINs with the comment and actor tables to get the block reason and
by-actor.

Bug: T210937
Change-Id: I230a4ab78e3ba6e83008b0466eeca8d40013ba3d

5 years agoMerge "Have BotPassword::login() call AuthManagerLoginAuthenticateAudit"
jenkins-bot [Wed, 12 Dec 2018 01:29:41 +0000 (01:29 +0000)]
Merge "Have BotPassword::login() call AuthManagerLoginAuthenticateAudit"

5 years agoMerge "Add PHPUnit tests for methods in ViewAction::class"
jenkins-bot [Tue, 11 Dec 2018 23:50:44 +0000 (23:50 +0000)]
Merge "Add PHPUnit tests for methods in ViewAction::class"

5 years agoMerge "Support message parameters in JavaScript messages with uselang=qqx"
jenkins-bot [Tue, 11 Dec 2018 22:56:55 +0000 (22:56 +0000)]
Merge "Support message parameters in JavaScript messages with uselang=qqx"

5 years agoSupport message parameters in JavaScript messages with uselang=qqx
Bartosz Dziewoński [Sat, 27 Oct 2018 20:01:39 +0000 (22:01 +0200)]
Support message parameters in JavaScript messages with uselang=qqx

Change-Id: I2266ec0770f08e826892a28f52f3201dfd10191d

5 years agoMerge "Localisation updates from https://translatewiki.net."
jenkins-bot [Tue, 11 Dec 2018 20:58:56 +0000 (20:58 +0000)]
Merge "Localisation updates from https://translatewiki.net."

5 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Tue, 11 Dec 2018 20:57:35 +0000 (21:57 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: I78c4d9c910da554460b91b6871b5e268a3a32c27

5 years agoMerge "Improve layout of ExpiryInputWidget on mobile"
jenkins-bot [Tue, 11 Dec 2018 20:55:22 +0000 (20:55 +0000)]
Merge "Improve layout of ExpiryInputWidget on mobile"

5 years agoHave BotPassword::login() call AuthManagerLoginAuthenticateAudit
Brad Jorsch [Thu, 10 May 2018 14:01:06 +0000 (10:01 -0400)]
Have BotPassword::login() call AuthManagerLoginAuthenticateAudit

To facilitate logging all authentications, even ones not via
AuthManager, BotPassword::login() should call the
AuthManagerLoginAuthenticateAudit hook.

Bug: T194338
Change-Id: I27b75c56e060fcb8f71d84ddc2eb8e1533fef33a

5 years agoImprove layout of ExpiryInputWidget on mobile
Thalia [Tue, 27 Nov 2018 16:17:07 +0000 (16:17 +0000)]
Improve layout of ExpiryInputWidget on mobile

Bug: T208271
Change-Id: If3f9c417cd2fad98165b8a2eaef9a05673ce5b4d

5 years agoMerge "rdbms: reduce LoadBalancer replication log spam"
jenkins-bot [Tue, 11 Dec 2018 19:39:26 +0000 (19:39 +0000)]
Merge "rdbms: reduce LoadBalancer replication log spam"

5 years agoFix typo in message documentation
Thalia [Tue, 11 Dec 2018 14:07:18 +0000 (14:07 +0000)]
Fix typo in message documentation

Change-Id: I373c973f35bb8897a00c96c51d83371b2d9eca4a

5 years agoMerge "Add new rules when user is blocked for UTP"
jenkins-bot [Tue, 11 Dec 2018 13:18:14 +0000 (13:18 +0000)]
Merge "Add new rules when user is blocked for UTP"

5 years agoMerge "Fix return typehint"
jenkins-bot [Tue, 11 Dec 2018 13:04:50 +0000 (13:04 +0000)]
Merge "Fix return typehint"

5 years agoFix return typehint
Jakub Vrana [Sat, 1 Dec 2018 08:58:42 +0000 (09:58 +0100)]
Fix return typehint

Found by PHPStan.

Change-Id: I2e649aa85c84925886b6acfba2bbdde1a4f12214

5 years agoAdd new rules when user is blocked for UTP
Dayllan Maza [Mon, 3 Dec 2018 13:20:47 +0000 (08:20 -0500)]
Add new rules when user is blocked for UTP

No changes for sitewide blocks when "Prevent user... edit own talk page"
is checked. On partial blocks, this option will be disabled and ignored. All users
will be allowed to edit their own talk page unless a page restriction
for their page is in place.

New rules will be implemented for Namespace restrictions in a different
patch when Namespace blocking is ready.

Bug: T210475
Change-Id: I096edf2887441bccd59f09bf0eceb3988b36db1e

5 years agoMerge "Use Travis CI cache and reduce clone depth to speed up setup time"
jenkins-bot [Tue, 11 Dec 2018 00:04:20 +0000 (00:04 +0000)]
Merge "Use Travis CI cache and reduce clone depth to speed up setup time"

5 years agoMerge "RCFilters: Tweak opt-out preference description"
jenkins-bot [Tue, 11 Dec 2018 00:03:13 +0000 (00:03 +0000)]
Merge "RCFilters: Tweak opt-out preference description"

5 years agoMerge "Chinese Conversion Table Update 2018-3"
jenkins-bot [Mon, 10 Dec 2018 23:55:03 +0000 (23:55 +0000)]
Merge "Chinese Conversion Table Update 2018-3"

5 years agoMerge "filebackend: avoiding computing file SHA-1 hashes unless needed"
jenkins-bot [Mon, 10 Dec 2018 23:51:35 +0000 (23:51 +0000)]
Merge "filebackend: avoiding computing file SHA-1 hashes unless needed"

5 years agofilebackend: avoiding computing file SHA-1 hashes unless needed
Aaron Schulz [Fri, 9 Nov 2018 01:13:51 +0000 (17:13 -0800)]
filebackend: avoiding computing file SHA-1 hashes unless needed

FileBackendStore already supports stat info not returning SHA-1.
Build on that logic with a "requireSHA1" parameter to getFileStat()
to move some logic from SwiftFileBackend to the parent class and
avoid computing missing SHA-1's for Swift when nothing actually
requested the SHA-1. Only getFileSha1Base36() needs to trigger this
lazy-population logic.

Note that thumbnails only use doQuickOperations(), which does not
need to examine SHA-1s, it only does regular getFileStat() calls.

Also renamed addMissingMetadata() to addMissingHashMetadata().

Bug: T204174
Change-Id: I2a378cb2a34608a6da2f8abe604861ff391ffaa7

5 years agoMerge "Can't call escaped() on a string."
jenkins-bot [Mon, 10 Dec 2018 22:07:24 +0000 (22:07 +0000)]
Merge "Can't call escaped() on a string."

5 years agordbms: reduce LoadBalancer replication log spam
Aaron Schulz [Mon, 10 Dec 2018 20:29:43 +0000 (15:29 -0500)]
rdbms: reduce LoadBalancer replication log spam

LoadMonitor already has similar and less-frequent logging since
it only happens on cache rebuilds.

Bug: T204531
Change-Id: I270a65ab1d3f471bd49c8f54d85151c91827a518

5 years agoAvoid deprecated OO.ui.infuse( id )
Ed Sanders [Mon, 10 Dec 2018 19:49:41 +0000 (19:49 +0000)]
Avoid deprecated OO.ui.infuse( id )

Bug: T211154
Change-Id: Ib5fdaaa662d8c7d85e7fd3ca1007bf5b8e82e738

5 years agoCan't call escaped() on a string.
Alexia E. Smith [Mon, 10 Dec 2018 19:32:12 +0000 (13:32 -0600)]
Can't call escaped() on a string.

Bug: T211442
Change-Id: Ica5b9cf380a646d9520d5307a937d1e51b7b0099

5 years agoMerge "Fix TitlesMultiselectWidget documentation"
jenkins-bot [Mon, 10 Dec 2018 19:22:20 +0000 (19:22 +0000)]
Merge "Fix TitlesMultiselectWidget documentation"

5 years agoFix TitlesMultiselectWidget documentation
Thalia [Mon, 10 Dec 2018 18:25:52 +0000 (18:25 +0000)]
Fix TitlesMultiselectWidget documentation

Change-Id: I4b6bad233b4a4dfd840385f26a10bd190f6cb6b9

5 years agoMerge "Revert "textSelection: Use execcommand to replace text""
jenkins-bot [Mon, 10 Dec 2018 18:17:55 +0000 (18:17 +0000)]
Merge "Revert "textSelection: Use execcommand to replace text""

5 years agoRevert "textSelection: Use execcommand to replace text"
Esanders [Mon, 10 Dec 2018 17:58:59 +0000 (17:58 +0000)]
Revert "textSelection: Use execcommand to replace text"

This reverts commit 4ba80ca7f5472dbdbccc1afa9ebf3549700f2778.

Change-Id: Iffeb021a1a6b204ea5ca6d8e16bab4d703ee7f6c

5 years agoMerge "Special:AllMessages: Remove 'id' attribute from message rows"
jenkins-bot [Mon, 10 Dec 2018 17:38:35 +0000 (17:38 +0000)]
Merge "Special:AllMessages: Remove 'id' attribute from message rows"

5 years agoMerge "Cancel the transaction if the file fails to move. This prevents losing files...
jenkins-bot [Mon, 10 Dec 2018 17:15:07 +0000 (17:15 +0000)]
Merge "Cancel the transaction if the file fails to move.  This prevents losing files when there is a database error."

5 years agoCancel the transaction if the file fails to move. This prevents
Alexia E. Smith [Fri, 7 Dec 2018 18:26:47 +0000 (12:26 -0600)]
Cancel the transaction if the file fails to move.  This prevents
losing files when there is a database error.

Bug: T211442
Change-Id: I4aaa8af50d684de9d72224d43dfe5209b930810f

5 years agoMerge "Create GuzzleHttpRequest class as new default for HttpRequestFactory"
jenkins-bot [Mon, 10 Dec 2018 15:39:49 +0000 (15:39 +0000)]
Merge "Create GuzzleHttpRequest class as new default for HttpRequestFactory"

5 years agoMerge "Use english for message text in SparqlException"
jenkins-bot [Mon, 10 Dec 2018 10:06:05 +0000 (10:06 +0000)]
Merge "Use english for message text in SparqlException"

5 years agoMerge "Use english for log text in AuthManagerSpecialPage"
jenkins-bot [Mon, 10 Dec 2018 10:05:59 +0000 (10:05 +0000)]
Merge "Use english for log text in AuthManagerSpecialPage"

5 years agoCreate GuzzleHttpRequest class as new default for HttpRequestFactory
Bill Pirkle [Fri, 17 Aug 2018 14:53:59 +0000 (09:53 -0500)]
Create GuzzleHttpRequest class as new default for HttpRequestFactory

Create a GuzzleHttpRequest class using the external Guzzle
(docs.guzzlephp.org) library. This will be the new default request type,
but CurlHttpRequest and PhpHttpRequest remain available and accessible
via Http::$httpEngine.

Bug: T202110
Change-Id: Ie720be2628d7baf427b002847f103fd86ee4cff3
Depends-On: I143a6410d111e75f01dbbfd43f300e2e60247451

5 years agoMerge "Hard deprecate SearchEngine::getNearMatchResultSet()"
jenkins-bot [Mon, 10 Dec 2018 03:20:37 +0000 (03:20 +0000)]
Merge "Hard deprecate SearchEngine::getNearMatchResultSet()"

5 years agoMerge "Hard deprecate LinkCache::addLink()"
jenkins-bot [Mon, 10 Dec 2018 03:18:47 +0000 (03:18 +0000)]
Merge "Hard deprecate LinkCache::addLink()"

5 years agoMerge "Hard deprecated SiteSQLStore::newInstance()"
jenkins-bot [Mon, 10 Dec 2018 03:17:30 +0000 (03:17 +0000)]
Merge "Hard deprecated SiteSQLStore::newInstance()"

5 years agoMerge "Revert "Pass $context to 'GetPreferences' hook""
jenkins-bot [Mon, 10 Dec 2018 03:13:44 +0000 (03:13 +0000)]
Merge "Revert "Pass $context to 'GetPreferences' hook""

5 years agoRevert "Pass $context to 'GetPreferences' hook"
Krinkle [Sun, 9 Dec 2018 02:12:24 +0000 (02:12 +0000)]
Revert "Pass $context to 'GetPreferences' hook"

This reverts commit d68569459420e80aa0e2f2636fc7160c643cf5fb.

Change-Id: I1e9299b8fdc4727895fdac60f04cc5dfa4d09b7a

5 years agoMerge "Allow users to block the user that blocked them."
jenkins-bot [Sun, 9 Dec 2018 23:47:25 +0000 (23:47 +0000)]
Merge "Allow users to block the user that blocked them."

5 years agoAllow users to block the user that blocked them.
Brian Wolff [Tue, 27 Nov 2018 18:38:14 +0000 (18:38 +0000)]
Allow users to block the user that blocked them.

This is to make it so that blocking all other admins is not
a succesful attack plan, as the blocked admins can block the
blocker, and then it ends in a stalemate with everyone blocked.

This also allows users with unblock-self right to adjust their
own blocks. The code already existed for this but was broken.

Credit for this idea goes to Tgr.

Bug: T150826
Change-Id: I0418279fdb2a59f8f1d7eeb8931d874123d03e4f

5 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Sun, 9 Dec 2018 20:55:00 +0000 (21:55 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: Icf65b2765d118c65b13d9b6b033cd380146262fb

5 years agoSpecial:AllMessages: Remove 'id' attribute from message rows
Timo Tijhof [Sun, 9 Dec 2018 19:09:43 +0000 (19:09 +0000)]
Special:AllMessages: Remove 'id' attribute from message rows

This was introduced in r13629 (2006; 17633ab92a4) to allow
easy linking to individual results, which predates the pagination
feature that was added in r53286 (2009; c90b9b93ecb).

This was a hidden feature not exposed througuh the user-interface
in any way, and not documented. Removing it should be safe.

Any recently crafted permalinks fallback to loading the page containing
the message key without jumping to it.

Any older permalinks have already been broken for 10 years because
pagination would have limited the results returned, likely not
included the anchored ID (dead-end fragment).

Change-Id: I53bd56e0d5a82fba65388e1c2da3c8349a138261

5 years agoRemove useless continue at end of loop
Fomafix [Fri, 5 Oct 2018 10:31:26 +0000 (12:31 +0200)]
Remove useless continue at end of loop

A loop always continues at the end of the loop.

Change-Id: I6be79afa6ea67247d37ab3dc3c552183a81d6706

5 years agoUse english for log text in AuthManagerSpecialPage
Umherirrender [Sun, 9 Dec 2018 10:22:30 +0000 (11:22 +0100)]
Use english for log text in AuthManagerSpecialPage

Change-Id: I747381031edad0903538cdc9b797de8a9b0aee1c

5 years agoUse english for message text in SparqlException
Umherirrender [Sun, 9 Dec 2018 10:17:39 +0000 (11:17 +0100)]
Use english for message text in SparqlException

Change-Id: I1d3d0fb5957527a2de9d8d4e86cae8aed8732866

5 years agoHard deprecate SearchEngine::getNearMatchResultSet()
Max Semenik [Sat, 8 Dec 2018 21:36:12 +0000 (13:36 -0800)]
Hard deprecate SearchEngine::getNearMatchResultSet()

Deprecated in 1.27, no callers.

Change-Id: I6084a114fe8d0b4681e2e4b55eada06b684c719c

5 years agoHard deprecate LinkCache::addLink()
Max Semenik [Sat, 8 Dec 2018 21:22:40 +0000 (13:22 -0800)]
Hard deprecate LinkCache::addLink()

Deprecated in 1.27, no callers.

Change-Id: Ide39566b6741d2b844ddd5c8e62dd0fc0382670a

5 years agoHard deprecated SiteSQLStore::newInstance()
Max Semenik [Sat, 8 Dec 2018 21:11:27 +0000 (13:11 -0800)]
Hard deprecated SiteSQLStore::newInstance()

Deprecated in 1.27, no callers.

Change-Id: Ia262790cc6804b29fee656d0f53be1374bf04c2f

5 years agoMerge "resourceloader: Add getConfig() method to ResourceLoaderContext"
jenkins-bot [Sun, 9 Dec 2018 02:01:18 +0000 (02:01 +0000)]
Merge "resourceloader: Add getConfig() method to ResourceLoaderContext"

5 years agoresourceloader: Add getConfig() method to ResourceLoaderContext
Roan Kattouw [Sat, 8 Dec 2018 01:38:41 +0000 (17:38 -0800)]
resourceloader: Add getConfig() method to ResourceLoaderContext

Change-Id: I38ece7320adab64113c5d2a91056d5522f369367

5 years agoMerge "No yoda conditions"
jenkins-bot [Sun, 9 Dec 2018 01:34:23 +0000 (01:34 +0000)]
Merge "No yoda conditions"

5 years agoMerge "Add browser test for preview functionality to MediaWiki core"
jenkins-bot [Sun, 9 Dec 2018 00:53:23 +0000 (00:53 +0000)]
Merge "Add browser test for preview functionality to MediaWiki core"

5 years agoMerge "SpecialUnusedimages: Change message when CountCategorizedImagesAsUsed"
jenkins-bot [Sat, 8 Dec 2018 21:32:17 +0000 (21:32 +0000)]
Merge "SpecialUnusedimages: Change message when CountCategorizedImagesAsUsed"

5 years agoMerge "Skin: Remove default loading of module 'mediawiki.user'"
jenkins-bot [Sat, 8 Dec 2018 20:23:33 +0000 (20:23 +0000)]
Merge "Skin: Remove default loading of module 'mediawiki.user'"

5 years agoSkin: Remove default loading of module 'mediawiki.user'
Fomafix [Mon, 3 Dec 2018 12:56:52 +0000 (13:56 +0100)]
Skin: Remove default loading of module 'mediawiki.user'

The default loading of module 'mediawiki.user' was added in 7d4108ecdb
(r88254).

At this time mw.user.options was defined in module 'mediawiki.user'.
Now mw.user.options is already defined in module 'startup'.

Change-Id: I772cf93317f64a7d1723b01cb92f7db7be91cf89

5 years agoMerge "Pass title to Revision constructor in ContribsPager "
jenkins-bot [Sat, 8 Dec 2018 17:32:23 +0000 (17:32 +0000)]
Merge "Pass title to Revision constructor in ContribsPager "

5 years agoparser: Fix PHPDoc annotations in parser module
Alangi Derick [Mon, 3 Dec 2018 14:58:57 +0000 (15:58 +0100)]
parser: Fix PHPDoc annotations in parser module

Change-Id: I09680d72516f943051e86655b5fddf9ff2988e4e

5 years agoSpecialUnusedimages: Change message when CountCategorizedImagesAsUsed
Rafid Aslam [Fri, 7 Dec 2018 21:00:40 +0000 (04:00 +0700)]
SpecialUnusedimages: Change message when CountCategorizedImagesAsUsed

Change the header message of SpecialUnusedimages to explain
that categorized images are considered as used when
$wgCountCategorizedImagesAsUsed is turned on.

Bug: T210923
Change-Id: Ifefdaaf6e80ee50ce64459c708f651bd871d746e

5 years agoMerge "User: Bypass repeatable-read when creating an actor_id"
jenkins-bot [Fri, 7 Dec 2018 23:37:09 +0000 (23:37 +0000)]
Merge "User: Bypass repeatable-read when creating an actor_id"

5 years agoMerge "Remove User::EDIT_TOKEN_SUFFIX, a deprecated constant since 1.27."
jenkins-bot [Fri, 7 Dec 2018 23:14:53 +0000 (23:14 +0000)]
Merge "Remove User::EDIT_TOKEN_SUFFIX, a deprecated constant since 1.27."

5 years agoRemove User::EDIT_TOKEN_SUFFIX, a deprecated constant since 1.27.
Matthewrbowker [Thu, 29 Nov 2018 19:23:25 +0000 (19:23 +0000)]
Remove User::EDIT_TOKEN_SUFFIX, a deprecated constant since 1.27.

Bug: T61113
Change-Id: I4a461003c881b457283dc6118153e24380fccc88

5 years agoMerge "monolog: add CeeFormatter"
jenkins-bot [Fri, 7 Dec 2018 21:24:17 +0000 (21:24 +0000)]
Merge "monolog: add CeeFormatter"

5 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Fri, 7 Dec 2018 21:00:28 +0000 (22:00 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: I848ec9003a94a5bc3eba15274f8c5ea8ea4812ad

5 years agoMerge "Login-related messages should get the URL as a parameter"
jenkins-bot [Fri, 7 Dec 2018 20:09:06 +0000 (20:09 +0000)]
Merge "Login-related messages should get the URL as a parameter"

5 years agojobqueue: Add PHPDoc param annotation for __construct() method
Alangi Derick [Mon, 3 Dec 2018 12:17:08 +0000 (13:17 +0100)]
jobqueue: Add PHPDoc param annotation for __construct() method

Document $parserCache, $title and $params for the constructor method
and minor typo fix newSpec() method.

Change-Id: I5968ee5bfe614da6f6dc8d7e0405799aa00b6127

5 years agoPass title to Revision constructor in ContribsPager
Umherirrender [Sat, 22 Sep 2018 13:40:05 +0000 (15:40 +0200)]
Pass title to Revision constructor in ContribsPager

The information for a title already in the select result.
Give it to Revision class to avoid extra Title::newFromId in
Revision::ensureTitle for each row

Change-Id: Ib8dd78f918bd0f3fe131f2a8ed9e659f87edd4a1

5 years agoMerge "Add dependencies on module 'user.options'"
jenkins-bot [Fri, 7 Dec 2018 18:22:13 +0000 (18:22 +0000)]
Merge "Add dependencies on module 'user.options'"

5 years agoAdd browser test for preview functionality to MediaWiki core
Thiemo Kreuz [Thu, 29 Nov 2018 18:04:31 +0000 (19:04 +0100)]
Add browser test for preview functionality to MediaWiki core

The basic functionality of being able to preview an edit is currently
not covered by a test, as far as I can see.

The assertion for a wpTextbox2 that should *not* be there is a result of
the issue documented at T209012, where the EditPage::isConflict flag was
accidentially set. This assertion makes sure accidential conflicts can't
happen again, no matter which extension might cause it.

Bug: T210758
Change-Id: Iae723430b3a88079ad3499429e65c29817eca67e

5 years agoMerge "textSelection: Use execcommand to replace text"
jenkins-bot [Fri, 7 Dec 2018 15:27:25 +0000 (15:27 +0000)]
Merge "textSelection: Use execcommand to replace text"

5 years agomonolog: add CeeFormatter
Filippo Giunchedi [Wed, 5 Dec 2018 15:00:04 +0000 (16:00 +0100)]
monolog: add CeeFormatter

This formatter extends LogstashFormatter to prefix records with "cee token"
used for syslog and JSON structured logging. See also related task for more
context.

Bug: T211124
Change-Id: I3cdeb4c666f54039b5e8ecc67bd4937220333526

5 years agoLogin-related messages should get the URL as a parameter
Gergő Tisza [Fri, 7 Dec 2018 00:18:47 +0000 (16:18 -0800)]
Login-related messages should get the URL as a parameter

System messages along the lines of "you can't view this page,
please log in" get the login link (with returnto parameters) as a
HTML string, but sometimes one might want to customize the link
on one page without affecting all the other pages so it's nice
to have the raw link available as well.

Change-Id: Ib71791ea28718455d2925e4424147e87ef901f33

5 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Thu, 6 Dec 2018 21:02:15 +0000 (22:02 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: Id77c8c55421c2ed60e00bca678cf61d0c9f7f485

5 years agoAdd dependencies on module 'user.options'
Fomafix [Thu, 6 Dec 2018 19:52:24 +0000 (20:52 +0100)]
Add dependencies on module 'user.options'

This change adds missing dependencies on the module 'user.options'
where the user options get requested via mw.user.options.

Change-Id: I63faaba4b286837cc4e3656d14ea1b255bbf32a6

5 years agoMerge "Skin: Assign module 'mediawiki.searchSuggest' already on initialization"
jenkins-bot [Thu, 6 Dec 2018 19:29:20 +0000 (19:29 +0000)]
Merge "Skin: Assign module 'mediawiki.searchSuggest' already on initialization"

5 years agoMerge "ApiComparePages: Don't try to find next/prev of a deleted revision"
jenkins-bot [Thu, 6 Dec 2018 18:19:39 +0000 (18:19 +0000)]
Merge "ApiComparePages: Don't try to find next/prev of a deleted revision"

5 years agoSkin: Assign module 'mediawiki.searchSuggest' already on initialization
Fomafix [Thu, 6 Dec 2018 17:01:13 +0000 (18:01 +0100)]
Skin: Assign module 'mediawiki.searchSuggest' already on initialization

The module 'mediawiki.searchSuggest' does not depend on anything and
can assigned to $modules already on initialization like the other
modules.

Change-Id: Ibf9bcbd4dde4703d72c9b97b0e88468c63978e0f

5 years agoMerge "Add namespace to action=info page"
jenkins-bot [Thu, 6 Dec 2018 00:28:44 +0000 (00:28 +0000)]
Merge "Add namespace to action=info page"

5 years agoMerge "Change rules when displaying block log extract"
jenkins-bot [Wed, 5 Dec 2018 23:55:22 +0000 (23:55 +0000)]
Merge "Change rules when displaying block log extract"

5 years agoChange rules when displaying block log extract
Dayllan Maza [Fri, 30 Nov 2018 05:14:38 +0000 (00:14 -0500)]
Change rules when displaying block log extract

Show log extract if the user is sitewide blocked, or is partially
blocked and not allowed to edit their user page or user talk page.

Bug: T203171
Change-Id: I9bcc50cfc1fad23f6bbbe5374a9a866f77bebc11

5 years agoMerge "TitlesMultiselectWidget: display pending element"
jenkins-bot [Wed, 5 Dec 2018 21:51:03 +0000 (21:51 +0000)]
Merge "TitlesMultiselectWidget: display pending element"

5 years agoMerge "i18n: Provide a value for the 'slot-name-main' fall-back key"
jenkins-bot [Wed, 5 Dec 2018 21:45:12 +0000 (21:45 +0000)]
Merge "i18n: Provide a value for the 'slot-name-main' fall-back key"

5 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Wed, 5 Dec 2018 21:14:55 +0000 (22:14 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: I4471ab7594a64131d33426575400d092ca2396be

5 years agoTitlesMultiselectWidget: display pending element
Thalia [Wed, 21 Nov 2018 11:38:21 +0000 (11:38 +0000)]
TitlesMultiselectWidget: display pending element

Create a PendingTextInputWidget and use it in
TitlesMultiSelectWidget instead of the multiline
text area for users who have JavaScript.

Bug: T210080
Change-Id: I824fea6a3df580d342e6087ab901fec025f0e70b

5 years agoMerge "ImageListPager: Actor migration for buildQueryConds()"
jenkins-bot [Wed, 5 Dec 2018 21:01:54 +0000 (21:01 +0000)]
Merge "ImageListPager: Actor migration for buildQueryConds()"

5 years agoMerge "Don't silently fail if API result fails to encode"
jenkins-bot [Wed, 5 Dec 2018 20:15:04 +0000 (20:15 +0000)]
Merge "Don't silently fail if API result fails to encode"

5 years agoMerge "i18n: Escape the File and Category namespaces in error links to pages"
jenkins-bot [Wed, 5 Dec 2018 19:24:41 +0000 (19:24 +0000)]
Merge "i18n: Escape the File and Category namespaces in error links to pages"