lhc/web/wiklou.git
3 years agoMerge "Selenium: record video of every test"
jenkins-bot [Tue, 16 Oct 2018 22:23:36 +0000 (22:23 +0000)]
Merge "Selenium: record video of every test"

3 years agoSelenium: record video of every test
Željko Filipin [Fri, 30 Mar 2018 16:42:04 +0000 (18:42 +0200)]
Selenium: record video of every test

In addition to two existing modes (headless and visible), this patch
introcues another mode, headless recording.

If DISPLAY environment variable is not set, Chrome will run in it's
built-in headless mode.
If it is set, and the value starts with colon (`:`), Chrome will
run in headless mode using Xvfb and record video of every test using FFmpeg.
If the value does not start with colon, Chrome will be visible.

Bug: T179188
Change-Id: Ic1723c5f2d57a28201caf6ba7056cb73fb74a957

3 years agomessagecache: check overridable message array in getMsgFromNamespace()
Aaron Schulz [Mon, 15 Oct 2018 15:08:24 +0000 (08:08 -0700)]
messagecache: check overridable message array in getMsgFromNamespace()

Follow up to a3d6c1411dad.

This avoids extra queries for messages that have a software defined value.

Bug: T193271
Change-Id: I25aa0e27200a0b417721cf1fbd34a82095405b89

3 years agoMerge "[Korean] Add 2 additional bookstoreList"
jenkins-bot [Tue, 16 Oct 2018 20:03:48 +0000 (20:03 +0000)]
Merge "[Korean] Add 2 additional bookstoreList"

3 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Tue, 16 Oct 2018 19:55:58 +0000 (21:55 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I44bc61d6e2147602329eeface6892e78db0388b2

3 years agoMerge "API: Allow prop=info intestactions to return reasons"
jenkins-bot [Tue, 16 Oct 2018 19:37:22 +0000 (19:37 +0000)]
Merge "API: Allow prop=info intestactions to return reasons"

3 years agoMerge "Migrate some wfWikiId() callers to getLocalDomainID()"
jenkins-bot [Tue, 16 Oct 2018 19:37:18 +0000 (19:37 +0000)]
Merge "Migrate some wfWikiId() callers to getLocalDomainID()"

3 years agoAPI: Allow prop=info intestactions to return reasons
Brad Jorsch [Thu, 27 Sep 2018 15:04:24 +0000 (11:04 -0400)]
API: Allow prop=info intestactions to return reasons

T194585 raises a use case for callers to be able to know why an action
is not allowed. We can make that possible easily enough. The default
remains to return only a boolean.

This also deprecates inprop=readable in favor of intestactions=read,
since they both just return `$title->userCan( 'read', $user )`.

(ApiQueryInfoTest added by David Barratt)

Bug: T194585
Change-Id: Ib880f0605880eac776d816ea04e0c7ab9cfbaab1
Co-Authored-By: David Barratt <dbarratt@wikimedia.org>
3 years agoMerge "Update ImportableUploadRevisionImporter for interwiki usernames"
jenkins-bot [Tue, 16 Oct 2018 16:17:59 +0000 (16:17 +0000)]
Merge "Update ImportableUploadRevisionImporter for interwiki usernames"

3 years agoMerge "Have maintenance/updateExtensionJsonSchema.php copy documentation"
jenkins-bot [Tue, 16 Oct 2018 16:10:24 +0000 (16:10 +0000)]
Merge "Have maintenance/updateExtensionJsonSchema.php copy documentation"

3 years agoHave maintenance/updateExtensionJsonSchema.php copy documentation
Brad Jorsch [Tue, 16 Oct 2018 15:12:43 +0000 (11:12 -0400)]
Have maintenance/updateExtensionJsonSchema.php copy documentation

It already skips version-1 style documentation keys that begin with "@".
It should also copy them into the "description" metadata key for
version 2.

Change-Id: I460568f074b9c0256eb6bbbcd0b046b16e0d8790

3 years agoUpdate ImportableUploadRevisionImporter for interwiki usernames
Brad Jorsch [Tue, 16 Oct 2018 14:47:44 +0000 (10:47 -0400)]
Update ImportableUploadRevisionImporter for interwiki usernames

This was somehow missed in I5401941c.

Bug: T206013
Change-Id: Ia618b05329e6cbfca7c95d9161f12ba4150705c8

3 years agoAdd session_write_close() calls to SessionManager tests
Brad Jorsch [Tue, 16 Oct 2018 14:22:33 +0000 (10:22 -0400)]
Add session_write_close() calls to SessionManager tests

PHP 7.3 doesn't like it if session_id() is called when the session has
been started, so we need to be sure to close it first in a few tests.

Bug: T207112
Change-Id: Ief36c1bb7b5c9066f158b5bb0d6d785a7f7ddd3c

3 years agoAvoid fatals when the filter tags is empty
Amir Sarabadani [Tue, 16 Oct 2018 11:02:45 +0000 (13:02 +0200)]
Avoid fatals when the filter tags is empty

Bug: T194164
Change-Id: I418cbe2259e7c1622a58a4a310a3cd56873f16c3

3 years agoMigrate some wfWikiId() callers to getLocalDomainID()
Aaron Schulz [Mon, 15 Oct 2018 22:20:50 +0000 (15:20 -0700)]
Migrate some wfWikiId() callers to getLocalDomainID()

Change-Id: I33fe222b7ca66babd61610febaebcf52d3806a7d

3 years agoMerge "Simplify `list-style` property"
jenkins-bot [Tue, 16 Oct 2018 05:28:33 +0000 (05:28 +0000)]
Merge "Simplify `list-style` property"

3 years agoMerge "Fix warning in doEditSectionLink() caused by not-yet-unstubbed $wgLang"
jenkins-bot [Tue, 16 Oct 2018 03:04:06 +0000 (03:04 +0000)]
Merge "Fix warning in doEditSectionLink() caused by not-yet-unstubbed $wgLang"

3 years agoMerge "API: Ignore expired blocks in ApiQueryBase::showHiddenUsersAddBlockInfo()"
jenkins-bot [Mon, 15 Oct 2018 23:07:47 +0000 (23:07 +0000)]
Merge "API: Ignore expired blocks in ApiQueryBase::showHiddenUsersAddBlockInfo()"

3 years agoMerge "LocalisationCache: Avoid use of compact()"
jenkins-bot [Mon, 15 Oct 2018 22:34:25 +0000 (22:34 +0000)]
Merge "LocalisationCache: Avoid use of compact()"

3 years agoMerge "API: Remove long-deprecated methods (and one class)"
jenkins-bot [Mon, 15 Oct 2018 22:34:20 +0000 (22:34 +0000)]
Merge "API: Remove long-deprecated methods (and one class)"

3 years agoMerge "CREDITS: Bump for 1.32.0 release"
jenkins-bot [Mon, 15 Oct 2018 21:48:29 +0000 (21:48 +0000)]
Merge "CREDITS: Bump for 1.32.0 release"

3 years agoAPI: Remove long-deprecated methods (and one class)
Brad Jorsch [Wed, 10 Oct 2018 17:55:09 +0000 (13:55 -0400)]
API: Remove long-deprecated methods (and one class)

* ApiBase::profileIn() (deprecated in 1.25)
* ApiBase::profileOut() (deprecated in 1.25)
* ApiBase::safeProfileOut() (deprecated in 1.25)
* ApiBase::profileDBIn() (deprecated in 1.25)
* ApiBase::profileDBOut() (deprecated in 1.25)
* ApiBase::dieUsage() (deprecated in 1.29)
* ApiBase::dieUsageMsg() (deprecated in 1.29)
* ApiBase::dieUsageMsgOrDebug() (deprecated in 1.29)
* ApiBase::getErrorFromStatus() (deprecated in 1.29)
* ApiBase::parseMsg() (deprecated in 1.29)
* ApiBase::setWarning() (deprecated in 1.29)
* ApiPageSet::getInvalidTitles() (deprecated in 1.26)
* ApiQueryLogEvents::addLogParams() (deprecated in 1.25)
* ApiUsageException::getCodeString() (deprecated in 1.29)
* ApiUsageException::getMessageArray() (deprecated in 1.29)
* UsageException (deprecated in 1.29)

Change-Id: Iabb2589a29cc3b46624d31358f3a6bf7b3ccbd57

3 years agoLocalisationCache: Avoid use of compact()
Kunal Mehta [Mon, 15 Oct 2018 07:17:38 +0000 (00:17 -0700)]
LocalisationCache: Avoid use of compact()

In PHP 7.3, compact() now raises notices if the variable is undefined, which
is something that we expect. So we can check whether the key exists instead
of bothering with compat() and suppressing warnings.

Bug: T206979
Change-Id: I612049db4debd850a2e6d10bc631d31aa17be898

3 years agoFix warning in doEditSectionLink() caused by not-yet-unstubbed $wgLang
Edward Chernenko [Mon, 15 Oct 2018 01:39:29 +0000 (04:39 +0300)]
Fix warning in doEditSectionLink() caused by not-yet-unstubbed $wgLang

In ParserOutput::getText(), $wgLang can be a StubUserLang object,
which causes a typecheck warning in doEditSectionLink().

Solution is to replace $wgLang with $context->getLanguage(),
which is always a Language object.

Change-Id: I9945e1615c3f1b7ed5c7897b9f67d7ca0450ee50

3 years agoSimplify `list-style` property
Volker E [Mon, 15 Oct 2018 20:03:13 +0000 (13:03 -0700)]
Simplify `list-style` property

Using `none none` value is also working on older IEs, which had
issues with shorthand only `list-style: none`.

Change-Id: I7d4b075ac90fd902e0c0fbc3e11449faf71fe9b2

3 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Mon, 15 Oct 2018 19:57:04 +0000 (21:57 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I4b631605549ac3599ca01d59fa69e35fad6c879e

3 years agoCREDITS: Bump for 1.32.0 release
James D. Forrester [Fri, 12 Oct 2018 17:31:55 +0000 (10:31 -0700)]
CREDITS: Bump for 1.32.0 release

Change-Id: I2187346003a53874c559fcfe23ee94d822829794

3 years agoUse "break" instead of "continue" inside a switch
RazeSoldier [Mon, 15 Oct 2018 15:58:26 +0000 (23:58 +0800)]
Use "break" instead of "continue" inside a switch

"continue" statements in a switch are equivalent to "break". In PHP 7.3, will generate a warning.

Bug: T206974
Change-Id: I54bcec013ff52ab81bff09f8f7ef02f3944a5b7d

3 years agoAPI: Ignore expired blocks in ApiQueryBase::showHiddenUsersAddBlockInfo()
Brad Jorsch [Mon, 15 Oct 2018 15:21:44 +0000 (11:21 -0400)]
API: Ignore expired blocks in ApiQueryBase::showHiddenUsersAddBlockInfo()

This probably went unnoticed for so long because expired blocks are
regularly cleared as long as new blocks continue being issued, so people
found that the problem "fixed" itself.

Bug: T206944
Change-Id: I6559e1ec23f4469d19684b4d931913acbccb56d4

3 years agoMerge "EmailNotification: Add newline before minor edit text"
jenkins-bot [Mon, 15 Oct 2018 14:19:43 +0000 (14:19 +0000)]
Merge "EmailNotification: Add newline before minor edit text"

3 years agoMerge "resources: Register jquery.client as foreign resource and update to v2.0.1"
jenkins-bot [Mon, 15 Oct 2018 14:07:14 +0000 (14:07 +0000)]
Merge "resources: Register jquery.client as foreign resource and update to v2.0.1"

3 years agoMerge "Add MessagesShn.php"
jenkins-bot [Mon, 15 Oct 2018 13:48:07 +0000 (13:48 +0000)]
Merge "Add MessagesShn.php"

3 years agoAdd MessagesShn.php
Martin Urbanec [Sun, 14 Oct 2018 18:02:26 +0000 (20:02 +0200)]
Add MessagesShn.php

This localizes:
* namespaces
* special page names

Bug: T206917
Bug: T206921
Change-Id: I0d27746aca56849056098ffffa866954d97f133d

3 years agoresources: Register jquery.client as foreign resource and update to v2.0.1
Timo Tijhof [Mon, 15 Oct 2018 02:27:41 +0000 (03:27 +0100)]
resources: Register jquery.client as foreign resource and update to v2.0.1

Change-Id: Iec6414a1675dec4aeb5d9b66635d28670f094e42

3 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Sun, 14 Oct 2018 19:54:50 +0000 (21:54 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I27647ca9376c400143ba52074322c4b50960db53

3 years agodocs: Remove outdated information from globals.txt
MGChecker [Sun, 14 Oct 2018 18:28:54 +0000 (20:28 +0200)]
docs: Remove outdated information from globals.txt

design.txt doesn't exist anymore.

Bug: T111283
Change-Id: Ibb67fb721060b325114e571ba3e470a607d98884

3 years agoMerge "jobqueue: clean up JobQueueDB::getCacheKey() to use makeGlobalKey()"
jenkins-bot [Sat, 13 Oct 2018 23:59:35 +0000 (23:59 +0000)]
Merge "jobqueue: clean up JobQueueDB::getCacheKey() to use makeGlobalKey()"

3 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Sat, 13 Oct 2018 07:49:22 +0000 (09:49 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I5958a3381bd070c1cb7d79e6819b638418b87165

3 years agojobqueue: clean up JobQueueDB::getCacheKey() to use makeGlobalKey()
Aaron Schulz [Sat, 13 Oct 2018 07:14:38 +0000 (00:14 -0700)]
jobqueue: clean up JobQueueDB::getCacheKey() to use makeGlobalKey()

Change-Id: I341720fda0d242c7822f78048cb49f63538d08bc

3 years agotravis: Remove PHP 7.2 from allowed failures
Kunal Mehta [Sat, 13 Oct 2018 06:47:42 +0000 (23:47 -0700)]
travis: Remove PHP 7.2 from allowed failures

It's now passing!

Bug: T204884
Change-Id: Idb17630cff54b803ca5fa942b2fcf17a775edd0d

3 years agoMerge "Output only to stderr in unit tests"
jenkins-bot [Sat, 13 Oct 2018 06:29:17 +0000 (06:29 +0000)]
Merge "Output only to stderr in unit tests"

3 years agoMerge "SlotDiffRenderer: add utility method for parameter type checks"
jenkins-bot [Sat, 13 Oct 2018 05:27:16 +0000 (05:27 +0000)]
Merge "SlotDiffRenderer: add utility method for parameter type checks"

3 years agoMerge "Linker: Document parseComment() as returning HTML"
jenkins-bot [Sat, 13 Oct 2018 05:23:43 +0000 (05:23 +0000)]
Merge "Linker: Document parseComment() as returning HTML"

3 years agoMerge "Log startAtomic()/endAtomic() to the query logger"
jenkins-bot [Sat, 13 Oct 2018 01:45:09 +0000 (01:45 +0000)]
Merge "Log startAtomic()/endAtomic() to the query logger"

3 years agoLog startAtomic()/endAtomic() to the query logger
Tim Starling [Wed, 10 Oct 2018 04:03:21 +0000 (15:03 +1100)]
Log startAtomic()/endAtomic() to the query logger

Change-Id: Ife7e292ef42946ec1c5e9121b7be6a90301b3903

3 years agoMerge "exception: Correct label "Notice" for E_USER_NOTICE, not "Warning""
jenkins-bot [Sat, 13 Oct 2018 00:58:16 +0000 (00:58 +0000)]
Merge "exception: Correct label "Notice" for E_USER_NOTICE, not "Warning""

3 years agoMerge "Revert "rdbms: add domain sanity checks to LoadBalancer connection methods""
jenkins-bot [Sat, 13 Oct 2018 00:58:11 +0000 (00:58 +0000)]
Merge "Revert "rdbms: add domain sanity checks to LoadBalancer connection methods""

3 years agoRevert "rdbms: add domain sanity checks to LoadBalancer connection methods"
Krinkle [Sat, 13 Oct 2018 00:35:55 +0000 (00:35 +0000)]
Revert "rdbms: add domain sanity checks to LoadBalancer connection methods"

This reverts commit b416e166a3eba1dcfc2e912e37e443981d7f60ef.

Fails on Travis CI / PHP 7.1 / Postgres:

> Creating administrator user account
>
> UnexpectedValueException:
> Got connection to 'traviswiki-mediawiki', but expected 'traviswiki'.
>
> Backtrace:
> #0 includes/libs/rdbms/loadbalancer/LoadBalancer.php(887): Wikimedia\Rdbms\LoadBalancer->openForeignConnection(integer, string, integer)
> #1 includes/libs/rdbms/loadbalancer/LoadBalancer.php(766): Wikimedia\Rdbms\LoadBalancer->openConnection(integer, string, integer)
> #2 includes/libs/rdbms/loadbalancer/LoadBalancer.php(851): Wikimedia\Rdbms\LoadBalancer->getConnection(integer, array, string, integer)
> #3 includes/jobqueue/JobQueueDB.php(780): Wikimedia\Rdbms\LoadBalancer->getConnectionRef(integer, array, string, integer)
> #4 includes/jobqueue/JobQueueDB.php(761): JobQueueDB->getDB(integer)
> #5 includes/jobqueue/JobQueueDB.php(187): JobQueueDB->getMasterDB()
> #6 includes/jobqueue/JobQueue.php(332): JobQueueDB->doBatchPush(array, integer)
> #7 includes/jobqueue/JobQueue.php(302): JobQueue->batchPush(array, integer)
> #8 includes/jobqueue/JobQueueGroup.php(154): JobQueue->push(array)
> #9 includes/user/UserGroupMembership.php(162): JobQueueGroup->push(array)
> #10 includes/user/User.php(3733): UserGroupMembership->insert(boolean)
> #11 includes/installer/Installer.php(1680): User->addGroup(string)
> #12 includes/installer/Installer.php(1601): Installer->createSysop(PostgresInstaller)
> #13 includes/installer/CliInstaller.php(176): Installer->performInstallation(array, array)

Change-Id: I269df89d47cc5a183af630447cd1642d3d4a3deb

3 years agoMerge "rdbms: add domain sanity checks to LoadBalancer connection methods"
Krinkle [Sat, 13 Oct 2018 00:08:28 +0000 (00:08 +0000)]
Merge "rdbms: add domain sanity checks to LoadBalancer connection methods"

3 years agoMerge "Avoid global $wgUpdateRowsPerQuery in WatchedItemStore"
jenkins-bot [Fri, 12 Oct 2018 22:35:49 +0000 (22:35 +0000)]
Merge "Avoid global $wgUpdateRowsPerQuery in WatchedItemStore"

3 years agoMerge "Add OOUI for HTMLFormFieldCloner"
jenkins-bot [Fri, 12 Oct 2018 22:30:59 +0000 (22:30 +0000)]
Merge "Add OOUI for HTMLFormFieldCloner"

3 years agoLinker: Document parseComment() as returning HTML
Roan Kattouw [Fri, 12 Oct 2018 22:18:03 +0000 (15:18 -0700)]
Linker: Document parseComment() as returning HTML

It's not entirely clear from the documentation whether this method
returns wikitext or HTML, so make it explicit.

Change-Id: I094e370e921c43dd8c5dc4376b3dddd803665d90

3 years agoMerge "Pass LBFactory to WatchedItemStore"
jenkins-bot [Fri, 12 Oct 2018 21:48:54 +0000 (21:48 +0000)]
Merge "Pass LBFactory to WatchedItemStore"

3 years agoMerge "HtmlTest: Perform multilingual tests"
jenkins-bot [Fri, 12 Oct 2018 18:59:28 +0000 (18:59 +0000)]
Merge "HtmlTest: Perform multilingual tests"

3 years agoMerge "Use a ScopedCallback to silence transaction profiler in SqlBagOStuff"
jenkins-bot [Fri, 12 Oct 2018 18:34:02 +0000 (18:34 +0000)]
Merge "Use a ScopedCallback to silence transaction profiler in SqlBagOStuff"

3 years agoHtmlTest: Perform multilingual tests
Erik Bernhardson [Fri, 12 Oct 2018 18:23:02 +0000 (11:23 -0700)]
HtmlTest: Perform multilingual tests

The tests here were only testing when user and content language
are the same, but the way things are rendered when they differ
is perhaps more interesting as it allows ensuring the two are used
in the correct places.

Change-Id: I357f50b082882fee485a95323d3a0a7cadb9a63c

3 years agoUse a ScopedCallback to silence transaction profiler in SqlBagOStuff
Umherirrender [Sat, 22 Sep 2018 12:38:02 +0000 (14:38 +0200)]
Use a ScopedCallback to silence transaction profiler in SqlBagOStuff

This affects most LCStoreDB which is the default cache
and spamming the log.

Bug: T154424
Bug: T97693
Change-Id: I68af177c7d0d88ab266eb3fefb4336eff86d861c

3 years agoDeprecate $wgUseKeyHeader and OutputPage::getKeyHeader()
C. Scott Ananian [Fri, 12 Oct 2018 15:50:14 +0000 (11:50 -0400)]
Deprecate $wgUseKeyHeader and OutputPage::getKeyHeader()

The `Key` header was a draft IETF specification which expired without
becoming a standard.  It does not appear to be in active use anywhere.

Change-Id: I3924a1b5ff428b107573d2827c40e4af8adaaeb1

3 years agoAvoid global $wgUpdateRowsPerQuery in WatchedItemStore
Umherirrender [Thu, 11 Oct 2018 19:13:35 +0000 (21:13 +0200)]
Avoid global $wgUpdateRowsPerQuery in WatchedItemStore

Change-Id: Ibff69d16919a595c3edb8e2b431aa42d84a2777a

3 years agoPass LBFactory to WatchedItemStore
Umherirrender [Thu, 11 Oct 2018 19:11:43 +0000 (21:11 +0200)]
Pass LBFactory to WatchedItemStore

Instead of passing the LoadBalancer and than get the LBFactory from the
service,
store the LBFactory on creation

Bug: T206601
Change-Id: I4c0d3712da591b2c5ddf2a65855d2cc9142417d2

3 years agoexception: Correct label "Notice" for E_USER_NOTICE, not "Warning"
Timo Tijhof [Fri, 12 Oct 2018 04:05:16 +0000 (05:05 +0100)]
exception: Correct label "Notice" for E_USER_NOTICE, not "Warning"

Follows-up ef06b528d9, which fixed the severity of all PHP errors
to have severity "Warning" or higher.

However, it also accidentally changed the label of "Notice"
to "Warning", which is confusing and incorrect.

Change-Id: Iffd39aa23b7f2cbff5cdaf876b8d4d595dcd6f96

3 years agordbms: add domain sanity checks to LoadBalancer connection methods
Aaron Schulz [Wed, 15 Aug 2018 02:24:37 +0000 (19:24 -0700)]
rdbms: add domain sanity checks to LoadBalancer connection methods

Bug: T193565
Change-Id: I94d905277e01b8e30ac3f6532ece07388bb20cce

3 years agoMerge "Make MergeableUpdate jobs avoid the sub-queue so they can always merge"
jenkins-bot [Fri, 12 Oct 2018 01:13:29 +0000 (01:13 +0000)]
Merge "Make MergeableUpdate jobs avoid the sub-queue so they can always merge"

3 years agoMerge "Make merged MergeableUpdate items always go to the end of the queue"
jenkins-bot [Fri, 12 Oct 2018 00:58:59 +0000 (00:58 +0000)]
Merge "Make merged MergeableUpdate items always go to the end of the queue"

3 years agoMerge "Fix Setup.php file-scope test"
jenkins-bot [Fri, 12 Oct 2018 00:58:54 +0000 (00:58 +0000)]
Merge "Fix Setup.php file-scope test"

3 years agoMake MergeableUpdate jobs avoid the sub-queue so they can always merge
Aaron Schulz [Thu, 11 Oct 2018 22:11:50 +0000 (15:11 -0700)]
Make MergeableUpdate jobs avoid the sub-queue so they can always merge

Change-Id: I5b100fae29b785ab4524d165dad2e8ee46406b0c

3 years agoIncrease OutputPage test coverage to >45%
Aryeh Gregor [Thu, 2 Aug 2018 18:42:17 +0000 (21:42 +0300)]
Increase OutputPage test coverage to >45%

Also stop returning a value from OutputPage::adaptCdnTTL().  There are
no users and the value doesn't seem very helpful: one would probably
expect it to return the new value of mCdnMaxage, but instead it
returns the new value of mCdnMaxageLimit. Better to have no return
value than one that's easily misunderstood (*and* which nobody uses).

Change-Id: Ia9dab86923b839334eab9f6fde17c4aed52130ec

3 years agoMerge "Add join conditions to ActiveUsersPager"
jenkins-bot [Thu, 11 Oct 2018 22:11:53 +0000 (22:11 +0000)]
Merge "Add join conditions to ActiveUsersPager"

3 years agoMerge "resourceloader: Throw exception when config serialization fails"
jenkins-bot [Thu, 11 Oct 2018 22:11:47 +0000 (22:11 +0000)]
Merge "resourceloader: Throw exception when config serialization fails"

3 years agoMake merged MergeableUpdate items always go to the end of the queue
Aaron Schulz [Thu, 11 Oct 2018 21:51:36 +0000 (14:51 -0700)]
Make merged MergeableUpdate items always go to the end of the queue

Change-Id: I2e8aa28f7426470d9b8b9e11b902deea793069b3

3 years agoresourceloader: Throw exception when config serialization fails
Roan Kattouw [Tue, 9 Oct 2018 20:43:56 +0000 (13:43 -0700)]
resourceloader: Throw exception when config serialization fails

If something puts a string that's invalid UTF-8 in a JS config variable,
JSON serialization will fail on the entire config blob. Currently, this
causes the entire config blob to be silently dropped, which breaks all
JavaScript because elementary variables like wgPageName are missing.

This change makes this scenario fail loudly rather than quietly, by
throwing an exception. This also makes bugs like these easier to track
down.

Bug: T206475
Change-Id: Ief2ae00228389a23627d440dc1cd9a54cf2b6926

3 years agoMerge "MessageCache: replace should actually replace, not reload"
jenkins-bot [Thu, 11 Oct 2018 20:56:33 +0000 (20:56 +0000)]
Merge "MessageCache: replace should actually replace, not reload"

3 years agoMerge "Localisation updates from https://translatewiki.net."
jenkins-bot [Thu, 11 Oct 2018 20:46:47 +0000 (20:46 +0000)]
Merge "Localisation updates from https://translatewiki.net."

3 years agoMerge "Accept BCP 47 codes as aliases for nonstandard variants"
jenkins-bot [Thu, 11 Oct 2018 20:46:42 +0000 (20:46 +0000)]
Merge "Accept BCP 47 codes as aliases for nonstandard variants"

3 years agoMerge "Ensure LanguageCode::bcp47() returns a valid BCP 47 language code"
jenkins-bot [Thu, 11 Oct 2018 20:46:35 +0000 (20:46 +0000)]
Merge "Ensure LanguageCode::bcp47() returns a valid BCP 47 language code"

3 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Thu, 11 Oct 2018 20:14:07 +0000 (22:14 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I17af87ea492359cd0c09dc3c62af8caa8755368a

3 years agoSplit out getSlotParserOutputUncached() method for the sake of profiling
Aaron Schulz [Thu, 11 Oct 2018 17:39:05 +0000 (10:39 -0700)]
Split out getSlotParserOutputUncached() method for the sake of profiling

Change-Id: I553dba13486982b4530d290c84dc1f53b4df6ff9

3 years agoMerge "Allow and use type Language instead of string for $lang of doEditSectionLink"
jenkins-bot [Thu, 11 Oct 2018 19:52:13 +0000 (19:52 +0000)]
Merge "Allow and use type Language instead of string for $lang of doEditSectionLink"

3 years agoMerge ".mailmap: Add a few new entries"
jenkins-bot [Thu, 11 Oct 2018 19:52:02 +0000 (19:52 +0000)]
Merge ".mailmap: Add a few new entries"

3 years agoMerge "Drop ParserLimitReport, deprecated in 1.22"
jenkins-bot [Thu, 11 Oct 2018 19:47:10 +0000 (19:47 +0000)]
Merge "Drop ParserLimitReport, deprecated in 1.22"

3 years agoMerge "Drop UnknownAction, deprecated in 1.19(!)"
jenkins-bot [Thu, 11 Oct 2018 19:44:16 +0000 (19:44 +0000)]
Merge "Drop UnknownAction, deprecated in 1.19(!)"

3 years agoMerge "Drop wfRunHooks, deprecated since 1.25"
jenkins-bot [Thu, 11 Oct 2018 19:41:18 +0000 (19:41 +0000)]
Merge "Drop wfRunHooks, deprecated since 1.25"

3 years agoMerge "Drop UserGetImplictGroups, deprecated since 1.25"
jenkins-bot [Thu, 11 Oct 2018 19:41:13 +0000 (19:41 +0000)]
Merge "Drop UserGetImplictGroups, deprecated since 1.25"

3 years agoAdd join conditions to ActiveUsersPager
Brad Jorsch [Fri, 21 Sep 2018 18:32:34 +0000 (14:32 -0400)]
Add join conditions to ActiveUsersPager

We're (very slowly and somewhat unofficially) moving towards using join
conditions everywhere, and here they're needed to avoid errors once the
actor migration reaches the READ_NEW stage.

Bug: T204767
Change-Id: I8bfe861fac7874f8938bed9bfac3b7ec6f478238

3 years agoMerge "Drop DoEditSectionLink, deprecated since 1.25"
jenkins-bot [Thu, 11 Oct 2018 19:27:39 +0000 (19:27 +0000)]
Merge "Drop DoEditSectionLink, deprecated since 1.25"

3 years agoMerge "tests: Add helper function for ini_set with automatic cleanup"
jenkins-bot [Thu, 11 Oct 2018 19:05:51 +0000 (19:05 +0000)]
Merge "tests: Add helper function for ini_set with automatic cleanup"

3 years agoMerge "Load installer i18n when running update.php"
jenkins-bot [Thu, 11 Oct 2018 18:59:34 +0000 (18:59 +0000)]
Merge "Load installer i18n when running update.php"

3 years agoMerge "messagecache: avoid caching message pages that do not override"
jenkins-bot [Thu, 11 Oct 2018 18:59:24 +0000 (18:59 +0000)]
Merge "messagecache: avoid caching message pages that do not override"

3 years agoMerge "Do not retry the ThumbnailRenderJob."
jenkins-bot [Thu, 11 Oct 2018 18:32:40 +0000 (18:32 +0000)]
Merge "Do not retry the ThumbnailRenderJob."

3 years agoLoad installer i18n when running update.php
Reedy [Thu, 11 Oct 2018 18:20:30 +0000 (19:20 +0100)]
Load installer i18n when running update.php

Bug: T206765
Change-Id: Ie1c1a5dbf7c905eaca55777448e5aba00267ed31

3 years agoMerge "Revert "Unwrap HTML loaded from parser cache""
jenkins-bot [Thu, 11 Oct 2018 18:11:55 +0000 (18:11 +0000)]
Merge "Revert "Unwrap HTML loaded from parser cache""

3 years ago.mailmap: Add a few new entries
James D. Forrester [Wed, 10 Oct 2018 23:34:43 +0000 (16:34 -0700)]
.mailmap: Add a few new entries

Change-Id: Iaacd5eff9c01ae9c03cf002a5063cae78cfb9e37

3 years agoAllow and use type Language instead of string for $lang of doEditSectionLink
Fomafix [Wed, 30 May 2018 04:33:01 +0000 (06:33 +0200)]
Allow and use type Language instead of string for $lang of doEditSectionLink

Hard-deprecate that the parameters $tooltip and $lang are optional.
Hard-deprecate other types than Language for parameter $lang.

Change-Id: I3ce048e3d0de9a4e96e2aa05d75a4ce41c3ec964
Depends-On: Ibe295e7020e995eea52e319feaf59c635f8bb4dc

3 years agoDo not retry the ThumbnailRenderJob.
Petr Pchelko [Thu, 11 Oct 2018 15:19:41 +0000 (08:19 -0700)]
Do not retry the ThumbnailRenderJob.

The job is a warmup for the thumbnail cache, so loosing it is not
an issue. Most of the times thumbnail rendering fails because of
non-renderable or broken images, or because the thumbnail was
already created by a request. These conditions will not be fixed
by retrying, will only create more load on Thumbor.

Bug: T203135
Change-Id: Ib4640eb13ca93f7350ff0671fc559a76ebbbb1e9

3 years agoMessageCache: replace should actually replace, not reload
Brad Jorsch [Wed, 26 Sep 2018 16:56:58 +0000 (12:56 -0400)]
MessageCache: replace should actually replace, not reload

Prior to I462554b30, MessageCache::replace() did just that: it took the
existing cache and updated the one entry.

In I462554b30, the rearrangement of work into a DeferredUpdate
introduced a bug: the in-process cache was updated, but when the shared
cache was loaded later the entry was never updated in there so the
shared caches kept the old value. This was found in code review and
worked around by reloading all the messages from the database instead of
updating the existing cache.

But all that extra work reloading everything from the database causes
major slowness saving any MediaWiki-namespace page when the wiki has
many such small pages. Let's go back and fix the bug so replace() can
again replace instead of reloading everything.

Bug: T203925
Change-Id: Ife8e1bd6f143f480eb8da09b817c85aadf33a923

3 years agoOnly expand `{{...}}` in messages once
C. Scott Ananian [Thu, 11 Oct 2018 13:05:05 +0000 (09:05 -0400)]
Only expand `{{...}}` in messages once

If we're going to call `OutputPage::addWikiText` to parse the message,
we don't need to pre-expand `{{...}}` markup before passing it to the
parser.  This makes these callsites consistent with how
`OutputPage::addWikiMsg()` inserts messages.

Bug: T206574
Change-Id: I2f68f73365df876e6f9d017e4e3ddea39c4a1284

3 years ago[Korean] Add 2 additional bookstoreList
Yongmin Hong [Thu, 11 Oct 2018 09:13:48 +0000 (18:13 +0900)]
[Korean] Add 2 additional bookstoreList

* Aladin.co.kr has HTTPS!
* National Library of Korea has 302 http://www.nl.go.kr on
  https://www.nl.go.kr
* Naver has HTTPS.

Change-Id: I5559ae2b32cddb540bc712e4b55cfe7c26c9a0b0
Signed-off-by: Yongmin Hong <revi@pobox.com>
3 years agoMerge "Drop File / MediaHandler::getStreamHeaders(), deprecated since 1.30"
jenkins-bot [Thu, 11 Oct 2018 07:44:08 +0000 (07:44 +0000)]
Merge "Drop File / MediaHandler::getStreamHeaders(), deprecated since 1.30"

3 years agoMerge "Drop DeferredUpdates::setImmediateMode(), deprecated since 1.29"
jenkins-bot [Thu, 11 Oct 2018 07:44:02 +0000 (07:44 +0000)]
Merge "Drop DeferredUpdates::setImmediateMode(), deprecated since 1.29"

3 years agoMerge "Drop ChangesListSpecialPageFilters, deprecated in 1.29 and uncalled"
jenkins-bot [Thu, 11 Oct 2018 07:36:20 +0000 (07:36 +0000)]
Merge "Drop ChangesListSpecialPageFilters, deprecated in 1.29 and uncalled"