jquery.suggestions: Do not show suggestions on prefilled values
authorFomafix <fomafix@googlemail.com>
Wed, 29 May 2019 09:18:47 +0000 (11:18 +0200)
committerFomafix <fomafix@googlemail.com>
Wed, 29 May 2019 22:01:19 +0000 (00:01 +0200)
Show the suggestions on load only if the current value differs to the
defaultValue from the HTML. This prevents suggestions if there is
already a prefilled value in the input field.

Also direct call $.suggestions.update() instead of trigger a keypress.

This change is a follow-up to 72f61f7a5930cf03d4e8ddde62c2ef627b05dd69.

Bug: T224524
Change-Id: I501596996a20c62d1497bf66e23c7858b58bf4ea

resources/src/jquery/jquery.suggestions.js

index 9e6ecc8..e970c06 100644 (file)
                                                }
                                                $.suggestions.hide( context );
                                                $.suggestions.cancel( context );
-                                       } )
-                                       // Simulate a keypress on load. This loads the search suggestions when there are already
-                                       // typed characters before the JavaScript is loaded.
-                                       .trigger( 'keypress' );
+                                       } );
+                               // Load suggestions if the value is changed because there are already
+                               // typed characters before the JavaScript is loaded.
+                               if ( this.value !== this.defaultValue ) {
+                                       $.suggestions.update( context, false );
+                               }
                        }
 
                        // Store the context for next time