Merge "Allow duplicate articles in parser tests with same content"
authorjenkins-bot <jenkins-bot@gerrit.wikimedia.org>
Thu, 5 Oct 2017 07:06:54 +0000 (07:06 +0000)
committerGerrit Code Review <gerrit@wikimedia.org>
Thu, 5 Oct 2017 07:06:54 +0000 (07:06 +0000)
tests/parser/ParserTestRunner.php

index 0121d53..149ba80 100644 (file)
@@ -1592,11 +1592,21 @@ class ParserTestRunner {
                        throw new MWException( "invalid title '$name' at $file:$line\n" );
                }
 
+               $newContent = ContentHandler::makeContent( $text, $title );
+
                $page = WikiPage::factory( $title );
                $page->loadPageData( 'fromdbmaster' );
 
                if ( $page->exists() ) {
-                       throw new MWException( "duplicate article '$name' at $file:$line\n" );
+                       $content = $page->getContent( Revision::RAW );
+                       // Only reject the title, if the content/content model is different.
+                       // This makes it easier to create Template:(( or Template:)) in different extensions
+                       if ( $newContent->equals( $content ) ) {
+                               return;
+                       }
+                       throw new MWException(
+                               "duplicate article '$name' with different content at $file:$line\n"
+                       );
                }
 
                // Use mock parser, to make debugging of actual parser tests simpler.
@@ -1606,7 +1616,7 @@ class ParserTestRunner {
                $restore = $this->executeSetupSnippets( [ 'wgParser' => new ParserTestMockParser ] );
                try {
                        $status = $page->doEditContent(
-                               ContentHandler::makeContent( $text, $title ),
+                               $newContent,
                                '',
                                EDIT_NEW | EDIT_INTERNAL
                        );