REST: HeaderContainer should start empty not null

Change-Id: I30b68862307f2b44e4f5708c06464e0a218c1ed5

diff --git a/includes/Rest/HeaderContainer.php b/includes/Rest/HeaderContainer.php
index 50f4355..a71f6a6 100644 (file)
--- a/includes/Rest/HeaderContainer.php
+++ b/includes/Rest/HeaderContainer.php
@@ -10,9 +10,9 @@ namespace MediaWiki\Rest;
  * Unlike PSR-7, the container is mutable.
  */
 class HeaderContainer {
-       private $headerLists;
-       private $headerLines;
-       private $headerNames;
+       private $headerLists = [];
+       private $headerLines = [];
+       private $headerNames = [];
 
        /**
         * Erase any existing headers and replace them with the specified

diff --git a/tests/phpunit/includes/Rest/HeaderContainerTest.php b/tests/phpunit/includes/Rest/HeaderContainerTest.php
index d0fae9f..e0dbfdf 100644 (file)
--- a/tests/phpunit/includes/Rest/HeaderContainerTest.php
+++ b/tests/phpunit/includes/Rest/HeaderContainerTest.php
@@ -42,6 +42,7 @@ class HeaderContainerTest extends MediaWikiTestCase {
                                [ 'tesT' => [ 'bar' ] ],
                                [ 'tesT' => 'bar' ]
                        ],
+                       'empty' => [ [], [], [] ],
                ];
        }