Followup r70479

If string is required, but it's value === '', that's missing!

diff --git a/includes/api/ApiBase.php b/includes/api/ApiBase.php
index 44acdda..8c79da5 100644 (file)
--- a/includes/api/ApiBase.php
+++ b/includes/api/ApiBase.php
@@ -662,6 +662,10 @@ abstract class ApiBase {
                                        case 'NULL': // nothing to do
                                                break;
                                        case 'string': // nothing to do
+                                               if ( $value === '' ) {
+                                                       $this->dieUsageMsg( array( 'missingparam', $paramName ) );
+                                               }
+                                       
                                                break;
                                        case 'integer': // Force everything using intval() and optionally validate limits