WLFilters: always create a balanced fieldset
authorStephane Bisson <sbisson@wikimedia.org>
Mon, 18 Sep 2017 19:07:55 +0000 (15:07 -0400)
committerCatrope <roan@wikimedia.org>
Mon, 18 Sep 2017 19:16:23 +0000 (19:16 +0000)
Don't count on Xml::fieldset creating only the opening tag.

Bug: T176155
Change-Id: Idc4e450c9fa03fc78a012fb5eefa60174bb1245a

includes/specials/SpecialWatchlist.php

index 2750551..8418865 100644 (file)
@@ -635,11 +635,13 @@ class SpecialWatchlist extends ChangesListSpecialPage {
                        'id' => 'mw-watchlist-form'
                ] );
                $form .= Html::hidden( 'title', $this->getPageTitle()->getPrefixedText() );
-               $form .= Xml::fieldset(
-                       $this->msg( 'watchlist-options' )->text(),
-                       false,
+               $form .= Xml::openElement(
+                       'fieldset',
                        [ 'id' => 'mw-watchlist-options', 'class' => 'cloptions' ]
                );
+               $form .= Xml::element(
+                       'legend', null, $this->msg( 'watchlist-options' )->text()
+               );
 
                if ( !$this->isStructuredFilterUiEnabled() ) {
                        $form .= $this->makeLegend();