Newly-disabled general rules:
* MediaWiki.Commenting.FunctionComment.MissingSplatVariadicArg
* MediaWiki.Commenting.FunctionComment.SuperfluousVariadicArgComment
* MediaWiki.Commenting.PhpunitAnnotations.ForbiddenExpectedException
* MediaWiki.Commenting.PhpunitAnnotations.ForbiddenExpectedExceptionMessage
* MediaWiki.Commenting.PhpunitAnnotations.ForbiddenExpectedExceptionMessageRegExp
* MediaWiki.Usage.NullableType.PHP71NullableStyle
* MediaWiki.Usage.PHPUnitTypeHints.MissingTypehint
* PSR12.Files.ImportStatement.LeadingSlash
* PSR12.Properties.ConstantVisibility.NotFound
Change-Id: Ifcf8c6d5fecc47a32741114b5a5b746a41510045
<ruleset name="MediaWiki">
<rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki">
<exclude name="Generic.ControlStructures.InlineControlStructure" />
<ruleset name="MediaWiki">
<rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki">
<exclude name="Generic.ControlStructures.InlineControlStructure" />
+ <exclude name="MediaWiki.Commenting.FunctionComment.ExtraParamComment" />
<exclude name="MediaWiki.Commenting.FunctionComment.MissingDocumentationProtected" />
<exclude name="MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic" />
<exclude name="MediaWiki.Commenting.FunctionComment.MissingParamTag" />
<exclude name="MediaWiki.Commenting.FunctionComment.MissingReturn" />
<exclude name="MediaWiki.Commenting.FunctionComment.MissingDocumentationProtected" />
<exclude name="MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic" />
<exclude name="MediaWiki.Commenting.FunctionComment.MissingParamTag" />
<exclude name="MediaWiki.Commenting.FunctionComment.MissingReturn" />
- <exclude name="MediaWiki.Commenting.FunctionComment.ExtraParamComment" />
+ <exclude name="MediaWiki.Commenting.FunctionComment.MissingSplatVariadicArg" />
+ <exclude name="MediaWiki.Commenting.FunctionComment.SuperfluousVariadicArgComment" />
<exclude name="MediaWiki.Commenting.FunctionComment.WrongStyle" />
<exclude name="MediaWiki.Commenting.FunctionComment.WrongStyle" />
- <exclude name="MediaWiki.Commenting.IllegalSingleLineComment.IllegalSingleLineCommentStart" />
<exclude name="MediaWiki.Commenting.IllegalSingleLineComment.IllegalSingleLineCommentEnd" />
<exclude name="MediaWiki.Commenting.IllegalSingleLineComment.IllegalSingleLineCommentEnd" />
+ <exclude name="MediaWiki.Commenting.IllegalSingleLineComment.IllegalSingleLineCommentStart" />
+ <exclude name="MediaWiki.Commenting.PhpunitAnnotations.ForbiddenExpectedException" />
+ <exclude name="MediaWiki.Commenting.PhpunitAnnotations.ForbiddenExpectedExceptionMessage" />
+ <exclude name="MediaWiki.Commenting.PhpunitAnnotations.ForbiddenExpectedExceptionMessageRegExp" />
<exclude name="MediaWiki.ControlStructures.AssignmentInControlStructures.AssignmentInControlStructures" />
<exclude name="MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName" />
<exclude name="MediaWiki.ControlStructures.AssignmentInControlStructures.AssignmentInControlStructures" />
<exclude name="MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName" />
+ <exclude name="MediaWiki.PHP71Features.NullableType.NotAllowed" />
<exclude name="MediaWiki.Usage.DbrQueryUsage.DbrQueryFound" />
<exclude name="MediaWiki.Usage.DeprecatedGlobalVariables.Deprecated$wgContLang" />
<exclude name="MediaWiki.Usage.DeprecatedGlobalVariables.Deprecated$wgTitle" />
<exclude name="MediaWiki.Usage.ForbiddenFunctions.passthru" />
<exclude name="MediaWiki.Usage.DbrQueryUsage.DbrQueryFound" />
<exclude name="MediaWiki.Usage.DeprecatedGlobalVariables.Deprecated$wgContLang" />
<exclude name="MediaWiki.Usage.DeprecatedGlobalVariables.Deprecated$wgTitle" />
<exclude name="MediaWiki.Usage.ForbiddenFunctions.passthru" />
+ <exclude name="MediaWiki.Usage.NullableType.PHP71NullableStyle" />
+ <exclude name="MediaWiki.Usage.PHPUnitTypeHints.MissingTypehint" />
<exclude name="MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment" />
<exclude name="MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.SingleSpaceBeforeSingleLineComment" />
<exclude name="MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment" />
<exclude name="MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.SingleSpaceBeforeSingleLineComment" />
+ <exclude name="PSR12.Files.ImportStatement.LeadingSlash" />
+ <exclude name="PSR12.Properties.ConstantVisibility.NotFound" />
<exclude name="Squiz.Scope.MethodScope.Missing" />
</rule>
<rule ref="MediaWiki.NamingConventions.PrefixedGlobalFunctions">
<exclude name="Squiz.Scope.MethodScope.Missing" />
</rule>
<rule ref="MediaWiki.NamingConventions.PrefixedGlobalFunctions">
"jakub-onderka/php-console-highlighter": "0.3.2",
"jakub-onderka/php-parallel-lint": "0.9.2",
"justinrainbow/json-schema": "~5.2",
"jakub-onderka/php-console-highlighter": "0.3.2",
"jakub-onderka/php-parallel-lint": "0.9.2",
"justinrainbow/json-schema": "~5.2",
- "mediawiki/mediawiki-codesniffer": "26.0.0",
+ "mediawiki/mediawiki-codesniffer": "28.0.0",
"monolog/monolog": "~1.24.0",
"nikic/php-parser": "3.1.5",
"seld/jsonlint": "1.7.1",
"monolog/monolog": "~1.24.0",
"nikic/php-parser": "3.1.5",
"seld/jsonlint": "1.7.1",
$pout = $page->getParserOutput( $popts, $revId, $suppressCache );
}
if ( !$pout ) {
$pout = $page->getParserOutput( $popts, $revId, $suppressCache );
}
if ( !$pout ) {
- $this->dieWithError( [ 'apierror-nosuchrevid', $revId ?: $page->getLatest() ] ); // @codeCoverageIgnore
+ // @codeCoverageIgnoreStart
+ $this->dieWithError( [ 'apierror-nosuchrevid', $revId ?: $page->getLatest() ] );
+ // @codeCoverageIgnoreEnd
protected function getLegacyShowHideFilters() {
$filters = [];
foreach ( $this->filterGroups as $group ) {
protected function getLegacyShowHideFilters() {
$filters = [];
foreach ( $this->filterGroups as $group ) {
- if ( $group instanceof ChangesListBooleanFilterGroup ) {
+ if ( $group instanceof ChangesListBooleanFilterGroup ) {
foreach ( $group->getFilters() as $key => $filter ) {
if ( $filter->displaysOnUnstructuredUi( $this ) ) {
$filters[ $key ] = $filter;
foreach ( $group->getFilters() as $key => $filter ) {
if ( $filter->displaysOnUnstructuredUi( $this ) ) {
$filters[ $key ] = $filter;
- function fakeUploadChunk( $fieldName, $fileName, $type, & $chunkData ) {
+ public function fakeUploadChunk( $fieldName, $fileName, $type, &$chunkData ) {
$tmpName = $this->getNewTempFile();
// copy the chunk data to temp location:
if ( !file_put_contents( $tmpName, $chunkData ) ) {
$tmpName = $this->getNewTempFile();
// copy the chunk data to temp location:
if ( !file_put_contents( $tmpName, $chunkData ) ) {