Message: Throw if given invalid serialized data

Instead of silently winding up with a bogus Message object having most
fields invalidly set to null, just throw an exception.

Bug: T210528
Change-Id: I79313f8acf3ebb1ef12dac30c362aa10c715f40b

diff --git a/includes/Message.php b/includes/Message.php
index 3bd7755..7dd22c7 100644 (file)
--- a/includes/Message.php
+++ b/includes/Message.php
@@ -300,6 +300,10 @@ class Message implements MessageSpecifier, Serializable {
         */
        public function unserialize( $serialized ) {
                $data = unserialize( $serialized );
+               if ( !is_array( $data ) ) {
+                       throw new InvalidArgumentException( __METHOD__ . ': Invalid serialized data' );
+               }
+
                $this->interface = $data['interface'];
                $this->key = $data['key'];
                $this->keysToTry = $data['keysToTry'];