Firstly, restore the availability to query all namespaces.
There is no reason to remove this feature.
Secondly, fix code not to treat '0' as falsy. Instead, use
the request object to get an integer or null.
Bug: T50247
Change-Id: I182e25be2d694d010a1e8382a461c5c08f898581
private $existingPropNames = null;
/**
private $existingPropNames = null;
/**
$request = $this->getRequest();
$propname = $request->getVal( 'propname', $par );
$request = $this->getRequest();
$propname = $request->getVal( 'propname', $par );
+ $this->ns = $request->getIntOrNull( 'namespace' );
$this->reverse = $request->getBool( 'reverse' );
$this->sortByValue = $request->getBool( 'sortbyvalue' );
$this->reverse = $request->getBool( 'reverse' );
$this->sortByValue = $request->getBool( 'sortbyvalue' );
'type' => 'namespaceselect',
'name' => 'namespace',
'label-message' => 'namespace',
'type' => 'namespaceselect',
'name' => 'namespace',
'label-message' => 'namespace',
- 'all' => null,
- 'default' => null,
+ 'all' => '',
+ 'default' => $this->ns,
],
'reverse' => [
'type' => 'check',
],
'reverse' => [
'type' => 'check',
public function onSubmit( $data, $form ) {
$this->propName = $data['propname'];
public function onSubmit( $data, $form ) {
$this->propName = $data['propname'];
- $this->ns = $data['namespace'];
parent::execute( $data['propname'] );
}
parent::execute( $data['propname'] );
}
- if ( $this->ns && isset( $this->ns ) ) {
+ if ( $this->ns !== null ) {
$query['conds']['page_namespace'] = $this->ns;
}
$query['conds']['page_namespace'] = $this->ns;
}