Simplify Language::getFallbackFor
authorFomafix <fomafix@googlemail.com>
Wed, 16 Dec 2015 09:51:53 +0000 (09:51 +0000)
committer[[mw:User:Fomafix]] <gerritpatchuploader@gmail.com>
Wed, 16 Dec 2015 09:51:53 +0000 (09:51 +0000)
This avoids a redundant check of the language code.

Change-Id: Ifbe23b80a9d8fd5c3aa06f6656dbf2699a318003

languages/Language.php

index 7747198..69f518b 100644 (file)
@@ -4451,12 +4451,11 @@ class Language {
         * @return bool|string
         */
        public static function getFallbackFor( $code ) {
-               if ( $code === 'en' || !Language::isValidBuiltInCode( $code ) ) {
-                       return false;
-               } else {
-                       $fallbacks = self::getFallbacksFor( $code );
+               $fallbacks = self::getFallbacksFor( $code );
+               if ( $fallbacks ) {
                        return $fallbacks[0];
                }
+               return false;
        }
 
        /**