Various fixes to make phan-taint-check happier

Bug: T216348
Change-Id: Ice672eed3b7e4a199e1307a6477ffe31502b97b5

diff --git a/includes/exception/MWException.php b/includes/exception/MWException.php
index 7f70c4f..502cee8 100644 (file)
--- a/includes/exception/MWException.php
+++ b/includes/exception/MWException.php
@@ -209,12 +209,7 @@ class MWException extends Exception {
                        wfHttpError( 500, 'Internal Server Error', $this->getText() );
                } elseif ( self::isCommandLine() ) {
                        $message = $this->getText();
                        wfHttpError( 500, 'Internal Server Error', $this->getText() );
                } elseif ( self::isCommandLine() ) {
                        $message = $this->getText();

-                       // T17602: STDERR may not be available
-                       if ( !defined( 'MW_PHPUNIT_TEST' ) && defined( 'STDERR' ) ) {
-                               fwrite( STDERR, $message );
-                       } else {
-                               echo $message;
-                       }
+                       $this->writeToCommandLine( $message );

                } else {
                        self::statusHeader( 500 );
                        self::header( "Content-Type: $wgMimeType; charset=utf-8" );
                } else {
                        self::statusHeader( 500 );
                        self::header( "Content-Type: $wgMimeType; charset=utf-8" );


@@ -223,6 +218,21 @@ class MWException extends Exception {
                }
        }
 
                }
        }
 

+       /**
+        * Write a message to stderr falling back to stdout if stderr unavailable
+        *
+        * @param string $message
+        * @suppress SecurityCheck-XSS
+        */
+       private function writeToCommandLine( $message ) {
+               // T17602: STDERR may not be available
+               if ( !defined( 'MW_PHPUNIT_TEST' ) && defined( 'STDERR' ) ) {
+                       fwrite( STDERR, $message );
+               } else {
+                       echo $message;
+               }
+       }
+

        /**
         * Check whether we are in command line mode or not to report the exception
         * in the correct format.
        /**
         * Check whether we are in command line mode or not to report the exception
         * in the correct format.

diff --git a/includes/exception/MWExceptionRenderer.php b/includes/exception/MWExceptionRenderer.php
index 22be2be..ca590d8 100644 (file)
--- a/includes/exception/MWExceptionRenderer.php
+++ b/includes/exception/MWExceptionRenderer.php
@@ -268,6 +268,7 @@ class MWExceptionRenderer {
         * Print a message, if possible to STDERR.
         * Use this in command line mode only (see isCommandLine)
         *
         * Print a message, if possible to STDERR.
         * Use this in command line mode only (see isCommandLine)
         *

+        * @suppress SecurityCheck-XSS

         * @param string $message Failure text
         */
        private static function printError( $message ) {
         * @param string $message Failure text
         */
        private static function printError( $message ) {