Removed clearSharedCache() hack in User.php
authorAaron Schulz <aschulz@wikimedia.org>
Wed, 9 Sep 2015 00:02:39 +0000 (17:02 -0700)
committerAaron Schulz <aschulz@wikimedia.org>
Wed, 9 Sep 2015 00:02:39 +0000 (17:02 -0700)
* WAN cache key salting/tombstones makes this overkill now

Change-Id: I078daacc5d2987858d720677f11e9828d71021e2

includes/User.php

index 605dab6..dbcbe31 100644 (file)
@@ -3709,14 +3709,6 @@ class User implements IDBAccessObject {
                Hooks::run( 'UserSaveSettings', array( $this ) );
                $this->clearSharedCache();
                $this->getUserPage()->invalidateCache();
-
-               // T95839: clear the cache again post-commit to reduce race conditions
-               // where stale values are written back to the cache by other threads.
-               // Note: this *still* doesn't deal with REPEATABLE-READ snapshot lag...
-               $that = $this;
-               $dbw->onTransactionIdle( function() use ( $that ) {
-                       $that->clearSharedCache();
-               } );
        }
 
        /**