RCFilters: better vertical alignment of checkbox and text in menus
authorStephane Bisson <sbisson@wikimedia.org>
Tue, 2 Oct 2018 16:55:12 +0000 (12:55 -0400)
committerCatrope <roan@wikimedia.org>
Wed, 3 Oct 2018 00:18:14 +0000 (00:18 +0000)
- Remove min-height so menu items are a little smaller and
  their content is vertically-aligned.

- Force `vertical-align: middle;` for checkboxes by overriding
  OOUI with extreme specificity.

Bug: T200364
Change-Id: If0b2b5c1b749f913badbd0c02a85852ec0007020

resources/src/mediawiki.rcfilters/styles/mw.rcfilters.ui.ItemMenuOptionWidget.less

index 1cc48e2..bf855be 100644 (file)
@@ -3,7 +3,6 @@
 @import 'mw.rcfilters.variables';
 
 .mw-rcfilters-ui-itemMenuOptionWidget {
-       min-height: 3.5em;
        padding: 0 0.5em;
        .box-sizing( border-box );
 
                .oo-ui-fieldLayout.oo-ui-fieldLayout-align-inline {
                        // Override margin-top and -bottom rules from FieldLayout
                        margin: 0 !important; /* stylelint-disable-line declaration-no-important */
+
+                       .oo-ui-fieldLayout-body > .oo-ui-fieldLayout-field {
+                               vertical-align: middle;
+                       }
                }
 
                .oo-ui-checkboxInputWidget {
                        // Workaround for IE11 rendering issues. T162098
                        display: block;
-                       padding-top: 1em;
                }
 
                label {