wfProfile fixes:
authorPlatonides <platonides@gmail.com>
Tue, 19 Mar 2013 15:12:14 +0000 (16:12 +0100)
committerPlatonides <platonides@gmail.com>
Tue, 19 Mar 2013 15:17:19 +0000 (16:17 +0100)
 0543c7b0 added a wfProfileIn() that should have been wfProfileOut()
 Reorder Http::request() so that wfProfileOut() is at the same
level as the above wfProfileIn() [checked by check-vars]

Change-Id: Ia91445d792e524b9c570890397f1513af0d8cd73

includes/HttpFunctions.php

index 98d36d3..9e280db 100644 (file)
@@ -69,14 +69,12 @@ class Http {
                $req = MWHttpRequest::factory( $url, $options );
                $status = $req->execute();
 
+               $content = false;
                if ( $status->isOK() ) {
                        $content = $req->getContent();
-                       wfProfileOut( __METHOD__ . "-$method" );
-                       return $content;
-               } else {
-                       wfProfileOut( __METHOD__ . "-$method" );
-                       return false;
                }
+               wfProfileOut( __METHOD__ . "-$method" );
+               return $content;
        }
 
        /**
@@ -629,7 +627,7 @@ class MWHttpRequest {
                        }
                }
 
-               wfProfileIn( __METHOD__ );
+               wfProfileOut( __METHOD__ );
        }
 
        /**