Merge "Add missing @param and @return documentation"

diff --combined includes/search/SearchEngine.php
index 3e78488,0cccec4..1b9ee6c
--- 1/includes/search/SearchEngine.php
--- 2/includes/search/SearchEngine.php
+++ b/includes/search/SearchEngine.php
@@@ -138,7 -138,7 +138,7 @@@ abstract class SearchEngine 
         * @return mixed the feature value or null if unset
         */
        public function getFeatureData( $feature ) {
 -              if ( isset ( $this->features[$feature] ) ) {
 +              if ( isset( $this->features[$feature] ) ) {
                        return $this->features[$feature];
                }
                return null;
@@@ -566,6 -566,7 +566,7 @@@
        /**
         * Process completion search results.
         * Resolves the titles and rescores.
+        * @param string $search
         * @param SearchSuggestionSet $suggestions
         * @return SearchSuggestionSet
         */

diff --combined includes/specialpage/LoginSignupSpecialPage.php
index 3ed131e,991d75d..04d391b
--- 1/includes/specialpage/LoginSignupSpecialPage.php
--- 2/includes/specialpage/LoginSignupSpecialPage.php
+++ b/includes/specialpage/LoginSignupSpecialPage.php
@@@ -1156,7 -1156,7 +1156,7 @@@ abstract class LoginSignupSpecialPage e
                        // Don't show a "create account" link if the user can't.
                        if ( $this->showCreateAccountLink() ) {
                                // link to the other action
 -                              $linkTitle = $this->getTitleFor( $this->isSignup() ? 'Userlogin' :'CreateAccount' );
 +                              $linkTitle = $this->getTitleFor( $this->isSignup() ? 'Userlogin' : 'CreateAccount' );
                                $linkq = $this->getReturnToQueryStringFragment();
                                // Pass any language selection on to the mode switch link
                                if ( $this->mLanguage ) {
@@@ -1247,6 -1247,7 +1247,7 @@@
        /**
         * Returns a string that can be appended to the URL (without encoding) to preserve the
         * return target. Does not include leading '?'/'&'.
+        * @return string
         */
        protected function getReturnToQueryStringFragment() {
                $returnto = '';
@@@ -1340,6 -1341,7 +1341,7 @@@
  
        /**
         * @param array &$formDescriptor
+        * @param array $requests
         */
        protected function postProcessFormDescriptor( &$formDescriptor, $requests ) {
                // Pre-fill username (if not creating an account, T46775).
@@@ -1395,6 -1397,11 +1397,11 @@@ class FakeAuthTemplate extends BaseTemp
        /**
         * Extensions (AntiSpoof and TitleBlacklist) call this in response to
         * UserCreateForm hook to add checkboxes to the create account form.
+        * @param string $name
+        * @param string $value
+        * @param string $type
+        * @param string $msg
+        * @param string|bool $helptext
         */
        public function addInputItem( $name, $value, $type, $msg, $helptext = false ) {
                // use the same indexes as UserCreateForm just in case someone adds an item manually
@@@ -1496,6 -1503,7 +1503,7 @@@ class LoginForm extends SpecialPage 
  
        /**
         * @deprecated since 1.27 - call LoginHelper::getValidErrorMessages instead.
+        * @return array
         */
        public static function getValidErrorMessages() {
                return LoginHelper::getValidErrorMessages();
@@@ -1503,6 -1511,8 +1511,8 @@@
  
        /**
         * @deprecated since 1.27 - don't use LoginForm, use AuthManager instead
+        * @param string $username
+        * @return array|false
         */
        public static function incrementLoginThrottle( $username ) {
                wfDeprecated( __METHOD__, "1.27" );
@@@ -1514,6 -1524,8 +1524,8 @@@
  
        /**
         * @deprecated since 1.27 - don't use LoginForm, use AuthManager instead
+        * @param string $username
+        * @return bool|int
         */
        public static function incLoginThrottle( $username ) {
                wfDeprecated( __METHOD__, "1.27" );
@@@ -1523,6 -1535,8 +1535,8 @@@
  
        /**
         * @deprecated since 1.27 - don't use LoginForm, use AuthManager instead
+        * @param string $username
+        * @return void
         */
        public static function clearLoginThrottle( $username ) {
                wfDeprecated( __METHOD__, "1.27" );
@@@ -1559,6 -1573,7 +1573,7 @@@
  
        /**
         * @deprecated since 1.27 - don't use LoginForm, use AuthManager instead
+        * @return string
         */
        public static function getCreateaccountToken() {
                wfDeprecated( __METHOD__, '1.27' );

diff --combined includes/specials/SpecialMediaStatistics.php
index 1312501,9e07523..1789bb2
--- 1/includes/specials/SpecialMediaStatistics.php
--- 2/includes/specials/SpecialMediaStatistics.php
+++ b/includes/specials/SpecialMediaStatistics.php
@@@ -63,6 -63,7 +63,7 @@@ class MediaStatisticsPage extends Query
         * come out of querycache table is the order they went in. Which is hacky.
         * However, other special pages like Special:Deadendpages and
         * Special:BrokenRedirects also rely on this.
+        * @return array
         */
        public function getQueryInfo() {
                $dbr = wfGetDB( DB_REPLICA );
@@@ -197,7 -198,7 +198,7 @@@
                $row .= Html::rawElement(
                        'td',
                        // Make sure js sorts it in numeric order
 -                      [ 'data-sort-value' =>  $bytes ],
 +                      [ 'data-sort-value' => $bytes ],
                        $this->msg( 'mediastatistics-nbytes' )
                                ->numParams( $bytes )
                                ->sizeParams( $bytes )
@@@ -251,6 -252,7 +252,7 @@@
         * Output the start of the table
         *
         * Including opening <table>, and first <tr> with column headers.
+        * @param string $mediaType
         */
        protected function outputTableStart( $mediaType ) {
                $this->getOutput()->addHTML(