Merge "Parser: Use 'Special:Badtitle/Parser' instead of 'NO TITLE'"

diff --combined includes/parser/Parser.php
index ec1628f,121afed..9ec5834
--- 1/includes/parser/Parser.php
--- 2/includes/parser/Parser.php
+++ b/includes/parser/Parser.php
@@@ -411,10 -411,8 +411,10 @@@ class Parser 
         */
        public function __destruct() {
                if ( isset( $this->mLinkHolders ) ) {
 +                      // @phan-suppress-next-line PhanTypeObjectUnsetDeclaredProperty
                        unset( $this->mLinkHolders );
                }
 +              // @phan-suppress-next-line PhanTypeSuspiciousNonTraversableForeach
                foreach ( $this as $name => $value ) {
                        unset( $this->$name );
                }
@@@ -910,7 -908,7 +910,7 @@@
         */
        public function setTitle( $t ) {
                if ( !$t ) {
-                       $t = Title::newFromText( 'NO TITLE' );
+                       $t = Title::makeTitle( NS_SPECIAL, 'Badtitle/Parser' );
                }
  
                if ( $t->hasFragment() ) {
@@@ -2010,7 -2008,6 +2010,7 @@@
         */
        public function replaceExternalLinks( $text ) {
                $bits = preg_split( $this->mExtLinkBracketedRegex, $text, -1, PREG_SPLIT_DELIM_CAPTURE );
 +              // @phan-suppress-next-line PhanTypeComparisonFromArray See phan issue #3161
                if ( $bits === false ) {
                        throw new MWException( "PCRE needs to be compiled with "
                                . "--enable-unicode-properties in order for MediaWiki to function" );
@@@ -2312,11 -2309,6 +2312,11 @@@
                $line = $a->current(); # Workaround for broken ArrayIterator::next() that returns "void"
                $s = substr( $s, 1 );
  
 +              if ( is_null( $this->mTitle ) ) {
 +                      throw new MWException( __METHOD__ . ": \$this->mTitle is null\n" );
 +              }
 +              $nottalk = !$this->mTitle->isTalkPage();
 +
                $useLinkPrefixExtension = $this->getTargetLanguage()->linkPrefixExtension();
                $e2 = null;
                if ( $useLinkPrefixExtension ) {
@@@ -2324,6 -2316,14 +2324,6 @@@
                        # e.g. in the case of 'The Arab al[[Razi]]', 'al' will be matched
                        $charset = $this->contLang->linkPrefixCharset();
                        $e2 = "/^((?>.*[^$charset]|))(.+)$/sDu";
 -              }
 -
 -              if ( is_null( $this->mTitle ) ) {
 -                      throw new MWException( __METHOD__ . ": \$this->mTitle is null\n" );
 -              }
 -              $nottalk = !$this->mTitle->isTalkPage();
 -
 -              if ( $useLinkPrefixExtension ) {
                        $m = [];
                        if ( preg_match( $e2, $s, $m ) ) {
                                $first_prefix = $m[2];
@@@ -6187,9 -6187,7 +6187,9 @@@
         */
        private static function normalizeSectionName( $text ) {
                # T90902: ensure the same normalization is applied for IDs as to links
 +              /** @var MediaWikiTitleCodec $titleParser */
                $titleParser = MediaWikiServices::getInstance()->getTitleParser();
 +              '@phan-var MediaWikiTitleCodec $titleParser';
                try {
  
                        $parts = $titleParser->splitTitleString( "#$text" );