Fix use of argument perfLogFilename in convertLinks.php
authorUmherirrender <umherirrender_de.wp@web.de>
Tue, 2 Jul 2019 20:07:25 +0000 (22:07 +0200)
committerUmherirrender <umherirrender_de.wp@web.de>
Sun, 1 Sep 2019 17:52:55 +0000 (17:52 +0000)
Maintenance::getArg needs a number to get the argument, not a string
Reorg the hasOption calls to match the addArg from constructor

Change-Id: Ice7013affb328363daf6e831010de4640583f486

maintenance/convertLinks.php

index 02152f7..2dcabe3 100644 (file)
@@ -100,10 +100,10 @@ class ConvertLinks extends Maintenance {
                # not used yet; highest row number from links table to process
                # $finalRowOffset = 0;
 
+               $this->logPerformance = $this->hasOption( 'logperformance' );
+               $perfLogFilename = $this->getArg( 1, "convLinksPerf.txt" );
                $overwriteLinksTable = !$this->hasOption( 'keep-links-table' );
                $noKeys = $this->hasOption( 'noKeys' );
-               $this->logPerformance = $this->hasOption( 'logperformance' );
-               $perfLogFilename = $this->getArg( 'perfLogFilename', "convLinksPerf.txt" );
 
                # --------------------------------------------------------------------