No need to wrap the result of DatabaseBase::select() in a ResultWrapper object.
authorAlexandre Emsenhuber <ialex.wiki@gmail.com>
Wed, 4 Jul 2012 08:55:09 +0000 (10:55 +0200)
committerAlexandre Emsenhuber <ialex.wiki@gmail.com>
Wed, 4 Jul 2012 08:57:57 +0000 (10:57 +0200)
Change-Id: I2cceb363b4573a850a7a63c93d2ca9899e477a7f
DatabaseBase::select() already returns a ResultWrapper object, so its useless to wrap it again.

includes/Pager.php

index 9d1f9fc..750636d 100644 (file)
@@ -306,8 +306,7 @@ abstract class IndexPager extends ContextSource implements Pager {
         */
        public function reallyDoQuery( $offset, $limit, $descending ) {
                list( $tables, $fields, $conds, $fname, $options, $join_conds ) = $this->buildQueryInfo( $offset, $limit, $descending );
-               $result = $this->mDb->select( $tables, $fields, $conds, $fname, $options, $join_conds );
-               return new ResultWrapper( $this->mDb, $result );
+               return $this->mDb->select( $tables, $fields, $conds, $fname, $options, $join_conds );
        }
 
        /**