config: Change ConfigException to extend LogicException

This exception is thrown when someone tries to fetch a
configuration entry with an invalid name, or override an already
set entry, both of which are errors in the logic and cannot be
meaningfully handled, so it does not make sense for this exception
to trigger IDE warnings.

(The one exception is the etcd load error, which probably shouldn't
be a ConfigException in the first place. But even that is not
something callers could meaningfully handle.)

Change-Id: I26b5b32f3348965f0cbf607cbb7cb5aaa509ed51

diff --git a/includes/config/ConfigException.php b/includes/config/ConfigException.php
index 3b3ba9d..b2d0fc6 100644 (file)
--- a/includes/config/ConfigException.php
+++ b/includes/config/ConfigException.php
@@ -25,5 +25,5 @@
  *
  * @since 1.23
  */
-class ConfigException extends Exception {
+class ConfigException extends LogicException {
 }