Follow-up Ib933de3a3f: remove unnecessary override from SpecialWatchlist
authorRoan Kattouw <roan.kattouw@gmail.com>
Wed, 13 Dec 2017 19:29:55 +0000 (11:29 -0800)
committerRoan Kattouw <roan.kattouw@gmail.com>
Wed, 13 Dec 2017 19:29:55 +0000 (11:29 -0800)
isStructuredFilterUiEnabledByDefault() should no longer be overridden,
overrides should be put in the static checkStructuredFilterUiEnabled()
instead. That function was already added, but the duplicated non-static
function wasn't removed.

It looks to me that ?rcfilters=1 shouldn't have been working on
Watchlist for this reason, but it was working, and I can't figure out
why.

Change-Id: Iaf962b4e0428e262b57dc12ee0ba2cb6f854eb7e

includes/specials/SpecialWatchlist.php

index e8e828d..2ad70a6 100644 (file)
@@ -117,11 +117,6 @@ class SpecialWatchlist extends ChangesListSpecialPage {
                );
        }
 
-       public function isStructuredFilterUiEnabledByDefault() {
-               return $this->getConfig()->get( 'StructuredChangeFiltersOnWatchlist' ) &&
-                       $this->getUser()->getDefaultOption( 'rcenhancedfilters' );
-       }
-
        /**
         * Return an array of subpages that this special page will accept.
         *