Simplify thumbnail styling to have consistency with mobile implementation
authorjrobson <jrobson@wikimedia.org>
Sun, 11 May 2014 14:17:05 +0000 (16:17 +0200)
committerJuliusz Gonera <jgonera@wikimedia.org>
Sun, 11 May 2014 15:06:57 +0000 (17:06 +0200)
Remove undocumented !important rule - !important is bad.

Bug: 65160
Change-Id: I21d6856d51478395cbe59e86e2f3aec495a74a38

skins/common/commonContent.css
skins/vector/components/thumbnails.less [new file with mode: 0644]
skins/vector/screen.less

index 4157b55..6bf01ae 100644 (file)
@@ -143,7 +143,7 @@ html .thumbimage {
 html .thumbcaption {
        border: none;
        line-height: 1.4em;
-       padding: 3px !important;
+       padding: 3px;
        font-size: 94%;
 }
 
diff --git a/skins/vector/components/thumbnails.less b/skins/vector/components/thumbnails.less
new file mode 100644 (file)
index 0000000..afb5f2a
--- /dev/null
@@ -0,0 +1,32 @@
+// FIXME: Due to commonContent.css we have to use html tag to make sure these are more specific
+html .thumb {
+       &.tright {
+               padding: 1px 0 0 15px;
+       }
+
+       &.tleft {
+               padding: 1px 15px 0 0;
+       }
+
+       // these resets should be unnecessary
+       div.thumbinner {
+               border: none;
+               background: none;
+               font-size: 100%;
+       }
+
+       .thumbcaption {
+               line-height: @content-line-height;
+               font-size: .85em;
+               padding: 3px 0 0 0;
+               color: #333;
+       }
+
+       .magnify {
+               display: none;
+       }
+
+       .thumbimage {
+               border: none;
+       }
+}
index f7b374f..3e824f3 100644 (file)
@@ -8,3 +8,4 @@
 @import "components/footer.less";
 @import 'components/notifications.less';
 @import "components/externalLinks.less";
+@import "components/thumbnails.less";