Merge "Avoid duplicate accesskey hints on OOUI widgets"
authorjenkins-bot <jenkins-bot@gerrit.wikimedia.org>
Tue, 1 Aug 2017 22:13:19 +0000 (22:13 +0000)
committerGerrit Code Review <gerrit@wikimedia.org>
Tue, 1 Aug 2017 22:13:20 +0000 (22:13 +0000)
languages/i18n/en.json
resources/src/mediawiki.action/mediawiki.action.edit.js

index 8c295b2..d9bbf9a 100644 (file)
        "rcfilters-activefilters": "Active filters",
        "rcfilters-advancedfilters": "Advanced filters",
        "rcfilters-limit-title": "Changes to show",
-       "rcfilters-limit-shownum": "Show last $1 changes",
+       "rcfilters-limit-shownum": "Show last {{PLURAL:$1|change|$1 changes}}",
        "rcfilters-days-title": "Recent days",
        "rcfilters-hours-title": "Recent hours",
        "rcfilters-days-show-days": "$1 {{PLURAL:$1|day|days}}",
index 5a9ed7e..68d6cbb 100644 (file)
@@ -17,7 +17,9 @@
         */
 
        $( function () {
-               var editBox, scrollTop, $editForm;
+               var editBox, scrollTop, $editForm,
+                       // TODO T6714: Once this can be adjusted, read this from config.
+                       summaryByteLimit = 255;
 
                if ( $( '#editform' ).hasClass( 'mw-editform-ooui' ) ) {
                        mw.loader.using( 'oojs-ui-core' ).then( function () {
                                // Show a byte-counter to users with how many bytes are left for their edit summary.
                                // TODO: This looks a bit weird, as there is no unit in the UI, just numbers; showing
                                // 'bytes' confused users in testing, and showing 'chars' would be a lie. See T42035.
-                               mw.widgets.visibleByteLimit( wpSummary, 255 );
+                               mw.widgets.visibleByteLimit( wpSummary, summaryByteLimit );
                        } );
                } else {
                        // Make sure edit summary does not exceed byte limit
-                       $( '#wpSummary' ).byteLimit( 255 );
+                       $( '#wpSummary' ).byteLimit( summaryByteLimit );
                }
 
                // Restore the edit box scroll state following a preview operation,