Improve Database::factory() $driver validation
authorAaron Schulz <aschulz@wikimedia.org>
Tue, 4 Oct 2016 05:35:51 +0000 (22:35 -0700)
committerAaron Schulz <aschulz@wikimedia.org>
Tue, 4 Oct 2016 10:21:48 +0000 (10:21 +0000)
Change-Id: Ie034e6f2f94f0f1731dbe2468f075297d5a171a2

includes/libs/rdbms/database/Database.php

index 16d30d7..9f1f228 100644 (file)
@@ -352,7 +352,7 @@ abstract class Database implements IDatabase, IMaintainableDatabase, LoggerAware
                } else {
                        $driver = $dbType;
                }
-               if ( $driver === false ) {
+               if ( $driver === false || $driver === '' ) {
                        throw new InvalidArgumentException( __METHOD__ .
                                " no viable database extension found for type '$dbType'" );
                }